@@ -1,69 +1,30 @@
1module Servant.QuickCheck.Internal.Predicates where
1module Servant.QuickCheck.Internal.Predicates where
3−import Control.Exception (catch, throw)
3+import Control.Monad
4−import Control.Monad (liftM2, unless, when)
5−import Data.Aeson (Object, decode)
4+import Data.Aeson (Object, decode)
6−import Data.Bifunctor (first)
5+import Data.Bifunctor (Bifunctor (..))
7−import qualified Data.ByteString as SBS
6+import qualified Data.ByteString.Lazy as LBS
7+import qualified Data.ByteString as SBS
8import qualified Data.ByteString.Char8 as SBSC
8import qualified Data.ByteString.Char8 as SBSC
9−import qualified Data.ByteString.Lazy as LBS
10−import Data.CaseInsensitive (foldCase, foldedCase, mk)
9+import Data.CaseInsensitive (mk)
11−import Data.Either (isRight)
10+import Data.Either (isRight)
12−import Data.List.Split (wordsBy)
11+import Data.List.Split (wordsBy)
13−import Data.Maybe (fromMaybe, isJust)
12+import Data.Monoid ((<>))
14−import Data.Semigroup (Semigroup (..))
13+import Data.Text (Text)
15−import qualified Data.Text as T
16−import Data.Time (UTCTime, defaultTimeLocale, parseTimeM,
18−import GHC.Generics (Generic)
14+import GHC.Generics (Generic)
19−import Network.HTTP.Client (Manager, Request, Response, httpLbs,
15+import Network.HTTP.Client (Manager, Request, Response, httpLbs,
20− method, parseRequest, requestHeaders,
21− responseBody, responseHeaders,
22− responseStatus)
16+ responseBody, responseStatus, responseHeaders)
23−import Network.HTTP.Media (matchAccept)
17+import Network.HTTP.Types (status500, status405, status401, parseMethod)
24−import Network.HTTP.Types (methodGet, methodHead, parseMethod,
18+
25− renderStdMethod, status100, status200,
26− status201, status300, status401,
27− status405, status500)
29−import System.Clock (Clock (Monotonic), diffTimeSpec,
32−import Servant.QuickCheck.Internal.ErrorTypes
35−-- | [__Best Practice__]
37−-- @500 Internal Server Error@ should be avoided - it may represent some
19+-- | @500 Internal Server Error@ should be avoided - it may represent some
38-- issue with the application code, and it moreover gives the client little
20-- issue with the application code, and it moreover gives the client little
39-- indication of how to proceed or what went wrong.
21-- indication of how to proceed or what went wrong.
41-- This function checks that the response code is not 500.
23-- This function checks that the response code is not 500.
44−not500 :: ResponsePredicate
24+not500 :: ResponsePredicate Text Bool
45−not500 = ResponsePredicate $ \resp ->
25+not500 = ResponsePredicate "not500" (\resp -> not $ responseStatus resp == status500)
46− when (responseStatus resp == status500) $ throw $ PredicateFailure "not500" Nothing resp
50−-- This function checks that the response from the server does not take longer
51−-- than the specified number of nanoseconds.
54−notLongerThan :: Integer -> RequestPredicate
55−notLongerThan maxAllowed
56− = RequestPredicate $ \req mgr -> do
57− start <- getTime Monotonic
58− resp <- httpLbs req mgr
59− end <- getTime Monotonic
60− when (toNanoSecs (end `diffTimeSpec` start) > maxAllowed) $
61− throw $ PredicateFailure "notLongerThan" (Just req) resp
64−-- | [__Best Practice__]
66−-- Returning anything other than an object when returning JSON is considered
27+-- | Returning anything other than an object when returning JSON is considered
67-- bad practice, as:
28-- bad practice, as:
69-- (1) it is hard to modify the returned value while maintaining backwards
30-- (1) it is hard to modify the returned value while maintaining backwards
@@ -80,197 +41,80 @@ notLongerThan maxAllowed
81-- * JSON Grammar: <https://tools.ietf.org/html/rfc7159#section-2 RFC 7159 Section 2>
42-- * JSON Grammar: <https://tools.ietf.org/html/rfc7159#section-2 RFC 7159 Section 2>
82-- * JSON Grammar: <https://tools.ietf.org/html/rfc4627#section-2 RFC 4627 Section 2>
43-- * JSON Grammar: <https://tools.ietf.org/html/rfc4627#section-2 RFC 4627 Section 2>
85−onlyJsonObjects :: ResponsePredicate
44+onlyJsonObjects :: ResponsePredicate Text Bool
86onlyJsonObjects
45onlyJsonObjects
87− = ResponsePredicate (\resp -> do
88− case lookup "content-type" (first foldedCase <$> responseHeaders resp) of
90− Just ctype -> when ("application/json" `SBS.isPrefixOf` ctype) $ do
91− case (decode (responseBody resp) :: Maybe Object) of
46+ = ResponsePredicate "onlyJsonObjects" (\resp -> case decode (responseBody resp) of
92− Nothing -> throw $ PredicateFailure "onlyJsonObjects" Nothing resp
47+ Nothing -> False
93− Just _ -> return ())
48+ Just (_ :: Object) -> True)
95−-- | __Optional__
50+{-
97−-- When creating a new resource, it is good practice to provide a @Location@
51+-- | When creating a new resource, it is good practice to provide a @Location@
98-- header with a link to the created resource.
52-- header with a link to the created resource.
100-- This function checks that every @201 Created@ response contains a @Location@
54-- This function checks that every @201 Created@ response contains a @Location@
101-- header, and that the link in it responds with a 2XX response code to @GET@
55-- header, and that the link in it responds with a 2XX response code to @GET@
102-- requests.
56-- requests.
104−-- This is considered optional because other means of linking to the resource
105−-- (e.g. via the response body) are also acceptable; linking to the resource in
106−-- some way is considered best practice.
110−-- * 201 Created: <https://tools.ietf.org/html/rfc7231#section-6.3.2 RFC 7231 Section 6.3.2>
111−-- * Location header: <https://tools.ietf.org/html/rfc7231#section-7.1.2 RFC 7231 Section 7.1.2>
58+-- References: <RFC 7231, Section 6.3.2 https://tools.ietf.org/html/rfc7231#section-6.3.2>
114−createContainsValidLocation :: RequestPredicate
59+createContainsValidLocation :: ResponsePredicate Text Bool
115createContainsValidLocation
60createContainsValidLocation
116− = RequestPredicate $ \req mgr -> do
117− let n = "createContainsValidLocation"
61+ = ResponsePredicate "createContainsValidLocation" (\resp ->
118− resp <- httpLbs req mgr
119− if responseStatus resp == status201
120− then case lookup "Location" $ responseHeaders resp of
121− Nothing -> throw $ PredicateFailure n (Just req) resp
122− Just l -> case parseRequest $ SBSC.unpack l of
123− Nothing -> throw $ PredicateFailure n (Just req) resp
125− resp2 <- httpLbs x mgr
126− status2XX (Just req) resp2 n
127− return [resp, resp2]
132−-- The @Last-Modified@ header represents the time a resource was last
133−-- modified. It is used to drive caching and conditional requests.
135−-- When using this mechanism, the server adds the @Last-Modified@ header to
136−-- responses. Clients may then make requests with the @If-Modified-Since@
137−-- header to conditionally request resources. If the resource has not
138−-- changed since that date, the server responds with a status code of 304
139−-- (@Not Modified@) without a response body.
141−-- The @Last-Modified@ header can also be used in conjunction with the
142−-- @If-Unmodified-Since@ header to drive optimistic concurrency.
144−-- The @Last-Modified@ date must be in RFC 822 format.
148−-- * 304 Not Modified: <https://tools.ietf.org/html/rfc7232#section-4.1 RFC 7232 Section 4.1>
149−-- * Last-Modified header: <https://tools.ietf.org/html/rfc7232#section-2.2 RFC 7232 Section 2.2>
150−-- * If-Modified-Since header: <https://tools.ietf.org/html/rfc7232#section-3.3 RFC 7232 Section 3.3>
151−-- * If-Unmodified-Since header: <https://tools.ietf.org/html/rfc7232#section-3.4 RFC 7232 Section 3.4>
152−-- * Date format: <https://tools.ietf.org/html/rfc2616#section-3.3 RFC 2616 Section 3.3>
155−getsHaveLastModifiedHeader :: RequestPredicate
156−getsHaveLastModifiedHeader
157− = RequestPredicate $ \req mgr ->
158− if (method req == methodGet)
160− resp <- httpLbs req mgr
161− unless (hasValidHeader "Last-Modified" isRFC822Date resp) $ do
162− throw $ PredicateFailure "getsHaveLastModifiedHeader" (Just req) resp
63+getsHaveLastModifiedHeader :: ResponsePredicate Text Bool
64+getsHaveLastModifiedHeader
65+ = ResponsePredicate "getsHaveLastModifiedHeader" (\resp ->
168−-- | [__RFC Compliance__]
170−-- When an HTTP request has a method that is not allowed,
69+-- | When an HTTP request has a method that is not allowed, a 405 response
171−-- a 405 response should be returned. Additionally, it is good practice to
70+-- should be returned. Additionally, it is good practice to return an @Allow@
173-- header with the list of allowed methods.
71-- header with the list of allowed methods.
175-- This function checks that every @405 Method Not Allowed@ response contains
73-- This function checks that every @405 Method Not Allowed@ response contains
176-- an @Allow@ header with a list of standard HTTP methods.
74-- an @Allow@ header with a list of standard HTTP methods.
178−-- Note that 'servant' itself does not currently set the @Allow@ headers.
180-- __References__:
76-- __References__:
182-- * @Allow@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.7>
78-- * @Allow@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.7>
183−-- * Status 405: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html RFC 2616 Section 10.4.6>
184−-- * Servant Allow header issue: <https://github.com/haskell-servant/servant/issues/489 Issue #489>
187−notAllowedContainsAllowHeader :: RequestPredicate
79+notAllowedContainsAllowHeader :: ResponsePredicate Text Bool
188notAllowedContainsAllowHeader
80notAllowedContainsAllowHeader
189− = RequestPredicate $ \req mgr -> do
190− let reqs = [ req { method = renderStdMethod m } | m <- [minBound .. maxBound]
191− , renderStdMethod m /= method req ]
192− resp <- mapM (flip httpLbs mgr) reqs
194− case filter pred' (zip reqs resp) of
195− (x:_) -> throw $ PredicateFailure "notAllowedContainsAllowHeader" (Just $ fst x) (snd x)
81+ = ResponsePredicate "notAllowedContainsAllowHeader" (\resp ->
198− pred' (_, resp) = responseStatus resp == status405 && not (hasValidHeader "Allow" go resp)
82+ if responseStatus resp == status405
83+ then hasValidHeader "Allow" go resp
200− go x = all (\y -> isRight $ parseMethod $ SBSC.pack y)
86+ go x = all (\y -> isRight $ parseMethod $ SBSC.pack y)
201− $ wordsBy (`elem` (", " :: [Char])) (SBSC.unpack x)
87+ $ wordsBy (`elem` (", " :: [Char])) (SBSC.unpack x)
204−-- | [__RFC Compliance__]
206−-- When a request contains an @Accept@ header, the server must either return
90+-- | When a request contains an @Accept@ header, the server must either return
207-- content in one of the requested representations, or respond with @406 Not
91-- content in one of the requested representations, or respond with @406 Not
208-- Acceptable@.
92-- Acceptable@.
210-- This function checks that every *successful* response has a @Content-Type@
94-- This function checks that every *successful* response has a @Content-Type@
211−-- header that matches the @Accept@ header. It does *not* check that the server
95+-- header that matches the @Accept@ header.
212−-- matches the quality descriptions of the @Accept@ header correctly.
216−-- * @Accept@ header: <https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html RFC 2616 Section 14.1>
219−honoursAcceptHeader :: RequestPredicate
96+honoursAcceptHeader :: Predicate b Bool
220honoursAcceptHeader
97honoursAcceptHeader
221− = RequestPredicate $ \req mgr -> do
98+ = RequestPredicate "honoursAcceptHeader" _
222− resp <- httpLbs req mgr
99+
223− let scode = responseStatus resp
224− sctype = lookup "Content-Type" $ responseHeaders resp
225− sacc = fromMaybe "*/*" $ lookup "Accept" (requestHeaders req)
226− if status100 < scode && scode < status300
227− then if isJust $ sctype >>= \x -> matchAccept [x] sacc
228− then throw $ PredicateFailure "honoursAcceptHeader" (Just req) resp
233−-- | [__Best Practice__]
235−-- Whether or not a representation should be cached, it is good practice to
100+-- | Whether or not a representation should be cached, it is good practice to
236-- have a @Cache-Control@ header for @GET@ requests. If the representation
101-- have a @Cache-Control@ header for @GET@ requests. If the representation
237-- should not be cached, used @Cache-Control: no-cache@.
102-- should not be cached, used @Cache-Control: no-cache@.
239−-- This function checks that @GET@ responses have @Cache-Control@ header.
104+-- This function checks that @GET@ responses have a valid @Cache-Control@
240−-- It does NOT currently check that the header is valid.
105+-- header.
242−-- __References__:
107+-- References: RFC 7234 Section 5.2
244−-- * @Cache-Control@ header: <https://tools.ietf.org/html/rfc7234#section-5.2 RFC 7234 Section 5.2>
108+-- https://tools.ietf.org/html/rfc7234#section-5.2
247−getsHaveCacheControlHeader :: RequestPredicate
109+getsHaveCacheControlHeader :: Predicate b Bool
248getsHaveCacheControlHeader
110getsHaveCacheControlHeader
249− = RequestPredicate $ \req mgr ->
250− if (method req == methodGet)
252− resp <- httpLbs req mgr
253− unless (hasValidHeader "Cache-Control" (const True) resp) $ do
254− throw $ PredicateFailure "getsHaveCacheControlHeader" (Just req) resp
111+ = ResponsePredicate "getsHaveCacheControlHeader" _
258−-- | [__Best Practice__]
260−-- Like 'getsHaveCacheControlHeader', but for @HEAD@ requests.
113+-- | Like 'getsHaveCacheControlHeader', but for @HEAD@ requests.
263−headsHaveCacheControlHeader :: RequestPredicate
114+headsHaveCacheControlHeader :: Predicate b Bool
264headsHaveCacheControlHeader
115headsHaveCacheControlHeader
265− = RequestPredicate $ \req mgr ->
266− if (method req == methodHead)
268− resp <- httpLbs req mgr
269− unless (hasValidHeader "Cache-Control" (const True) resp) $
270− throw $ PredicateFailure "headsHaveCacheControlHeader" (Just req) resp
116+ = ResponsePredicate "headsHaveCacheControlHeader" _
276-- If the original request modifies the resource, this function makes two
120-- If the original request modifies the resource, this function makes two
@@ -319,9 +163,7 @@ linkHeadersAreValid
319 = ResponsePredicate "linkHeadersAreValid" _
163 = ResponsePredicate "linkHeadersAreValid" _
322−-- | [__RFC Compliance__]
324−-- Any @401 Unauthorized@ response must include a @WWW-Authenticate@ header.
166+-- | Any @401 Unauthorized@ response must include a @WWW-Authenticate@ header.
326-- This function checks that, if a response has status code 401, it contains a
168-- This function checks that, if a response has status code 401, it contains a
327-- @WWW-Authenticate@ header.
169-- @WWW-Authenticate@ header.
@@ -329,37 +171,12 @@ linkHeadersAreValid
329-- __References__:
171-- __References__:
331-- * @WWW-Authenticate@ header: <https://tools.ietf.org/html/rfc7235#section-4.1 RFC 7235 Section 4.1>
173-- * @WWW-Authenticate@ header: <https://tools.ietf.org/html/rfc7235#section-4.1 RFC 7235 Section 4.1>
334−unauthorizedContainsWWWAuthenticate :: ResponsePredicate
174+unauthorizedContainsWWWAuthenticate :: ResponsePredicate Text Bool
335unauthorizedContainsWWWAuthenticate
175unauthorizedContainsWWWAuthenticate
336− = ResponsePredicate $ \resp ->
176+ = ResponsePredicate "unauthorizedContainsWWWAuthenticate" (\resp ->
337 if responseStatus resp == status401
177 if responseStatus resp == status401
338− then unless (hasValidHeader "WWW-Authenticate" (const True) resp) $
178+ then hasValidHeader "WWW-Authenticate" (const True) resp
339− throw $ PredicateFailure "unauthorizedContainsWWWAuthenticate" Nothing resp
340− else return ()
179+ else True)
343−-- | [__RFC Compliance__]
345−-- [An HTML] document will start with exactly this string: <!DOCTYPE html>
347−-- This function checks that HTML documents (those with `Content-Type: text/html...`)
348−-- include a DOCTYPE declaration at the top. We do not enforce capital case for the string `DOCTYPE`.
352−-- * HTML5 Doctype: <https://tools.ietf.org/html/rfc7992#section-6.1 RFC 7992 Section 6.1>
354−htmlIncludesDoctype :: ResponsePredicate
356− = ResponsePredicate $ \resp ->
357− if hasValidHeader "Content-Type" (SBS.isPrefixOf . foldCase $ "text/html") resp
359− let htmlContent = foldCase . LBS.take 20 $ responseBody resp
360− unless (LBS.isPrefixOf (foldCase "<!doctype html>") htmlContent) $
361− throw $ PredicateFailure "htmlIncludesDoctype" Nothing resp
364-- * Predicate logic
181-- * Predicate logic
@@ -369,77 +186,79 @@ htmlIncludesDoctype
370-- Still, this is all kind of ugly.
187-- Still, this is all kind of ugly.
372−-- | A predicate that depends only on the response.
375−newtype ResponsePredicate = ResponsePredicate
189+data ResponsePredicate n r = ResponsePredicate
376− { getResponsePredicate :: Response LBS.ByteString -> IO ()
191+ , respPred :: Response LBS.ByteString -> r
377− } deriving (Generic)
192+ } deriving (Functor, Generic)
379−instance Semigroup ResponsePredicate where
194+instance Bifunctor ResponsePredicate where
380− ResponsePredicate a <> ResponsePredicate b = ResponsePredicate $ \x -> a x >> b x
195+ first f (ResponsePredicate a b) = ResponsePredicate (f a) b
382−instance Monoid ResponsePredicate where
198+instance (Monoid n, Monoid r) => Monoid (ResponsePredicate n r) where
383− mempty = ResponsePredicate $ const $ return ()
199+ mempty = ResponsePredicate mempty mempty
384− mappend = (<>)
200+ a `mappend` b = ResponsePredicate
201+ { respPredName = respPredName a <> respPredName b
202+ , respPred = respPred a <> respPred b
386−-- | A predicate that depends on both the request and the response.
389−newtype RequestPredicate = RequestPredicate
205+data RequestPredicate n r = RequestPredicate
390− { getRequestPredicate :: Request -> Manager -> IO [Response LBS.ByteString]
207+ , reqResps :: Request -> Manager -> IO [Response LBS.ByteString]
208+ , reqPred :: ResponsePredicate n r
391− } deriving (Generic)
209+ } deriving (Generic, Functor)
393−-- TODO: This isn't actually a monoid
394−instance Monoid RequestPredicate where
211+instance Bifunctor RequestPredicate where
395− mempty = RequestPredicate (\r m -> httpLbs r m >>= \x -> return ([x]))
212+ first f (RequestPredicate a b c) = RequestPredicate (f a) b (first f c)
396− mappend = (<>)
213+ second = fmap
398-- TODO: This isn't actually a monoid
215-- TODO: This isn't actually a monoid
399−instance Semigroup RequestPredicate where
216+instance (Monoid n, Monoid r) => Monoid (RequestPredicate n r) where
400− RequestPredicate a <> RequestPredicate b = RequestPredicate $ \r mgr ->
217+ mempty = RequestPredicate mempty (\r m -> return <$> httpLbs r m) mempty
401− liftM2 (<>) (a r mgr) (b r mgr)
218+ a `mappend` b = RequestPredicate
402−
219+ { reqPredName = reqPredName a <> reqPredName b
403−-- | A set of predicates. Construct one with 'mempty' and '<%>'.
220+ , reqResps = \x m -> liftM2 (<>) (reqResps a x m) (reqResps b x m)
221+ , reqPred = reqPred a <> reqPred b
404−data Predicates = Predicates
224+data Predicates n r = Predicates
405− { requestPredicates :: RequestPredicate
225+ { reqPreds :: RequestPredicate n r
406− , responsePredicates :: ResponsePredicate
226+ , respPreds :: ResponsePredicate n r
407− } deriving (Generic)
227+ } deriving (Generic, Functor)
229+instance (Monoid n, Monoid r) => Monoid (Predicates n r) where
230+ mempty = Predicates mempty mempty
231+ a `mappend` b = Predicates (reqPreds a <> reqPreds b) (respPreds a <> respPreds b)
409−instance Semigroup Predicates where
410− a <> b = Predicates (requestPredicates a <> requestPredicates b)
411− (responsePredicates a <> responsePredicates b)
413−instance Monoid Predicates where
414− mempty = Predicates mempty mempty
417class JoinPreds a where
235class JoinPreds a where
418− joinPreds :: a -> Predicates -> Predicates
236+ joinPreds :: a -> Predicates [Text] [Text] -> Predicates [Text] [Text]
420−instance JoinPreds (RequestPredicate ) where
238+instance JoinPreds (RequestPredicate Text Bool) where
421− joinPreds p (Predicates x y) = Predicates (p <> x) y
239+ joinPreds p (Predicates x y) = Predicates (go <> x) y
240+ where go = let p' = first return p
241+ in fmap (\z -> if z then [] else reqPredName p') p'
243+instance JoinPreds (ResponsePredicate Text Bool) where
244+ joinPreds p (Predicates x y) = Predicates x (go <> y)
245+ where go = let p' = first return p
246+ in fmap (\z -> if z then [] else respPredName p') p'
423−instance JoinPreds (ResponsePredicate ) where
424− joinPreds p (Predicates x y) = Predicates x (p <> y)
426-- | Adds a new predicate (either `ResponsePredicate` or `RequestPredicate`) to
249-- | Adds a new predicate (either `ResponsePredicate` or `RequestPredicate`) to
427-- the existing predicates.
250-- the existing predicates.
429-- > not500 <%> onlyJsonObjects <%> empty
252-- > not500 <%> onlyJsonObjects <%> empty
432−(<%>) :: JoinPreds a => a -> Predicates -> Predicates
253+(<%>) :: JoinPreds a => a -> Predicates [Text] [Text] -> Predicates [Text] [Text]
433(<%>) = joinPreds
254(<%>) = joinPreds
434infixr 6 <%>
255infixr 6 <%>
436−finishPredicates :: Predicates -> Request -> Manager -> IO (Maybe PredicateFailure)
257+finishPredicates :: Predicates [Text] [Text] -> Request -> Manager -> IO [Text]
437−finishPredicates p req mgr = go `catch` \(e :: PredicateFailure) -> return $ Just e
258+finishPredicates p req mgr = do
438− where
259+ resps <- reqResps (reqPreds p) req mgr
439− go = do
260+ let preds = reqPred (reqPreds p) <> respPreds p
440− resps <- getRequestPredicate (requestPredicates p) req mgr
261+ return $ mconcat [respPred preds r | r <- resps ]
441− mapM_ (getResponsePredicate $ responsePredicates p) resps
444-- * helpers
263-- * helpers
@@ -447,15 +266,3 @@ hasValidHeader :: SBS.ByteString -> (SBS.ByteString -> Bool) -> Response b -> Bo
447hasValidHeader hdr p r = case lookup (mk hdr) (responseHeaders r) of
266hasValidHeader hdr p r = case lookup (mk hdr) (responseHeaders r) of
448 Nothing -> False
267 Nothing -> False
449 Just v -> p v
268 Just v -> p v
451−isRFC822Date :: SBS.ByteString -> Bool
453− = case parseTimeM True defaultTimeLocale rfc822DateFormat (SBSC.unpack s) of
455− Just (_ :: UTCTime) -> True
457−status2XX :: Monad m => Maybe Request -> Response LBS.ByteString -> T.Text -> m ()
458−status2XX mreq resp t
459− | status200 <= responseStatus resp && responseStatus resp < status300
461− | otherwise = throw $ PredicateFailure t mreq resp