git.iko.soy/servant
on master help sign in
Only add a ? when query string is nonempty (#1589)
1fba9dcIan Shipman
changelog.d/1589new file+2
compare with master
unifiedsplit
@@ -0,0 +1,2 @@
1+synopsis: Only include question mark for nonempty query strings
2+prs: 1589
servant-client/src/Servant/Client/Internal/HttpClient.hs+2−1
@@ -289,7 +289,8 @@ defaultMakeClientRequest burl r = Client.defaultRequest
289 Https -> True
289 Https -> True
290
290
291 -- Query string builder which does not do any encoding
291 -- Query string builder which does not do any encoding
292+ buildQueryString [] = mempty
292− buildQueryString = ("?" <>) . foldl' addQueryParam mempty
293+ buildQueryString qps = "?" <> foldl' addQueryParam mempty qps
293
294
294 addQueryParam qs (k, v) =
295 addQueryParam qs (k, v) =
295 qs <> (if BS.null qs then mempty else "&") <> urlEncode True k <> foldMap ("=" <>) v
296 qs <> (if BS.null qs then mempty else "&") <> urlEncode True k <> foldMap ("=" <>) v