From 43eee83c33ccc56af9c56fa6c67e47d551090068 Mon Sep 17 00:00:00 2001
From: Simon Michael <simon@joyful.com>
Date: Mon, 21 Jul 2014 08:54:17 -0700
Subject: [PATCH] web: fix js error on journal select field

---
 hledger-web/Foundation.hs     |  2 +-
 hledger-web/static/hledger.js | 60 +++++++++++++++++------------------
 2 files changed, 30 insertions(+), 32 deletions(-)

diff --git a/hledger-web/Foundation.hs b/hledger-web/Foundation.hs
index 06c6cc185..44a0828e0 100644
--- a/hledger-web/Foundation.hs
+++ b/hledger-web/Foundation.hs
@@ -379,7 +379,7 @@ addform _ vd@VD{..} = [hamlet|
 
 journalselect :: [(FilePath,String)] -> HtmlUrl AppRoute
 journalselect journalfiles = [hamlet|
-<select id=journalselect name=journal onchange="journalSelect(event)">
+<select id=journalselect name=journal onchange="/*journalSelect(event)*/">
  $forall f <- journalfiles
   <option value=#{fst f}>#{fst f}
 |]
diff --git a/hledger-web/static/hledger.js b/hledger-web/static/hledger.js
index f4190f4b9..4f7aebede 100644
--- a/hledger-web/static/hledger.js
+++ b/hledger-web/static/hledger.js
@@ -247,25 +247,6 @@ function addformDeletePosting() {
   if (focuslost) $('#addform tr.posting:last > td:first input:last').focus();
 }
 
-function journalSelect(ev) {
-  var textareas = $('textarea', $('form#editform'));
-  for (i=0; i<textareas.length; i++) {
-    textareas[i].style.display = 'none';
-    textareas[i].disabled = true;
-  }
-  var targ = getTarget(ev);
-  if (targ.value) {
-    var journalid = targ.value+'_textarea';
-    var textarea = document.getElementById(journalid);
-  }
-  else {
-    var textarea = textareas[0];
-  }
-  textarea.style.display = 'block';
-  textarea.disabled = false;
-  return true;
-}
-
 //----------------------------------------------------------------------
 // SIDEBAR
 
@@ -314,15 +295,32 @@ function enableTypeahead($el, suggester) {
   );
 }
 
-/*
-// Get the current event's target in a robust way.
-// http://www.quirksmode.org/js/events_properties.html
-function getTarget(ev) {
-  var targ;
-  if (!ev) var ev = window.event;
-  if (ev.target) targ = ev.target;
-  else if (ev.srcElement) targ = ev.srcElement;
-  if (targ.nodeType == 3) targ = targ.parentNode;
-  return targ;
-}
-*/
+// function journalSelect(ev) {
+//   var textareas = $('textarea', $('form#editform'));
+//   for (i=0; i<textareas.length; i++) {
+//     textareas[i].style.display = 'none';
+//     textareas[i].disabled = true;
+//   }
+//   var targ = getTarget(ev);
+//   if (targ.value) {
+//     var journalid = targ.value+'_textarea';
+//     var textarea = document.getElementById(journalid);
+//   }
+//   else {
+//     var textarea = textareas[0];
+//   }
+//   textarea.style.display = 'block';
+//   textarea.disabled = false;
+//   return true;
+// }
+
+// // Get the current event's target in a robust way.
+// // http://www.quirksmode.org/js/events_properties.html
+// function getTarget(ev) {
+//   var targ;
+//   if (!ev) var ev = window.event;
+//   if (ev.target) targ = ev.target;
+//   else if (ev.srcElement) targ = ev.srcElement;
+//   if (targ.nodeType == 3) targ = targ.parentNode;
+//   return targ;
+// }