Replace showPosting with a wrapper around postingAsLines.
The functions textConcat(Top|Bottom)Padded are no longer used anywhere
in the code base, and can be removed if desired.
This produces slightly different output for showPosting, in particular
it no longer displays the transaction date. However, this has been
marked as ‘for debugging only’ for a while, and is only used in
hledger-check-fancy assertions. The output there is still acceptable.
This will not change the results computed for the typical use-case,
just makes "roi" more thorough/consistent by supporting posting dates
when they are provided.
The # syntax for comments results in all the lines being rendered as
separate headers because it's markdown syntax for titles. I believe the
markdown custom is to use `<!-- HTML comments -->`.
[ci skip]
The URL in the PR template redirects to a general contributing guide,
which is useful, but it's hard to see the trees for the forest when just
looking for PR and commit guidelines.
[ci skip]
The offending syntax is no longer used so the comment can be removed
too. Ideally `allow-newer` isn't used in the project's setup. The
problem should rather be fixed by adjusting constraints, though these
adjustments may need to be made in dependencies upstream.
Fixes#1365
[ci skip]
Use an org export setting in BACKLOG.org and ROADMAP.org to disable
-- being converted to dashes. Leave the markdown+smart workaround
in Shake.hs also, it's doing no harm and seems useful as backup.
':nil would disable smart quotes as well, but that seems to be org's
default.
Combining valuation with filtration is subtle and error-prone (see e.g. #1625).
We have to do in in both MultiBalanceReport and PostingsReport, where it
is done in slightly different ways. This refactors this functionality
into separate functions which are called in both reports, for uniform
behaviour.
