on master help sign in
Merge pull request #3086 from lwm/maybe-have-template

Proposal: add NBs to a pull request template.

commit7a7edc23d3bea054456fbe28bbe56f584d7328f1 authorLuke Murphy <lwm@users.noreply.github.com> dateFri 15 Dec 2017, 11:46 (9 years ago) parente8a6f45f954081
2 files changed+5−11
.github/PULL_REQUEST_TEMPLATE.md+5 MAINTAINERS.md−11
.github/PULL_REQUEST_TEMPLATE.mdnew file+5
@@ -0,0 +1,5 @@
1+Checklist:
2+- [ ] Meaningful commit message.
3+- [ ] Some time passed since Hackage upload.
4+- [ ] Tested with Stackage Nightly.
5+---
MAINTAINERS.md−11
@@ -63,17 +63,6 @@ $ cabal test
6363$ cabal haddock
6464```
6565
66−**NB** Please use commit messages like "add foo-bar" or "add johndev's packages"
67−(`build-constraints.yaml` is the most frequently changed file in this git repo
68−so commit messages like "update build-constraints.yaml" are not helpful).
69−
70−**NB2** There can be a delay of up to an hour before package versions
71−newly uploaded to Hackage appear to our build server. If you just
72−uploaded a package to Hackage that you're trying to get included, we
73−recommend waiting an hour before opening the PR. You can verify this
74−by making sure the latest version is listed at
75−https://github.com/commercialhaskell/all-cabal-metadata/tree/master/packages/.
76−
7766## Github and Notifications
7867
7968Stackage uses Github notifications to reduce overhead of contacting individual