git.iko.soy/stackage
on master help sign in
Use HASKELL_PACKAGE_SANDBOX for tests haskell/cabal#2034
d51181aMichael Snoyman
Stackage/Test.hs+5−14
compare with master
unifiedsplit
@@ -102,23 +102,14 @@ runTestSuite :: CabalVersion
102runTestSuite cabalVersion settings testdir (packageName, SelectedPackageInfo {..}) = do
102runTestSuite cabalVersion settings testdir (packageName, SelectedPackageInfo {..}) = do
103 -- Set up a new environment that includes the sandboxed bin folder in PATH.
103 -- Set up a new environment that includes the sandboxed bin folder in PATH.
104 env' <- getModifiedEnv settings
104 env' <- getModifiedEnv settings
105− let menv addGPP
106− = Just $ (if addGPP then (("GHC_PACKAGE_PATH", packageDir settings ++ ":"):) else id)
107− $ addSandbox env'
105+ let menv = Just $ addSandbox env'
108− -- FIXME why do these packages require the workaround?
109− bannedSandboxVar = map PackageName $ words "wai-logger warp"
110− addSandbox
111− | packageName `elem` bannedSandboxVar = id
112− | otherwise = (("HASKELL_PACKAGE_SANDBOX", packageDir settings):)
106+ addSandbox = (("HASKELL_PACKAGE_SANDBOX", packageDir settings):)
113
107
114− let runGen addGPP cmd args wdir handle' = do
108+ let run cmd args wdir handle' = do
115− ph <- runProcess cmd args (Just wdir) (menv addGPP) Nothing (Just handle') (Just handle')
109+ ph <- runProcess cmd args (Just wdir) menv Nothing (Just handle') (Just handle')
116 ec <- waitForProcess ph
110 ec <- waitForProcess ph
117 unless (ec == ExitSuccess) $ throwIO TestException
111 unless (ec == ExitSuccess) $ throwIO TestException
118
112
119− let run = runGen False
120− runGhcPackagePath = runGen True
121−
122 passed <- handle (\TestException -> return False) $ do
113 passed <- handle (\TestException -> return False) $ do
123 package' <- replaceTarball (tarballDir settings) package
114 package' <- replaceTarball (tarballDir settings) package
124 getHandle WriteMode $ run "cabal" ["unpack", package'] testdir
115 getHandle WriteMode $ run "cabal" ["unpack", package'] testdir
@@ -134,7 +125,7 @@ runTestSuite cabalVersion settings testdir (packageName, SelectedPackageInfo {..
134 getHandle AppendMode $ run "cabal" (addCabalArgs settings BSTest ["configure", "--enable-tests"]) dir
125 getHandle AppendMode $ run "cabal" (addCabalArgs settings BSTest ["configure", "--enable-tests"]) dir
135 when spiHasTests $ do
126 when spiHasTests $ do
136 getHandle AppendMode $ run "cabal" ["build"] dir
127 getHandle AppendMode $ run "cabal" ["build"] dir
137− getHandle AppendMode $ runGhcPackagePath "cabal" (concat
128+ getHandle AppendMode $ run "cabal" (concat
138 [ ["test"]
129 [ ["test"]
139 , if cabalVersion >= CabalVersion 1 20
130 , if cabalVersion >= CabalVersion 1 20
140 then ["--show-details=streaming"] -- FIXME temporary workaround for https://github.com/haskell/cabal/issues/1810
131 then ["--show-details=streaming"] -- FIXME temporary workaround for https://github.com/haskell/cabal/issues/1810