6fd884e · streamly · git.iko.soy

git.iko.soy/streamly

Move non-GHC2021 extensions in a separate section

commit6fd884e0945b15b7ea450c4ff3ab1d9a0c718196 authorHarendra Kumar <harendra@composewell.com> dateSun 14 Jan 2024, 14:58 (3 years ago) parentbd8befb

12 files changed+63−23

compare with master

unifiedsplit

core/src/Streamly/Internal/Data/Array/Type.hs+4

@@ -1,4 +1,8 @@

11{-# LANGUAGE CPP #-}

2+{-# LANGUAGE TypeFamilies #-}

3+-- Must come after TypeFamilies, otherwise it is re-enabled.

4+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

5+{-# LANGUAGE NoMonoLocalBinds #-}

26-- |

37-- Module : Streamly.Internal.Data.Array.Type

core/src/Streamly/Internal/Data/IsMap.hs+4

@@ -1,3 +1,7 @@

1+{-# LANGUAGE TypeFamilies #-}

2+-- Must come after TypeFamilies, otherwise it is re-enabled.

3+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

4+{-# LANGUAGE NoMonoLocalBinds #-}

15-- |

26-- Module : Streamly.Internal.Data.IsMap

core/src/Streamly/Internal/Data/Stream/Type.hs+6

@@ -1,5 +1,11 @@

11{-# LANGUAGE CPP #-}

2+{-# LANGUAGE PatternSynonyms #-}

3+{-# LANGUAGE TypeFamilies #-}

4+-- Must come after TypeFamilies, otherwise it is re-enabled.

5+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

6+{-# LANGUAGE NoMonoLocalBinds #-}

27{-# LANGUAGE UndecidableInstances #-}

8+{-# LANGUAGE ViewPatterns #-}

410-- |

511-- Module : Streamly.Internal.Data.Stream.Type

core/src/Streamly/Internal/Data/StreamK/Type.hs+4

@@ -1,4 +1,8 @@

11{-# LANGUAGE CPP #-}

2+{-# LANGUAGE TypeFamilies #-}

3+-- Must come after TypeFamilies, otherwise it is re-enabled.

4+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

5+{-# LANGUAGE NoMonoLocalBinds #-}

26{-# LANGUAGE UndecidableInstances #-}

37-- |

48-- Module : Streamly.Internal.Data.StreamK.Type

core/src/Streamly/Internal/Data/Time/Units.hs−4

@@ -1,7 +1,3 @@

1−{-# LANGUAGE DataKinds #-}

2−{-# LANGUAGE PolyKinds #-}

3−{-# LANGUAGE UnboxedTuples #-}

4−

51-- |

62-- Module : Streamly.Internal.Data.Time.Units

core/src/Streamly/Internal/Data/Unbox.hs+4−1

@@ -1,5 +1,8 @@

11{-# LANGUAGE DataKinds #-}

2−{-# LANGUAGE DefaultSignatures #-}

2+{-# LANGUAGE TypeFamilies #-}

3+-- Must come after TypeFamilies, otherwise it is re-enabled.

4+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

5+{-# LANGUAGE NoMonoLocalBinds #-}

36{-# LANGUAGE UnboxedTuples #-}

47{-# LANGUAGE UndecidableInstances #-}

core/streamly-core.cabal+12−9

@@ -218,8 +218,6 @@ common compile-options

218218common default-extensions

219219 default-extensions:

220220 BangPatterns

221− CApiFFI

222− CPP

223221 ConstraintKinds

224222 DeriveDataTypeable

225223 DeriveGeneric

@@ -230,24 +228,29 @@ common default-extensions

230228 GeneralizedNewtypeDeriving

231229 InstanceSigs

232230 KindSignatures

233− LambdaCase

234− MagicHash

235231 MultiParamTypeClasses

236− PatternSynonyms

237232 RankNTypes

238− RecordWildCards

239233 ScopedTypeVariables

240234 StandaloneDeriving

241235 TupleSections

242236 TypeApplications

243− TypeFamilies

244237 TypeOperators

245− ViewPatterns

246238

239+ -- Not GHC2021

240+ CApiFFI

241+ CPP

242+ DefaultSignatures

243+ LambdaCase

244+ MagicHash

245+ RecordWildCards

246+

247+ -- TypeFamilies is required by IsList, IsMap type classes and

248+ -- Unbox generic deriving code.

249+ -- TypeFamilies

247250 -- MonoLocalBinds, enabled by TypeFamilies, causes performance

248251 -- regressions. Disable it. This must come after TypeFamilies,

249252 -- otherwise TypeFamilies will enable it again.

250− NoMonoLocalBinds

253+ -- NoMonoLocalBinds

251254

252255 -- UndecidableInstances -- Does not show any perf impact

253256 -- UnboxedTuples -- interferes with (#.)

src/Streamly/Internal/Data/IsMap/HashMap.hs+5

@@ -1,3 +1,8 @@

1+{-# LANGUAGE TypeFamilies #-}

2+-- Must come after TypeFamilies, otherwise it is re-enabled.

3+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

4+{-# LANGUAGE NoMonoLocalBinds #-}

16{-# OPTIONS_GHC -Wno-orphans #-}

38-- |

src/Streamly/Internal/Data/Stream/IsStream/Expand.hs+5

@@ -1,3 +1,8 @@

1+{-# LANGUAGE TypeFamilies #-}

2+-- Must come after TypeFamilies, otherwise it is re-enabled.

3+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

4+{-# LANGUAGE NoMonoLocalBinds #-}

16{-# OPTIONS_GHC -Wno-deprecations #-}

38-- |

src/Streamly/Internal/Data/Stream/Serial.hs+5

@@ -1,4 +1,9 @@

1+{-# LANGUAGE TypeFamilies #-}

2+-- Must come after TypeFamilies, otherwise it is re-enabled.

3+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

4+{-# LANGUAGE NoMonoLocalBinds #-}

15{-# LANGUAGE UndecidableInstances #-}

27{-# OPTIONS_GHC -Wno-deprecations #-}

38{-# OPTIONS_GHC -Wno-redundant-constraints #-}

src/Streamly/Internal/Data/Stream/Zip.hs+5

@@ -1,4 +1,9 @@

1+{-# LANGUAGE TypeFamilies #-}

2+-- Must come after TypeFamilies, otherwise it is re-enabled.

3+-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.

4+{-# LANGUAGE NoMonoLocalBinds #-}

15{-# LANGUAGE UndecidableInstances #-}

27{-# OPTIONS_GHC -Wno-deprecations #-}

49-- |

streamly.cabal+9−9

@@ -294,8 +294,6 @@ common compile-options

294294common default-extensions

295295 default-extensions:

296296 BangPatterns

297− CApiFFI

298− CPP

299297 ConstraintKinds

300298 DeriveDataTypeable

301299 DeriveGeneric

@@ -306,23 +304,25 @@ common default-extensions

306304 GeneralizedNewtypeDeriving

307305 InstanceSigs

308306 KindSignatures

309− LambdaCase

310− MagicHash

311307 MultiParamTypeClasses

312− PatternSynonyms

313308 RankNTypes

314− RecordWildCards

315309 ScopedTypeVariables

316310 TupleSections

317311 TypeApplications

318− TypeFamilies

319312 TypeOperators

320− ViewPatterns

321313

314+ -- Not GHC2021

315+ CApiFFI

316+ CPP

317+ LambdaCase

318+ MagicHash

319+ RecordWildCards

320+

321+ -- TypeFamilies -- required by IsHashMap type class

322322 -- MonoLocalBinds, enabled by TypeFamilies, causes performance

323323 -- regressions. Disable it. This must come after TypeFamilies,

324324 -- otherwise TypeFamilies will enable it again.

325− NoMonoLocalBinds

325+ -- NoMonoLocalBinds

326326

327327 -- UndecidableInstances -- Does not show any perf impact

328328 -- UnboxedTuples -- interferes with (#.)