on master help sign in
update pr merge checklist
879d159Harendra Kumar
MAINTAINING.md+8−4
@@ -5,11 +5,15 @@
5* All the CI tests pass
5* All the CI tests pass
6* New tests are added where applicable
6* New tests are added where applicable
7* Benchmarks are added where applicable
7* Benchmarks are added where applicable
8−* hlint
9* Run benchmarks locally if you suspect any regressions
8* Run benchmarks locally if you suspect any regressions
10−* If the PR is by someone other than you yourself then merge with a merge
9+* Documentation is added for any new combinators
11− commit, otherwise merge by rebasing on master without a separate merge
10+* Changelog entry is added for exposed combinators.
12− commit.
11+* Optionally, look at hlint output if anything in that is worth fixing.
12+* Merge the PR by rebasing. Note that github always creates new commits when
13+ merged with rebase, it records the committer as well as the author in the
14+ commit. This makes the local branch diverge from master. You can rebase and
15+ merge the commit manually in your local git tree and push the resulting
16+ master branch to avoid new commits and divergence from the original tree.
13
17
14## Release Checklist
18## Release Checklist
15
19