@@ -124,15 +124,16 @@ run_bench () {
124 find_bench_prog
124 find_bench_prog
125 mkdir -p charts
125 mkdir -p charts
127− # We set min-samples to 1 so that we run with default benchmark duration of 5
127+ # We set min-samples to 3 if we use less than three samples, statistical
128− # seconds, whatever number of samples are possible in that.
128+ # analysis crashes. Note that the benchmark runs for a minimum of 5 seconds.
129− # We run just one iteration for each sample. Anyway the default is to run
129+ # We use min-duration=0 to run just one iteration for each sample. Anyway the
130+ # default is to run iterations worth minimum 30 ms and most of our benchmarks
130− # for 30 ms and most our benchmarks are close to that or more.
131+ # are close to that or more.
131− # If we use less than three samples, statistical analysis crashes
132 $BENCH_PROG $ENABLE_QUICK \
132 $BENCH_PROG $ENABLE_QUICK \
133 --include-first-iter \
133 --include-first-iter \
134 --min-samples 3 \
134 --min-samples 3 \
135 --min-duration 0 \
135 --min-duration 0 \
136 --csvraw=$OUTPUT_FILE \
137 --csvraw=$OUTPUT_FILE \
138 --measure-with $BENCH_PROG $GAUGE_ARGS || die "Benchmarking failed"
139 --measure-with $BENCH_PROG $GAUGE_ARGS || die "Benchmarking failed"