on ff40cf0 help sign in
benchmark/Streamly/Benchmark/FileSystem/Handle/Read.hs+8−7
since splitsnapshots
unifiedsplit
@@ -33,6 +33,7 @@ import qualified Streamly.Data.Stream as Stream
33import qualified Streamly.Data.Fold as Fold
33import qualified Streamly.Data.Fold as Fold
34import qualified Streamly.FileSystem.Handle as FH
34import qualified Streamly.FileSystem.Handle as FH
35import qualified Streamly.Internal.Data.Array as A
35import qualified Streamly.Internal.Data.Array as A
36+import qualified Streamly.Internal.Data.Array as AT
36import qualified Streamly.Internal.Data.Fold as FL
37import qualified Streamly.Internal.Data.Fold as FL
37import qualified Streamly.Internal.Data.Stream as IP
38import qualified Streamly.Internal.Data.Stream as IP
38import qualified Streamly.Internal.FileSystem.Handle as IFH
39import qualified Streamly.Internal.FileSystem.Handle as IFH
@@ -47,7 +48,7 @@ import Streamly.Benchmark.Common.Handle
47#ifdef INSPECTION
48#ifdef INSPECTION
48import Streamly.Internal.Data.Stream (Step(..), FoldMany)
49import Streamly.Internal.Data.Stream (Step(..), FoldMany)
49
50
50−import qualified Streamly.Internal.Data.MutArray as MutArray
51+import qualified Streamly.Internal.Data.MutArray as MA
51import qualified Streamly.Internal.Data.Stream as D
52import qualified Streamly.Internal.Data.Stream as D
52import qualified Streamly.Internal.Data.Unfold as IUF
53import qualified Streamly.Internal.Data.Unfold as IUF
53
54
@@ -68,7 +69,7 @@ readLast = S.fold Fold.last . S.unfold FH.reader
68inspect $ hasNoTypeClasses 'readLast
69inspect $ hasNoTypeClasses 'readLast
69inspect $ 'readLast `hasNoType` ''Step -- S.unfold
70inspect $ 'readLast `hasNoType` ''Step -- S.unfold
70inspect $ 'readLast `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
71inspect $ 'readLast `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
71−inspect $ 'readLast `hasNoType` ''MutArray.ArrayUnsafe -- FH.read/A.read
72+inspect $ 'readLast `hasNoType` ''MA.ArrayUnsafe -- FH.read/A.read
72#endif
73#endif
73
74
74-- assert that flattenArrays constructors are not present
75-- assert that flattenArrays constructors are not present
@@ -80,7 +81,7 @@ readCountBytes = S.fold Fold.length . S.unfold FH.reader
80inspect $ hasNoTypeClasses 'readCountBytes
81inspect $ hasNoTypeClasses 'readCountBytes
81inspect $ 'readCountBytes `hasNoType` ''Step -- S.unfold
82inspect $ 'readCountBytes `hasNoType` ''Step -- S.unfold
82inspect $ 'readCountBytes `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
83inspect $ 'readCountBytes `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
83−inspect $ 'readCountBytes `hasNoType` ''MutArray.ArrayUnsafe -- FH.read/A.read
84+inspect $ 'readCountBytes `hasNoType` ''MA.ArrayUnsafe -- FH.read/A.read
84#endif
85#endif
85
86
86-- | Count the number of lines in a file.
87-- | Count the number of lines in a file.
@@ -95,7 +96,7 @@ readCountLines =
95inspect $ hasNoTypeClasses 'readCountLines
96inspect $ hasNoTypeClasses 'readCountLines
96inspect $ 'readCountLines `hasNoType` ''Step
97inspect $ 'readCountLines `hasNoType` ''Step
97inspect $ 'readCountLines `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
98inspect $ 'readCountLines `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
98−inspect $ 'readCountLines `hasNoType` ''MutArray.ArrayUnsafe -- FH.read/A.read
99+inspect $ 'readCountLines `hasNoType` ''MA.ArrayUnsafe -- FH.read/A.read
99#endif
100#endif
100
101
101-- | Count the number of words in a file.
102-- | Count the number of words in a file.
@@ -119,7 +120,7 @@ readSumBytes = S.fold Fold.sum . S.unfold FH.reader
119inspect $ hasNoTypeClasses 'readSumBytes
120inspect $ hasNoTypeClasses 'readSumBytes
120inspect $ 'readSumBytes `hasNoType` ''Step
121inspect $ 'readSumBytes `hasNoType` ''Step
121inspect $ 'readSumBytes `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
122inspect $ 'readSumBytes `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
122−inspect $ 'readSumBytes `hasNoType` ''MutArray.ArrayUnsafe -- FH.read/A.read
123+inspect $ 'readSumBytes `hasNoType` ''MA.ArrayUnsafe -- FH.read/A.read
123#endif
124#endif
124
125
125-- XXX When we mark this with INLINE and we have two benchmarks using S.drain
126-- XXX When we mark this with INLINE and we have two benchmarks using S.drain
@@ -235,13 +236,13 @@ groupsOf :: Int -> Handle -> IO Int
235groupsOf n inh =
236groupsOf n inh =
236 -- writeNUnsafe gives 2.5x boost here over writeN.
237 -- writeNUnsafe gives 2.5x boost here over writeN.
237 S.fold Fold.length
238 S.fold Fold.length
238− $ IP.groupsOf n (A.writeNUnsafe n) (S.unfold FH.reader inh)
239+ $ IP.groupsOf n (AT.writeNUnsafe n) (S.unfold FH.reader inh)
239
240
240#ifdef INSPECTION
241#ifdef INSPECTION
241inspect $ hasNoTypeClasses 'groupsOf
242inspect $ hasNoTypeClasses 'groupsOf
242inspect $ 'groupsOf `hasNoType` ''Step
243inspect $ 'groupsOf `hasNoType` ''Step
243inspect $ 'groupsOf `hasNoType` ''FoldMany
244inspect $ 'groupsOf `hasNoType` ''FoldMany
244−inspect $ 'groupsOf `hasNoType` ''MutArray.ArrayUnsafe -- AT.writeNUnsafe
245+inspect $ 'groupsOf `hasNoType` ''AT.ArrayUnsafe -- AT.writeNUnsafe
245 -- FH.read/A.read
246 -- FH.read/A.read
246inspect $ 'groupsOf `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
247inspect $ 'groupsOf `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
247#endif
248#endif
benchmark/Streamly/Benchmark/FileSystem/Handle/ReadWrite.hs+9−8
@@ -42,7 +42,8 @@ import Streamly.Internal.Data.Stream (Step(..))
42
42
43import qualified Streamly.Internal.Data.Stream as D
43import qualified Streamly.Internal.Data.Stream as D
44import qualified Streamly.Internal.Data.Tuple.Strict as Strict
44import qualified Streamly.Internal.Data.Tuple.Strict as Strict
45−import qualified Streamly.Internal.Data.MutArray as MutArray
45+import qualified Streamly.Internal.Data.MutArray.Stream as MAS
46+import qualified Streamly.Internal.Data.Array as AT
46
47
47import Test.Inspection
48import Test.Inspection
48#endif
49#endif
@@ -82,7 +83,7 @@ copyStream inh outh = S.fold (FH.write outh) (S.unfold FH.reader inh)
82inspect $ hasNoTypeClasses 'copyStream
83inspect $ hasNoTypeClasses 'copyStream
83inspect $ 'copyStream `hasNoType` ''Step -- S.unfold
84inspect $ 'copyStream `hasNoType` ''Step -- S.unfold
84inspect $ 'copyStream `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
85inspect $ 'copyStream `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
85−inspect $ 'copyStream `hasNoType` ''MutArray.ArrayUnsafe -- FH.write/writeNUnsafe
86+inspect $ 'copyStream `hasNoType` ''AT.ArrayUnsafe -- FH.write/writeNUnsafe
86 -- FH.read/A.read
87 -- FH.read/A.read
87inspect $ 'copyStream `hasNoType` ''Strict.Tuple3' -- FH.write/chunksOf
88inspect $ 'copyStream `hasNoType` ''Strict.Tuple3' -- FH.write/chunksOf
88#endif
89#endif
@@ -108,8 +109,8 @@ readFromBytesNull inh devNull = IFH.putBytes devNull $ S.unfold FH.reader inh
108#ifdef INSPECTION
109#ifdef INSPECTION
109inspect $ hasNoTypeClasses 'readFromBytesNull
110inspect $ hasNoTypeClasses 'readFromBytesNull
110inspect $ 'readFromBytesNull `hasNoType` ''Step
111inspect $ 'readFromBytesNull `hasNoType` ''Step
111−inspect $ 'readFromBytesNull `hasNoType` ''MutArray.SpliceState
112+inspect $ 'readFromBytesNull `hasNoType` ''MAS.SpliceState
112−inspect $ 'readFromBytesNull `hasNoType` ''MutArray.ArrayUnsafe -- FH.fromBytes/S.chunksOf
113+inspect $ 'readFromBytesNull `hasNoType` ''AT.ArrayUnsafe -- FH.fromBytes/S.chunksOf
113inspect $ 'readFromBytesNull `hasNoType` ''D.FoldMany
114inspect $ 'readFromBytesNull `hasNoType` ''D.FoldMany
114#endif
115#endif
115
116
@@ -122,8 +123,8 @@ readWithFromBytesNull inh devNull =
122#ifdef INSPECTION
123#ifdef INSPECTION
123inspect $ hasNoTypeClasses 'readWithFromBytesNull
124inspect $ hasNoTypeClasses 'readWithFromBytesNull
124inspect $ 'readWithFromBytesNull `hasNoType` ''Step
125inspect $ 'readWithFromBytesNull `hasNoType` ''Step
125−inspect $ 'readWithFromBytesNull `hasNoType` ''MutArray.SpliceState
126+inspect $ 'readWithFromBytesNull `hasNoType` ''MAS.SpliceState
126−inspect $ 'readWithFromBytesNull `hasNoType` ''MutArray.ArrayUnsafe -- FH.fromBytes/S.chunksOf
127+inspect $ 'readWithFromBytesNull `hasNoType` ''AT.ArrayUnsafe -- FH.fromBytes/S.chunksOf
127inspect $ 'readWithFromBytesNull `hasNoType` ''D.FoldMany
128inspect $ 'readWithFromBytesNull `hasNoType` ''D.FoldMany
128#endif
129#endif
129
130
@@ -170,7 +171,7 @@ writeReadWith inh devNull = IUF.fold fld unf (defaultChunkSize, inh)
170inspect $ hasNoTypeClasses 'writeReadWith
171inspect $ hasNoTypeClasses 'writeReadWith
171inspect $ 'writeReadWith `hasNoType` ''Step
172inspect $ 'writeReadWith `hasNoType` ''Step
172inspect $ 'writeReadWith `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
173inspect $ 'writeReadWith `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
173−inspect $ 'writeReadWith `hasNoType` ''MutArray.ArrayUnsafe -- FH.write/writeNUnsafe
174+inspect $ 'writeReadWith `hasNoType` ''AT.ArrayUnsafe -- FH.write/writeNUnsafe
174 -- FH.read/A.read
175 -- FH.read/A.read
175#endif
176#endif
176
177
@@ -187,7 +188,7 @@ writeRead inh devNull = IUF.fold fld unf inh
187inspect $ hasNoTypeClasses 'writeRead
188inspect $ hasNoTypeClasses 'writeRead
188inspect $ 'writeRead `hasNoType` ''Step
189inspect $ 'writeRead `hasNoType` ''Step
189inspect $ 'writeRead `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
190inspect $ 'writeRead `hasNoType` ''IUF.ConcatState -- FH.read/UF.many
190−inspect $ 'writeRead `hasNoType` ''MutArray.ArrayUnsafe -- FH.write/writeNUnsafe
191+inspect $ 'writeRead `hasNoType` ''AT.ArrayUnsafe -- FH.write/writeNUnsafe
191 -- FH.read/A.read
192 -- FH.read/A.read
192#endif
193#endif
193
194
benchmark/Streamly/Benchmark/Unicode/Stream.hs+3−4
@@ -45,10 +45,9 @@ import Streamly.Benchmark.Common.Handle
45#ifdef INSPECTION
45#ifdef INSPECTION
46import Streamly.Internal.Data.MutByteArray (Unbox)
46import Streamly.Internal.Data.MutByteArray (Unbox)
47import Streamly.Internal.Data.Stream (Step(..))
47import Streamly.Internal.Data.Stream (Step(..))
48−import qualified Streamly.Internal.Data.Array as Array
49−import qualified Streamly.Internal.Data.MutArray as MutArray
50import qualified Streamly.Internal.Data.Fold as Fold
48import qualified Streamly.Internal.Data.Fold as Fold
51import qualified Streamly.Internal.Data.Tuple.Strict as Strict
49import qualified Streamly.Internal.Data.Tuple.Strict as Strict
50+import qualified Streamly.Internal.Data.Array as Array
52
51
53import Test.Inspection
52import Test.Inspection
54#endif
53#endif
@@ -224,7 +223,7 @@ inspect $ 'copyStreamLatin1' `hasNoType` ''Step
224inspect $ 'copyStreamLatin1' `hasNoType` ''Unfold.ConcatState -- Handle.read/UF.many
223inspect $ 'copyStreamLatin1' `hasNoType` ''Unfold.ConcatState -- Handle.read/UF.many
225
224
226inspect $ 'copyStreamLatin1' `hasNoType` ''Fold.Step
225inspect $ 'copyStreamLatin1' `hasNoType` ''Fold.Step
227−inspect $ 'copyStreamLatin1' `hasNoType` ''MutArray.ArrayUnsafe -- Handle.write/writeNUnsafe
226+inspect $ 'copyStreamLatin1' `hasNoType` ''Array.ArrayUnsafe -- Handle.write/writeNUnsafe
228 -- Handle.read/Array.read
227 -- Handle.read/Array.read
229inspect $ 'copyStreamLatin1' `hasNoType` ''Strict.Tuple3' -- Handle.write/chunksOf
228inspect $ 'copyStreamLatin1' `hasNoType` ''Strict.Tuple3' -- Handle.write/chunksOf
230#endif
229#endif
@@ -245,7 +244,7 @@ inspect $ 'copyStreamLatin1 `hasNoType` ''Unfold.ConcatState -- Handle.read/UF.m
245
244
246inspect $ 'copyStreamLatin1 `hasNoType` ''Fold.ManyState
245inspect $ 'copyStreamLatin1 `hasNoType` ''Fold.ManyState
247inspect $ 'copyStreamLatin1 `hasNoType` ''Fold.Step
246inspect $ 'copyStreamLatin1 `hasNoType` ''Fold.Step
248−inspect $ 'copyStreamLatin1 `hasNoType` ''MutArray.ArrayUnsafe -- Handle.write/writeNUnsafe
247+inspect $ 'copyStreamLatin1 `hasNoType` ''Array.ArrayUnsafe -- Handle.write/writeNUnsafe
249 -- Handle.read/Array.read
248 -- Handle.read/Array.read
250inspect $ 'copyStreamLatin1 `hasNoType` ''Strict.Tuple3' -- Handle.write/chunksOf
249inspect $ 'copyStreamLatin1 `hasNoType` ''Strict.Tuple3' -- Handle.write/chunksOf
251#endif
250#endif
configure+9−9
@@ -1,6 +1,6 @@
1#! /bin/sh
1#! /bin/sh
2# Guess values for system-dependent variables and create Makefiles.
2# Guess values for system-dependent variables and create Makefiles.
3−# Generated by GNU Autoconf 2.71 for streamly 0.10.1.
3+# Generated by GNU Autoconf 2.71 for streamly 0.10.0.
4#
4#
5# Report bugs to <streamly@composewell.com>.
5# Report bugs to <streamly@composewell.com>.
6#
6#
@@ -610,8 +610,8 @@ MAKEFLAGS=
610# Identity of this package.
610# Identity of this package.
611PACKAGE_NAME='streamly'
611PACKAGE_NAME='streamly'
612PACKAGE_TARNAME='streamly'
612PACKAGE_TARNAME='streamly'
613−PACKAGE_VERSION='0.10.1'
613+PACKAGE_VERSION='0.10.0'
614−PACKAGE_STRING='streamly 0.10.1'
614+PACKAGE_STRING='streamly 0.10.0'
615PACKAGE_BUGREPORT='streamly@composewell.com'
615PACKAGE_BUGREPORT='streamly@composewell.com'
616PACKAGE_URL='https://streamly.composewell.com'
616PACKAGE_URL='https://streamly.composewell.com'
617
617
@@ -1224,7 +1224,7 @@ if test "$ac_init_help" = "long"; then
1224 # Omit some internal or obsolete options to make the list less imposing.
1224 # Omit some internal or obsolete options to make the list less imposing.
1225 # This message is too long to be a string in the A/UX 3.1 sh.
1225 # This message is too long to be a string in the A/UX 3.1 sh.
1226 cat <<_ACEOF
1226 cat <<_ACEOF
1227−\`configure' configures streamly 0.10.1 to adapt to many kinds of systems.
1227+\`configure' configures streamly 0.10.0 to adapt to many kinds of systems.
1228
1228
1229Usage: $0 [OPTION]... [VAR=VALUE]...
1229Usage: $0 [OPTION]... [VAR=VALUE]...
1230
1230
@@ -1286,7 +1286,7 @@ fi
1286
1286
1287if test -n "$ac_init_help"; then
1287if test -n "$ac_init_help"; then
1288 case $ac_init_help in
1288 case $ac_init_help in
1289− short | recursive ) echo "Configuration of streamly 0.10.1:";;
1289+ short | recursive ) echo "Configuration of streamly 0.10.0:";;
1290 esac
1290 esac
1291 cat <<\_ACEOF
1291 cat <<\_ACEOF
1292
1292
@@ -1372,7 +1372,7 @@ fi
1372test -n "$ac_init_help" && exit $ac_status
1372test -n "$ac_init_help" && exit $ac_status
1373if $ac_init_version; then
1373if $ac_init_version; then
1374 cat <<\_ACEOF
1374 cat <<\_ACEOF
1375−streamly configure 0.10.1
1375+streamly configure 0.10.0
1376generated by GNU Autoconf 2.71
1376generated by GNU Autoconf 2.71
1377
1377
1378Copyright (C) 2021 Free Software Foundation, Inc.
1378Copyright (C) 2021 Free Software Foundation, Inc.
@@ -1500,7 +1500,7 @@ cat >config.log <<_ACEOF
1500This file contains any messages produced by compilers while
1500This file contains any messages produced by compilers while
1501running configure, to aid debugging if configure makes a mistake.
1501running configure, to aid debugging if configure makes a mistake.
1502
1502
1503−It was created by streamly $as_me 0.10.1, which was
1503+It was created by streamly $as_me 0.10.0, which was
1504generated by GNU Autoconf 2.71. Invocation command line was
1504generated by GNU Autoconf 2.71. Invocation command line was
1505
1505
1506 $ $0$ac_configure_args_raw
1506 $ $0$ac_configure_args_raw
@@ -3800,7 +3800,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
3800# report actual input values of CONFIG_FILES etc. instead of their
3800# report actual input values of CONFIG_FILES etc. instead of their
3801# values after options handling.
3801# values after options handling.
3802ac_log="
3802ac_log="
3803−This file was extended by streamly $as_me 0.10.1, which was
3803+This file was extended by streamly $as_me 0.10.0, which was
3804generated by GNU Autoconf 2.71. Invocation command line was
3804generated by GNU Autoconf 2.71. Invocation command line was
3805
3805
3806 CONFIG_FILES = $CONFIG_FILES
3806 CONFIG_FILES = $CONFIG_FILES
@@ -3856,7 +3856,7 @@ ac_cs_config_escaped=`printf "%s\n" "$ac_cs_config" | sed "s/^ //; s/'/'\\\\\\\\
3856cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
3856cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
3857ac_cs_config='$ac_cs_config_escaped'
3857ac_cs_config='$ac_cs_config_escaped'
3858ac_cs_version="\\
3858ac_cs_version="\\
3859−streamly config.status 0.10.1
3859+streamly config.status 0.10.0
3860configured by $0, generated by GNU Autoconf 2.71,
3860configured by $0, generated by GNU Autoconf 2.71,
3861 with options \\"\$ac_cs_config\\"
3861 with options \\"\$ac_cs_config\\"
3862
3862
configure.ac+1−1
@@ -3,7 +3,7 @@
3# See https://www.gnu.org/software/autoconf/manual/autoconf.html for help on
3# See https://www.gnu.org/software/autoconf/manual/autoconf.html for help on
4# the macros used in this file.
4# the macros used in this file.
5
5
6−AC_INIT([streamly], [0.10.1], [streamly@composewell.com], [streamly], [https://streamly.composewell.com])
6+AC_INIT([streamly], [0.10.0], [streamly@composewell.com], [streamly], [https://streamly.composewell.com])
7
7
8# To suppress "WARNING: unrecognized options: --with-compiler"
8# To suppress "WARNING: unrecognized options: --with-compiler"
9AC_ARG_WITH([compiler], [GHC])
9AC_ARG_WITH([compiler], [GHC])
core/configure+9−9
@@ -1,6 +1,6 @@
1#! /bin/sh
1#! /bin/sh
2# Guess values for system-dependent variables and create Makefiles.
2# Guess values for system-dependent variables and create Makefiles.
3−# Generated by GNU Autoconf 2.71 for streamly-core 0.2.2.
3+# Generated by GNU Autoconf 2.71 for streamly-core 0.2.1.
4#
4#
5# Report bugs to <streamly@composewell.com>.
5# Report bugs to <streamly@composewell.com>.
6#
6#
@@ -610,8 +610,8 @@ MAKEFLAGS=
610# Identity of this package.
610# Identity of this package.
611PACKAGE_NAME='streamly-core'
611PACKAGE_NAME='streamly-core'
612PACKAGE_TARNAME='streamly-core'
612PACKAGE_TARNAME='streamly-core'
613−PACKAGE_VERSION='0.2.2'
613+PACKAGE_VERSION='0.2.1'
614−PACKAGE_STRING='streamly-core 0.2.2'
614+PACKAGE_STRING='streamly-core 0.2.1'
615PACKAGE_BUGREPORT='streamly@composewell.com'
615PACKAGE_BUGREPORT='streamly@composewell.com'
616PACKAGE_URL='https://streamly.composewell.com'
616PACKAGE_URL='https://streamly.composewell.com'
617
617
@@ -1256,7 +1256,7 @@ if test "$ac_init_help" = "long"; then
1256 # Omit some internal or obsolete options to make the list less imposing.
1256 # Omit some internal or obsolete options to make the list less imposing.
1257 # This message is too long to be a string in the A/UX 3.1 sh.
1257 # This message is too long to be a string in the A/UX 3.1 sh.
1258 cat <<_ACEOF
1258 cat <<_ACEOF
1259−\`configure' configures streamly-core 0.2.2 to adapt to many kinds of systems.
1259+\`configure' configures streamly-core 0.2.1 to adapt to many kinds of systems.
1260
1260
1261Usage: $0 [OPTION]... [VAR=VALUE]...
1261Usage: $0 [OPTION]... [VAR=VALUE]...
1262
1262
@@ -1318,7 +1318,7 @@ fi
1318
1318
1319if test -n "$ac_init_help"; then
1319if test -n "$ac_init_help"; then
1320 case $ac_init_help in
1320 case $ac_init_help in
1321− short | recursive ) echo "Configuration of streamly-core 0.2.2:";;
1321+ short | recursive ) echo "Configuration of streamly-core 0.2.1:";;
1322 esac
1322 esac
1323 cat <<\_ACEOF
1323 cat <<\_ACEOF
1324
1324
@@ -1404,7 +1404,7 @@ fi
1404test -n "$ac_init_help" && exit $ac_status
1404test -n "$ac_init_help" && exit $ac_status
1405if $ac_init_version; then
1405if $ac_init_version; then
1406 cat <<\_ACEOF
1406 cat <<\_ACEOF
1407−streamly-core configure 0.2.2
1407+streamly-core configure 0.2.1
1408generated by GNU Autoconf 2.71
1408generated by GNU Autoconf 2.71
1409
1409
1410Copyright (C) 2021 Free Software Foundation, Inc.
1410Copyright (C) 2021 Free Software Foundation, Inc.
@@ -1622,7 +1622,7 @@ cat >config.log <<_ACEOF
1622This file contains any messages produced by compilers while
1622This file contains any messages produced by compilers while
1623running configure, to aid debugging if configure makes a mistake.
1623running configure, to aid debugging if configure makes a mistake.
1624
1624
1625−It was created by streamly-core $as_me 0.2.2, which was
1625+It was created by streamly-core $as_me 0.2.1, which was
1626generated by GNU Autoconf 2.71. Invocation command line was
1626generated by GNU Autoconf 2.71. Invocation command line was
1627
1627
1628 $ $0$ac_configure_args_raw
1628 $ $0$ac_configure_args_raw
@@ -3832,7 +3832,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
3832# report actual input values of CONFIG_FILES etc. instead of their
3832# report actual input values of CONFIG_FILES etc. instead of their
3833# values after options handling.
3833# values after options handling.
3834ac_log="
3834ac_log="
3835−This file was extended by streamly-core $as_me 0.2.2, which was
3835+This file was extended by streamly-core $as_me 0.2.1, which was
3836generated by GNU Autoconf 2.71. Invocation command line was
3836generated by GNU Autoconf 2.71. Invocation command line was
3837
3837
3838 CONFIG_FILES = $CONFIG_FILES
3838 CONFIG_FILES = $CONFIG_FILES
@@ -3888,7 +3888,7 @@ ac_cs_config_escaped=`printf "%s\n" "$ac_cs_config" | sed "s/^ //; s/'/'\\\\\\\\
3888cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
3888cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
3889ac_cs_config='$ac_cs_config_escaped'
3889ac_cs_config='$ac_cs_config_escaped'
3890ac_cs_version="\\
3890ac_cs_version="\\
3891−streamly-core config.status 0.2.2
3891+streamly-core config.status 0.2.1
3892configured by $0, generated by GNU Autoconf 2.71,
3892configured by $0, generated by GNU Autoconf 2.71,
3893 with options \\"\$ac_cs_config\\"
3893 with options \\"\$ac_cs_config\\"
3894
3894
core/configure.ac+1−1
@@ -3,7 +3,7 @@
3# See https://www.gnu.org/software/autoconf/manual/autoconf.html for help on
3# See https://www.gnu.org/software/autoconf/manual/autoconf.html for help on
4# the macros used in this file.
4# the macros used in this file.
5
5
6−AC_INIT([streamly-core], [0.2.2], [streamly@composewell.com], [streamly-core], [https://streamly.composewell.com])
6+AC_INIT([streamly-core], [0.2.1], [streamly@composewell.com], [streamly-core], [https://streamly.composewell.com])
7
7
8# To suppress "WARNING: unrecognized options: --with-compiler"
8# To suppress "WARNING: unrecognized options: --with-compiler"
9AC_ARG_WITH([compiler], [GHC])
9AC_ARG_WITH([compiler], [GHC])
core/docs/ApiChangelogs/0.2.0-0.2.2.txtdeleted−306
@@ -1,306 +0,0 @@
1−---------------------------------
2−API Annotations
3−---------------------------------
4−
5−[A] : Added
6−[R] : Removed
7−[C] : Changed
8−[O] : Old definition
9−[N] : New definition
10−[D] : Deprecated
11−
12−---------------------------------
13−API diff
14−---------------------------------
15−
16−[C] Streamly.Data.Stream
17− [A] (FixityR,5)
18− [A] (FixityR,5)
19−[C] Streamly.Data.MutArray.Generic
20− [A] emptyOf :: MonadIO m => Int -> m (MutArray a)
21− [A] createOf :: MonadIO m => Int -> Fold m a (MutArray a)
22− [A] create :: MonadIO m => Fold m a (MutArray a)
23−[C] Streamly.Data.MutArray
24− [A] pinnedEmptyOf :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a)
25− [A] emptyOf :: (MonadIO m, Unbox a) => Int -> m (MutArray a)
26− [A] createOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
27− [A] create :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
28− [A] appendN :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a) -> Fold m a (MutArray a)
29− [A] append :: forall m a. (MonadIO m, Unbox a) => m (MutArray a) -> Fold m a (MutArray a)
30−[C] Streamly.Data.Array.Generic
31− [A] createOf :: MonadIO m => Int -> Fold m a (Array a)
32− [A] create :: MonadIO m => Fold m a (Array a)
33−[C] Streamly.Data.Array
34− [A] class Serialize a
35− [A] serializeAt :: Serialize a => Int -> MutByteArray -> a -> IO Int
36− [A] pinnedSerialize :: Serialize a => a -> Array Word8
37− [A] deserializeAt :: Serialize a => Int -> MutByteArray -> Int -> IO (Int, a)
38− [A] deserialize :: Serialize a => Array Word8 -> a
39− [A] createOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
40− [A] create :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
41− [A] addSizeTo :: Serialize a => Int -> a -> Int
42−
43−---------------------------------
44−Internal API diff
45−---------------------------------
46−
47−[C] Streamly.Internal.Unicode.Stream
48− [A] encodeUtf16le' :: Stream m Char -> Stream m Word16
49− [A] decodeUtf16le' :: Stream m Word16 -> Stream m Char
50−[A] Streamly.Internal.FileSystem.Path
51− [A] class IsPath a
52− [A] Rel
53− [A] File
54− [A] Dir
55− [A] Abs
56− [A] Streamly.Internal.FileSystem.Path.IsPath
57− [A] instance Streamly.Internal.FileSystem.Path.IsPath Streamly.Internal.FileSystem.Path.Path
58− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.Rel Streamly.Internal.FileSystem.Path.Path)
59− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.Rel (Streamly.Internal.FileSystem.Path.File Streamly.Internal.FileSystem.Path.Path))
60− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.Rel (Streamly.Internal.FileSystem.Path.Dir Streamly.Internal.FileSystem.Path.Path))
61− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.File Streamly.Internal.FileSystem.Path.Path)
62− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.Dir Streamly.Internal.FileSystem.Path.Path)
63− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.Abs Streamly.Internal.FileSystem.Path.Path)
64− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.Abs (Streamly.Internal.FileSystem.Path.File Streamly.Internal.FileSystem.Path.Path))
65− [A] instance Streamly.Internal.FileSystem.Path.IsPath (Streamly.Internal.FileSystem.Path.Abs (Streamly.Internal.FileSystem.Path.Dir Streamly.Internal.FileSystem.Path.Path))
66− [A] GHC.Show.Show
67− [A] instance GHC.Show.Show Streamly.Internal.FileSystem.Path.PathException
68− [A] GHC.Exception.Type.Exception
69− [A] instance GHC.Exception.Type.Exception Streamly.Internal.FileSystem.Path.PathException
70− [A] GHC.Classes.Eq
71− [A] instance GHC.Classes.Eq Streamly.Internal.FileSystem.Path.PathException
72− [A] Path
73− [A] Path :: Array Word8 -> Path
74− [A] toString :: Path -> [Char]
75− [A] toPath :: IsPath a => a -> Path
76− [A] toChunk :: Path -> Array Word8
77− [A] toChars :: Monad m => Path -> Stream m Char
78− [A] relfile :: QuasiQuoter
79− [A] reldir :: QuasiQuoter
80− [A] rel :: QuasiQuoter
81− [A] primarySeparator :: Char
82− [A] path :: QuasiQuoter
83− [A] mkRelFile :: String -> Q Exp
84− [A] mkRelDir :: String -> Q Exp
85− [A] mkRel :: String -> Q Exp
86− [A] mkPath :: String -> Q Exp
87− [A] mkFile :: String -> Q Exp
88− [A] mkDir :: String -> Q Exp
89− [A] mkAbsFile :: String -> Q Exp
90− [A] mkAbsDir :: String -> Q Exp
91− [A] mkAbs :: String -> Q Exp
92− [A] isSeparator :: Char -> Bool
93− [A] fromString :: MonadThrow m => [Char] -> m Path
94− [A] fromPathUnsafe :: IsPath a => Path -> a
95− [A] fromPath :: (IsPath a, MonadThrow m) => Path -> m a
96− [A] fromChunkUnsafe :: Array Word8 -> Path
97− [A] fromChunk :: MonadThrow m => Array Word8 -> m Path
98− [A] fromChars :: MonadThrow m => Stream Identity Char -> m Path
99− [A] file :: QuasiQuoter
100− [A] extendPath :: Path -> Path -> Path
101− [A] extendDir :: (IsPath (a (Dir Path)), IsPath b, IsPath (a b)) => a (Dir Path) -> Rel b -> a b
102− [A] dir :: QuasiQuoter
103− [A] adaptPath :: (MonadThrow m, IsPath a, IsPath b) => a -> m b
104− [A] absfile :: QuasiQuoter
105− [A] absdir :: QuasiQuoter
106− [A] abs :: QuasiQuoter
107−[C] Streamly.Internal.Data.Stream
108− [A] (FixityR,5)
109− [A] (FixityR,5)
110− [C] splitInnerBySuffix
111− [O] splitInnerBySuffix :: (Monad m, Eq (f a), Monoid (f a)) => (f a -> m (f a, Maybe (f a))) -> (f a -> f a -> m (f a)) -> Stream m (f a) -> Stream m (f a)
112− [N] splitInnerBySuffix :: Monad m => (f a -> Bool) -> (f a -> m (f a, Maybe (f a))) -> (f a -> f a -> m (f a)) -> Stream m (f a) -> Stream m (f a)
113− [D] sliceOnSuffix :: Monad m => (a -> Bool) -> Stream m a -> Stream m (Int, Int)
114− [A] indexOnSuffix :: Monad m => (a -> Bool) -> Stream m a -> Stream m (Int, Int)
115−[C] Streamly.Internal.Data.MutByteArray
116− [A] unsafePinnedAsPtr :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
117− [A] unsafeAsPtr :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
118− [D] nil :: MutByteArray
119− [A] empty :: MutByteArray
120− [D] asPtrUnsafe :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
121−[D] Streamly.Internal.Data.MutArray.Stream
122− [D] writeChunks :: (MonadIO m, Unbox a) => Int -> Fold m a (StreamK n (MutArray a))
123− [D] fromArrayStreamK :: (Unbox a, MonadIO m) => StreamK m (MutArray a) -> m (MutArray a)
124− [D] flattenArraysRev :: forall m a. (MonadIO m, Unbox a) => Stream m (MutArray a) -> Stream m a
125− [D] flattenArrays :: forall m a. (MonadIO m, Unbox a) => Stream m (MutArray a) -> Stream m a
126−[C] Streamly.Internal.Data.MutArray.Generic
127− [D] writeWith :: MonadIO m => Int -> Fold m a (MutArray a)
128− [D] writeNUnsafe :: MonadIO m => Int -> Fold m a (MutArray a)
129− [A] unsafeCreateOf :: MonadIO m => Int -> Fold m a (MutArray a)
130− [A] emptyOf :: MonadIO m => Int -> m (MutArray a)
131− [A] createWith :: MonadIO m => Int -> Fold m a (MutArray a)
132− [A] createOf :: MonadIO m => Int -> Fold m a (MutArray a)
133− [A] create :: MonadIO m => Fold m a (MutArray a)
134−[C] Streamly.Internal.Data.MutArray
135− [A] SpliceState
136− [A] SpliceYielding :: arr -> SpliceState s arr -> SpliceState s arr
137− [A] SpliceInitial :: s -> SpliceState s arr
138− [A] SpliceFinish :: SpliceState s arr
139− [A] SpliceBuffering :: s -> arr -> SpliceState s arr
140− [R] MutByteArray
141− [D] writeWith :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
142− [D] writeRevN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
143− [D] writeNWithUnsafe :: forall m a. (MonadIO m, Unbox a) => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
144− [D] writeNUnsafe :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
145− [D] writeChunks :: (MonadIO m, Unbox a) => Int -> Fold m a (StreamK n (MutArray a))
146− [D] writeAppendWith :: forall m a. (MonadIO m, Unbox a) => (Int -> Int) -> m (MutArray a) -> Fold m a (MutArray a)
147− [D] writeAppendNUnsafe :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a) -> Fold m a (MutArray a)
148− [A] unsafePinnedCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
149− [A] unsafePinnedAsPtr :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
150− [A] unsafeCreateOfWith :: forall m a. (MonadIO m, Unbox a) => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
151− [A] unsafeCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
152− [A] unsafeAsPtr :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
153− [A] unsafeAppendN :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a) -> Fold m a (MutArray a)
154− [A] toStreamWith :: forall m a. (Monad m, Unbox a) => (forall b. IO b -> m b) -> MutArray a -> Stream m a
155− [A] toStreamRevWith :: forall m a. (Monad m, Unbox a) => (forall b. IO b -> m b) -> MutArray a -> Stream m a
156− [R] toStreamDWith :: forall m a. (Monad m, Unbox a) => (forall b. IO b -> m b) -> MutArray a -> Stream m a
157− [R] toStreamDRevWith :: forall m a. (Monad m, Unbox a) => (forall b. IO b -> m b) -> MutArray a -> Stream m a
158− [A] slicerFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (MutArray a) (MutArray a)
159− [A] sliceIndexerFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (MutArray a) (Int, Int)
160− [A] revCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
161− [D] resizeExp :: forall m a. (MonadIO m, Unbox a) => Int -> MutArray a -> m (MutArray a)
162− [D] resize :: forall m a. (MonadIO m, Unbox a) => Int -> MutArray a -> m (MutArray a)
163− [A] pokeSkipUnsafe :: Int -> MutArray Word8 -> MutArray Word8
164− [A] pokeAppendMay :: forall m a. (MonadIO m, Unbox a) => MutArray Word8 -> a -> m (Maybe (MutArray Word8))
165− [A] pokeAppend :: forall m a. (MonadIO m, Unbox a) => MutArray Word8 -> a -> m (MutArray Word8)
166− [D] pinnedWriteNUnsafe :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
167− [D] pinnedWriteN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
168− [D] pinnedWrite :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
169− [D] pinnedNewBytes :: MonadIO m => Int -> m (MutArray a)
170− [A] pinnedEmptyOf :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a)
171− [A] pinnedCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
172− [A] pinnedCreate :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
173− [A] pinnedCompactLE :: forall m a. (MonadIO m, Unbox a) => Int -> Stream m (MutArray a) -> Stream m (MutArray a)
174− [A] peekUnconsUnsafe :: forall m a. (MonadIO m, Unbox a) => MutArray Word8 -> m (a, MutArray Word8)
175− [A] peekUncons :: forall m a. (MonadIO m, Unbox a) => MutArray Word8 -> m (Maybe a, MutArray Word8)
176− [A] peekSkipUnsafe :: Int -> MutArray Word8 -> MutArray Word8
177− [A] pPinnedCompactLE :: forall m a. (MonadIO m, Unbox a) => Int -> Parser (MutArray a) m (MutArray a)
178− [A] pCompactLE :: forall m a. (MonadIO m, Unbox a) => Int -> Parser (MutArray a) m (MutArray a)
179− [D] nil :: MutArray a
180− [A] lPinnedCompactGE :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m (MutArray a) () -> Fold m (MutArray a) ()
181− [A] lCompactGE :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m (MutArray a) () -> Fold m (MutArray a) ()
182− [A] indexReaderWith :: (Monad m, Unbox a) => (forall b. IO b -> m b) -> Stream m Int -> Unfold m (MutArray a) a
183− [A] indexReader :: (MonadIO m, Unbox a) => Stream m Int -> Unfold m (MutArray a) a
184− [A] growExp :: forall m a. (MonadIO m, Unbox a) => Int -> MutArray a -> m (MutArray a)
185− [A] grow :: forall m a. (MonadIO m, Unbox a) => Int -> MutArray a -> m (MutArray a)
186− [D] getSlicesFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (MutArray a) (MutArray a)
187− [R] getIndicesD :: (Monad m, Unbox a) => (forall b. IO b -> m b) -> Stream m Int -> Unfold m (MutArray a) a
188− [D] getIndices :: (MonadIO m, Unbox a) => Stream m Int -> Unfold m (MutArray a) a
189− [D] genSlicesFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (MutArray a) (Int, Int)
190− [A] fromStreamN :: forall m a. (MonadIO m, Unbox a) => Int -> Stream m a -> m (MutArray a)
191− [D] fromStreamDN :: forall m a. (MonadIO m, Unbox a) => Int -> Stream m a -> m (MutArray a)
192− [D] fromStreamD :: (MonadIO m, Unbox a) => Stream m a -> m (MutArray a)
193− [A] fromPureStreamN :: (MonadIO m, Unbox a) => Int -> Stream Identity a -> m (MutArray a)
194− [A] fromPtrN :: MonadIO m => Int -> Ptr Word8 -> m (MutArray Word8)
195− [A] fromChunksRealloced :: forall m a. (MonadIO m, Unbox a) => Stream m (MutArray a) -> m (MutArray a)
196− [A] fromChunksK :: (Unbox a, MonadIO m) => StreamK m (MutArray a) -> m (MutArray a)
197− [A] fromByteStr# :: MonadIO m => Addr# -> m (MutArray Word8)
198− [D] fromArrayStreamK :: (Unbox a, MonadIO m) => StreamK m (MutArray a) -> m (MutArray a)
199− [D] flattenArraysRev :: forall m a. (MonadIO m, Unbox a) => Stream m (MutArray a) -> Stream m a
200− [D] flattenArrays :: forall m a. (MonadIO m, Unbox a) => Stream m (MutArray a) -> Stream m a
201− [A] fPinnedCompactGE :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m (MutArray a) (MutArray a)
202− [A] fCompactGE :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m (MutArray a) (MutArray a)
203− [A] emptyOf :: (MonadIO m, Unbox a) => Int -> m (MutArray a)
204− [A] empty :: MutArray a
205− [A] createWith :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
206− [A] createOfWith :: forall m a. (MonadIO m, Unbox a) => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
207− [A] createOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
208− [A] create :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
209− [A] concatWith :: forall m a. (Monad m, Unbox a) => (forall b. IO b -> m b) -> Stream m (MutArray a) -> Stream m a
210− [A] concatRevWith :: forall m a. (Monad m, Unbox a) => (forall b. IO b -> m b) -> Stream m (MutArray a) -> Stream m a
211− [A] concatRev :: forall m a. (MonadIO m, Unbox a) => Stream m (MutArray a) -> Stream m a
212− [A] concat :: forall m a. (MonadIO m, Unbox a) => Stream m (MutArray a) -> Stream m a
213− [A] compactOnByteSuffix :: MonadIO m => Word8 -> Stream m (MutArray Word8) -> Stream m (MutArray Word8)
214− [A] compactOnByte :: MonadIO m => Word8 -> Stream m (MutArray Word8) -> Stream m (MutArray Word8)
215− [A] compactLeAs :: forall m a. (MonadIO m, Unbox a) => PinnedState -> Int -> Stream m (MutArray a) -> Stream m (MutArray a)
216− [A] compactLE :: (MonadIO m, Unbox a) => Int -> Stream m (MutArray a) -> Stream m (MutArray a)
217− [A] compactGE :: (MonadIO m, Unbox a) => Int -> Stream m (MutArray a) -> Stream m (MutArray a)
218− [A] compactEQ :: Int -> Stream m (MutArray a) -> Stream m (MutArray a)
219− [D] cmp :: MonadIO m => MutArray a -> MutArray a -> m Ordering
220− [A] byteEq :: MonadIO m => MutArray a -> MutArray a -> m Bool
221− [A] byteCmp :: MonadIO m => MutArray a -> MutArray a -> m Ordering
222− [A] buildChunks :: (MonadIO m, Unbox a) => Int -> Fold m a (StreamK n (MutArray a))
223− [D] asPtrUnsafe :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
224− [A] appendWith :: forall m a. (MonadIO m, Unbox a) => (Int -> Int) -> m (MutArray a) -> Fold m a (MutArray a)
225− [A] appendN :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a) -> Fold m a (MutArray a)
226− [A] append :: forall m a. (MonadIO m, Unbox a) => m (MutArray a) -> Fold m a (MutArray a)
227−[D] Streamly.Internal.Data.Array.Stream
228− [C] interposeSuffix
229− [O] interposeSuffix :: (Monad m, Unbox a) => a -> Stream m (Array a) -> Stream m a
230− [N] interposeSuffix :: forall m a. (Monad m, Unbox a) => a -> Stream m (Array a) -> Stream m a
231− [D] flattenArraysRev :: forall m a. (MonadIO m, Unbox a) => Stream m (Array a) -> Stream m a
232− [D] flattenArrays :: forall m a. (MonadIO m, Unbox a) => Stream m (Array a) -> Stream m a
233− [C] concatRev
234− [O] concatRev :: (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
235− [N] concatRev :: forall m a. (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
236− [D] bufferChunks :: (MonadIO m, Unbox a) => Stream m a -> m (StreamK m (Array a))
237−[C] Streamly.Internal.Data.Array.Generic
238− [A] createOf :: MonadIO m => Int -> Fold m a (Array a)
239− [A] create :: MonadIO m => Fold m a (Array a)
240−[C] Streamly.Internal.Data.Array
241− [R] ArrayUnsafe
242− [D] writeWith :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
243− [D] writeNUnsafe :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
244− [A] unsafePinnedCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
245− [A] unsafePinnedAsPtr :: MonadIO m => Array a -> (Ptr a -> m b) -> m b
246− [A] unsafeCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
247− [D] toStreamDRev :: forall m a. (Monad m, Unbox a) => Array a -> Stream m a
248− [D] toStreamD :: forall m a. (Monad m, Unbox a) => Array a -> Stream m a
249− [C] splice
250− [O] splice :: (MonadIO m, Unbox a) => Array a -> Array a -> m (Array a)
251− [N] splice :: MonadIO m => Array a -> Array a -> m (Array a)
252− [A] slicerFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (Array a) (Array a)
253− [A] sliceIndexerFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (Array a) (Int, Int)
254− [D] pinnedWriteNUnsafe :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
255− [D] pinnedWriteNAligned :: forall m a. (MonadIO m, Unbox a) => Int -> Int -> Fold m a (Array a)
256− [D] pinnedWriteN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
257− [D] pinnedWrite :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
258− [A] pinnedCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
259− [A] pinnedCreate :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
260− [A] pinnedCompactLE :: (MonadIO m, Unbox a) => Int -> Stream m (Array a) -> Stream m (Array a)
261− [A] parseBreakChunksK :: forall m a b. (MonadIO m, Unbox a) => Parser a m b -> StreamK m (Array a) -> m (Either ParseError b, StreamK m (Array a))
262− [D] nil :: Array a
263− [A] lPinnedCompactGE :: (MonadIO m, Unbox a) => Int -> Fold m (Array a) () -> Fold m (Array a) ()
264− [A] lCompactGE :: (MonadIO m, Unbox a) => Int -> Fold m (Array a) () -> Fold m (Array a) ()
265− [A] interposeSuffix :: forall m a. (Monad m, Unbox a) => a -> Stream m (Array a) -> Stream m a
266− [A] interpose :: (Monad m, Unbox a) => a -> Stream m (Array a) -> Stream m a
267− [A] intercalateSuffix :: (Monad m, Unbox a) => Array a -> Stream m (Array a) -> Stream m a
268− [A] indexReaderFromThenTo :: Unfold m (Int, Int, Int, Array a) a
269− [A] indexReader :: (Monad m, Unbox a) => Stream m Int -> Unfold m (Array a) a
270− [A] indexFinder :: (a -> Bool) -> Unfold Identity (Array a) Int
271− [D] getSlicesFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (Array a) (Array a)
272− [R] getIndicesFromThenTo :: Unfold m (Int, Int, Int, Array a) a
273− [D] getIndices :: (Monad m, Unbox a) => Stream m Int -> Unfold m (Array a) a
274− [D] genSlicesFromLen :: forall m a. (Monad m, Unbox a) => Int -> Int -> Unfold m (Array a) (Int, Int)
275− [D] fromStreamDN :: forall m a. (MonadIO m, Unbox a) => Int -> Stream m a -> m (Array a)
276− [D] fromStreamD :: forall m a. (MonadIO m, Unbox a) => Stream m a -> m (Array a)
277− [A] fromPureStreamN :: Unbox a => Int -> Stream Identity a -> Array a
278− [A] fromPtrN :: Int -> Ptr Word8 -> Array Word8
279− [A] fromChunksK :: (MonadIO m, Unbox a) => StreamK m (Array a) -> m (Array a)
280− [A] fromChunks :: (MonadIO m, Unbox a) => Stream m (Array a) -> m (Array a)
281− [A] fromByteStr :: Ptr Word8 -> Array Word8
282− [A] foldChunks :: (MonadIO m, Unbox a) => Fold m a b -> Stream m (Array a) -> m b
283− [A] foldBreakChunksK :: forall m a b. (MonadIO m, Unbox a) => Fold m a b -> StreamK m (Array a) -> m (b, StreamK m (Array a))
284− [A] foldBreakChunks :: forall m a b. (MonadIO m, Unbox a) => Fold m a b -> Stream m (Array a) -> m (b, Stream m (Array a))
285− [D] flattenArraysRev :: forall m a. (MonadIO m, Unbox a) => Stream m (Array a) -> Stream m a
286− [D] flattenArrays :: forall m a. (MonadIO m, Unbox a) => Stream m (Array a) -> Stream m a
287− [C] findIndicesOf
288− [O] findIndicesOf :: (a -> Bool) -> Unfold Identity (Array a) Int
289− [N] findIndicesOf :: (a -> Bool) -> Array a -> Stream Identity Int
290− [A] fPinnedCompactGE :: (MonadIO m, Unbox a) => Int -> Fold m (Array a) (Array a)
291− [A] fCompactGE :: (MonadIO m, Unbox a) => Int -> Fold m (Array a) (Array a)
292− [A] empty :: Array a
293− [A] createWith :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
294− [A] createOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
295− [A] create :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
296− [A] concatRev :: forall m a. (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
297− [A] concat :: (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
298− [A] compactOnByteSuffix :: MonadIO m => Word8 -> Stream m (Array Word8) -> Stream m (Array Word8)
299− [A] compactOnByte :: MonadIO m => Word8 -> Stream m (Array Word8) -> Stream m (Array Word8)
300− [A] compactLE :: (MonadIO m, Unbox a) => Int -> Stream m (Array a) -> Stream m (Array a)
301− [A] compactGE :: (MonadIO m, Unbox a) => Int -> Stream m (Array a) -> Stream m (Array a)
302− [A] byteEq :: Array a -> Array a -> Bool
303− [A] byteCmp :: Array a -> Array a -> Ordering
304− [A] buildChunks :: (MonadIO m, Unbox a) => Stream m a -> m (StreamK m (Array a))
305− [D] bufferChunks :: (MonadIO m, Unbox a) => Stream m a -> m (StreamK m (Array a))
306− [D] asPtrUnsafe :: MonadIO m => Array a -> (Ptr a -> m b) -> m b
core/docs/Changelog.md+1−3
@@ -1,12 +1,10 @@
1# Changelog
1# Changelog
2
2
3−## 0.2.2 (Jan 2024)
3+## Unreleased
4
4
5* Add fixities `infixr 5` for `cons` and `consM` functions.
5* Add fixities `infixr 5` for `cons` and `consM` functions.
6* Fix a bug in Array `Eq` instance when the type is a sum type with
6* Fix a bug in Array `Eq` instance when the type is a sum type with
7 differently sized constructors.
7 differently sized constructors.
8−* lpackArraysChunksOf, compact, writeChunksWith, putChunksWith now take the
9− buffer size in number of array elements instead of bytes.
10
8
11## 0.2.1 (Dec 2023)
9## 0.2.1 (Dec 2023)
12
10
core/src/DocTestDataArray.hs−3
@@ -11,12 +11,9 @@
11
11
12>>> import qualified Streamly.Data.Array as Array
12>>> import qualified Streamly.Data.Array as Array
13>>> import qualified Streamly.Data.Fold as Fold
13>>> import qualified Streamly.Data.Fold as Fold
14−>>> import qualified Streamly.Data.ParserK as ParserK
15>>> import qualified Streamly.Data.Stream as Stream
14>>> import qualified Streamly.Data.Stream as Stream
16−>>> import qualified Streamly.Data.StreamK as StreamK
17
15
18For APIs that have not been released yet.
16For APIs that have not been released yet.
19
17
20>>> import qualified Streamly.Internal.Data.Array as Array
18>>> import qualified Streamly.Internal.Data.Array as Array
21−>>> import qualified Streamly.Internal.Data.Stream as Stream
22-}
19-}
core/src/DocTestDataStream.hs−2
@@ -6,7 +6,6 @@
6>>> import Control.Monad.IO.Class (MonadIO (liftIO))
6>>> import Control.Monad.IO.Class (MonadIO (liftIO))
7>>> import Control.Monad.Trans.Class (lift)
7>>> import Control.Monad.Trans.Class (lift)
8>>> import Control.Monad.Trans.Identity (runIdentityT)
8>>> import Control.Monad.Trans.Identity (runIdentityT)
9−>>> import Data.Char (isSpace)
10>>> import Data.Either (fromLeft, fromRight, isLeft, isRight, either)
9>>> import Data.Either (fromLeft, fromRight, isLeft, isRight, either)
11>>> import Data.Maybe (fromJust, isJust)
10>>> import Data.Maybe (fromJust, isJust)
12>>> import Data.Function (fix, (&))
11>>> import Data.Function (fix, (&))
@@ -33,7 +32,6 @@ For APIs that have not been released yet.
33>>> import qualified Streamly.Internal.Data.Fold as Fold
32>>> import qualified Streamly.Internal.Data.Fold as Fold
34>>> import qualified Streamly.Internal.Data.Parser as Parser
33>>> import qualified Streamly.Internal.Data.Parser as Parser
35>>> import qualified Streamly.Internal.Data.Stream as Stream
34>>> import qualified Streamly.Internal.Data.Stream as Stream
36−>>> import qualified Streamly.Internal.Data.StreamK as StreamK
37>>> import qualified Streamly.Internal.Data.Unfold as Unfold
35>>> import qualified Streamly.Internal.Data.Unfold as Unfold
38>>> import qualified Streamly.Internal.FileSystem.Dir as Dir
36>>> import qualified Streamly.Internal.FileSystem.Dir as Dir
39-}
37-}
core/src/DocTestFileSystemHandle.hs+1−1
@@ -8,7 +8,7 @@
8
8
9For APIs that have not been released yet.
9For APIs that have not been released yet.
10
10
11−>>> import qualified Streamly.Internal.Data.Array as Array (unsafeCreateOf)
11+>>> import qualified Streamly.Internal.Data.Array as Array (writeNUnsafe)
12>>> import qualified Streamly.Internal.Data.Unfold as Unfold (first)
12>>> import qualified Streamly.Internal.Data.Unfold as Unfold (first)
13>>> import qualified Streamly.Internal.FileSystem.Handle as Handle
13>>> import qualified Streamly.Internal.FileSystem.Handle as Handle
14>>> import qualified Streamly.Internal.System.IO as IO (defaultChunkSize)
14>>> import qualified Streamly.Internal.System.IO as IO (defaultChunkSize)
core/src/Streamly/Data/Array.hs+27−30
@@ -31,42 +31,42 @@ module Streamly.Data.Array
31 -- * The Array Type
31 -- * The Array Type
32 Array
32 Array
33
33
34− -- * Pinning & Unpinning
35− -- | Arrays are created unpinned by default unless pinned versions of
36− -- creation APIs are used. Look for APIs with @pinned@ prefix in
37− -- "Streamly.Internal.Data.Array" for some unreleased pinned creation APIs.
38− -- If an array is to be sent to the OS without any further modification
39− -- then it should be created pinned in the first place instead of pinning
40− -- it later. Pinning an unpinned array has a copy overhead. OS interfacing
41− -- APIs create a pinned array directly or convert an unpinned array to
42− -- pinned array before sending it to the OS.
43− , pin
44− , unpin
45− , isPinned
46−
47 -- * Construction
34 -- * Construction
48 -- | When performance matters, the fastest way to generate an array is
35 -- | When performance matters, the fastest way to generate an array is
49− -- 'createOf'. 'IsList' and 'IsString' instances can be
36+ -- 'writeN'. 'IsList' and 'IsString' instances can be
50 -- used to conveniently construct arrays from literal values.
37 -- used to conveniently construct arrays from literal values.
51 -- 'OverloadedLists' extension or 'fromList' can be used to construct an
38 -- 'OverloadedLists' extension or 'fromList' can be used to construct an
52 -- array from a list literal. Similarly, 'OverloadedStrings' extension or
39 -- array from a list literal. Similarly, 'OverloadedStrings' extension or
53 -- 'fromList' can be used to construct an array from a string literal.
40 -- 'fromList' can be used to construct an array from a string literal.
54
41
55− -- ** From Stream
56− , createOf
57− , create
58− , writeLastN -- drop old (ring buffer)
59−
60− -- ** From List
42+ -- Pure List APIs
61 , fromListN
43 , fromListN
62 , fromList
44 , fromList
63
45
64− -- * To List
46+ -- Monadic APIs
47+ , writeN -- drop new
48+ , write -- full buffer
49+ , writeLastN -- drop old (ring buffer)
50+
51+ -- * Conversion
65 -- 'GHC.Exts.toList' from "GHC.Exts" can be used to convert an array to a
52 -- 'GHC.Exts.toList' from "GHC.Exts" can be used to convert an array to a
66 -- list.
53 -- list.
67 , toList
54 , toList
68
55
69− -- * To Stream
56+ -- * Pinning & Unpinning
57+ -- | Arrays are created unpinned by default unless pinned versions of
58+ -- creation APIs are used. Look for APIs with @pinned@ prefix in
59+ -- "Streamly.Internal.Data.Array" for some unreleased pinned creation APIs.
60+ -- If an array is to be sent to the OS without any further modification
61+ -- then it should be created pinned in the first place instead of pinning
62+ -- it later. Pinning an unpinned array has a copy overhead. OS interfacing
63+ -- APIs create a pinned array directly or convert an unpinned array to
64+ -- pinned array before sending it to the OS.
65+ , pin
66+ , unpin
67+ , isPinned
68+
69+ -- * Streams
70 , read
70 , read
71 , readRev
71 , readRev
72
72
@@ -90,10 +90,6 @@ module Streamly.Data.Array
90 -- * Re-exports
90 -- * Re-exports
91 , Unbox (..)
91 , Unbox (..)
92 , Serialize(..)
92 , Serialize(..)
93−
94− -- * Deprecated
95− , writeN -- drop new
96− , write -- full buffer
97 )
93 )
98where
94where
99
95
@@ -126,7 +122,7 @@ import Prelude hiding (read, length)
126--
122--
127-- Convert array to stream, transform, and fold back to array:
123-- Convert array to stream, transform, and fold back to array:
128--
124--
129−-- >>> amap f arr = Array.read arr & fmap f & Stream.fold (Array.createOf (Array.length arr))
125+-- >>> amap f arr = Array.read arr & fmap f & Stream.fold Array.write
130-- >>> amap (+1) (Array.fromList [1,2,3::Int])
126-- >>> amap (+1) (Array.fromList [1,2,3::Int])
131-- fromList [2,3,4]
127-- fromList [2,3,4]
132--
128--
@@ -153,11 +149,12 @@ import Prelude hiding (read, length)
153-- See the 'fromPureStream' unreleased API to generate an array from an
149-- See the 'fromPureStream' unreleased API to generate an array from an
154-- Identity stream safely without using MonadIO constraint.
150-- Identity stream safely without using MonadIO constraint.
155--
151--
152+--
156-- Note that 'Identity' streams can be generalized to IO streams:
153-- Note that 'Identity' streams can be generalized to IO streams:
157--
154--
158−-- >>> stream = Stream.fromList [1,2,3] :: Stream Identity Int
155+-- >>> pure = Stream.fromList [1,2,3] :: Stream Identity Int
159−-- >>> pure2IO s = Stream.morphInner (return . runIdentity) s :: Stream IO Int
156+-- >>> generally = Stream.morphInner (return . runIdentity)
160−-- >>> Stream.fold Array.create (pure2IO stream)
157+-- >>> Stream.fold Array.write (generally pure :: Stream IO Int)
161-- fromList [1,2,3]
158-- fromList [1,2,3]
162--
159--
163-- == Programming Tips
160-- == Programming Tips
core/src/Streamly/Data/Array/Generic.hs+13−16
@@ -15,37 +15,34 @@ module Streamly.Data.Array.Generic
15 ( Array
15 ( Array
16
16
17 -- * Construction
17 -- * Construction
18− , fromListN
18+ , A.fromListN
19− , fromList
19+ , A.fromList
20
20
21 -- MonadicAPIs
21 -- MonadicAPIs
22− , createOf
22+ , A.writeN
23− , create
23+ , A.write
24
24
25 -- * Conversion
25 -- * Conversion
26− , toList
26+ , A.toList
27
27
28 -- * Streams
28 -- * Streams
29− , read
29+ , A.read
30− , readRev
30+ , A.readRev
31
31
32 -- * Unfolds
32 -- * Unfolds
33− , reader
33+ , A.reader
34 -- , A.readerRev
34 -- , A.readerRev
35
35
36 -- * Random Access
36 -- * Random Access
37− , length
37+ , A.length
38− , getIndex
38+ , A.getIndex
39
39
40 -- -- * Folding Arrays
40 -- -- * Folding Arrays
41 -- , A.streamFold
41 -- , A.streamFold
42 -- , A.fold
42 -- , A.fold
43−
44− -- * Deprecated
45− , writeN
46− , write
47 )
43 )
48where
44where
49
45
50−import Streamly.Internal.Data.Array.Generic
46+import Streamly.Internal.Data.Array.Generic (Array)
51−import Prelude hiding (length, read)
47+
48+import qualified Streamly.Internal.Data.Array.Generic as A
core/src/Streamly/Data/MutArray.hs+6−12
@@ -32,14 +32,14 @@ module Streamly.Data.MutArray
32 -- * Construction
32 -- * Construction
33
33
34 -- Uninitialized Arrays
34 -- Uninitialized Arrays
35− , emptyOf
35+ , new
36− , pinnedEmptyOf
36+ , pinnedNew
37
37
38 -- From containers
38 -- From containers
39 , fromListN
39 , fromListN
40 , fromList
40 , fromList
41− , createOf
41+ , writeN -- drop new
42− , create
42+ , write -- full buffer
43 -- writeLastN
43 -- writeLastN
44
44
45 -- * Pinning & Unpinning
45 -- * Pinning & Unpinning
@@ -51,8 +51,8 @@ module Streamly.Data.MutArray
51 , snoc
51 , snoc
52
52
53 -- * Appending streams
53 -- * Appending streams
54− , appendN
54+ , writeAppendN -- XXX Rename to writeSnocN?
55− , append
55+ , writeAppend -- XXX Rename to writeSnoc?
56
56
57 -- * Inplace mutation
57 -- * Inplace mutation
58 , putIndex
58 , putIndex
@@ -88,12 +88,6 @@ module Streamly.Data.MutArray
88
88
89 -- * Deprecated
89 -- * Deprecated
90 , newPinned
90 , newPinned
91− , new
92− , pinnedNew
93− , writeN
94− , write
95− , writeAppendN
96− , writeAppend
97 )
91 )
98where
92where
99
93
core/src/Streamly/Data/MutArray/Generic.hs+3−8
@@ -23,11 +23,11 @@ module Streamly.Data.MutArray.Generic
23 MutArray
23 MutArray
24
24
25 -- * Construction
25 -- * Construction
26− , emptyOf
26+ , new
27 , fromListN
27 , fromListN
28 , fromList
28 , fromList
29− , createOf
29+ , writeN
30− , create
30+ , write
31
31
32 -- * Appending elements
32 -- * Appending elements
33 , snoc
33 , snoc
@@ -56,11 +56,6 @@ module Streamly.Data.MutArray.Generic
56
56
57 -- * Size
57 -- * Size
58 , length
58 , length
59−
60− -- * Deprecated
61− , new
62− , writeN
63− , write
64 )
59 )
65where
60where
66
61
core/src/Streamly/Data/Stream.hs+20−129
@@ -70,15 +70,6 @@ module Streamly.Data.Stream
70
70
71 -- ** From Values
71 -- ** From Values
72 -- | Generate a monadic stream from a seed value or values.
72 -- | Generate a monadic stream from a seed value or values.
73− --
74− -- Non-empty pure streams can be cycled using repeat and unfold:
75− --
76− -- >>> cycle = Stream.unfoldMany Unfold.fromList . Stream.repeat
77− --
78− -- Non-empty StreamK can be cycled using append:
79− --
80− -- >>> cycle xs = let ys = xs `StreamK.append` ys in ys
81− --
82 , fromPure
73 , fromPure
83 , fromEffect
74 , fromEffect
84 , repeat
75 , repeat
@@ -221,57 +212,21 @@ module Streamly.Data.Stream
221 -- operations like mapping a function over the stream.
212 -- operations like mapping a function over the stream.
222 , foldrM
213 , foldrM
223 , foldr
214 , foldr
224− -- foldr1
225
215
226 -- ** Specific Folds
216 -- ** Specific Folds
227− -- | Streams are folded using folds in "Streamly.Data.Fold". Here are some
217+ -- | Usually you can use the folds in "Streamly.Data.Fold". However, some
228− -- idioms and equivalents of Data.List APIs using folds:
218+ -- folds that may be commonly used or may have an edge in performance in
219+ -- some cases are provided here.
220+ --
221+ -- Useful idioms:
229 --
222 --
230 -- >>> foldlM' f a = Stream.fold (Fold.foldlM' f a)
223 -- >>> foldlM' f a = Stream.fold (Fold.foldlM' f a)
231− -- >>> foldl1' f = Stream.fold (Fold.foldl1' f)
224+ -- >>> foldl1 f = Stream.fold (Fold.foldl1' f)
232 -- >>> foldl' f a = Stream.fold (Fold.foldl' f a)
225 -- >>> foldl' f a = Stream.fold (Fold.foldl' f a)
233 -- >>> drain = Stream.fold Fold.drain
226 -- >>> drain = Stream.fold Fold.drain
234 -- >>> mapM_ f = Stream.fold (Fold.drainMapM f)
227 -- >>> mapM_ f = Stream.fold (Fold.drainMapM f)
235 -- >>> length = Stream.fold Fold.length
228 -- >>> length = Stream.fold Fold.length
236− -- >>> genericLength = Stream.fold Fold.lengthGeneric
237 -- >>> head = Stream.fold Fold.one
229 -- >>> head = Stream.fold Fold.one
238− -- >>> last = Stream.fold Fold.latest
239− -- >>> null = Stream.fold Fold.null
240− -- >>> and = Stream.fold Fold.and
241− -- >>> or = Stream.fold Fold.or
242− -- >>> any p = Stream.fold (Fold.any p)
243− -- >>> all p = Stream.fold (Fold.all p)
244− -- >>> sum = Stream.fold Fold.sum
245− -- >>> product = Stream.fold Fold.product
246− -- >>> maximum = Stream.fold Fold.maximum
247− -- >>> maximumBy cmp = Stream.fold (Fold.maximumBy cmp)
248− -- >>> minimum = Stream.fold Fold.minimum
249− -- >>> minimumBy cmp = Stream.fold (Fold.minimumBy cmp)
250− -- >>> elem x = Stream.fold (Fold.elem x)
251− -- >>> notElem x = Stream.fold (Fold.notElem x)
252− -- >>> lookup x = Stream.fold (Fold.lookup x)
253− -- >>> find p = Stream.fold (Fold.find p)
254− -- >>> (!?) i = Stream.fold (Fold.index i)
255− -- >>> genericIndex i = Stream.fold (Fold.indexGeneric i)
256− -- >>> elemIndex x = Stream.fold (Fold.elemIndex x)
257− -- >>> findIndex p = Stream.fold (Fold.findIndex p)
258− --
259− -- Some equivalents of Data.List APIs from the Stream module:
260− --
261− -- >>> head = fmap (fmap fst) . Stream.uncons
262− -- >>> tail = fmap (fmap snd) . Stream.uncons
263− -- >>> tail = Stream.tail -- unreleased API
264− -- >>> init = Stream.init -- unreleased API
265− --
266− -- A Stream based toList fold implementation is provided below because it
267− -- has a better performance compared to the fold.
268−
269− -- Functions in Data.List, missing here:
270− -- unsnoc = Stream.parseBreak (Parser.init Fold.toList)
271− -- genericTake
272− -- genericDrop
273− -- genericSplitAt
274− -- genericReplicate
275 , toList
230 , toList
276
231
277 -- * Mapping
232 -- * Mapping
@@ -325,15 +280,6 @@ module Streamly.Data.Stream
325 , scan
280 , scan
326 , postscan
281 , postscan
327 -- XXX postscan1 can be implemented using Monoids or Refolds.
282 -- XXX postscan1 can be implemented using Monoids or Refolds.
328− -- The following scans from Data.List are not provided.
329− -- XXX scanl
330− -- XXX scanl1
331− -- XXX scanr
332− -- XXX scanr1
333− -- XXX mapAccumL
334− -- XXX mapAccumR
335− -- XXX inits
336− -- XXX tails
337
283
338 -- ** Specific scans
284 -- ** Specific scans
339 -- Indexing can be considered as a special type of zipping where we zip a
285 -- Indexing can be considered as a special type of zipping where we zip a
@@ -342,8 +288,6 @@ module Streamly.Data.Stream
342
288
343 -- * Insertion
289 -- * Insertion
344 -- | Add elements to the stream.
290 -- | Add elements to the stream.
345− --
346− -- >>> insert = Stream.insertBy compare
347
291
348 -- Inserting elements is a special case of interleaving/merging streams.
292 -- Inserting elements is a special case of interleaving/merging streams.
349 , insertBy
293 , insertBy
@@ -379,15 +323,12 @@ module Streamly.Data.Stream
379 -- "Streamly.Internal.Data.Fold" can be used along with 'scanMaybe' to
323 -- "Streamly.Internal.Data.Fold" can be used along with 'scanMaybe' to
380 -- perform stateful filtering operations in general.
324 -- perform stateful filtering operations in general.
381 --
325 --
382− -- Idioms and equivalents of Data.List APIs:
326+ -- Useful idioms:
383 --
327 --
384 -- >>> deleteBy cmp x = Stream.scanMaybe (Fold.deleteBy cmp x)
328 -- >>> deleteBy cmp x = Stream.scanMaybe (Fold.deleteBy cmp x)
385− -- >>> deleteBy = Stream.deleteBy -- unreleased API
386− -- >>> delete = deleteBy (==)
387 -- >>> findIndices p = Stream.scanMaybe (Fold.findIndices p)
329 -- >>> findIndices p = Stream.scanMaybe (Fold.findIndices p)
388 -- >>> elemIndices a = findIndices (== a)
330 -- >>> elemIndices a = findIndices (== a)
389 -- >>> uniq = Stream.scanMaybe (Fold.uniqBy (==))
331 -- >>> uniq = Stream.scanMaybe (Fold.uniqBy (==))
390− -- >>> partition p = Stream.fold (Fold.partition Fold.toList Fold.toList) . fmap (if p then Left else Right)
391 , scanMaybe
332 , scanMaybe
392 , take
333 , take
393 , takeWhile
334 , takeWhile
@@ -395,8 +336,6 @@ module Streamly.Data.Stream
395 , drop
336 , drop
396 , dropWhile
337 , dropWhile
397 , dropWhileM
338 , dropWhileM
398− -- XXX write to an array in reverse and then read in reverse
399− -- > dropWhileEnd = reverse . dropWhile p . reverse
400
339
401 -- XXX These are available as scans in folds. We need to check the
340 -- XXX These are available as scans in folds. We need to check the
402 -- performance though. If these are common and we need convenient stream
341 -- performance though. If these are common and we need convenient stream
@@ -433,9 +372,6 @@ module Streamly.Data.Stream
433 -- >>> s = s1 `Stream.append` s2
372 -- >>> s = s1 `Stream.append` s2
434
373
435 -- ** Appending
374 -- ** Appending
436− -- | Equivalent of Data.List append:
437− --
438− -- >>> (++) = Stream.append
439 , append
375 , append
440
376
441 -- ** Interleaving
377 -- ** Interleaving
@@ -446,14 +382,8 @@ module Streamly.Data.Stream
446 , mergeByM
382 , mergeByM
447
383
448 -- ** Zipping
384 -- ** Zipping
449− -- | Idioms and equivalents of Data.List APIs:
450− --
451− -- >>> zip = Stream.zipWith (,)
452− -- >>> unzip = Stream.fold (Fold.unzip Fold.toList Fold.toList)
453 , zipWith
385 , zipWith
454 , zipWithM
386 , zipWithM
455− -- XXX zipWith3,4,5,6,7
456− -- XXX unzip3,4,5,6,7
457 -- , ZipStream (..)
387 -- , ZipStream (..)
458
388
459 -- ** Cross Product
389 -- ** Cross Product
@@ -486,89 +416,48 @@ module Streamly.Data.Stream
486 -- One dimension loops are just a special case of nested loops. For
416 -- One dimension loops are just a special case of nested loops. For
487 -- example, 'concatMap' can degenerate to a simple map operation:
417 -- example, 'concatMap' can degenerate to a simple map operation:
488 --
418 --
489− -- >>> map f m = Stream.concatMap (\x -> Stream.fromPure (f x)) m
419+ -- > map f m = S.concatMap (\x -> S.fromPure (f x)) m
490 --
420 --
491 -- Similarly, 'concatMap' can perform filtering by mapping an element to a
421 -- Similarly, 'concatMap' can perform filtering by mapping an element to a
492 -- 'nil' stream:
422 -- 'nil' stream:
493 --
423 --
494− -- >>> filter p m = Stream.concatMap (\x -> if p x then Stream.fromPure x else Stream.nil) m
424+ -- > filter p m = S.concatMap (\x -> if p x then S.fromPure x else S.nil) m
495− --
496− -- Idioms and equivalents of Data.List APIs:
497 --
425 --
498− -- >>> concat = Stream.concatMap id
499− -- >>> unlines = Stream.interposeSuffix '\n'
500− -- >>> unlines = Stream.intercalateSuffix Unfold.fromList "\n"
501− -- >>> unwords = Stream.interpose ' '
502− -- >>> unwords = Stream.intercalate Unfold.fromList " "
503
426
504 , concatEffect
427 , concatEffect
505 , concatMap
428 , concatMap
506 , concatMapM
429 , concatMapM
507
430
508 -- * Repeated Fold
431 -- * Repeated Fold
509− -- | Idioms and equivalents of Data.List APIs:
432+ -- | Useful idioms:
510 --
433 --
434+ -- >>> splitWithSuffix p f = Stream.foldMany (Fold.takeEndBy p f)
435+ -- >>> splitOnSuffix p f = Stream.foldMany (Fold.takeEndBy_ p f)
436+ -- >>> groupsBy eq f = Stream.parseMany (Parser.groupBy eq f)
437+ -- >>> groupsByRolling eq f = Stream.parseMany (Parser.groupByRolling eq f)
511− -- >>> groupsOf n = Stream.foldMany (Fold.take n Fold.toList)
438+ -- >>> groupsOf n f = Stream.foldMany (Fold.take n f)
512− -- >>> groupBy eq = Stream.groupsWhile eq Fold.toList
513− -- >>> groupBy eq = Stream.parseMany (Parser.groupBy eq Fold.toList)
514− -- >>> groupsByRolling eq = Stream.parseMany (Parser.groupByRolling eq Fold.toList)
515− -- >>> groups = groupBy (==)
516 , foldMany -- XXX Rename to foldRepeat
439 , foldMany -- XXX Rename to foldRepeat
517 , groupsOf
440 , groupsOf
518 , parseMany
441 , parseMany
519
442
520 -- * Splitting
443 -- * Splitting
521− -- | Idioms and equivalents of Data.List APIs:
522− --
523− -- >>> splitWithSuffix p f = Stream.foldMany (Fold.takeEndBy p f)
524− -- >>> splitOnSuffix p f = Stream.foldMany (Fold.takeEndBy_ p f)
525− -- >>> lines = splitOnSuffix (== '\n')
526− -- >>> words = Stream.wordsBy isSpace
527− -- >>> splitAt n = Stream.fold (Fold.splitAt n Fold.toList Fold.toList)
528− -- >>> span p = Parser.splitWith (,) (Parser.takeWhile p Fold.toList) (Parser.fromFold Fold.toList)
529− -- >>> break p = span (not . p)
530 , splitOn
444 , splitOn
531 , wordsBy
445 , wordsBy
532
446
533 -- * Buffered Operations
447 -- * Buffered Operations
534 -- | Operations that require buffering of the stream.
448 -- | Operations that require buffering of the stream.
535 -- Reverse is essentially a left fold followed by an unfold.
449 -- Reverse is essentially a left fold followed by an unfold.
536− --
537− -- Idioms and equivalents of Data.List APIs:
538− --
539− -- >>> nub = Stream.fold Fold.toList . Stream.scanMaybe Fold.nub
540− -- >>> nub = Stream.ordNub -- unreleased API
541− -- >>> sortBy = StreamK.sortBy
542− -- >>> sortOn f = StreamK.sortOn -- unreleased API
543− -- >>> deleteFirstsBy = Stream.deleteFirstsBy -- unreleased
544− -- >>> (\\) = Stream.deleteFirstsBy (==) -- unreleased
545− -- >>> intersectBy = Stream.intersectBy -- unreleased
546− -- >>> intersect = Stream.intersectBy (==) -- unreleased
547− -- >>> unionBy = Stream.unionBy -- unreleased
548− -- >>> union = Stream.unionBy (==) -- unreleased
549− --
550 , reverse
450 , reverse
551− -- XXX transpose: write the streams to arrays and then stream transposed.
552− -- XXX subsequences
553− -- XXX permutations
554− -- , nub
555− -- , ordNub
556− -- , nubBy
557
451
558 -- * Multi-Stream folds
452 -- * Multi-Stream folds
559 -- | Operations that consume multiple streams at the same time.
453 -- | Operations that consume multiple streams at the same time.
560 , eqBy
454 , eqBy
561 , cmpBy
455 , cmpBy
562 , isPrefixOf
456 , isPrefixOf
563− , isInfixOf
564− -- , isSuffixOf
565− -- , isSuffixOfUnbox
566 , isSubsequenceOf
457 , isSubsequenceOf
567
458
568 -- trimming sequences
459 -- trimming sequences
569− -- , stripPrefix
460+ , stripPrefix
570− -- , stripSuffix
571− -- , stripSuffixUnbox
572
461
573 -- Exceptions and resource management depend on the "exceptions" package
462 -- Exceptions and resource management depend on the "exceptions" package
574 -- XXX We can have IO Stream operations not depending on "exceptions"
463 -- XXX We can have IO Stream operations not depending on "exceptions"
@@ -632,8 +521,10 @@ where
632import Streamly.Internal.Data.Stream
521import Streamly.Internal.Data.Stream
633import Prelude
522import Prelude
634 hiding (filter, drop, dropWhile, take, takeWhile, zipWith, foldr,
523 hiding (filter, drop, dropWhile, take, takeWhile, zipWith, foldr,
524+ foldl, map, mapM, mapM_, sequence, all, any, sum, product, elem,
525+ notElem, maximum, minimum, head, last, tail, length, null,
635− mapM, sequence, reverse, iterate, foldr1, repeat, replicate,
526+ reverse, iterate, init, and, or, lookup, foldr1, (!!),
636− concatMap)
527+ scanl, scanl1, repeat, replicate, concatMap, span)
637
528
638import qualified Streamly.Internal.Data.Array.Type as Array
529import qualified Streamly.Internal.Data.Array.Type as Array
639
530
core/src/Streamly/Internal/Data/Array.hs+128−551
@@ -2,6 +2,7 @@
2-- |
2-- |
3-- Module : Streamly.Internal.Data.Array
3-- Module : Streamly.Internal.Data.Array
4-- Copyright : (c) 2019 Composewell Technologies
4-- Copyright : (c) 2019 Composewell Technologies
5+--
5-- License : BSD3
6-- License : BSD3
6-- Maintainer : streamly@composewell.com
7-- Maintainer : streamly@composewell.com
7-- Stability : experimental
8-- Stability : experimental
@@ -19,21 +20,30 @@ module Streamly.Internal.Data.Array
19 module Streamly.Internal.Data.Array.Type
20 module Streamly.Internal.Data.Array.Type
20
21
21 -- * Construction
22 -- * Construction
23+ -- Stream Folds
24+ , fromStreamN
25+ , fromStream
26+
22 -- Monadic Folds
27 -- Monadic Folds
23 , writeLastN
28 , writeLastN
24
29
30+ -- * Unfolds
31+ , reader
32+ , readerUnsafe
33+ , producer -- experimental
34+
25 -- * Random Access
35 -- * Random Access
26 -- , (!!)
36 -- , (!!)
27 , getIndex
37 , getIndex
28 , getIndexRev
38 , getIndexRev
29− , last -- XXX getLastIndex?
39+ , last -- XXX getIndexLast?
40+ , getIndices
41+ , getIndicesFromThenTo
30 -- , getIndicesFrom -- read from a given position to the end of file
42 -- , getIndicesFrom -- read from a given position to the end of file
31 -- , getIndicesUpto -- read from beginning up to the given position
43 -- , getIndicesUpto -- read from beginning up to the given position
32 -- , getIndicesFromTo
44 -- , getIndicesFromTo
33 -- , getIndicesFromRev -- read from a given position to the beginning of file
45 -- , getIndicesFromRev -- read from a given position to the beginning of file
34 -- , getIndicesUptoRev -- read from end to the given position in file
46 -- , getIndicesUptoRev -- read from end to the given position in file
35− , indexReader
36− , indexReaderFromThenTo
37
47
38 -- * Size
48 -- * Size
39 , null
49 , null
@@ -41,8 +51,6 @@ module Streamly.Internal.Data.Array
41 -- * Search
51 -- * Search
42 , binarySearch
52 , binarySearch
43 , findIndicesOf
53 , findIndicesOf
44− -- getIndicesOf
45− , indexFinder -- see splitOn
46 -- , findIndexOf
54 -- , findIndexOf
47 -- , find
55 -- , find
48
56
@@ -55,8 +63,8 @@ module Streamly.Internal.Data.Array
55 -- * Subarrays
63 -- * Subarrays
56 , getSliceUnsafe
64 , getSliceUnsafe
57 -- , getSlice
65 -- , getSlice
58− , sliceIndexerFromLen
66+ , genSlicesFromLen
59− , slicerFromLen
67+ , getSlicesFromLen
60 , splitOn
68 , splitOn
61
69
62 -- * Streaming Operations
70 -- * Streaming Operations
@@ -66,34 +74,11 @@ module Streamly.Internal.Data.Array
66 , streamFold
74 , streamFold
67 , fold
75 , fold
68
76
69− -- * Stream of Arrays
70−
71− -- XXX these are probably not very useful to have in this module as we can
72− -- express these idiomatically using streams.
73− , interpose
74− , interposeSuffix
75− , intercalateSuffix
76−
77− , compactLE
78− , pinnedCompactLE
79− , compactOnByte
80− , compactOnByteSuffix
81−
82− , foldBreakChunks
83− , foldChunks
84− , foldBreakChunksK
85− , parseBreakChunksK
86−
87 -- * Serialization
77 -- * Serialization
88 , encodeAs
78 , encodeAs
89 , serialize
79 , serialize
90 , pinnedSerialize
80 , pinnedSerialize
91 , deserialize
81 , deserialize
92−
93− -- * Deprecated
94− , genSlicesFromLen
95− , getSlicesFromLen
96− , getIndices
97 )
82 )
98where
83where
99
84
@@ -101,43 +86,37 @@ where
101#include "inline.hs"
86#include "inline.hs"
102#include "ArrayMacros.h"
87#include "ArrayMacros.h"
103
88
89+import Control.Monad (when)
104import Control.Monad.IO.Class (MonadIO(..))
90import Control.Monad.IO.Class (MonadIO(..))
105−-- import Data.Bifunctor (first)
106−-- import Data.Either (fromRight)
107import Data.Functor.Identity (Identity)
91import Data.Functor.Identity (Identity)
108import Data.Proxy (Proxy(..))
92import Data.Proxy (Proxy(..))
109import Data.Word (Word8)
93import Data.Word (Word8)
110import Foreign.C.String (CString)
94import Foreign.C.String (CString)
111import Foreign.Ptr (castPtr)
95import Foreign.Ptr (castPtr)
112import Foreign.Storable (Storable)
96import Foreign.Storable (Storable)
113−import GHC.Types (SPEC(..))
114import Streamly.Internal.Data.Unbox (Unbox(..))
97import Streamly.Internal.Data.Unbox (Unbox(..))
115import Prelude hiding (length, null, last, map, (!!), read, concat)
98import Prelude hiding (length, null, last, map, (!!), read, concat)
116
99
117−import Streamly.Internal.Data.MutByteArray.Type (PinnedState(..), MutByteArray)
100+import Streamly.Internal.Data.MutByteArray.Type (PinnedState(..))
118import Streamly.Internal.Data.Serialize.Type (Serialize)
101import Streamly.Internal.Data.Serialize.Type (Serialize)
119import Streamly.Internal.Data.Fold.Type (Fold(..))
102import Streamly.Internal.Data.Fold.Type (Fold(..))
120−import Streamly.Internal.Data.Parser (Parser(..), Initial(..), ParseError(..))
103+import Streamly.Internal.Data.Producer.Type (Producer(..))
121−import Streamly.Internal.Data.Stream (Stream(..))
104+import Streamly.Internal.Data.Stream (Stream)
122−import Streamly.Internal.Data.StreamK (StreamK)
123−import Streamly.Internal.Data.SVar.Type (adaptState, defState)
124−import Streamly.Internal.Data.Tuple.Strict (Tuple'(..), Tuple3Fused'(..))
105+import Streamly.Internal.Data.Tuple.Strict (Tuple3Fused'(..))
125import Streamly.Internal.Data.Unfold.Type (Unfold(..))
106import Streamly.Internal.Data.Unfold.Type (Unfold(..))
126import Streamly.Internal.System.IO (unsafeInlineIO)
107import Streamly.Internal.System.IO (unsafeInlineIO)
127
108
128−import qualified Streamly.Internal.Data.Fold.Type as Fold
129import qualified Streamly.Internal.Data.Serialize.Type as Serialize
109import qualified Streamly.Internal.Data.Serialize.Type as Serialize
130import qualified Streamly.Internal.Data.MutByteArray.Type as MBA
110import qualified Streamly.Internal.Data.MutByteArray.Type as MBA
131import qualified Streamly.Internal.Data.MutArray as MA
111import qualified Streamly.Internal.Data.MutArray as MA
112+import qualified Streamly.Internal.Data.Array.Type as A
132import qualified Streamly.Internal.Data.Fold as FL
113import qualified Streamly.Internal.Data.Fold as FL
114+import qualified Streamly.Internal.Data.Producer.Type as Producer
115+import qualified Streamly.Internal.Data.Producer as Producer
133import qualified Streamly.Internal.Data.Ring as RB
116import qualified Streamly.Internal.Data.Ring as RB
134−import qualified Streamly.Internal.Data.Parser as Parser
135−-- import qualified Streamly.Internal.Data.ParserK as ParserK
136import qualified Streamly.Internal.Data.Stream as D
117import qualified Streamly.Internal.Data.Stream as D
137import qualified Streamly.Internal.Data.Stream as Stream
118import qualified Streamly.Internal.Data.Stream as Stream
138−import qualified Streamly.Internal.Data.StreamK as StreamK
139import qualified Streamly.Internal.Data.Unfold as Unfold
119import qualified Streamly.Internal.Data.Unfold as Unfold
140−import qualified Prelude
141
120
142import Streamly.Internal.Data.Array.Type
121import Streamly.Internal.Data.Array.Type
143
122
@@ -166,10 +145,82 @@ import Streamly.Internal.Data.Array.Type
166-- if we use one array for each chunk. This is still significant to add
145-- if we use one array for each chunk. This is still significant to add
167-- pressure to GC.
146-- pressure to GC.
168
147
148+-------------------------------------------------------------------------------
149+-- Construction
150+-------------------------------------------------------------------------------
151+
152+-- | Create an 'Array' from the first N elements of a stream. The array is
153+-- allocated to size N, if the stream terminates before N elements then the
154+-- array may hold less than N elements.
155+--
156+-- /Pre-release/
157+{-# INLINE fromStreamN #-}
158+fromStreamN :: (MonadIO m, Unbox a) => Int -> Stream m a -> m (Array a)
159+fromStreamN n m = do
160+ when (n < 0) $ error "writeN: negative write count specified"
161+ A.fromStreamDN n m
162+
163+-- | Create an 'Array' from a stream. This is useful when we want to create a
164+-- single array from a stream of unknown size. 'writeN' is at least twice
165+-- as efficient when the size is already known.
166+--
167+-- Note that if the input stream is too large memory allocation for the array
168+-- may fail. When the stream size is not known, `chunksOf` followed by
169+-- processing of indvidual arrays in the resulting stream should be preferred.
170+--
171+-- /Pre-release/
172+{-# INLINE fromStream #-}
173+fromStream :: (MonadIO m, Unbox a) => Stream m a -> m (Array a)
174+fromStream = Stream.fold A.write
175+-- write m = A.fromStreamD $ D.fromStreamK m
176+
169-------------------------------------------------------------------------------
177-------------------------------------------------------------------------------
170-- Elimination
178-- Elimination
171-------------------------------------------------------------------------------
179-------------------------------------------------------------------------------
172
180
181+{-# INLINE_NORMAL producer #-}
182+producer :: forall m a. (Monad m, Unbox a) => Producer m (Array a) a
183+producer =
184+ Producer.translate A.unsafeThaw A.unsafeFreeze
185+ $ MA.producerWith (return . unsafeInlineIO)
186+
187+-- | Unfold an array into a stream.
188+--
189+{-# INLINE_NORMAL reader #-}
190+reader :: forall m a. (Monad m, Unbox a) => Unfold m (Array a) a
191+reader = Producer.simplify producer
192+
193+-- | Unfold an array into a stream, does not check the end of the array, the
194+-- user is responsible for terminating the stream within the array bounds. For
195+-- high performance application where the end condition can be determined by
196+-- a terminating fold.
197+--
198+-- Written in the hope that it may be faster than "read", however, in the case
199+-- for which this was written, "read" proves to be faster even though the core
200+-- generated with unsafeRead looks simpler.
201+--
202+-- /Pre-release/
203+--
204+{-# INLINE_NORMAL readerUnsafe #-}
205+readerUnsafe :: forall m a. (Monad m, Unbox a) => Unfold m (Array a) a
206+readerUnsafe = Unfold step inject
207+ where
208+
209+ inject (Array contents start end) =
210+ return (ArrayUnsafe contents end start)
211+
212+ {-# INLINE_LATE step #-}
213+ step (ArrayUnsafe contents end p) = do
214+ -- unsafeInlineIO allows us to run this in Identity monad for pure
215+ -- toList/foldr case which makes them much faster due to not
216+ -- accumulating the list and fusing better with the pure consumers.
217+ --
218+ -- This should be safe as the array contents are guaranteed to be
219+ -- evaluated/written to before we peek at them.
220+ let !x = unsafeInlineIO $ peekAt p contents
221+ let !p1 = INDEX_NEXT(p,a)
222+ return $ D.Yield x (ArrayUnsafe contents end p1)
223+
173-- |
224-- |
174--
225--
175-- >>> null arr = Array.byteLength arr == 0
226-- >>> null arr = Array.byteLength arr == 0
@@ -177,7 +228,7 @@ import Streamly.Internal.Data.Array.Type
177-- /Pre-release/
228-- /Pre-release/
178{-# INLINE null #-}
229{-# INLINE null #-}
179null :: Array a -> Bool
230null :: Array a -> Bool
180−null arr = byteLength arr == 0
231+null arr = A.byteLength arr == 0
181
232
182-- | Like 'getIndex' but indexes the array in reverse from the end.
233-- | Like 'getIndex' but indexes the array in reverse from the end.
183--
234--
@@ -205,8 +256,6 @@ last = getIndexRev 0
205-- Folds with Array as the container
256-- Folds with Array as the container
206-------------------------------------------------------------------------------
257-------------------------------------------------------------------------------
207
258
208−-- XXX We should generate this from Ring.
209−
210-- | @writeLastN n@ folds a maximum of @n@ elements from the end of the input
259-- | @writeLastN n@ folds a maximum of @n@ elements from the end of the input
211-- stream to an 'Array'.
260-- stream to an 'Array'.
212--
261--
@@ -215,7 +264,7 @@ writeLastN ::
215 (Storable a, Unbox a, MonadIO m) => Int -> Fold m a (Array a)
264 (Storable a, Unbox a, MonadIO m) => Int -> Fold m a (Array a)
216writeLastN n
265writeLastN n
217 | n <= 0 = fmap (const mempty) FL.drain
266 | n <= 0 = fmap (const mempty) FL.drain
218− | otherwise = unsafeFreeze <$> Fold step initial done done
267+ | otherwise = A.unsafeFreeze <$> Fold step initial done done
219
268
220 where
269 where
221
270
@@ -228,9 +277,11 @@ writeLastN n
228 in fmap f $ liftIO $ RB.new n
277 in fmap f $ liftIO $ RB.new n
229
278
230 done (Tuple3Fused' rb rh i) = do
279 done (Tuple3Fused' rb rh i) = do
231− arr <- MA.new n
280+ arr <- liftIO $ MA.new n
281+ foldFunc i rh snoc' arr rb
282+
232− -- XXX We should write a read unfold for ring.
283+ -- XXX We should write a read unfold for ring.
233− foldFunc i rh MA.snocUnsafe arr rb
284+ snoc' b a = liftIO $ MA.snocUnsafe b a
234
285
235 foldFunc i
286 foldFunc i
236 | i < n = RB.unsafeFoldRingM
287 | i < n = RB.unsafeFoldRingM
@@ -256,26 +307,19 @@ binarySearch = undefined
256-- compared to streams by using SIMD instructions.
307-- compared to streams by using SIMD instructions.
257-- We can also return a bit array instead.
308-- We can also return a bit array instead.
258
309
259−-- Can use SIMD.
260−
261-- | Perform a linear search to find all the indices where a given element is
310-- | Perform a linear search to find all the indices where a given element is
262-- present in an array.
311-- present in an array.
263--
312--
264-- /Unimplemented/
313-- /Unimplemented/
265−indexFinder :: (a -> Bool) -> Unfold Identity (Array a) Int
314+findIndicesOf :: (a -> Bool) -> Unfold Identity (Array a) Int
266−indexFinder = undefined
315+findIndicesOf = undefined
267−
268−-- |
269−-- /Unimplemented/
270−findIndicesOf :: (a -> Bool) -> Array a -> Stream Identity Int
271−findIndicesOf p = Stream.unfold (indexFinder p)
272
316
273{-
317{-
274findIndexOf :: (a -> Bool) -> Array a -> Maybe Int
318findIndexOf :: (a -> Bool) -> Array a -> Maybe Int
275−findIndexOf p = Unfold.fold Fold.one . Stream.unfold (indexFinder p)
319+findIndexOf p = Unfold.fold Fold.one . Stream.unfold (findIndicesOf p)
276
320
277find :: (a -> Bool) -> Array a -> Bool
321find :: (a -> Bool) -> Array a -> Bool
278−find = Unfold.fold Fold.null . Stream.unfold (indexFinder p)
322+find = Unfold.fold Fold.null . Stream.unfold (findIndicesOf p)
279-}
323-}
280
324
281-------------------------------------------------------------------------------
325-------------------------------------------------------------------------------
@@ -317,45 +361,29 @@ splitOn :: (Monad m, Unbox a) =>
317 (a -> Bool) -> Array a -> Stream m (Array a)
361 (a -> Bool) -> Array a -> Stream m (Array a)
318splitOn predicate arr =
362splitOn predicate arr =
319 fmap (\(i, len) -> getSliceUnsafe i len arr)
363 fmap (\(i, len) -> getSliceUnsafe i len arr)
320− $ D.indexOnSuffix predicate (read arr)
364+ $ D.sliceOnSuffix predicate (A.toStreamD arr)
321
365
322−{-# INLINE sliceIndexerFromLen #-}
323−sliceIndexerFromLen :: forall m a. (Monad m, Unbox a)
324− => Int -- ^ from index
325− -> Int -- ^ length of the slice
326− -> Unfold m (Array a) (Int, Int)
327−sliceIndexerFromLen from len =
328− Unfold.lmap unsafeThaw (MA.sliceIndexerFromLen from len)
329−
330−{-# DEPRECATED genSlicesFromLen "Please use sliceIndexerFromLen instead." #-}
331{-# INLINE genSlicesFromLen #-}
366{-# INLINE genSlicesFromLen #-}
332genSlicesFromLen :: forall m a. (Monad m, Unbox a)
367genSlicesFromLen :: forall m a. (Monad m, Unbox a)
333 => Int -- ^ from index
368 => Int -- ^ from index
334 -> Int -- ^ length of the slice
369 -> Int -- ^ length of the slice
335 -> Unfold m (Array a) (Int, Int)
370 -> Unfold m (Array a) (Int, Int)
336−genSlicesFromLen = sliceIndexerFromLen
371+genSlicesFromLen from len =
372+ Unfold.lmap A.unsafeThaw (MA.genSlicesFromLen from len)
337
373
338-- | Generate a stream of slices of specified length from an array, starting
374-- | Generate a stream of slices of specified length from an array, starting
339-- from the supplied array index. The last slice may be shorter than the
375-- from the supplied array index. The last slice may be shorter than the
340-- requested length.
376-- requested length.
341--
377--
342-- /Pre-release//
378-- /Pre-release//
343−{-# INLINE slicerFromLen #-}
344−slicerFromLen :: forall m a. (Monad m, Unbox a)
345− => Int -- ^ from index
346− -> Int -- ^ length of the slice
347− -> Unfold m (Array a) (Array a)
348−slicerFromLen from len =
349− fmap unsafeFreeze
350− $ Unfold.lmap unsafeThaw (MA.slicerFromLen from len)
351−
352−{-# DEPRECATED getSlicesFromLen "Please use slicerFromLen instead." #-}
353{-# INLINE getSlicesFromLen #-}
379{-# INLINE getSlicesFromLen #-}
354getSlicesFromLen :: forall m a. (Monad m, Unbox a)
380getSlicesFromLen :: forall m a. (Monad m, Unbox a)
355 => Int -- ^ from index
381 => Int -- ^ from index
356 -> Int -- ^ length of the slice
382 -> Int -- ^ length of the slice
357 -> Unfold m (Array a) (Array a)
383 -> Unfold m (Array a) (Array a)
358−getSlicesFromLen = slicerFromLen
384+getSlicesFromLen from len =
385+ fmap A.unsafeFreeze
386+ $ Unfold.lmap A.unsafeThaw (MA.getSlicesFromLen from len)
359
387
360-------------------------------------------------------------------------------
388-------------------------------------------------------------------------------
361-- Random reads and writes
389-- Random reads and writes
@@ -385,25 +413,19 @@ getIndex i arr =
385-- @
413-- @
386-- read =
414-- read =
387-- let u = lmap (\arr -> (0, length arr - 1)) Unfold.enumerateFromTo
415-- let u = lmap (\arr -> (0, length arr - 1)) Unfold.enumerateFromTo
388−-- in Unfold.lmap f (indexReader arr)
416+-- in Unfold.lmap f (getIndices arr)
389--
417--
390-- readRev =
418-- readRev =
391-- let i = length arr - 1
419-- let i = length arr - 1
392−-- in Unfold.lmap f (indexReaderFromThenTo i (i - 1) 0)
420+-- in Unfold.lmap f (getIndicesFromThenTo i (i - 1) 0)
393-- @
421-- @
394--
422--
395-- /Pre-release/
423-- /Pre-release/
396−{-# INLINE indexReader #-}
397−indexReader :: (Monad m, Unbox a) => Stream m Int -> Unfold m (Array a) a
398−indexReader m =
399− let unf = MA.indexReaderWith (return . unsafeInlineIO) m
400− in Unfold.lmap unsafeThaw unf
401−
402−-- XXX DO NOT REMOVE, change the signature to use Stream instead of unfold
403−{-# DEPRECATED getIndices "Please use getIndices instead." #-}
404{-# INLINE getIndices #-}
424{-# INLINE getIndices #-}
405getIndices :: (Monad m, Unbox a) => Stream m Int -> Unfold m (Array a) a
425getIndices :: (Monad m, Unbox a) => Stream m Int -> Unfold m (Array a) a
406−getIndices = indexReader
426+getIndices m =
427+ let unf = MA.getIndicesD (return . unsafeInlineIO) m
428+ in Unfold.lmap A.unsafeThaw unf
407
429
408-- | Unfolds @(from, then, to, array)@ generating a finite stream whose first
430-- | Unfolds @(from, then, to, array)@ generating a finite stream whose first
409-- element is the array value from the index @from@ and the successive elements
431-- element is the array value from the index @from@ and the successive elements
@@ -419,9 +441,9 @@ getIndices = indexReader
419-- @
441-- @
420--
442--
421-- /Unimplemented/
443-- /Unimplemented/
422−{-# INLINE indexReaderFromThenTo #-}
444+{-# INLINE getIndicesFromThenTo #-}
423−indexReaderFromThenTo :: Unfold m (Int, Int, Int, Array a) a
445+getIndicesFromThenTo :: Unfold m (Int, Int, Int, Array a) a
424−indexReaderFromThenTo = undefined
446+getIndicesFromThenTo = undefined
425
447
426-------------------------------------------------------------------------------
448-------------------------------------------------------------------------------
427-- Transform via stream operations
449-- Transform via stream operations
@@ -438,7 +460,7 @@ indexReaderFromThenTo = undefined
438{-# INLINE runPipe #-}
460{-# INLINE runPipe #-}
439runPipe :: (MonadIO m, Unbox a, Unbox b)
461runPipe :: (MonadIO m, Unbox a, Unbox b)
440 => Pipe m a b -> Array a -> m (Array b)
462 => Pipe m a b -> Array a -> m (Array b)
441−runPipe f arr = P.runPipe (toArrayMinChunk (length arr)) $ f (read arr)
463+runPipe f arr = P.runPipe (toArrayMinChunk (length arr)) $ f (A.read arr)
442-}
464-}
443
465
444-- XXX For transformations that cannot change the number of elements e.g. "map"
466-- XXX For transformations that cannot change the number of elements e.g. "map"
@@ -452,7 +474,7 @@ runPipe f arr = P.runPipe (toArrayMinChunk (length arr)) $ f (read arr)
452streamTransform :: forall m a b. (MonadIO m, Unbox a, Unbox b)
474streamTransform :: forall m a b. (MonadIO m, Unbox a, Unbox b)
453 => (Stream m a -> Stream m b) -> Array a -> m (Array b)
475 => (Stream m a -> Stream m b) -> Array a -> m (Array b)
454streamTransform f arr =
476streamTransform f arr =
455− Stream.fold (createWith (length arr)) $ f (read arr)
477+ Stream.fold (A.writeWith (length arr)) $ f (A.read arr)
456
478
457-------------------------------------------------------------------------------
479-------------------------------------------------------------------------------
458-- Casts
480-- Casts
@@ -486,7 +508,7 @@ asBytes = castUnsafe
486--
508--
487cast :: forall a b. (Unbox b) => Array a -> Maybe (Array b)
509cast :: forall a b. (Unbox b) => Array a -> Maybe (Array b)
488cast arr =
510cast arr =
489− let len = byteLength arr
511+ let len = A.byteLength arr
490 r = len `mod` SIZE_OF(b)
512 r = len `mod` SIZE_OF(b)
491 in if r /= 0
513 in if r /= 0
492 then Nothing
514 then Nothing
@@ -504,9 +526,9 @@ cast arr =
504--
526--
505asCStringUnsafe :: Array a -> (CString -> IO b) -> IO b
527asCStringUnsafe :: Array a -> (CString -> IO b) -> IO b
506asCStringUnsafe arr act = do
528asCStringUnsafe arr act = do
507− let arr1 = asBytes arr <> fromList [0]
529+ let arr1 = asBytes arr <> A.fromList [0]
508− -- unsafePinnedAsPtr makes sure the array is pinned
530+ -- asPtrUnsafe makes sure the array is pinned
509− unsafePinnedAsPtr arr1 $ \ptr -> act (castPtr ptr)
531+ asPtrUnsafe arr1 $ \ptr -> act (castPtr ptr)
510
532
511-------------------------------------------------------------------------------
533-------------------------------------------------------------------------------
512-- Folds
534-- Folds
@@ -519,14 +541,14 @@ asCStringUnsafe arr act = do
519-- /Pre-release/
541-- /Pre-release/
520{-# INLINE fold #-}
542{-# INLINE fold #-}
521fold :: forall m a b. (Monad m, Unbox a) => Fold m a b -> Array a -> m b
543fold :: forall m a b. (Monad m, Unbox a) => Fold m a b -> Array a -> m b
522−fold f arr = Stream.fold f (read arr)
544+fold f arr = Stream.fold f (A.read arr)
523
545
524-- | Fold an array using a stream fold operation.
546-- | Fold an array using a stream fold operation.
525--
547--
526-- /Pre-release/
548-- /Pre-release/
527{-# INLINE streamFold #-}
549{-# INLINE streamFold #-}
528streamFold :: (Monad m, Unbox a) => (Stream m a -> m b) -> Array a -> m b
550streamFold :: (Monad m, Unbox a) => (Stream m a -> m b) -> Array a -> m b
529−streamFold f arr = f (read arr)
551+streamFold f arr = f (A.read arr)
530
552
531--------------------------------------------------------------------------------
553--------------------------------------------------------------------------------
532-- Serialization
554-- Serialization
@@ -571,448 +593,3 @@ deserialize arr@(Array {..}) = unsafeInlineIO $ do
571 Serialize.deserializeAt arrStart arrContents (arrStart + lenArr)
593 Serialize.deserializeAt arrStart arrContents (arrStart + lenArr)
572 assertM(off == arrStart + lenArr)
594 assertM(off == arrStart + lenArr)
573 pure val
595 pure val
574−
575−-------------------------------------------------------------------------------
576−-- Streams of Arrays
577−-------------------------------------------------------------------------------
578−
579−-- TODO: efficiently compare two streams of arrays. Two streams can have chunks
580−-- of different sizes, we can handle that in the stream comparison abstraction.
581−-- This could be useful e.g. to fast compare whether two files differ.
582−
583−-- | Insert the given element between arrays and flatten.
584−--
585−-- >>> interpose x = Stream.interpose x Array.reader
586−--
587−{-# INLINE interpose #-}
588−interpose :: (Monad m, Unbox a) => a -> Stream m (Array a) -> Stream m a
589−interpose x = D.interpose x reader
590−
591−data FlattenState s =
592− OuterLoop s
593− | InnerLoop s !MutByteArray !Int !Int
594−
595−-- | Insert the given element after each array and flatten. This is similar to
596−-- unlines.
597−--
598−-- >>> interposeSuffix x = Stream.interposeSuffix x Array.reader
599−--
600−{-# INLINE_NORMAL interposeSuffix #-}
601−interposeSuffix :: forall m a. (Monad m, Unbox a)
602− => a -> Stream m (Array a) -> Stream m a
603−-- This does not require MonadIO constraint.
604−-- interposeSuffix x = D.interposeSuffix x reader
605−interposeSuffix sep (D.Stream step state) = D.Stream step' (OuterLoop state)
606−
607− where
608−
609− {-# INLINE_LATE step' #-}
610− step' gst (OuterLoop st) = do
611− r <- step (adaptState gst) st
612− return $ case r of
613− D.Yield Array{..} s ->
614− D.Skip (InnerLoop s arrContents arrStart arrEnd)
615− D.Skip s -> D.Skip (OuterLoop s)
616− D.Stop -> D.Stop
617−
618− step' _ (InnerLoop st _ p end) | p == end =
619− return $ D.Yield sep $ OuterLoop st
620−
621− step' _ (InnerLoop st contents p end) = do
622− x <- pure $ unsafeInlineIO $ peekAt p contents
623− return $ D.Yield x (InnerLoop st contents (INDEX_NEXT(p,a)) end)
624−
625−-- | Insert the given array after each array and flatten.
626−--
627−-- >>> intercalateSuffix = Stream.intercalateSuffix Array.reader
628−--
629−{-# INLINE intercalateSuffix #-}
630−intercalateSuffix :: (Monad m, Unbox a)
631− => Array a -> Stream m (Array a) -> Stream m a
632−intercalateSuffix = D.intercalateSuffix reader
633−
634−-- | @compactLE n@ coalesces adjacent arrays in the input stream
635−-- only if the combined size would be less than or equal to n.
636−--
637−-- Generates unpinned arrays irrespective of the pinning status of input
638−-- arrays.
639−{-# INLINE_NORMAL compactLE #-}
640−compactLE :: (MonadIO m, Unbox a)
641− => Int -> Stream m (Array a) -> Stream m (Array a)
642−compactLE n stream =
643− D.map unsafeFreeze $ MA.compactLE n $ D.map unsafeThaw stream
644−
645−-- | Pinned version of 'compactLE'.
646−{-# INLINE_NORMAL pinnedCompactLE #-}
647−pinnedCompactLE :: (MonadIO m, Unbox a)
648− => Int -> Stream m (Array a) -> Stream m (Array a)
649−pinnedCompactLE n stream =
650− D.map unsafeFreeze $ MA.pinnedCompactLE n $ D.map unsafeThaw stream
651−
652−-- | Split a stream of arrays on a given separator byte, dropping the separator
653−-- and coalescing all the arrays between two separators into a single array.
654−--
655−{-# INLINE compactOnByte #-}
656−compactOnByte
657− :: (MonadIO m)
658− => Word8
659− -> Stream m (Array Word8)
660− -> Stream m (Array Word8)
661−compactOnByte byte =
662− fmap unsafeFreeze . MA.compactOnByte byte . fmap unsafeThaw
663−
664−-- | Like 'compactOnByte' considers the separator in suffix position instead of
665−-- infix position.
666−{-# INLINE compactOnByteSuffix #-}
667−compactOnByteSuffix
668− :: (MonadIO m)
669− => Word8
670− -> Stream m (Array Word8)
671− -> Stream m (Array Word8)
672−compactOnByteSuffix byte =
673− fmap unsafeFreeze . MA.compactOnByteSuffix byte . fmap unsafeThaw
674−
675−-------------------------------------------------------------------------------
676−-- Folding Streams of Arrays
677−-------------------------------------------------------------------------------
678−
679−-- XXX This should not be used for breaking a stream as the D.cons used in
680−-- reconstructing the stream could be very bad for performance. This can only
681−-- be useful in folding without breaking.
682−{-# INLINE_NORMAL foldBreakChunks #-}
683−foldBreakChunks :: forall m a b. (MonadIO m, Unbox a) =>
684− Fold m a b -> Stream m (Array a) -> m (b, Stream m (Array a))
685−foldBreakChunks (Fold fstep initial _ final) stream@(Stream step state) = do
686− res <- initial
687− case res of
688− Fold.Partial fs -> go SPEC state fs
689− Fold.Done fb -> return $! (fb, stream)
690−
691− where
692−
693− {-# INLINE go #-}
694− go !_ st !fs = do
695− r <- step defState st
696− case r of
697− Stream.Yield (Array contents start end) s ->
698− let fp = Tuple' end contents
699− in goArray SPEC s fp start fs
700− Stream.Skip s -> go SPEC s fs
701− Stream.Stop -> do
702− b <- final fs
703− return (b, D.nil)
704−
705− goArray !_ s (Tuple' end _) !cur !fs
706− | cur == end = do
707− go SPEC s fs
708− goArray !_ st fp@(Tuple' end contents) !cur !fs = do
709− x <- liftIO $ peekAt cur contents
710− res <- fstep fs x
711− let next = INDEX_NEXT(cur,a)
712− case res of
713− Fold.Done b -> do
714− let arr = Array contents next end
715− return $! (b, D.cons arr (D.Stream step st))
716− Fold.Partial fs1 -> goArray SPEC st fp next fs1
717−
718−-- This may be more robust wrt fusion compared to unfoldMany?
719−
720−-- | Fold a stream of arrays using a 'Fold'. This is equivalent to the
721−-- following:
722−--
723−-- >>> foldChunks f = Stream.fold f . Stream.unfoldMany Array.reader
724−--
725−foldChunks :: (MonadIO m, Unbox a) => Fold m a b -> Stream m (Array a) -> m b
726−foldChunks f s = fmap fst (foldBreakChunks f s)
727−-- foldStream f = Stream.fold f . Stream.unfoldMany reader
728−
729−-- | Fold a stream of arrays using a 'Fold' and return the remaining stream.
730−--
731−-- The following alternative to this function allows composing the fold using
732−-- the parser Monad:
733−--
734−-- @
735−-- foldBreakStreamK f s =
736−-- fmap (first (fromRight undefined))
737−-- $ StreamK.parseBreakChunks (ParserK.adaptC (Parser.fromFold f)) s
738−-- @
739−--
740−-- We can compare perf and remove this one or define it in terms of that.
741−--
742−foldBreakChunksK :: forall m a b. (MonadIO m, Unbox a) =>
743− Fold m a b -> StreamK m (Array a) -> m (b, StreamK m (Array a))
744−{-
745−foldBreakChunksK f s =
746− fmap (first (fromRight undefined))
747− $ StreamK.parseBreakChunks (ParserK.adaptC (Parser.fromFold f)) s
748−-}
749−foldBreakChunksK (Fold fstep initial _ final) stream = do
750− res <- initial
751− case res of
752− Fold.Partial fs -> go fs stream
753− Fold.Done fb -> return (fb, stream)
754−
755− where
756−
757− {-# INLINE go #-}
758− go !fs st = do
759− let stop = (, StreamK.nil) <$> final fs
760− single a = yieldk a StreamK.nil
761− yieldk (Array contents start end) r =
762− let fp = Tuple' end contents
763− in goArray fs r fp start
764− in StreamK.foldStream defState yieldk single stop st
765−
766− goArray !fs st (Tuple' end _) !cur
767− | cur == end = do
768− go fs st
769− goArray !fs st fp@(Tuple' end contents) !cur = do
770− x <- liftIO $ peekAt cur contents
771− res <- fstep fs x
772− let next = INDEX_NEXT(cur,a)
773− case res of
774− Fold.Done b -> do
775− let arr = Array contents next end
776− return $! (b, StreamK.cons arr st)
777− Fold.Partial fs1 -> goArray fs1 st fp next
778−
779−{-
780−-- This can be generalized to any type provided it can be unfolded to a stream
781−-- and it can be combined using a semigroup operation.
782−--
783−{-# INLINE_NORMAL parseBreakD #-}
784−parseBreakD ::
785− forall m a b. (MonadIO m, MonadThrow m, Unbox a)
786− => PRD.Parser a m b
787− -> D.Stream m (Array.Array a)
788− -> m (b, D.Stream m (Array.Array a))
789−parseBreakD
790− (PRD.Parser pstep initial extract) stream@(D.Stream step state) = do
791−
792− res <- initial
793− case res of
794− PRD.IPartial s -> go SPEC state (List []) s
795− PRD.IDone b -> return (b, stream)
796− PRD.IError err -> throwM $ ParseError err
797−
798− where
799−
800− -- "backBuf" contains last few items in the stream that we may have to
801− -- backtrack to.
802− --
803− -- XXX currently we are using a dumb list based approach for backtracking
804− -- buffer. This can be replaced by a sliding/ring buffer using Data.Array.
805− -- That will allow us more efficient random back and forth movement.
806− go !_ st backBuf !pst = do
807− r <- step defState st
808− case r of
809− D.Yield (Array contents start end) s ->
810− gobuf SPEC s backBuf
811− (Tuple' end contents) start pst
812− D.Skip s -> go SPEC s backBuf pst
813− D.Stop -> do
814− b <- extract pst
815− return (b, D.nil)
816−
817− -- Use strictness on "cur" to keep it unboxed
818− gobuf !_ s backBuf (Tuple' end _) !cur !pst
819− | cur == end = do
820− go SPEC s backBuf pst
821− gobuf !_ s backBuf fp@(Tuple' end contents) !cur !pst = do
822− x <- liftIO $ peekByteIndex contents cur
823− pRes <- pstep pst x
824− let next = INDEX_NEXT(cur,a)
825− case pRes of
826− PR.Partial 0 pst1 ->
827− gobuf SPEC s (List []) fp next pst1
828− PR.Partial n pst1 -> do
829− assert (n <= Prelude.length (x:getList backBuf)) (return ())
830− let src0 = Prelude.take n (x:getList backBuf)
831− arr0 = A.fromListN n (Prelude.reverse src0)
832− arr1 = Array contents next end
833− src = arr0 <> arr1
834− let !(Array cont1 start end1) = src
835− fp1 = Tuple' end1 cont1
836− gobuf SPEC s (List []) fp1 start pst1
837− PR.Continue 0 pst1 ->
838− gobuf SPEC s (List (x:getList backBuf)) fp next pst1
839− PR.Continue n pst1 -> do
840− assert (n <= Prelude.length (x:getList backBuf)) (return ())
841− let (src0, buf1) = splitAt n (x:getList backBuf)
842− arr0 = A.fromListN n (Prelude.reverse src0)
843− arr1 = Array contents next end
844− src = arr0 <> arr1
845− let !(Array cont1 start end1) = src
846− fp1 = Tuple' end1 cont1
847− gobuf SPEC s (List buf1) fp1 start pst1
848− PR.Done 0 b -> do
849− let arr = Array contents next end
850− return (b, D.cons arr (D.Stream step s))
851− PR.Done n b -> do
852− assert (n <= Prelude.length (x:getList backBuf)) (return ())
853− let src0 = Prelude.take n (x:getList backBuf)
854− -- XXX create the array in reverse instead
855− arr0 = A.fromListN n (Prelude.reverse src0)
856− arr1 = Array contents next end
857− -- XXX Use StreamK to avoid adding arbitrary layers of
858− -- constructors every time.
859− str = D.cons arr0 (D.cons arr1 (D.Stream step s))
860− return (b, str)
861− PR.Error err -> throwM $ ParseError err
862−-}
863−
864−-- | Parse an array stream using the supplied 'Parser'. Returns the parse
865−-- result and the unconsumed stream. Throws 'ParseError' if the parse fails.
866−--
867−-- The following alternative to this function allows composing the parser using
868−-- the parser Monad:
869−--
870−-- >>> parseBreakStreamK p = StreamK.parseBreakChunks (ParserK.adaptC p)
871−--
872−-- We can compare perf and remove this one or define it in terms of that.
873−--
874−-- /Internal/
875−--
876−{-# INLINE_NORMAL parseBreakChunksK #-}
877−parseBreakChunksK ::
878− forall m a b. (MonadIO m, Unbox a)
879− => Parser a m b
880− -> StreamK m (Array a)
881− -> m (Either ParseError b, StreamK m (Array a))
882−-- parseBreakStreamK p = StreamK.parseBreakChunks (ParserK.adaptC p)
883−parseBreakChunksK (Parser pstep initial extract) stream = do
884− res <- initial
885− case res of
886− IPartial s -> go s stream []
887− IDone b -> return (Right b, stream)
888− IError err -> return (Left (ParseError err), stream)
889−
890− where
891−
892− -- "backBuf" contains last few items in the stream that we may have to
893− -- backtrack to.
894− --
895− -- XXX currently we are using a dumb list based approach for backtracking
896− -- buffer. This can be replaced by a sliding/ring buffer using Data.Array.
897− -- That will allow us more efficient random back and forth movement.
898− go !pst st backBuf = do
899− let stop = goStop pst backBuf -- (, K.nil) <$> extract pst
900− single a = yieldk a StreamK.nil
901− yieldk arr r = goArray pst backBuf r arr
902− in StreamK.foldStream defState yieldk single stop st
903−
904− -- Use strictness on "cur" to keep it unboxed
905− goArray !pst backBuf st (Array _ cur end) | cur == end = go pst st backBuf
906− goArray !pst backBuf st (Array contents cur end) = do
907− x <- liftIO $ peekAt cur contents
908− pRes <- pstep pst x
909− let next = INDEX_NEXT(cur,a)
910− case pRes of
911− Parser.Partial 0 s ->
912− goArray s [] st (Array contents next end)
913− Parser.Partial n s -> do
914− assert (n <= Prelude.length (x:backBuf)) (return ())
915− let src0 = Prelude.take n (x:backBuf)
916− arr0 = fromListN n (Prelude.reverse src0)
917− arr1 = Array contents next end
918− src = arr0 <> arr1
919− goArray s [] st src
920− Parser.Continue 0 s ->
921− goArray s (x:backBuf) st (Array contents next end)
922− Parser.Continue n s -> do
923− assert (n <= Prelude.length (x:backBuf)) (return ())
924− let (src0, buf1) = Prelude.splitAt n (x:backBuf)
925− arr0 = fromListN n (Prelude.reverse src0)
926− arr1 = Array contents next end
927− src = arr0 <> arr1
928− goArray s buf1 st src
929− Parser.Done 0 b -> do
930− let arr = Array contents next end
931− return (Right b, StreamK.cons arr st)
932− Parser.Done n b -> do
933− assert (n <= Prelude.length (x:backBuf)) (return ())
934− let src0 = Prelude.take n (x:backBuf)
935− -- XXX Use fromListRevN once implemented
936− -- arr0 = A.fromListRevN n src0
937− arr0 = fromListN n (Prelude.reverse src0)
938− arr1 = Array contents next end
939− str = StreamK.cons arr0 (StreamK.cons arr1 st)
940− return (Right b, str)
941− Parser.Error err -> do
942− let n = Prelude.length backBuf
943− arr0 = fromListN n (Prelude.reverse backBuf)
944− arr1 = Array contents cur end
945− str = StreamK.cons arr0 (StreamK.cons arr1 stream)
946− return (Left (ParseError err), str)
947−
948− -- This is a simplified goArray
949− goExtract !pst backBuf (Array _ cur end)
950− | cur == end = goStop pst backBuf
951− goExtract !pst backBuf (Array contents cur end) = do
952− x <- liftIO $ peekAt cur contents
953− pRes <- pstep pst x
954− let next = INDEX_NEXT(cur,a)
955− case pRes of
956− Parser.Partial 0 s ->
957− goExtract s [] (Array contents next end)
958− Parser.Partial n s -> do
959− assert (n <= Prelude.length (x:backBuf)) (return ())
960− let src0 = Prelude.take n (x:backBuf)
961− arr0 = fromListN n (Prelude.reverse src0)
962− arr1 = Array contents next end
963− src = arr0 <> arr1
964− goExtract s [] src
965− Parser.Continue 0 s ->
966− goExtract s backBuf (Array contents next end)
967− Parser.Continue n s -> do
968− assert (n <= Prelude.length (x:backBuf)) (return ())
969− let (src0, buf1) = Prelude.splitAt n (x:backBuf)
970− arr0 = fromListN n (Prelude.reverse src0)
971− arr1 = Array contents next end
972− src = arr0 <> arr1
973− goExtract s buf1 src
974− Parser.Done 0 b -> do
975− let arr = Array contents next end
976− return (Right b, StreamK.fromPure arr)
977− Parser.Done n b -> do
978− assert (n <= Prelude.length backBuf) (return ())
979− let src0 = Prelude.take n backBuf
980− -- XXX Use fromListRevN once implemented
981− -- arr0 = A.fromListRevN n src0
982− arr0 = fromListN n (Prelude.reverse src0)
983− arr1 = Array contents next end
984− str = StreamK.cons arr0 (StreamK.fromPure arr1)
985− return (Right b, str)
986− Parser.Error err -> do
987− let n = Prelude.length backBuf
988− arr0 = fromListN n (Prelude.reverse backBuf)
989− arr1 = Array contents cur end
990− str = StreamK.cons arr0 (StreamK.cons arr1 stream)
991− return (Left (ParseError err), str)
992−
993− -- This is a simplified goExtract
994− {-# INLINE goStop #-}
995− goStop !pst backBuf = do
996− pRes <- extract pst
997− case pRes of
998− Parser.Partial _ _ -> error "Bug: parseBreak: Partial in extract"
999− Parser.Continue 0 s ->
1000− goStop s backBuf
1001− Parser.Continue n s -> do
1002− assert (n <= Prelude.length backBuf) (return ())
1003− let (src0, buf1) = Prelude.splitAt n backBuf
1004− arr = fromListN n (Prelude.reverse src0)
1005− goExtract s buf1 arr
1006− Parser.Done 0 b ->
1007− return (Right b, StreamK.nil)
1008− Parser.Done n b -> do
1009− assert (n <= Prelude.length backBuf) (return ())
1010− let src0 = Prelude.take n backBuf
1011− -- XXX Use fromListRevN once implemented
1012− -- arr0 = A.fromListRevN n src0
1013− arr0 = fromListN n (Prelude.reverse src0)
1014− return (Right b, StreamK.fromPure arr0)
1015− Parser.Error err -> do
1016− let n = Prelude.length backBuf
1017− arr0 = fromListN n (Prelude.reverse backBuf)
1018− return (Left (ParseError err), StreamK.fromPure arr0)
core/src/Streamly/Internal/Data/Array/Generic.hs+6−22
@@ -11,8 +11,8 @@ module Streamly.Internal.Data.Array.Generic
11
11
12 -- * Construction
12 -- * Construction
13 , nil
13 , nil
14− , createOf
14+ , writeN
15− , create
15+ , write
16 , writeWith
16 , writeWith
17 , writeLastN
17 , writeLastN
18
18
@@ -44,10 +44,6 @@ module Streamly.Internal.Data.Array.Generic
44 , getIndex
44 , getIndex
45 , getSliceUnsafe
45 , getSliceUnsafe
46 , strip
46 , strip
47−
48− -- * Deprecated
49− , writeN
50− , write
51 )
47 )
52where
48where
53
49
@@ -108,33 +104,21 @@ nil = unsafePerformIO $ unsafeFreeze <$> MArray.nil
108-- Construction - Folds
104-- Construction - Folds
109-------------------------------------------------------------------------------
105-------------------------------------------------------------------------------
110
106
111−{-# INLINE_NORMAL createOf #-}
107+{-# INLINE_NORMAL writeN #-}
112−createOf :: MonadIO m => Int -> Fold m a (Array a)
113−createOf = fmap unsafeFreeze <$> MArray.createOf
114−
115−-- XXX Deprecate in major
116−-- {-# DEPRECATED writeN "Please use createOf instead." #-}
117−{-# INLINE writeN #-}
118writeN :: MonadIO m => Int -> Fold m a (Array a)
108writeN :: MonadIO m => Int -> Fold m a (Array a)
119−writeN = createOf
109+writeN = fmap unsafeFreeze <$> MArray.writeN
120
110
121{-# INLINE_NORMAL writeWith #-}
111{-# INLINE_NORMAL writeWith #-}
122writeWith :: MonadIO m => Int -> Fold m a (Array a)
112writeWith :: MonadIO m => Int -> Fold m a (Array a)
123−writeWith elemCount = unsafeFreeze <$> MArray.createWith elemCount
113+writeWith elemCount = unsafeFreeze <$> MArray.writeWith elemCount
124
114
125-- | Fold the whole input to a single array.
115-- | Fold the whole input to a single array.
126--
116--
127-- /Caution! Do not use this on infinite streams./
117-- /Caution! Do not use this on infinite streams./
128--
118--
129−{-# INLINE create #-}
130−create :: MonadIO m => Fold m a (Array a)
131−create = fmap unsafeFreeze MArray.create
132−
133−-- XXX Deprecate in major
134−-- {-# DEPRECATED write "Please use create instead." #-}
135{-# INLINE write #-}
119{-# INLINE write #-}
136write :: MonadIO m => Fold m a (Array a)
120write :: MonadIO m => Fold m a (Array a)
137−write = create
121+write = fmap unsafeFreeze MArray.write
138
122
139fromPureStream :: Stream Identity a -> Array a
123fromPureStream :: Stream Identity a -> Array a
140fromPureStream x =
124fromPureStream x =
core/src/Streamly/Internal/Data/Array/Stream.hs+474−15
@@ -12,7 +12,6 @@
12-- keep this as a separate module and release it.
12-- keep this as a separate module and release it.
13--
13--
14module Streamly.Internal.Data.Array.Stream
14module Streamly.Internal.Data.Array.Stream
15−{-# DEPRECATED "Please use \"Streamly.Internal.Data.Array\" instead." #-}
16 (
15 (
17 -- * Creation
16 -- * Creation
18 Array.chunksOf
17 Array.chunksOf
@@ -20,13 +19,13 @@ module Streamly.Internal.Data.Array.Stream
20 , Array.bufferChunks
19 , Array.bufferChunks
21
20
22 -- * Flattening to elements
21 -- * Flattening to elements
23− , Array.concat
22+ , concat
24 , Array.flattenArrays
23 , Array.flattenArrays
25− , Array.concatRev
24+ , concatRev
26 , Array.flattenArraysRev
25 , Array.flattenArraysRev
27− , Array.interpose
26+ , interpose
28− , Array.interposeSuffix
27+ , interposeSuffix
29− , Array.intercalateSuffix
28+ , intercalateSuffix
30 , unlines
29 , unlines
31
30
32 -- * Elimination
31 -- * Elimination
@@ -96,9 +95,14 @@ import Streamly.Internal.Data.Parser (ParseError(..))
96import Streamly.Internal.Data.Stream (Stream)
95import Streamly.Internal.Data.Stream (Stream)
97import Streamly.Internal.Data.StreamK (StreamK, fromStream, toStream)
96import Streamly.Internal.Data.StreamK (StreamK, fromStream, toStream)
98import Streamly.Internal.Data.SVar.Type (adaptState, defState)
97import Streamly.Internal.Data.SVar.Type (adaptState, defState)
98+import Streamly.Internal.Data.Tuple.Strict (Tuple'(..))
99
99
100+import qualified Streamly.Data.Fold as FL
100import qualified Streamly.Internal.Data.Array as A
101import qualified Streamly.Internal.Data.Array as A
101import qualified Streamly.Internal.Data.Array as Array
102import qualified Streamly.Internal.Data.Array as Array
103+import qualified Streamly.Internal.Data.MutArray.Type as MA
104+import qualified Streamly.Internal.Data.MutArray.Stream as AS
105+import qualified Streamly.Internal.Data.Fold.Type as FL (Fold(..), Step(..))
102import qualified Streamly.Internal.Data.Parser as PR
106import qualified Streamly.Internal.Data.Parser as PR
103import qualified Streamly.Internal.Data.Parser as PRD
107import qualified Streamly.Internal.Data.Parser as PRD
104 (Parser(..), Initial(..))
108 (Parser(..), Initial(..))
@@ -109,19 +113,110 @@ import qualified Streamly.Internal.Data.StreamK as K
109-- XXX Since these are immutable arrays MonadIO constraint can be removed from
113-- XXX Since these are immutable arrays MonadIO constraint can be removed from
110-- most places.
114-- most places.
111
115
116+-------------------------------------------------------------------------------
117+-- Append
118+-------------------------------------------------------------------------------
119+
120+-- XXX efficiently compare two streams of arrays. Two streams can have chunks
121+-- of different sizes, we can handle that in the stream comparison abstraction.
122+-- This could be useful e.g. to fast compare whether two files differ.
123+
124+-- | Convert a stream of arrays into a stream of their elements.
125+--
126+-- Same as the following:
127+--
128+-- > concat = Stream.unfoldMany Array.read
129+--
130+-- @since 0.7.0
131+{-# INLINE concat #-}
132+concat :: (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
133+-- concat m = fromStreamD $ A.flattenArrays (toStreamD m)
134+-- concat m = fromStreamD $ D.concatMap A.toStreamD (toStreamD m)
135+concat = D.unfoldMany A.reader
136+
137+-- | Convert a stream of arrays into a stream of their elements reversing the
138+-- contents of each array before flattening.
139+--
140+-- > concatRev = Stream.unfoldMany Array.readerRev
141+--
142+-- @since 0.7.0
143+{-# INLINE concatRev #-}
144+concatRev :: (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
145+-- concatRev m = fromStreamD $ A.flattenArraysRev (toStreamD m)
146+concatRev = D.unfoldMany A.readerRev
147+
112-------------------------------------------------------------------------------
148-------------------------------------------------------------------------------
113-- Intersperse and append
149-- Intersperse and append
114-------------------------------------------------------------------------------
150-------------------------------------------------------------------------------
115
151
152+-- | Flatten a stream of arrays after inserting the given element between
153+-- arrays.
154+--
155+-- /Pre-release/
156+{-# INLINE interpose #-}
157+interpose :: (Monad m, Unbox a) => a -> Stream m (Array a) -> Stream m a
158+interpose x = D.interpose x A.reader
159+
160+{-# INLINE intercalateSuffix #-}
161+intercalateSuffix :: (Monad m, Unbox a)
162+ => Array a -> Stream m (Array a) -> Stream m a
163+intercalateSuffix = D.intercalateSuffix A.reader
164+
165+-- | Flatten a stream of arrays appending the given element after each
166+-- array.
167+--
168+-- @since 0.7.0
169+{-# INLINE interposeSuffix #-}
170+interposeSuffix :: (Monad m, Unbox a)
171+ => a -> Stream m (Array a) -> Stream m a
172+-- interposeSuffix x = fromStreamD . A.unlines x . toStreamD
173+interposeSuffix x = D.interposeSuffix x A.reader
174+
175+data FlattenState s =
176+ OuterLoop s
177+ | InnerLoop s !MA.MutableByteArray !Int !Int
178+
179+-- XXX This is a special case of interposeSuffix, can be removed.
180+-- XXX Remove monadIO constraint
116{-# INLINE_NORMAL unlines #-}
181{-# INLINE_NORMAL unlines #-}
117unlines :: forall m a. (MonadIO m, Unbox a)
182unlines :: forall m a. (MonadIO m, Unbox a)
118 => a -> D.Stream m (Array a) -> D.Stream m a
183 => a -> D.Stream m (Array a) -> D.Stream m a
119−unlines = Array.interposeSuffix
184+unlines sep (D.Stream step state) = D.Stream step' (OuterLoop state)
185+ where
186+ {-# INLINE_LATE step' #-}
187+ step' gst (OuterLoop st) = do
188+ r <- step (adaptState gst) st
189+ return $ case r of
190+ D.Yield Array{..} s ->
191+ D.Skip (InnerLoop s arrContents arrStart arrEnd)
192+ D.Skip s -> D.Skip (OuterLoop s)
193+ D.Stop -> D.Stop
194+
195+ step' _ (InnerLoop st _ p end) | p == end =
196+ return $ D.Yield sep $ OuterLoop st
197+
198+ step' _ (InnerLoop st contents p end) = do
199+ x <- liftIO $ peekByteIndex p contents
200+ return $ D.Yield x (InnerLoop st contents (INDEX_NEXT(p,a)) end)
120
201
121-------------------------------------------------------------------------------
202-------------------------------------------------------------------------------
122-- Compact
203-- Compact
123-------------------------------------------------------------------------------
204-------------------------------------------------------------------------------
124
205
206+-- XXX These would not be needed once we implement compactLEFold, see
207+-- module Streamly.Internal.Data.Stream.MutChunked
208+--
209+-- XXX Note that this thaws immutable arrays for appending, that may be
210+-- problematic if multiple users do the same thing, however, immutable arrays
211+-- would usually have no capacity to append, therefore, a copy will be forced
212+-- anyway. Confirm this. We can forcefully trim the array capacity before thaw
213+-- to ensure this.
214+{-# INLINE_NORMAL packArraysChunksOf #-}
215+packArraysChunksOf :: (MonadIO m, Unbox a)
216+ => Int -> D.Stream m (Array a) -> D.Stream m (Array a)
217+packArraysChunksOf n str =
218+ D.map A.unsafeFreeze $ AS.packArraysChunksOf n $ D.map A.unsafeThaw str
219+
125-- XXX instead of writing two different versions of this operation, we should
220-- XXX instead of writing two different versions of this operation, we should
126-- write it as a pipe.
221-- write it as a pipe.
127--
222--
@@ -129,7 +224,8 @@ unlines = Array.interposeSuffix
129{-# INLINE_NORMAL lpackArraysChunksOf #-}
224{-# INLINE_NORMAL lpackArraysChunksOf #-}
130lpackArraysChunksOf :: (MonadIO m, Unbox a)
225lpackArraysChunksOf :: (MonadIO m, Unbox a)
131 => Int -> Fold m (Array a) () -> Fold m (Array a) ()
226 => Int -> Fold m (Array a) () -> Fold m (Array a) ()
132−lpackArraysChunksOf = Array.lCompactGE
227+lpackArraysChunksOf n fld =
228+ FL.lmap A.unsafeThaw $ AS.lpackArraysChunksOf n (FL.lmap A.unsafeFreeze fld)
133
229
134-- | Coalesce adjacent arrays in incoming stream to form bigger arrays of a
230-- | Coalesce adjacent arrays in incoming stream to form bigger arrays of a
135-- maximum specified size in bytes.
231-- maximum specified size in bytes.
@@ -138,7 +234,7 @@ lpackArraysChunksOf = Array.lCompactGE
138{-# INLINE compact #-}
234{-# INLINE compact #-}
139compact :: (MonadIO m, Unbox a)
235compact :: (MonadIO m, Unbox a)
140 => Int -> Stream m (Array a) -> Stream m (Array a)
236 => Int -> Stream m (Array a) -> Stream m (Array a)
141−compact = Array.compactLE
237+compact = packArraysChunksOf
142
238
143-- | Given a stream of arrays, splice them all together to generate a single
239-- | Given a stream of arrays, splice them all together to generate a single
144-- array. The stream must be /finite/.
240-- array. The stream must be /finite/.
@@ -146,12 +242,71 @@ compact = Array.compactLE
146-- @since 0.7.0
242-- @since 0.7.0
147{-# INLINE toArray #-}
243{-# INLINE toArray #-}
148toArray :: (MonadIO m, Unbox a) => Stream m (Array a) -> m (Array a)
244toArray :: (MonadIO m, Unbox a) => Stream m (Array a) -> m (Array a)
149−toArray = Array.fromChunks
245+toArray s =
246+ fmap A.unsafeFreeze $ MA.fromArrayStreamRealloced (fmap A.unsafeThaw s)
150
247
151-------------------------------------------------------------------------------
248-------------------------------------------------------------------------------
152-- Split
249-- Split
153-------------------------------------------------------------------------------
250-------------------------------------------------------------------------------
154
251
252+data SplitState s arr
253+ = Initial s
254+ | Buffering s arr
255+ | Splitting s arr
256+ | Yielding arr (SplitState s arr)
257+ | Finishing
258+
259+-- | Split a stream of arrays on a given separator byte, dropping the separator
260+-- and coalescing all the arrays between two separators into a single array.
261+--
262+-- @since 0.7.0
263+{-# INLINE_NORMAL _splitOn #-}
264+_splitOn
265+ :: MonadIO m
266+ => Word8
267+ -> D.Stream m (Array Word8)
268+ -> D.Stream m (Array Word8)
269+_splitOn byte (D.Stream step state) = D.Stream step' (Initial state)
270+
271+ where
272+
273+ {-# INLINE_LATE step' #-}
274+ step' gst (Initial st) = do
275+ r <- step gst st
276+ case r of
277+ D.Yield arr s -> do
278+ (arr1, marr2) <- A.breakOn byte arr
279+ return $ case marr2 of
280+ Nothing -> D.Skip (Buffering s arr1)
281+ Just arr2 -> D.Skip (Yielding arr1 (Splitting s arr2))
282+ D.Skip s -> return $ D.Skip (Initial s)
283+ D.Stop -> return D.Stop
284+
285+ step' gst (Buffering st buf) = do
286+ r <- step gst st
287+ case r of
288+ D.Yield arr s -> do
289+ (arr1, marr2) <- A.breakOn byte arr
290+ -- XXX Should use MutArray.splice
291+ buf' <- A.splice buf arr1
292+ return $ case marr2 of
293+ Nothing -> D.Skip (Buffering s buf')
294+ Just x -> D.Skip (Yielding buf' (Splitting s x))
295+ D.Skip s -> return $ D.Skip (Buffering s buf)
296+ D.Stop -> return $
297+ if A.byteLength buf == 0
298+ then D.Stop
299+ else D.Skip (Yielding buf Finishing)
300+
301+ step' _ (Splitting st buf) = do
302+ (arr1, marr2) <- A.breakOn byte buf
303+ return $ case marr2 of
304+ Nothing -> D.Skip $ Buffering st arr1
305+ Just arr2 -> D.Skip $ Yielding arr1 (Splitting st arr2)
306+
307+ step' _ (Yielding arr next) = return $ D.Yield arr next
308+ step' _ Finishing = return D.Stop
309+
155-- XXX Remove MonadIO constraint.
310-- XXX Remove MonadIO constraint.
156-- | Split a stream of arrays on a given separator byte, dropping the separator
311-- | Split a stream of arrays on a given separator byte, dropping the separator
157-- and coalescing all the arrays between two separators into a single array.
312-- and coalescing all the arrays between two separators into a single array.
@@ -163,7 +318,11 @@ splitOn
163 => Word8
318 => Word8
164 -> Stream m (Array Word8)
319 -> Stream m (Array Word8)
165 -> Stream m (Array Word8)
320 -> Stream m (Array Word8)
166−splitOn = Array.compactOnByte
321+splitOn byte =
322+ fmap A.unsafeFreeze
323+ -- XXX use spliceExp and rightSize?
324+ . D.splitInnerBy (MA.breakOn byte) MA.splice
325+ . fmap A.unsafeThaw
167
326
168{-# INLINE splitOnSuffix #-}
327{-# INLINE splitOnSuffix #-}
169splitOnSuffix
328splitOnSuffix
@@ -171,7 +330,13 @@ splitOnSuffix
171 => Word8
330 => Word8
172 -> Stream m (Array Word8)
331 -> Stream m (Array Word8)
173 -> Stream m (Array Word8)
332 -> Stream m (Array Word8)
333+-- splitOn byte s = fromStreamD $ A.splitOn byte $ toStreamD s
174−splitOnSuffix = Array.compactOnByteSuffix
334+splitOnSuffix byte =
335+ fmap A.unsafeFreeze
336+ -- XXX use spliceExp and rightSize?
337+ . D.splitInnerBySuffix
338+ (\arr -> MA.byteLength arr == 0) (MA.breakOn byte) MA.splice
339+ . fmap A.unsafeThaw
175
340
176-------------------------------------------------------------------------------
341-------------------------------------------------------------------------------
177-- Elimination - Running folds
342-- Elimination - Running folds
@@ -180,7 +345,71 @@ splitOnSuffix = Array.compactOnByteSuffix
180{-# INLINE_NORMAL foldBreakD #-}
345{-# INLINE_NORMAL foldBreakD #-}
181foldBreakD :: forall m a b. (MonadIO m, Unbox a) =>
346foldBreakD :: forall m a b. (MonadIO m, Unbox a) =>
182 Fold m a b -> D.Stream m (Array a) -> m (b, D.Stream m (Array a))
347 Fold m a b -> D.Stream m (Array a) -> m (b, D.Stream m (Array a))
183−foldBreakD = Array.foldBreakChunks
348+foldBreakD (FL.Fold fstep initial _ final) stream@(D.Stream step state) = do
349+ res <- initial
350+ case res of
351+ FL.Partial fs -> go SPEC state fs
352+ FL.Done fb -> return $! (fb, stream)
353+
354+ where
355+
356+ {-# INLINE go #-}
357+ go !_ st !fs = do
358+ r <- step defState st
359+ case r of
360+ D.Yield (Array contents start end) s ->
361+ let fp = Tuple' end contents
362+ in goArray SPEC s fp start fs
363+ D.Skip s -> go SPEC s fs
364+ D.Stop -> do
365+ b <- final fs
366+ return (b, D.nil)
367+
368+ goArray !_ s (Tuple' end _) !cur !fs
369+ | cur == end = do
370+ go SPEC s fs
371+ goArray !_ st fp@(Tuple' end contents) !cur !fs = do
372+ x <- liftIO $ peekByteIndex cur contents
373+ res <- fstep fs x
374+ let next = INDEX_NEXT(cur,a)
375+ case res of
376+ FL.Done b -> do
377+ let arr = Array contents next end
378+ return $! (b, D.cons arr (D.Stream step st))
379+ FL.Partial fs1 -> goArray SPEC st fp next fs1
380+
381+{-# INLINE_NORMAL foldBreakK #-}
382+foldBreakK :: forall m a b. (MonadIO m, Unbox a) =>
383+ Fold m a b -> K.StreamK m (Array a) -> m (b, K.StreamK m (Array a))
384+foldBreakK (FL.Fold fstep initial _ final) stream = do
385+ res <- initial
386+ case res of
387+ FL.Partial fs -> go fs stream
388+ FL.Done fb -> return (fb, stream)
389+
390+ where
391+
392+ {-# INLINE go #-}
393+ go !fs st = do
394+ let stop = (, K.nil) <$> final fs
395+ single a = yieldk a K.nil
396+ yieldk (Array contents start end) r =
397+ let fp = Tuple' end contents
398+ in goArray fs r fp start
399+ in K.foldStream defState yieldk single stop st
400+
401+ goArray !fs st (Tuple' end _) !cur
402+ | cur == end = do
403+ go fs st
404+ goArray !fs st fp@(Tuple' end contents) !cur = do
405+ x <- liftIO $ peekByteIndex cur contents
406+ res <- fstep fs x
407+ let next = INDEX_NEXT(cur,a)
408+ case res of
409+ FL.Done b -> do
410+ let arr = Array contents next end
411+ return $! (b, K.cons arr st)
412+ FL.Partial fs1 -> goArray fs1 st fp next
184
413
185-- | Fold an array stream using the supplied 'Fold'. Returns the fold result
414-- | Fold an array stream using the supplied 'Fold'. Returns the fold result
186-- and the unconsumed stream.
415-- and the unconsumed stream.
@@ -206,7 +435,7 @@ foldBreak ::
206 => Fold m a b
435 => Fold m a b
207 -> StreamK m (A.Array a)
436 -> StreamK m (A.Array a)
208 -> m (b, StreamK m (A.Array a))
437 -> m (b, StreamK m (A.Array a))
209−foldBreak = Array.foldBreakChunksK
438+foldBreak = foldBreakK
210--
439--
211-- foldBreak f s = fmap fromStreamD <$> foldBreakD f (toStreamD s)
440-- foldBreak f s = fmap fromStreamD <$> foldBreakD f (toStreamD s)
212--
441--
@@ -270,6 +499,236 @@ splitAtArrayListRev n ls
270{-# ANN type List NoSpecConstr #-}
499{-# ANN type List NoSpecConstr #-}
271newtype List a = List {getList :: [a]}
500newtype List a = List {getList :: [a]}
272
501
502+{-
503+-- This can be generalized to any type provided it can be unfolded to a stream
504+-- and it can be combined using a semigroup operation.
505+--
506+-- XXX This should be written using CPS (as parseK) if we want it to scale wrt
507+-- to the number of times it can be called on the same stream.
508+{-# INLINE_NORMAL parseBreakD #-}
509+parseBreakD ::
510+ forall m a b. (MonadIO m, MonadThrow m, Unbox a)
511+ => PRD.Parser a m b
512+ -> D.Stream m (Array.Array a)
513+ -> m (b, D.Stream m (Array.Array a))
514+parseBreakD
515+ (PRD.Parser pstep initial extract) stream@(D.Stream step state) = do
516+
517+ res <- initial
518+ case res of
519+ PRD.IPartial s -> go SPEC state (List []) s
520+ PRD.IDone b -> return (b, stream)
521+ PRD.IError err -> throwM $ ParseError err
522+
523+ where
524+
525+ -- "backBuf" contains last few items in the stream that we may have to
526+ -- backtrack to.
527+ --
528+ -- XXX currently we are using a dumb list based approach for backtracking
529+ -- buffer. This can be replaced by a sliding/ring buffer using Data.Array.
530+ -- That will allow us more efficient random back and forth movement.
531+ go !_ st backBuf !pst = do
532+ r <- step defState st
533+ case r of
534+ D.Yield (Array contents start end) s ->
535+ gobuf SPEC s backBuf
536+ (Tuple' end contents) start pst
537+ D.Skip s -> go SPEC s backBuf pst
538+ D.Stop -> do
539+ b <- extract pst
540+ return (b, D.nil)
541+
542+ -- Use strictness on "cur" to keep it unboxed
543+ gobuf !_ s backBuf (Tuple' end _) !cur !pst
544+ | cur == end = do
545+ go SPEC s backBuf pst
546+ gobuf !_ s backBuf fp@(Tuple' end contents) !cur !pst = do
547+ x <- liftIO $ peekByteIndex contents cur
548+ pRes <- pstep pst x
549+ let next = INDEX_NEXT(cur,a)
550+ case pRes of
551+ PR.Partial 0 pst1 ->
552+ gobuf SPEC s (List []) fp next pst1
553+ PR.Partial n pst1 -> do
554+ assert (n <= Prelude.length (x:getList backBuf)) (return ())
555+ let src0 = Prelude.take n (x:getList backBuf)
556+ arr0 = A.fromListN n (Prelude.reverse src0)
557+ arr1 = Array contents next end
558+ src = arr0 <> arr1
559+ let !(Array cont1 start end1) = src
560+ fp1 = Tuple' end1 cont1
561+ gobuf SPEC s (List []) fp1 start pst1
562+ PR.Continue 0 pst1 ->
563+ gobuf SPEC s (List (x:getList backBuf)) fp next pst1
564+ PR.Continue n pst1 -> do
565+ assert (n <= Prelude.length (x:getList backBuf)) (return ())
566+ let (src0, buf1) = splitAt n (x:getList backBuf)
567+ arr0 = A.fromListN n (Prelude.reverse src0)
568+ arr1 = Array contents next end
569+ src = arr0 <> arr1
570+ let !(Array cont1 start end1) = src
571+ fp1 = Tuple' end1 cont1
572+ gobuf SPEC s (List buf1) fp1 start pst1
573+ PR.Done 0 b -> do
574+ let arr = Array contents next end
575+ return (b, D.cons arr (D.Stream step s))
576+ PR.Done n b -> do
577+ assert (n <= Prelude.length (x:getList backBuf)) (return ())
578+ let src0 = Prelude.take n (x:getList backBuf)
579+ -- XXX create the array in reverse instead
580+ arr0 = A.fromListN n (Prelude.reverse src0)
581+ arr1 = Array contents next end
582+ -- XXX Use StreamK to avoid adding arbitrary layers of
583+ -- constructors every time.
584+ str = D.cons arr0 (D.cons arr1 (D.Stream step s))
585+ return (b, str)
586+ PR.Error err -> throwM $ ParseError err
587+-}
588+
589+{-# INLINE_NORMAL parseBreakK #-}
590+parseBreakK ::
591+ forall m a b. (MonadIO m, Unbox a)
592+ => PRD.Parser a m b
593+ -> K.StreamK m (Array.Array a)
594+ -> m (Either ParseError b, K.StreamK m (Array.Array a))
595+parseBreakK (PRD.Parser pstep initial extract) stream = do
596+ res <- initial
597+ case res of
598+ PRD.IPartial s -> go s stream []
599+ PRD.IDone b -> return (Right b, stream)
600+ PRD.IError err -> return (Left (ParseError err), stream)
601+
602+ where
603+
604+ -- "backBuf" contains last few items in the stream that we may have to
605+ -- backtrack to.
606+ --
607+ -- XXX currently we are using a dumb list based approach for backtracking
608+ -- buffer. This can be replaced by a sliding/ring buffer using Data.Array.
609+ -- That will allow us more efficient random back and forth movement.
610+ go !pst st backBuf = do
611+ let stop = goStop pst backBuf -- (, K.nil) <$> extract pst
612+ single a = yieldk a K.nil
613+ yieldk arr r = goArray pst backBuf r arr
614+ in K.foldStream defState yieldk single stop st
615+
616+ -- Use strictness on "cur" to keep it unboxed
617+ goArray !pst backBuf st (Array _ cur end) | cur == end = go pst st backBuf
618+ goArray !pst backBuf st (Array contents cur end) = do
619+ x <- liftIO $ peekByteIndex cur contents
620+ pRes <- pstep pst x
621+ let next = INDEX_NEXT(cur,a)
622+ case pRes of
623+ PR.Partial 0 s ->
624+ goArray s [] st (Array contents next end)
625+ PR.Partial n s -> do
626+ assert (n <= Prelude.length (x:backBuf)) (return ())
627+ let src0 = Prelude.take n (x:backBuf)
628+ arr0 = A.fromListN n (Prelude.reverse src0)
629+ arr1 = Array contents next end
630+ src = arr0 <> arr1
631+ goArray s [] st src
632+ PR.Continue 0 s ->
633+ goArray s (x:backBuf) st (Array contents next end)
634+ PR.Continue n s -> do
635+ assert (n <= Prelude.length (x:backBuf)) (return ())
636+ let (src0, buf1) = splitAt n (x:backBuf)
637+ arr0 = A.fromListN n (Prelude.reverse src0)
638+ arr1 = Array contents next end
639+ src = arr0 <> arr1
640+ goArray s buf1 st src
641+ PR.Done 0 b -> do
642+ let arr = Array contents next end
643+ return (Right b, K.cons arr st)
644+ PR.Done n b -> do
645+ assert (n <= Prelude.length (x:backBuf)) (return ())
646+ let src0 = Prelude.take n (x:backBuf)
647+ -- XXX Use fromListRevN once implemented
648+ -- arr0 = A.fromListRevN n src0
649+ arr0 = A.fromListN n (Prelude.reverse src0)
650+ arr1 = Array contents next end
651+ str = K.cons arr0 (K.cons arr1 st)
652+ return (Right b, str)
653+ PR.Error err -> do
654+ let n = Prelude.length backBuf
655+ arr0 = A.fromListN n (Prelude.reverse backBuf)
656+ arr1 = Array contents cur end
657+ str = K.cons arr0 (K.cons arr1 stream)
658+ return (Left (ParseError err), str)
659+
660+ -- This is a simplified goArray
661+ goExtract !pst backBuf (Array _ cur end)
662+ | cur == end = goStop pst backBuf
663+ goExtract !pst backBuf (Array contents cur end) = do
664+ x <- liftIO $ peekByteIndex cur contents
665+ pRes <- pstep pst x
666+ let next = INDEX_NEXT(cur,a)
667+ case pRes of
668+ PR.Partial 0 s ->
669+ goExtract s [] (Array contents next end)
670+ PR.Partial n s -> do
671+ assert (n <= Prelude.length (x:backBuf)) (return ())
672+ let src0 = Prelude.take n (x:backBuf)
673+ arr0 = A.fromListN n (Prelude.reverse src0)
674+ arr1 = Array contents next end
675+ src = arr0 <> arr1
676+ goExtract s [] src
677+ PR.Continue 0 s ->
678+ goExtract s backBuf (Array contents next end)
679+ PR.Continue n s -> do
680+ assert (n <= Prelude.length (x:backBuf)) (return ())
681+ let (src0, buf1) = splitAt n (x:backBuf)
682+ arr0 = A.fromListN n (Prelude.reverse src0)
683+ arr1 = Array contents next end
684+ src = arr0 <> arr1
685+ goExtract s buf1 src
686+ PR.Done 0 b -> do
687+ let arr = Array contents next end
688+ return (Right b, K.fromPure arr)
689+ PR.Done n b -> do
690+ assert (n <= Prelude.length backBuf) (return ())
691+ let src0 = Prelude.take n backBuf
692+ -- XXX Use fromListRevN once implemented
693+ -- arr0 = A.fromListRevN n src0
694+ arr0 = A.fromListN n (Prelude.reverse src0)
695+ arr1 = Array contents next end
696+ str = K.cons arr0 (K.fromPure arr1)
697+ return (Right b, str)
698+ PR.Error err -> do
699+ let n = Prelude.length backBuf
700+ arr0 = A.fromListN n (Prelude.reverse backBuf)
701+ arr1 = Array contents cur end
702+ str = K.cons arr0 (K.cons arr1 stream)
703+ return (Left (ParseError err), str)
704+
705+ -- This is a simplified goExtract
706+ {-# INLINE goStop #-}
707+ goStop !pst backBuf = do
708+ pRes <- extract pst
709+ case pRes of
710+ PR.Partial _ _ -> error "Bug: parseBreak: Partial in extract"
711+ PR.Continue 0 s ->
712+ goStop s backBuf
713+ PR.Continue n s -> do
714+ assert (n <= Prelude.length backBuf) (return ())
715+ let (src0, buf1) = splitAt n backBuf
716+ arr = A.fromListN n (Prelude.reverse src0)
717+ goExtract s buf1 arr
718+ PR.Done 0 b ->
719+ return (Right b, K.nil)
720+ PR.Done n b -> do
721+ assert (n <= Prelude.length backBuf) (return ())
722+ let src0 = Prelude.take n backBuf
723+ -- XXX Use fromListRevN once implemented
724+ -- arr0 = A.fromListRevN n src0
725+ arr0 = A.fromListN n (Prelude.reverse src0)
726+ return (Right b, K.fromPure arr0)
727+ PR.Error err -> do
728+ let n = Prelude.length backBuf
729+ arr0 = A.fromListN n (Prelude.reverse backBuf)
730+ return (Left (ParseError err), K.fromPure arr0)
731+
273-- | Parse an array stream using the supplied 'Parser'. Returns the parse
732-- | Parse an array stream using the supplied 'Parser'. Returns the parse
274-- result and the unconsumed stream. Throws 'ParseError' if the parse fails.
733-- result and the unconsumed stream. Throws 'ParseError' if the parse fails.
275--
734--
@@ -293,7 +752,7 @@ parseBreak ::
293parseBreak p s =
752parseBreak p s =
294 fmap fromStreamD <$> parseBreakD (PRD.fromParserK p) (toStreamD s)
753 fmap fromStreamD <$> parseBreakD (PRD.fromParserK p) (toStreamD s)
295-}
754-}
296−parseBreak = Array.parseBreakChunksK
755+parseBreak = parseBreakK
297-- parseBreak p = K.parseBreakChunks (ParserK.adaptC p)
756-- parseBreak p = K.parseBreakChunks (ParserK.adaptC p)
298
757
299-------------------------------------------------------------------------------
758-------------------------------------------------------------------------------
core/src/Streamly/Internal/Data/Array/Type.hs+108−390
@@ -1,11 +1,8 @@
1{-# LANGUAGE CPP #-}
1{-# LANGUAGE CPP #-}
2−{-# LANGUAGE TypeFamilies #-}
3−-- Must come after TypeFamilies, otherwise it is re-enabled.
4−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
5−{-# LANGUAGE NoMonoLocalBinds #-}
6-- |
2-- |
7-- Module : Streamly.Internal.Data.Array.Type
3-- Module : Streamly.Internal.Data.Array.Type
8-- Copyright : (c) 2020 Composewell Technologies
4-- Copyright : (c) 2020 Composewell Technologies
5+--
9-- License : BSD3-3-Clause
6-- License : BSD3-3-Clause
10-- Maintainer : streamly@composewell.com
7-- Maintainer : streamly@composewell.com
11-- Stability : experimental
8-- Stability : experimental
@@ -13,146 +10,96 @@
13--
10--
14-- See notes in "Streamly.Internal.Data.MutArray.Type"
11-- See notes in "Streamly.Internal.Data.MutArray.Type"
15--
12--
16−
17module Streamly.Internal.Data.Array.Type
13module Streamly.Internal.Data.Array.Type
18 (
14 (
19 -- ** Type
15 -- ** Type
20 -- $arrayNotes
16 -- $arrayNotes
21 Array (..)
17 Array (..)
18+ , asPtrUnsafe
19+ , nil
22
20
23− -- ** Conversion
21+ -- ** Freezing and Thawing
24− -- *** Mutable and Immutable
25 , unsafeFreeze
22 , unsafeFreeze
26 , unsafeFreezeWithShrink
23 , unsafeFreezeWithShrink
27 , unsafeThaw
24 , unsafeThaw
28
25
29− -- *** Pinned and Unpinned
26+ -- ** Pinning and Unpinning
30 , pin
27 , pin
31 , unpin
28 , unpin
32 , isPinned
29 , isPinned
33
30
34− -- *** Casting
35− , unsafePinnedAsPtr
36−
37 -- ** Construction
31 -- ** Construction
38− , empty
32+ , splice
39
33
40− -- *** Cloning
41− -- XXX Why would we clone an immutable array?
42− , clone
43− , pinnedClone
44−
45− -- *** Slicing
46− -- | Get a subarray without copying
47− , splitAt
48− , breakOn -- XXX requires MonadIO
49−
50− -- *** Stream Folds
51− , unsafeMakePure
52− , createOf
53− , pinnedCreateOf
54− , unsafeCreateOf
55− , unsafePinnedCreateOf
56− , create
57− , pinnedCreate
58− , createWith
59−
60− -- *** From containers
61− , fromListN
62− , pinnedFromListN
63 , fromList
34 , fromList
64 , pinnedFromList
35 , pinnedFromList
65− , fromListRevN
36+ , fromListN
37+ , pinnedFromListN
66 , fromListRev
38 , fromListRev
67− , fromStreamN
39+ , fromListRevN
68− , fromStream
40+ , fromStreamDN
41+ , fromStreamD
69 , fromPureStreamN
42 , fromPureStreamN
70 , fromPureStream
43 , fromPureStream
71 , fromByteStr#
44 , fromByteStr#
72 , fromByteStr
45 , fromByteStr
73 , fromPtrN
46 , fromPtrN
74− , fromChunks
47+ , fromArrayStreamK
75− , fromChunksK
76−
77− -- ** Reading
78−
79− -- *** Indexing
80− , unsafeIndexIO -- XXX unsafeGetIndexIO
81− , getIndexUnsafe -- XXX unsafeGetIndex
82−
83− -- *** To Streams
84− , read
85− , readRev
86− , toStreamK
87− , toStreamKRev
88
48
89− -- *** To Containers
49+ -- ** Split
90− , toList
50+ , breakOn
91
51
92− -- *** Unfolds
52+ -- ** Cloning arrays
93− , producer -- experimental
53+ , clone
94− , readerUnsafe
54+ , pinnedClone
95− , reader
96− , readerRev
97
55
98− -- *** Size
56+ -- ** Elimination
99− , length
57+ , unsafeIndexIO
58+ , getIndexUnsafe
100 , byteLength
59 , byteLength
60+ , length
101
61
102− -- ** Folding
103 , foldl'
62 , foldl'
104 , foldr
63 , foldr
105− , byteCmp
64+ , splitAt
106− , byteEq
107−
108− -- ** Appending
109− , splice -- XXX requires MonadIO
110−
111− -- ** Streams of arrays
112− -- *** Chunk
113− -- | Group a stream into arrays.
114− , chunksOf
115− , pinnedChunksOf
116− , buildChunks
117−
118− -- *** Split
119− -- | Split an array into slices.
120−
121− -- *** Concat
122− -- | Append the arrays in a stream to form a stream of elements.
123− , concat
124− , concatRev
125−
126− -- *** Compact
127− -- | Append the arrays in a stream to form a stream of larger arrays.
128− , fCompactGE
129− , fPinnedCompactGE
130− , lCompactGE
131− , lPinnedCompactGE
132− , compactGE
133
65
134− -- ** Deprecated
135− , asPtrUnsafe
136− , unsafeIndex
137− , bufferChunks
138− , flattenArrays
139− , flattenArraysRev
140− , fromArrayStreamK
141− , fromStreamDN
142− , fromStreamD
143 , toStreamD
66 , toStreamD
144 , toStreamDRev
67 , toStreamDRev
68+ , toStreamK
69+ , toStreamKRev
145 , toStream
70 , toStream
146 , toStreamRev
71 , toStreamRev
147− , nil
72+ , read
73+ , readRev
74+ , readerRev
75+ , toList
76+
77+ -- ** Folds
148 , writeWith
78 , writeWith
149 , writeN
79 , writeN
150 , pinnedWriteN
80 , pinnedWriteN
151 , writeNUnsafe
81 , writeNUnsafe
152 , pinnedWriteNUnsafe
82 , pinnedWriteNUnsafe
83+ , MA.ArrayUnsafe (..)
153 , pinnedWriteNAligned
84 , pinnedWriteNAligned
154 , write
85 , write
155 , pinnedWrite
86 , pinnedWrite
87+ , unsafeMakePure
88+ , byteCmp
89+ , byteEq
90+
91+ -- ** Streams of arrays
92+ , chunksOf
93+ , pinnedChunksOf
94+ , buildChunks
95+ , concatChunks
96+ , concatChunksRev
97+
98+ -- ** Deprecated
99+ , unsafeIndex
100+ , bufferChunks
101+ , flattenArrays
102+ , flattenArraysRev
156 )
103 )
157where
104where
158
105
@@ -160,7 +107,7 @@ where
160#include "inline.hs"
107#include "inline.hs"
161
108
162import Control.Exception (assert)
109import Control.Exception (assert)
163−import Control.Monad (replicateM, when)
110+import Control.Monad (replicateM)
164import Control.Monad.IO.Class (MonadIO(..))
111import Control.Monad.IO.Class (MonadIO(..))
165import Data.Functor.Identity (Identity(..))
112import Data.Functor.Identity (Identity(..))
166import Data.Int (Int8, Int16, Int32, Int64)
113import Data.Int (Int8, Int16, Int32, Int64)
@@ -171,9 +118,7 @@ import GHC.Exts (IsList, IsString(..), Addr#)
171
118
172import GHC.IO (unsafePerformIO)
119import GHC.IO (unsafePerformIO)
173import GHC.Ptr (Ptr(..))
120import GHC.Ptr (Ptr(..))
174−import Streamly.Internal.Data.Producer.Type (Producer(..))
121+import Streamly.Internal.Data.MutArray.Type (MutArray(..), MutByteArray)
175−import Streamly.Internal.Data.MutArray.Type (MutArray(..))
176−import Streamly.Internal.Data.MutByteArray.Type (MutByteArray)
177import Streamly.Internal.Data.Fold.Type (Fold(..))
122import Streamly.Internal.Data.Fold.Type (Fold(..))
178import Streamly.Internal.Data.Stream.Type (Stream)
123import Streamly.Internal.Data.Stream.Type (Stream)
179import Streamly.Internal.Data.StreamK.Type (StreamK)
124import Streamly.Internal.Data.StreamK.Type (StreamK)
@@ -181,15 +126,13 @@ import Streamly.Internal.Data.Unbox (Unbox(..))
181import Streamly.Internal.Data.Unfold.Type (Unfold(..))
126import Streamly.Internal.Data.Unfold.Type (Unfold(..))
182import Text.Read (readPrec)
127import Text.Read (readPrec)
183
128
184−import Prelude hiding (Foldable(..), concat, read, unlines, splitAt)
129+import Prelude hiding (Foldable(..), read, unlines, splitAt)
185
130
186import qualified GHC.Exts as Exts
131import qualified GHC.Exts as Exts
187−import qualified Streamly.Internal.Data.Fold.Type as Fold
188import qualified Streamly.Internal.Data.MutArray.Type as MA
132import qualified Streamly.Internal.Data.MutArray.Type as MA
189import qualified Streamly.Internal.Data.Stream.Type as D
133import qualified Streamly.Internal.Data.Stream.Type as D
190import qualified Streamly.Internal.Data.StreamK.Type as K
134import qualified Streamly.Internal.Data.StreamK.Type as K
191import qualified Streamly.Internal.Data.MutByteArray.Type as Unboxed
135import qualified Streamly.Internal.Data.MutByteArray.Type as Unboxed
192−import qualified Streamly.Internal.Data.Producer as Producer
193import qualified Streamly.Internal.Data.Unfold.Type as Unfold
136import qualified Streamly.Internal.Data.Unfold.Type as Unfold
194import qualified Text.ParserCombinators.ReadPrec as ReadPrec
137import qualified Text.ParserCombinators.ReadPrec as ReadPrec
195
138
@@ -243,20 +186,15 @@ data Array a =
243
186
244-- | Use an @Array a@ as @Ptr a@.
187-- | Use an @Array a@ as @Ptr a@.
245--
188--
246−-- See 'MA.unsafePinnedAsPtr' in the Mutable array module for more details.
189+-- See 'MA.asPtrUnsafe' in the Mutable array module for more details.
247--
190--
248-- /Unsafe/
191-- /Unsafe/
249--
192--
250-- /Pre-release/
193-- /Pre-release/
251--
194--
252−{-# INLINE unsafePinnedAsPtr #-}
253−unsafePinnedAsPtr :: MonadIO m => Array a -> (Ptr a -> m b) -> m b
254−unsafePinnedAsPtr arr = MA.unsafePinnedAsPtr (unsafeThaw arr)
255−
256−{-# DEPRECATED asPtrUnsafe "Please use unsafePinnedAsPtr instead." #-}
257{-# INLINE asPtrUnsafe #-}
195{-# INLINE asPtrUnsafe #-}
258asPtrUnsafe :: MonadIO m => Array a -> (Ptr a -> m b) -> m b
196asPtrUnsafe :: MonadIO m => Array a -> (Ptr a -> m b) -> m b
259−asPtrUnsafe = unsafePinnedAsPtr
197+asPtrUnsafe arr = MA.asPtrUnsafe (unsafeThaw arr)
260
198
261-------------------------------------------------------------------------------
199-------------------------------------------------------------------------------
262-- Freezing and Thawing
200-- Freezing and Thawing
@@ -327,7 +265,7 @@ isPinned = MA.isPinned . unsafeThaw
327-- | Copy two immutable arrays into a new array. If you want to splice more
265-- | Copy two immutable arrays into a new array. If you want to splice more
328-- than two arrays then this operation would be highly inefficient because it
266-- than two arrays then this operation would be highly inefficient because it
329-- would make a copy on every splice operation, instead use the
267-- would make a copy on every splice operation, instead use the
330−-- 'fromChunksK' operation to combine n immutable arrays.
268+-- 'fromArrayStreamK' operation to combine n immutable arrays.
331{-# INLINE splice #-}
269{-# INLINE splice #-}
332splice :: MonadIO m => Array a -> Array a -> m (Array a)
270splice :: MonadIO m => Array a -> Array a -> m (Array a)
333splice arr1 arr2 =
271splice arr1 arr2 =
@@ -375,45 +313,15 @@ pinnedFromList xs = unsafePerformIO $ unsafeFreeze <$> MA.pinnedFromList xs
375fromListRev :: Unbox a => [a] -> Array a
313fromListRev :: Unbox a => [a] -> Array a
376fromListRev xs = unsafePerformIO $ unsafeFreeze <$> MA.fromListRev xs
314fromListRev xs = unsafePerformIO $ unsafeFreeze <$> MA.fromListRev xs
377
315
378−-- | Create an 'Array' from the first N elements of a stream. The array is
379−-- allocated to size N, if the stream terminates before N elements then the
380−-- array may hold less than N elements.
381−--
382−-- >>> fromStreamN n = Stream.fold (Array.writeN n)
383−--
384−-- /Pre-release/
385−{-# INLINE_NORMAL fromStreamN #-}
316+{-# INLINE_NORMAL fromStreamDN #-}
386−fromStreamN :: (MonadIO m, Unbox a) => Int -> Stream m a -> m (Array a)
387−fromStreamN n m = do
388− when (n < 0) $ error "writeN: negative write count specified"
389− unsafeFreeze <$> MA.fromStreamN n m
390−-- fromStreamN n = D.fold (writeN n)
391−
392−{-# DEPRECATED fromStreamDN "Please use fromStreamN instead." #-}
393fromStreamDN :: forall m a. (MonadIO m, Unbox a)
317fromStreamDN :: forall m a. (MonadIO m, Unbox a)
394 => Int -> D.Stream m a -> m (Array a)
318 => Int -> D.Stream m a -> m (Array a)
395−fromStreamDN = fromStreamN
319+fromStreamDN limit str = unsafeFreeze <$> MA.fromStreamDN limit str
396
320
397−-- | Create an 'Array' from a stream. This is useful when we want to create a
398−-- single array from a stream of unknown size. 'writeN' is at least twice
399−-- as efficient when the size is already known.
400−--
401−-- >>> fromStream = Stream.fold Array.write
402−--
403−-- Note that if the input stream is too large memory allocation for the array
404−-- may fail. When the stream size is not known, `chunksOf` followed by
405−-- processing of indvidual arrays in the resulting stream should be preferred.
406−--
407−-- /Pre-release/
408{-# INLINE_NORMAL fromStreamD #-}
321{-# INLINE_NORMAL fromStreamD #-}
409−fromStream :: (MonadIO m, Unbox a) => Stream m a -> m (Array a)
410−fromStream = D.fold write
411−-- fromStreamD str = unsafeFreeze <$> MA.fromStream str
412−
413−{-# DEPRECATED fromStreamD "Please use fromStream instead." #-}
414fromStreamD :: forall m a. (MonadIO m, Unbox a)
322fromStreamD :: forall m a. (MonadIO m, Unbox a)
415 => D.Stream m a -> m (Array a)
323 => D.Stream m a -> m (Array a)
416−fromStreamD = fromStream
324+fromStreamD str = unsafeFreeze <$> MA.fromStreamD str
417
325
418-------------------------------------------------------------------------------
326-------------------------------------------------------------------------------
419-- Cloning
327-- Cloning
@@ -472,100 +380,37 @@ pinnedChunksOf :: forall m a. (MonadIO m, Unbox a)
472 => Int -> D.Stream m a -> D.Stream m (Array a)
380 => Int -> D.Stream m a -> D.Stream m (Array a)
473pinnedChunksOf n str = D.map unsafeFreeze $ MA.pinnedChunksOf n str
381pinnedChunksOf n str = D.map unsafeFreeze $ MA.pinnedChunksOf n str
474
382
475−-- | Convert a stream of arrays into a stream of their elements.
383+-- | Use the "reader" unfold instead.
384+--
385+-- @concatChunks = unfoldMany reader@
476--
386--
477−-- >>> concat = Stream.unfoldMany Array.reader
387+-- We can try this if there are any fusion issues in the unfold.
478--
388--
479−{-# INLINE_NORMAL concat #-}
389+{-# INLINE_NORMAL concatChunks #-}
390+concatChunks :: forall m a. (MonadIO m, Unbox a)
480−concat :: (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
391+ => D.Stream m (Array a) -> D.Stream m a
481−-- XXX this requires MonadIO whereas the unfoldMany version does not
392+concatChunks = MA.concatChunks . D.map unsafeThaw
482−concat = MA.concatWith (pure . unsafeInlineIO) . D.map unsafeThaw
483−-- concat = D.unfoldMany reader
484
393
485{-# DEPRECATED flattenArrays "Please use \"unfoldMany reader\" instead." #-}
394{-# DEPRECATED flattenArrays "Please use \"unfoldMany reader\" instead." #-}
486−{-# INLINE flattenArrays #-}
487flattenArrays :: forall m a. (MonadIO m, Unbox a)
395flattenArrays :: forall m a. (MonadIO m, Unbox a)
488 => D.Stream m (Array a) -> D.Stream m a
396 => D.Stream m (Array a) -> D.Stream m a
489−flattenArrays = concat
397+flattenArrays = concatChunks
490
398
491−-- | Convert a stream of arrays into a stream of their elements reversing the
399+-- | Use the "readerRev" unfold instead.
492−-- contents of each array before flattening.
400+--
401+-- @concatChunksRev = unfoldMany readerRev@
493--
402--
494−-- >>> concatRev = Stream.unfoldMany Array.readerRev
403+-- We can try this if there are any fusion issues in the unfold.
495--
404--
496−{-# INLINE_NORMAL concatRev #-}
405+{-# INLINE_NORMAL concatChunksRev #-}
497−concatRev :: forall m a. (Monad m, Unbox a)
406+concatChunksRev :: forall m a. (MonadIO m, Unbox a)
498 => D.Stream m (Array a) -> D.Stream m a
407 => D.Stream m (Array a) -> D.Stream m a
499−-- XXX this requires MonadIO whereas the unfoldMany version does not
408+concatChunksRev = MA.concatChunksRev . D.map unsafeThaw
500−concatRev = MA.concatRevWith (pure . unsafeInlineIO) . D.map unsafeThaw
501−-- concatRev = D.unfoldMany readerRev
502
409
503{-# DEPRECATED flattenArraysRev "Please use \"unfoldMany readerRev\" instead." #-}
410{-# DEPRECATED flattenArraysRev "Please use \"unfoldMany readerRev\" instead." #-}
504−{-# INLINE flattenArraysRev #-}
505flattenArraysRev :: forall m a. (MonadIO m, Unbox a)
411flattenArraysRev :: forall m a. (MonadIO m, Unbox a)
506 => D.Stream m (Array a) -> D.Stream m a
412 => D.Stream m (Array a) -> D.Stream m a
507−flattenArraysRev = concatRev
413+flattenArraysRev = concatChunksRev
508−
509−-------------------------------------------------------------------------------
510−-- Compact
511−-------------------------------------------------------------------------------
512−
513−-- XXX Note that this thaws immutable arrays for appending, that may be
514−-- problematic if multiple users do the same thing, however, thawed immutable
515−-- arrays would have no capacity to append, therefore, a copy will be forced
516−-- anyway.
517−
518−-- | Fold @fCompactGE n@ coalesces adjacent arrays in the input stream
519−-- until the size becomes greater than or equal to n.
520−--
521−-- Generates unpinned arrays irrespective of the pinning status of input
522−-- arrays.
523−{-# INLINE_NORMAL fCompactGE #-}
524−fCompactGE :: (MonadIO m, Unbox a) => Int -> Fold m (Array a) (Array a)
525−fCompactGE n = fmap unsafeFreeze $ Fold.lmap unsafeThaw $ MA.fCompactGE n
526−
527−-- | PInned version of 'fCompactGE'.
528−{-# INLINE_NORMAL fPinnedCompactGE #-}
529−fPinnedCompactGE :: (MonadIO m, Unbox a) => Int -> Fold m (Array a) (Array a)
530−fPinnedCompactGE n =
531− fmap unsafeFreeze $ Fold.lmap unsafeThaw $ MA.fPinnedCompactGE n
532−
533−-- | @compactGE n stream@ coalesces adjacent arrays in the @stream@ until
534−-- the size becomes greater than or equal to @n@.
535−--
536−-- >>> compactGE n = Stream.foldMany (Array.fCompactGE n)
537−--
538−-- Generates unpinned arrays irrespective of the pinning status of input
539−-- arrays.
540−{-# INLINE compactGE #-}
541−compactGE ::
542− (MonadIO m, Unbox a)
543− => Int -> Stream m (Array a) -> Stream m (Array a)
544−compactGE n stream =
545− D.map unsafeFreeze $ MA.compactGE n $ D.map unsafeThaw stream
546−
547−-- | Like 'compactGE' but for transforming folds instead of stream.
548−--
549−-- >>> lCompactGE n = Fold.many (Array.fCompactGE n)
550−--
551−-- Generates unpinned arrays irrespective of the pinning status of input
552−-- arrays.
553−{-# INLINE_NORMAL lCompactGE #-}
554−lCompactGE :: (MonadIO m, Unbox a)
555− => Int -> Fold m (Array a) () -> Fold m (Array a) ()
556−lCompactGE n fld =
557− Fold.lmap unsafeThaw $ MA.lCompactGE n (Fold.lmap unsafeFreeze fld)
558−
559−-- | Pinned version of 'lCompactGE'.
560−{-# INLINE_NORMAL lPinnedCompactGE #-}
561−lPinnedCompactGE :: (MonadIO m, Unbox a)
562− => Int -> Fold m (Array a) () -> Fold m (Array a) ()
563−lPinnedCompactGE n fld =
564− Fold.lmap unsafeThaw $ MA.lPinnedCompactGE n (Fold.lmap unsafeFreeze fld)
565−
566−-------------------------------------------------------------------------------
567−-- Splitting
568−-------------------------------------------------------------------------------
569
414
570-- Drops the separator byte
415-- Drops the separator byte
571{-# INLINE breakOn #-}
416{-# INLINE breakOn #-}
@@ -609,68 +454,24 @@ byteLength = MA.byteLength . unsafeThaw
609length :: Unbox a => Array a -> Int
454length :: Unbox a => Array a -> Int
610length arr = MA.length (unsafeThaw arr)
455length arr = MA.length (unsafeThaw arr)
611
456
612−{-# INLINE_NORMAL producer #-}
613−producer :: forall m a. (Monad m, Unbox a) => Producer m (Array a) a
614−producer =
615− Producer.translate unsafeThaw unsafeFreeze
616− $ MA.producerWith (return . unsafeInlineIO)
617−
618−-- | Unfold an array into a stream.
619−--
620−{-# INLINE_NORMAL reader #-}
621−reader :: forall m a. (Monad m, Unbox a) => Unfold m (Array a) a
622−reader = Producer.simplify producer
623−
624−-- | Unfold an array into a stream, does not check the end of the array, the
625−-- user is responsible for terminating the stream within the array bounds. For
626−-- high performance application where the end condition can be determined by
627−-- a terminating fold.
628−--
629−-- Written in the hope that it may be faster than "read", however, in the case
630−-- for which this was written, "read" proves to be faster even though the core
631−-- generated with unsafeRead looks simpler.
632−--
633−-- /Pre-release/
634−--
635−{-# INLINE_NORMAL readerUnsafe #-}
636−readerUnsafe :: forall m a. (Monad m, Unbox a) => Unfold m (Array a) a
637−readerUnsafe = Unfold step inject
638− where
639−
640− inject (Array contents start end) =
641− return (MA.ArrayUnsafe contents end start)
642−
643− {-# INLINE_LATE step #-}
644− step (MA.ArrayUnsafe contents end p) = do
645− -- unsafeInlineIO allows us to run this in Identity monad for pure
646− -- toList/foldr case which makes them much faster due to not
647− -- accumulating the list and fusing better with the pure consumers.
648− --
649− -- This should be safe as the array contents are guaranteed to be
650− -- evaluated/written to before we peek at them.
651− let !x = unsafeInlineIO $ peekAt p contents
652− let !p1 = INDEX_NEXT(p,a)
653− return $ D.Yield x (MA.ArrayUnsafe contents end p1)
654−
655-- | Unfold an array into a stream in reverse order.
457-- | Unfold an array into a stream in reverse order.
656--
458--
657{-# INLINE_NORMAL readerRev #-}
459{-# INLINE_NORMAL readerRev #-}
658readerRev :: forall m a. (Monad m, Unbox a) => Unfold m (Array a) a
460readerRev :: forall m a. (Monad m, Unbox a) => Unfold m (Array a) a
659readerRev = Unfold.lmap unsafeThaw $ MA.readerRevWith (return . unsafeInlineIO)
461readerRev = Unfold.lmap unsafeThaw $ MA.readerRevWith (return . unsafeInlineIO)
660
462
661−{-# DEPRECATED toStreamD "Please use 'read' instead." #-}
662{-# INLINE_NORMAL toStreamD #-}
463{-# INLINE_NORMAL toStreamD #-}
663toStreamD :: forall m a. (Monad m, Unbox a) => Array a -> D.Stream m a
464toStreamD :: forall m a. (Monad m, Unbox a) => Array a -> D.Stream m a
664−toStreamD = read
465+toStreamD arr = MA.toStreamDWith (return . unsafeInlineIO) (unsafeThaw arr)
665
466
666{-# INLINE toStreamK #-}
467{-# INLINE toStreamK #-}
667toStreamK :: forall m a. (Monad m, Unbox a) => Array a -> K.StreamK m a
468toStreamK :: forall m a. (Monad m, Unbox a) => Array a -> K.StreamK m a
668toStreamK arr = MA.toStreamKWith (return . unsafeInlineIO) (unsafeThaw arr)
469toStreamK arr = MA.toStreamKWith (return . unsafeInlineIO) (unsafeThaw arr)
669
470
670−{-# DEPRECATED toStreamDRev "Please use 'readRev' instead." #-}
671{-# INLINE_NORMAL toStreamDRev #-}
471{-# INLINE_NORMAL toStreamDRev #-}
672toStreamDRev :: forall m a. (Monad m, Unbox a) => Array a -> D.Stream m a
472toStreamDRev :: forall m a. (Monad m, Unbox a) => Array a -> D.Stream m a
673−toStreamDRev = readRev
473+toStreamDRev arr =
474+ MA.toStreamDRevWith (return . unsafeInlineIO) (unsafeThaw arr)
674
475
675{-# INLINE toStreamKRev #-}
476{-# INLINE toStreamKRev #-}
676toStreamKRev :: forall m a. (Monad m, Unbox a) => Array a -> K.StreamK m a
477toStreamKRev :: forall m a. (Monad m, Unbox a) => Array a -> K.StreamK m a
@@ -682,7 +483,7 @@ toStreamKRev arr =
682-- /Pre-release/
483-- /Pre-release/
683{-# INLINE_EARLY read #-}
484{-# INLINE_EARLY read #-}
684read :: (Monad m, Unbox a) => Array a -> Stream m a
485read :: (Monad m, Unbox a) => Array a -> Stream m a
685−read arr = MA.toStreamWith (return . unsafeInlineIO) (unsafeThaw arr)
486+read = toStreamD
686
487
687-- | Same as 'read'
488-- | Same as 'read'
688--
489--
@@ -699,7 +500,7 @@ toStream = read
699-- /Pre-release/
500-- /Pre-release/
700{-# INLINE_EARLY readRev #-}
501{-# INLINE_EARLY readRev #-}
701readRev :: (Monad m, Unbox a) => Array a -> Stream m a
502readRev :: (Monad m, Unbox a) => Array a -> Stream m a
702−readRev arr = MA.toStreamRevWith (return . unsafeInlineIO) (unsafeThaw arr)
503+readRev = toStreamDRev
703
504
704-- | Same as 'readRev'
505-- | Same as 'readRev'
705--
506--
@@ -723,7 +524,6 @@ foldr f z arr = runIdentity $ D.foldr f z $ toStreamD arr
723-- | Create two slices of an array without copying the original array. The
524-- | Create two slices of an array without copying the original array. The
724-- specified index @i@ is the first index of the second slice.
525-- specified index @i@ is the first index of the second slice.
725--
526--
726−{-# INLINE splitAt #-}
727splitAt :: Unbox a => Int -> Array a -> (Array a, Array a)
527splitAt :: Unbox a => Int -> Array a -> (Array a, Array a)
728splitAt i arr = (unsafeFreeze a, unsafeFreeze b)
528splitAt i arr = (unsafeFreeze a, unsafeFreeze b)
729 where
529 where
@@ -757,28 +557,17 @@ toList s = build (\c n -> toListFB c n s)
757-- Folds
557-- Folds
758-------------------------------------------------------------------------------
558-------------------------------------------------------------------------------
759
559
760−-- | @createOf n@ folds a maximum of @n@ elements from the input stream to an
560+-- | @writeN n@ folds a maximum of @n@ elements from the input stream to an
761-- 'Array'.
561-- 'Array'.
762--
562--
763−{-# INLINE_NORMAL createOf #-}
563+{-# INLINE_NORMAL writeN #-}
764−createOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
765−createOf = fmap unsafeFreeze . MA.createOf
766−
767−-- XXX Deprecate in major
768−-- {-# DEPRECATED writeN "Please use createOf instead." #-}
769−{-# INLINE writeN #-}
770writeN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
564writeN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
771−writeN = createOf
772−
773−-- | Like 'createOf' but creates a pinned array.
774−{-# INLINE_NORMAL pinnedCreateOf #-}
775−pinnedCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
776−pinnedCreateOf = fmap unsafeFreeze . MA.pinnedCreateOf
565+writeN = fmap unsafeFreeze . MA.writeN
777
566
778−{-# DEPRECATED pinnedWriteN "Please use pinnedCreateOf instead." #-}
567+-- | Like 'fromListN' but creates a pinned array.
779−{-# INLINE pinnedWriteN #-}
568+{-# INLINE_NORMAL pinnedWriteN #-}
780pinnedWriteN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
569pinnedWriteN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (Array a)
781−pinnedWriteN = pinnedCreateOf
570+pinnedWriteN = fmap unsafeFreeze . MA.pinnedWriteN
782
571
783-- | @pinnedWriteNAligned alignment n@ folds a maximum of @n@ elements from the input
572-- | @pinnedWriteNAligned alignment n@ folds a maximum of @n@ elements from the input
784-- stream to an 'Array' aligned to the given size.
573-- stream to an 'Array' aligned to the given size.
@@ -786,74 +575,44 @@ pinnedWriteN = pinnedCreateOf
786-- /Pre-release/
575-- /Pre-release/
787--
576--
788{-# INLINE_NORMAL pinnedWriteNAligned #-}
577{-# INLINE_NORMAL pinnedWriteNAligned #-}
789−{-# DEPRECATED pinnedWriteNAligned "To be removed." #-}
790pinnedWriteNAligned :: forall m a. (MonadIO m, Unbox a)
578pinnedWriteNAligned :: forall m a. (MonadIO m, Unbox a)
791 => Int -> Int -> Fold m a (Array a)
579 => Int -> Int -> Fold m a (Array a)
792pinnedWriteNAligned alignSize = fmap unsafeFreeze . MA.pinnedWriteNAligned alignSize
580pinnedWriteNAligned alignSize = fmap unsafeFreeze . MA.pinnedWriteNAligned alignSize
793
581
794−-- | Like 'createOf' but does not check the array bounds when writing. The fold
582+-- | Like 'writeN' but does not check the array bounds when writing. The fold
795-- driver must not call the step function more than 'n' times otherwise it will
583-- driver must not call the step function more than 'n' times otherwise it will
796-- corrupt the memory and crash. This function exists mainly because any
584-- corrupt the memory and crash. This function exists mainly because any
797-- conditional in the step function blocks fusion causing 10x performance
585-- conditional in the step function blocks fusion causing 10x performance
798-- slowdown.
586-- slowdown.
799--
587--
800−{-# INLINE_NORMAL unsafeCreateOf #-}
801−unsafeCreateOf :: forall m a. (MonadIO m, Unbox a)
802− => Int -> Fold m a (Array a)
803−unsafeCreateOf n = unsafeFreeze <$> MA.unsafeCreateOf n
804−
805−{-# DEPRECATED writeNUnsafe "Please use unsafeCreateOf instead." #-}
806−{-# INLINE writeNUnsafe #-}
588+{-# INLINE_NORMAL writeNUnsafe #-}
807writeNUnsafe :: forall m a. (MonadIO m, Unbox a)
589writeNUnsafe :: forall m a. (MonadIO m, Unbox a)
808 => Int -> Fold m a (Array a)
590 => Int -> Fold m a (Array a)
809−writeNUnsafe = unsafeCreateOf
591+writeNUnsafe n = unsafeFreeze <$> MA.writeNUnsafe n
810−
811−{-# INLINE_NORMAL unsafePinnedCreateOf #-}
812−unsafePinnedCreateOf :: forall m a. (MonadIO m, Unbox a)
813− => Int -> Fold m a (Array a)
814−unsafePinnedCreateOf n = unsafeFreeze <$> MA.unsafePinnedCreateOf n
815
592
816−{-# DEPRECATED pinnedWriteNUnsafe "Please use unsafePinnedCreateOf instead." #-}
817−{-# INLINE pinnedWriteNUnsafe #-}
593+{-# INLINE_NORMAL pinnedWriteNUnsafe #-}
818pinnedWriteNUnsafe :: forall m a. (MonadIO m, Unbox a)
594pinnedWriteNUnsafe :: forall m a. (MonadIO m, Unbox a)
819 => Int -> Fold m a (Array a)
595 => Int -> Fold m a (Array a)
820−pinnedWriteNUnsafe = unsafePinnedCreateOf
596+pinnedWriteNUnsafe n = unsafeFreeze <$> MA.pinnedWriteNUnsafe n
821−
822−{-# INLINE_NORMAL createWith #-}
823−createWith :: forall m a. (MonadIO m, Unbox a)
824− => Int -> Fold m a (Array a)
825−-- createWith n = FL.rmapM spliceArrays $ toArraysOf n
826−createWith elemCount = unsafeFreeze <$> MA.createWith elemCount
827
597
828−{-# DEPRECATED writeWith "Please use createWith instead." #-}
829−{-# INLINE writeWith #-}
598+{-# INLINE_NORMAL writeWith #-}
830writeWith :: forall m a. (MonadIO m, Unbox a)
599writeWith :: forall m a. (MonadIO m, Unbox a)
831 => Int -> Fold m a (Array a)
600 => Int -> Fold m a (Array a)
832−writeWith = createWith
601+-- writeWith n = FL.rmapM spliceArrays $ toArraysOf n
602+writeWith elemCount = unsafeFreeze <$> MA.writeWith elemCount
833
603
834-- | Fold the whole input to a single array.
604-- | Fold the whole input to a single array.
835--
605--
836-- /Caution! Do not use this on infinite streams./
606-- /Caution! Do not use this on infinite streams./
837--
607--
838−{-# INLINE create #-}
839−create :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
840−create = fmap unsafeFreeze MA.create
841−
842−-- XXX Deprecate in major
843−-- {-# DEPRECATED write "Please use create instead." #-}
844{-# INLINE write #-}
608{-# INLINE write #-}
845write :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
609write :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
846−write = create
610+write = fmap unsafeFreeze MA.write
847
611
848−-- | Like 'create' but creates a pinned array.
612+-- | Like 'write' but creates a pinned array.
849−{-# INLINE pinnedCreate #-}
850−pinnedCreate :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
851−pinnedCreate = fmap unsafeFreeze MA.pinnedCreate
852−
853−{-# DEPRECATED pinnedWrite "Please use pinnedCreate instead." #-}
854{-# INLINE pinnedWrite #-}
613{-# INLINE pinnedWrite #-}
855pinnedWrite :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
614pinnedWrite :: forall m a. (MonadIO m, Unbox a) => Fold m a (Array a)
856−pinnedWrite = pinnedCreate
615+pinnedWrite = fmap unsafeFreeze MA.pinnedWrite
857
616
858-- | Fold "step" has a dependency on "initial", and each step is dependent on
617-- | Fold "step" has a dependency on "initial", and each step is dependent on
859-- the previous invocation of step due to state passing, finally extract
618-- the previous invocation of step due to state passing, finally extract
@@ -901,19 +660,13 @@ fromPureStream x = unsafePerformIO $ fmap (unsafeFreeze) (MA.fromPureStream x)
901-- fromPureStream = runIdentity . D.fold (unsafeMakePure write)
660-- fromPureStream = runIdentity . D.fold (unsafeMakePure write)
902-- fromPureStream = fromList . runIdentity . D.toList
661-- fromPureStream = fromList . runIdentity . D.toList
903
662
904−-- XXX This should be monadic.
905−
906-- | Copy an immutable 'Ptr Word8' sequence into an array.
663-- | Copy an immutable 'Ptr Word8' sequence into an array.
907--
664--
908-- /Unsafe:/ The caller is responsible for safe addressing.
665-- /Unsafe:/ The caller is responsible for safe addressing.
909--
666--
910−-- Note that this should be evaluated strictly to ensure that we do not hold
911−-- the reference to the pointer in a lazy thunk.
912fromPtrN :: Int -> Ptr Word8 -> Array Word8
667fromPtrN :: Int -> Ptr Word8 -> Array Word8
913fromPtrN n addr = unsafePerformIO $ fmap unsafeFreeze (MA.fromPtrN n addr)
668fromPtrN n addr = unsafePerformIO $ fmap unsafeFreeze (MA.fromPtrN n addr)
914
669
915−-- XXX This should be monadic.
916−
917-- | Copy a null terminated immutable 'Addr#' Word8 sequence into an array.
670-- | Copy a null terminated immutable 'Addr#' Word8 sequence into an array.
918--
671--
919-- /Unsafe:/ The caller is responsible for safe addressing.
672-- /Unsafe:/ The caller is responsible for safe addressing.
@@ -924,46 +677,21 @@ fromPtrN n addr = unsafePerformIO $ fmap unsafeFreeze (MA.fromPtrN n addr)
924-- >>> Array.toList $ Array.fromByteStr# "\1\2\3\0"#
677-- >>> Array.toList $ Array.fromByteStr# "\1\2\3\0"#
925-- [1,2,3]
678-- [1,2,3]
926--
679--
927−-- Note that this should be evaluated strictly to ensure that we do not hold
928−-- the reference to the pointer in a lazy thunk.
929fromByteStr# :: Addr# -> Array Word8
680fromByteStr# :: Addr# -> Array Word8
930fromByteStr# addr = unsafePerformIO $ fmap unsafeFreeze (MA.fromByteStr# addr)
681fromByteStr# addr = unsafePerformIO $ fmap unsafeFreeze (MA.fromByteStr# addr)
931
682
932−-- XXX This should be monadic.
933−
934−-- | Note that this should be evaluated strictly to ensure that we do not hold
935−-- the reference to the pointer in a lazy thunk.
936fromByteStr :: Ptr Word8 -> Array Word8
683fromByteStr :: Ptr Word8 -> Array Word8
937fromByteStr (Ptr addr#) = fromByteStr# addr#
684fromByteStr (Ptr addr#) = fromByteStr# addr#
938
685
939−-- XXX implement fromChunks/fromChunkList instead?
686+-- XXX implement fromArrayStream/fromArrayList instead?
940
687
941-- | Convert an array stream to an array. Note that this requires peak memory
688-- | Convert an array stream to an array. Note that this requires peak memory
942-- that is double the size of the array stream.
689-- that is double the size of the array stream.
943--
690--
944−{-# INLINE fromChunksK #-}
945−fromChunksK :: (MonadIO m, Unbox a) => StreamK m (Array a) -> m (Array a)
946−fromChunksK stream =
947− -- We buffer the entire stream and then allocate the target array of the
948− -- same size, thus requiring double the memory.
949− fmap unsafeFreeze $ MA.fromChunksK $ fmap unsafeThaw stream
950−
951−{-# DEPRECATED fromArrayStreamK "Please use fromChunksK instead." #-}
691+{-# INLINE fromArrayStreamK #-}
952fromArrayStreamK :: (Unbox a, MonadIO m) => StreamK m (Array a) -> m (Array a)
692fromArrayStreamK :: (Unbox a, MonadIO m) => StreamK m (Array a) -> m (Array a)
953−fromArrayStreamK = fromChunksK
693+fromArrayStreamK stream =
954−
955−-- | Given a stream of arrays, splice them all together to generate a single
956−-- array. The stream must be /finite/.
957−--
958−{-# INLINE fromChunks #-}
959−fromChunks :: (MonadIO m, Unbox a) => Stream m (Array a) -> m (Array a)
960−fromChunks s =
961− -- XXX Check which implementation is better
962− -- This may also require double the memory as we double the space every
963− -- time, when copying the last array we may have reallocated almost double
964− -- the space required before we right size it.
965− fmap unsafeFreeze $ MA.fromChunksRealloced (fmap unsafeThaw s)
694+ fmap unsafeFreeze $ MA.fromArrayStreamK $ fmap unsafeThaw stream
966− -- fromChunkStreamK $ D.toStreamK s
967
695
968-------------------------------------------------------------------------------
696-------------------------------------------------------------------------------
969-- Instances
697-- Instances
@@ -1007,7 +735,6 @@ instance Unbox a => IsList (Array a) where
1007{-# INLINE byteCmp #-}
735{-# INLINE byteCmp #-}
1008byteCmp :: Array a -> Array a -> Ordering
736byteCmp :: Array a -> Array a -> Ordering
1009byteCmp arr1 arr2 =
737byteCmp arr1 arr2 =
1010− -- unsafePerformIO?
1011 unsafeInlineIO $! unsafeThaw arr1 `MA.byteCmp` unsafeThaw arr2
738 unsafeInlineIO $! unsafeThaw arr1 `MA.byteCmp` unsafeThaw arr2
1012
739
1013-- | Byte equality of two arrays.
740-- | Byte equality of two arrays.
@@ -1029,21 +756,20 @@ MK_EQ_INSTANCE(Char)
1029MK_EQ_INSTANCE(Word8)
756MK_EQ_INSTANCE(Word8)
1030MK_EQ_INSTANCE(Word16)
757MK_EQ_INSTANCE(Word16)
1031MK_EQ_INSTANCE(Word32)
758MK_EQ_INSTANCE(Word32)
1032−
1033−-- XXX The Word64 default instance should be as fast because we are comparing
1034−-- 64-bit at a time.
1035MK_EQ_INSTANCE(Word64)
759MK_EQ_INSTANCE(Word64)
1036MK_EQ_INSTANCE(Int)
760MK_EQ_INSTANCE(Int)
1037MK_EQ_INSTANCE(Int8)
761MK_EQ_INSTANCE(Int8)
1038MK_EQ_INSTANCE(Int16)
762MK_EQ_INSTANCE(Int16)
1039MK_EQ_INSTANCE(Int32)
763MK_EQ_INSTANCE(Int32)
1040−
1041−-- XXX The Int64 default instance should be as fast.
1042MK_EQ_INSTANCE(Int64)
764MK_EQ_INSTANCE(Int64)
1043
765
1044−-- | If the type allows a byte-by-byte comparison this instance can be
766+-- | If the type allows a byte-by-byte comparison (see 'byteCmp') this instance
1045−-- overlapped by a more specific instance that uses 'byteCmp'. Byte comparison
767+-- can be overlapped by a more specific instance that uses a byte comparison.
1046−-- can be significantly faster.
768+-- Byte comparison can be significantly faster.
769+--
770+-- For example:
771+--
772+-- >>> (==) = byteCmp
1047--
773--
1048instance {-# OVERLAPPABLE #-} (Unbox a, Eq a) => Eq (Array a) where
774instance {-# OVERLAPPABLE #-} (Unbox a, Eq a) => Eq (Array a) where
1049 {-# INLINE (==) #-}
775 {-# INLINE (==) #-}
@@ -1124,24 +850,16 @@ instance Foldable Array where
1124
850
1125-- | This should not be used for combining many or N arrays as it would copy
851-- | This should not be used for combining many or N arrays as it would copy
1126-- the two arrays everytime to a new array. For coalescing multiple arrays use
852-- the two arrays everytime to a new array. For coalescing multiple arrays use
1127−-- 'fromChunksK' instead.
853+-- 'fromArrayStreamK' instead.
1128instance Unbox a => Semigroup (Array a) where
854instance Unbox a => Semigroup (Array a) where
1129 arr1 <> arr2 = unsafePerformIO $ splice arr1 arr2
855 arr1 <> arr2 = unsafePerformIO $ splice arr1 arr2
1130
856
1131−empty ::
1132−#ifdef DEVBUILD
1133− Unbox a =>
1134−#endif
1135− Array a
1136−empty = Array Unboxed.empty 0 0
1137−
1138−{-# DEPRECATED nil "Please use empty instead." #-}
1139nil ::
857nil ::
1140#ifdef DEVBUILD
858#ifdef DEVBUILD
1141 Unbox a =>
859 Unbox a =>
1142#endif
860#endif
1143 Array a
861 Array a
1144−nil = empty
862+nil = Array Unboxed.nil 0 0
1145
863
1146instance Unbox a => Monoid (Array a) where
864instance Unbox a => Monoid (Array a) where
1147 mempty = nil
865 mempty = nil
core/src/Streamly/Internal/Data/Fold/Combinators.hs+92
@@ -30,6 +30,8 @@ module Streamly.Internal.Data.Fold.Combinators
30 -- *** Reducers
30 -- *** Reducers
31 , drainMapM
31 , drainMapM
32 , the
32 , the
33+ , length
34+ , lengthGeneric
33 , mean
35 , mean
34 , rollingHash
36 , rollingHash
35 , defaultSalt
37 , defaultSalt
@@ -164,6 +166,8 @@ module Streamly.Internal.Data.Fold.Combinators
164 -- ** Trimming
166 -- ** Trimming
165
167
166 -- By elements
168 -- By elements
169+ , takeEndBy
170+ , takeEndBy_
167 , takeEndBySeq
171 , takeEndBySeq
168 , takeEndBySeq_
172 , takeEndBySeq_
169 {-
173 {-
@@ -705,6 +709,30 @@ the = foldt' step initial id
705-- To Summary
709-- To Summary
706------------------------------------------------------------------------------
710------------------------------------------------------------------------------
707
711
712+-- | Like 'length', except with a more general 'Num' return value
713+--
714+-- Definition:
715+--
716+-- >>> lengthGeneric = fmap getSum $ Fold.foldMap (Sum . const 1)
717+-- >>> lengthGeneric = Fold.foldl' (\n _ -> n + 1) 0
718+--
719+-- /Pre-release/
720+{-# INLINE lengthGeneric #-}
721+lengthGeneric :: (Monad m, Num b) => Fold m a b
722+lengthGeneric = foldl' (\n _ -> n + 1) 0
723+
724+-- | Determine the length of the input stream.
725+--
726+-- Definition:
727+--
728+-- >>> length = Fold.lengthGeneric
729+-- >>> length = fmap getSum $ Fold.foldMap (Sum . const 1)
730+--
731+{-# INLINE length #-}
732+length :: Monad m => Fold m a Int
733+length = lengthGeneric
734+
735+
708-- | Determine the sum of all elements of a stream of numbers. Returns additive
736-- | Determine the sum of all elements of a stream of numbers. Returns additive
709-- identity (@0@) when the stream is empty. Note that this is not numerically
737-- identity (@0@) when the stream is empty. Note that this is not numerically
710-- stable for floating point numbers.
738-- stable for floating point numbers.
@@ -1482,6 +1510,70 @@ droppingWhileM p = Fold step initial extract extract
1482droppingWhile :: Monad m => (a -> Bool) -> Fold m a (Maybe a)
1510droppingWhile :: Monad m => (a -> Bool) -> Fold m a (Maybe a)
1483droppingWhile p = droppingWhileM (return . p)
1511droppingWhile p = droppingWhileM (return . p)
1484
1512
1513+-- Note: Keep this consistent with S.splitOn. In fact we should eliminate
1514+-- S.splitOn in favor of the fold.
1515+--
1516+-- XXX Use Fold.many instead once it is fixed.
1517+-- > Stream.splitOnSuffix p f = Stream.foldMany (Fold.takeEndBy_ p f)
1518+
1519+-- | Like 'takeEndBy' but drops the element on which the predicate succeeds.
1520+--
1521+-- Example:
1522+--
1523+-- >>> input = Stream.fromList "hello\nthere\n"
1524+-- >>> line = Fold.takeEndBy_ (== '\n') Fold.toList
1525+-- >>> Stream.fold line input
1526+-- "hello"
1527+--
1528+-- >>> Stream.fold Fold.toList $ Stream.foldMany line input
1529+-- ["hello","there"]
1530+--
1531+{-# INLINE takeEndBy_ #-}
1532+takeEndBy_ :: Monad m => (a -> Bool) -> Fold m a b -> Fold m a b
1533+-- takeEndBy_ predicate = scanMaybe (takingEndBy_ predicate)
1534+takeEndBy_ predicate (Fold fstep finitial fextract ffinal) =
1535+ Fold step finitial fextract ffinal
1536+
1537+ where
1538+
1539+ step s a =
1540+ if not (predicate a)
1541+ then fstep s a
1542+ else Done <$> ffinal s
1543+
1544+-- Note:
1545+-- > Stream.splitWithSuffix p f = Stream.foldMany (Fold.takeEndBy p f)
1546+
1547+-- | Take the input, stop when the predicate succeeds taking the succeeding
1548+-- element as well.
1549+--
1550+-- Example:
1551+--
1552+-- >>> input = Stream.fromList "hello\nthere\n"
1553+-- >>> line = Fold.takeEndBy (== '\n') Fold.toList
1554+-- >>> Stream.fold line input
1555+-- "hello\n"
1556+--
1557+-- >>> Stream.fold Fold.toList $ Stream.foldMany line input
1558+-- ["hello\n","there\n"]
1559+--
1560+{-# INLINE takeEndBy #-}
1561+takeEndBy :: Monad m => (a -> Bool) -> Fold m a b -> Fold m a b
1562+-- takeEndBy predicate = scanMaybe (takingEndBy predicate)
1563+takeEndBy predicate (Fold fstep finitial fextract ffinal) =
1564+ Fold step finitial fextract ffinal
1565+
1566+ where
1567+
1568+ step s a = do
1569+ res <- fstep s a
1570+ if not (predicate a)
1571+ then return res
1572+ else do
1573+ case res of
1574+ Partial s1 -> Done <$> ffinal s1
1575+ Done b -> return $ Done b
1576+
1485------------------------------------------------------------------------------
1577------------------------------------------------------------------------------
1486-- Binary splitting on a separator
1578-- Binary splitting on a separator
1487------------------------------------------------------------------------------
1579------------------------------------------------------------------------------
core/src/Streamly/Internal/Data/Fold/Type.hs−91
@@ -367,8 +367,6 @@ module Streamly.Internal.Data.Fold.Type
367 , toList
367 , toList
368 , toStreamK
368 , toStreamK
369 , toStreamKRev
369 , toStreamKRev
370− , lengthGeneric
371− , length
372
370
373 -- * Combinators
371 -- * Combinators
374
372
@@ -393,8 +391,6 @@ module Streamly.Internal.Data.Fold.Type
393 -- ** Trimming
391 -- ** Trimming
394 , take
392 , take
395 , taking
393 , taking
396− , takeEndBy_
397− , takeEndBy
398 , dropping
394 , dropping
399
395
400 -- ** Sequential application
396 -- ** Sequential application
@@ -771,29 +767,6 @@ toStreamKRev = foldl' (flip K.cons) K.nil
771toStreamK :: Monad m => Fold m a (K.StreamK n a)
767toStreamK :: Monad m => Fold m a (K.StreamK n a)
772toStreamK = foldr K.cons K.nil
768toStreamK = foldr K.cons K.nil
773
769
774−-- | Like 'length', except with a more general 'Num' return value
775−--
776−-- Definition:
777−--
778−-- >>> lengthGeneric = fmap getSum $ Fold.foldMap (Sum . const 1)
779−-- >>> lengthGeneric = Fold.foldl' (\n _ -> n + 1) 0
780−--
781−-- /Pre-release/
782−{-# INLINE lengthGeneric #-}
783−lengthGeneric :: (Monad m, Num b) => Fold m a b
784−lengthGeneric = foldl' (\n _ -> n + 1) 0
785−
786−-- | Determine the length of the input stream.
787−--
788−-- Definition:
789−--
790−-- >>> length = Fold.lengthGeneric
791−-- >>> length = fmap getSum $ Fold.foldMap (Sum . const 1)
792−--
793−{-# INLINE length #-}
794−length :: Monad m => Fold m a Int
795−length = lengthGeneric
796−
797------------------------------------------------------------------------------
770------------------------------------------------------------------------------
798-- Instances
771-- Instances
799------------------------------------------------------------------------------
772------------------------------------------------------------------------------
@@ -1544,70 +1517,6 @@ take n (Fold fstep finitial fextract ffinal) = Fold step initial extract final
1544
1517
1545 final (Tuple'Fused _ r) = ffinal r
1518 final (Tuple'Fused _ r) = ffinal r
1546
1519
1547−-- Note: Keep this consistent with S.splitOn. In fact we should eliminate
1548−-- S.splitOn in favor of the fold.
1549−--
1550−-- XXX Use Fold.many instead once it is fixed.
1551−-- > Stream.splitOnSuffix p f = Stream.foldMany (Fold.takeEndBy_ p f)
1552−
1553−-- | Like 'takeEndBy' but drops the element on which the predicate succeeds.
1554−--
1555−-- Example:
1556−--
1557−-- >>> input = Stream.fromList "hello\nthere\n"
1558−-- >>> line = Fold.takeEndBy_ (== '\n') Fold.toList
1559−-- >>> Stream.fold line input
1560−-- "hello"
1561−--
1562−-- >>> Stream.fold Fold.toList $ Stream.foldMany line input
1563−-- ["hello","there"]
1564−--
1565−{-# INLINE takeEndBy_ #-}
1566−takeEndBy_ :: Monad m => (a -> Bool) -> Fold m a b -> Fold m a b
1567−-- takeEndBy_ predicate = scanMaybe (takingEndBy_ predicate)
1568−takeEndBy_ predicate (Fold fstep finitial fextract ffinal) =
1569− Fold step finitial fextract ffinal
1570−
1571− where
1572−
1573− step s a =
1574− if not (predicate a)
1575− then fstep s a
1576− else Done <$> ffinal s
1577−
1578−-- Note:
1579−-- > Stream.splitWithSuffix p f = Stream.foldMany (Fold.takeEndBy p f)
1580−
1581−-- | Take the input, stop when the predicate succeeds taking the succeeding
1582−-- element as well.
1583−--
1584−-- Example:
1585−--
1586−-- >>> input = Stream.fromList "hello\nthere\n"
1587−-- >>> line = Fold.takeEndBy (== '\n') Fold.toList
1588−-- >>> Stream.fold line input
1589−-- "hello\n"
1590−--
1591−-- >>> Stream.fold Fold.toList $ Stream.foldMany line input
1592−-- ["hello\n","there\n"]
1593−--
1594−{-# INLINE takeEndBy #-}
1595−takeEndBy :: Monad m => (a -> Bool) -> Fold m a b -> Fold m a b
1596−-- takeEndBy predicate = scanMaybe (takingEndBy predicate)
1597−takeEndBy predicate (Fold fstep finitial fextract ffinal) =
1598− Fold step finitial fextract ffinal
1599−
1600− where
1601−
1602− step s a = do
1603− res <- fstep s a
1604− if not (predicate a)
1605− then return res
1606− else do
1607− case res of
1608− Partial s1 -> Done <$> ffinal s1
1609− Done b -> return $ Done b
1610−
1611------------------------------------------------------------------------------
1520------------------------------------------------------------------------------
1612-- Nesting
1521-- Nesting
1613------------------------------------------------------------------------------
1522------------------------------------------------------------------------------
core/src/Streamly/Internal/Data/IsMap.hs−4
@@ -1,7 +1,3 @@
1−{-# LANGUAGE TypeFamilies #-}
2−-- Must come after TypeFamilies, otherwise it is re-enabled.
3−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
4−{-# LANGUAGE NoMonoLocalBinds #-}
5-- |
1-- |
6-- Module : Streamly.Internal.Data.IsMap
2-- Module : Streamly.Internal.Data.IsMap
7-- Copyright : (c) 2022 Composewell Technologies
3-- Copyright : (c) 2022 Composewell Technologies
core/src/Streamly/Internal/Data/MutArray.hs+35−151
@@ -11,197 +11,81 @@ module Streamly.Internal.Data.MutArray
11 -- * MutArray.Type module
11 -- * MutArray.Type module
12 module Streamly.Internal.Data.MutArray.Type
12 module Streamly.Internal.Data.MutArray.Type
13 -- * MutArray module
13 -- * MutArray module
14− , sliceIndexerFromLen
14+ , splitOn
15− , slicerFromLen
16− , compactLE
17− , pinnedCompactLE
18− , compactOnByte
19− , compactOnByteSuffix
20− -- * Unboxed IORef
21− , module Streamly.Internal.Data.IORef.Unboxed
22−
23− -- * Deprecated
24 , genSlicesFromLen
15 , genSlicesFromLen
25 , getSlicesFromLen
16 , getSlicesFromLen
17+ , fromStream
18+ -- * Unboxed IORef
19+ , module Streamly.Internal.Data.IORef.Unboxed
26 )
20 )
27where
21where
28
22
29#include "inline.hs"
23#include "inline.hs"
30
24
31import Control.Monad.IO.Class (MonadIO(..))
25import Control.Monad.IO.Class (MonadIO(..))
32−import Data.Word (Word8)
33−import Streamly.Internal.Data.MutByteArray.Type (PinnedState(..))
34−import Streamly.Internal.Data.Stream.Type (Stream)
35import Streamly.Internal.Data.Unbox (Unbox)
26import Streamly.Internal.Data.Unbox (Unbox)
27+import Streamly.Internal.Data.Stream (Stream)
36import Streamly.Internal.Data.Unfold.Type (Unfold(..))
28import Streamly.Internal.Data.Unfold.Type (Unfold(..))
37
29
38−import qualified Streamly.Internal.Data.Stream.Type as Stream
30+import qualified Streamly.Internal.Data.Stream as D
39−import qualified Streamly.Internal.Data.Stream.Nesting as Stream
40−-- import qualified Streamly.Internal.Data.Stream.Transform as Stream
41import qualified Streamly.Internal.Data.Unfold as Unfold
31import qualified Streamly.Internal.Data.Unfold as Unfold
42
32
43import Prelude hiding (foldr, length, read, splitAt)
33import Prelude hiding (foldr, length, read, splitAt)
44import Streamly.Internal.Data.MutArray.Type
34import Streamly.Internal.Data.MutArray.Type
45import Streamly.Internal.Data.IORef.Unboxed
35import Streamly.Internal.Data.IORef.Unboxed
46
36
37+-- | Split the array into a stream of slices using a predicate. The element
38+-- matching the predicate is dropped.
39+--
40+-- /Pre-release/
41+{-# INLINE splitOn #-}
42+splitOn :: (MonadIO m, Unbox a) =>
43+ (a -> Bool) -> MutArray a -> Stream m (MutArray a)
44+splitOn predicate arr =
45+ fmap (\(i, len) -> getSliceUnsafe i len arr)
46+ $ D.sliceOnSuffix predicate (read arr)
47+
47-- | Generate a stream of array slice descriptors ((index, len)) of specified
48-- | Generate a stream of array slice descriptors ((index, len)) of specified
48-- length from an array, starting from the supplied array index. The last slice
49-- length from an array, starting from the supplied array index. The last slice
49-- may be shorter than the requested length depending on the array length.
50-- may be shorter than the requested length depending on the array length.
50--
51--
51-- /Pre-release/
52-- /Pre-release/
52−{-# INLINE sliceIndexerFromLen #-}
53+{-# INLINE genSlicesFromLen #-}
53−sliceIndexerFromLen :: forall m a. (Monad m, Unbox a)
54+genSlicesFromLen :: forall m a. (Monad m, Unbox a)
54 => Int -- ^ from index
55 => Int -- ^ from index
55 -> Int -- ^ length of the slice
56 -> Int -- ^ length of the slice
56 -> Unfold m (MutArray a) (Int, Int)
57 -> Unfold m (MutArray a) (Int, Int)
57−sliceIndexerFromLen from len =
58+genSlicesFromLen from len =
58 let fromThenTo n = (from, from + len, n - 1)
59 let fromThenTo n = (from, from + len, n - 1)
59 mkSlice n i = return (i, min len (n - i))
60 mkSlice n i = return (i, min len (n - i))
60 in Unfold.lmap length
61 in Unfold.lmap length
61 $ Unfold.mapM2 mkSlice
62 $ Unfold.mapM2 mkSlice
62 $ Unfold.lmap fromThenTo Unfold.enumerateFromThenTo
63 $ Unfold.lmap fromThenTo Unfold.enumerateFromThenTo
63
64
64−{-# DEPRECATED genSlicesFromLen "Please use sliceIndexerFromLen instead." #-}
65−genSlicesFromLen :: forall m a. (Monad m, Unbox a)
66− => Int -- ^ from index
67− -> Int -- ^ length of the slice
68− -> Unfold m (MutArray a) (Int, Int)
69−genSlicesFromLen = sliceIndexerFromLen
70−
71-- | Generate a stream of slices of specified length from an array, starting
65-- | Generate a stream of slices of specified length from an array, starting
72-- from the supplied array index. The last slice may be shorter than the
66-- from the supplied array index. The last slice may be shorter than the
73-- requested length depending on the array length.
67-- requested length depending on the array length.
74--
68--
75-- /Pre-release/
69-- /Pre-release/
76−{-# INLINE slicerFromLen #-}
77−slicerFromLen :: forall m a. (Monad m, Unbox a)
78− => Int -- ^ from index
79− -> Int -- ^ length of the slice
80− -> Unfold m (MutArray a) (MutArray a)
81−slicerFromLen from len =
82− let mkSlice arr (i, n) = return $ getSliceUnsafe i n arr
83− in Unfold.mapM2 mkSlice (sliceIndexerFromLen from len)
84−
85−{-# DEPRECATED getSlicesFromLen "Please use slicerFromLen instead." #-}
70+{-# INLINE getSlicesFromLen #-}
86getSlicesFromLen :: forall m a. (Monad m, Unbox a)
71getSlicesFromLen :: forall m a. (Monad m, Unbox a)
87 => Int -- ^ from index
72 => Int -- ^ from index
88 -> Int -- ^ length of the slice
73 -> Int -- ^ length of the slice
89 -> Unfold m (MutArray a) (MutArray a)
74 -> Unfold m (MutArray a) (MutArray a)
90−getSlicesFromLen = slicerFromLen
75+getSlicesFromLen from len =
91−
76+ let mkSlice arr (i, n) = return $ getSliceUnsafe i n arr
92−-------------------------------------------------------------------------------
77+ in Unfold.mapM2 mkSlice (genSlicesFromLen from len)
93−-- Compacting Streams of Arrays
94−-------------------------------------------------------------------------------
95
78
96−-- | @compactLE maxElems@ coalesces adjacent arrays in the input stream
79+-- | Create an 'Array' from a stream. This is useful when we want to create a
97−-- only if the combined size would be less than or equal to @maxElems@
80+-- single array from a stream of unknown size. 'writeN' is at least twice
98−-- elements. Note that it won't split an array if the original array is already
81+-- as efficient when the size is already known.
99−-- larger than maxElems.
100--
82--
101−-- @maxElems@ must be greater than 0.
83+-- Note that if the input stream is too large memory allocation for the array
84+-- may fail. When the stream size is not known, `chunksOf` followed by
85+-- processing of indvidual arrays in the resulting stream should be preferred.
102--
86--
103−-- Generates unpinned arrays irrespective of the pinning status of input
87+-- /Pre-release/
104−-- arrays.
88+{-# INLINE fromStream #-}
105−{-# INLINE compactLE #-}
106−compactLE :: (MonadIO m, Unbox a) =>
107− Int -> Stream m (MutArray a) -> Stream m (MutArray a)
89+fromStream :: (MonadIO m, Unbox a) => Stream m a -> m (MutArray a)
108−-- XXX compactLE can be moved to MutArray/Type if we are not using the parser
90+fromStream = fromStreamD
109−-- to implement it.
91+-- fromStream (Stream m) = P.fold write m
110−compactLE = compactLeAs Unpinned
111−-- The parser version turns out to be a little bit slower.
112−-- compactLE n = Stream.catRights . Stream.parseManyD (pCompactLE n)
113−
114−-- | Pinned version of 'compactLE'.
115−{-# INLINE pinnedCompactLE #-}
116−pinnedCompactLE :: forall m a. (MonadIO m, Unbox a)
117− => Int -> Stream m (MutArray a) -> Stream m (MutArray a)
118−pinnedCompactLE = compactLeAs Pinned
119−-- pinnedCompactLE n = Stream.catRights . Stream.parseManyD (pPinnedCompactLE n)
120−
121−data SplitState s arr
122− = Initial s
123− | Buffering s arr
124− | Splitting s arr
125− | Yielding arr (SplitState s arr)
126− | Finishing
127−
128−-- | Split a stream of arrays on a given separator byte, dropping the separator
129−-- and coalescing all the arrays between two separators into a single array.
130−--
131−{-# INLINE_NORMAL _compactOnByteCustom #-}
132−_compactOnByteCustom
133− :: MonadIO m
134− => Word8
135− -> Stream m (MutArray Word8)
136− -> Stream m (MutArray Word8)
137−_compactOnByteCustom byte (Stream.Stream step state) =
138− Stream.Stream step' (Initial state)
139−
140− where
141−
142− {-# INLINE_LATE step' #-}
143− step' gst (Initial st) = do
144− r <- step gst st
145− case r of
146− Stream.Yield arr s -> do
147− (arr1, marr2) <- breakOn byte arr
148− return $ case marr2 of
149− Nothing -> Stream.Skip (Buffering s arr1)
150− Just arr2 -> Stream.Skip (Yielding arr1 (Splitting s arr2))
151− Stream.Skip s -> return $ Stream.Skip (Initial s)
152− Stream.Stop -> return Stream.Stop
153−
154− step' gst (Buffering st buf) = do
155− r <- step gst st
156− case r of
157− Stream.Yield arr s -> do
158− (arr1, marr2) <- breakOn byte arr
159− -- XXX Use spliceExp instead and then rightSize?
160− buf1 <- splice buf arr1
161− return $ case marr2 of
162− Nothing -> Stream.Skip (Buffering s buf1)
163− Just x -> Stream.Skip (Yielding buf1 (Splitting s x))
164− Stream.Skip s -> return $ Stream.Skip (Buffering s buf)
165− Stream.Stop -> return $
166− if byteLength buf == 0
167− then Stream.Stop
168− else Stream.Skip (Yielding buf Finishing)
169−
170− step' _ (Splitting st buf) = do
171− (arr1, marr2) <- breakOn byte buf
172− return $ case marr2 of
173− Nothing -> Stream.Skip $ Buffering st arr1
174− Just arr2 -> Stream.Skip $ Yielding arr1 (Splitting st arr2)
175−
176− step' _ (Yielding arr next) = return $ Stream.Yield arr next
177− step' _ Finishing = return Stream.Stop
178−
179−-- XXX implement predicate based version of this
180−-- XXX Naming of predicate based vs custom version
181−
182−-- | Split a stream of arrays on a given separator byte, dropping the separator
183−-- and coalescing all the arrays between two separators into a single array.
184−--
185−{-# INLINE compactOnByte #-}
186−compactOnByte
187− :: (MonadIO m)
188− => Word8
189− -> Stream m (MutArray Word8)
190− -> Stream m (MutArray Word8)
191−-- XXX compare perf of custom vs idiomatic version
192−-- compactOnByte = _compactOnByteCustom
193−-- XXX use spliceExp and rightSize?
194−compactOnByte byte = Stream.splitInnerBy (breakOn byte) splice
195−
196−-- | Like 'compactOnByte' considers the separator in suffix position instead of
197−-- infix position.
198−{-# INLINE compactOnByteSuffix #-}
199−compactOnByteSuffix
200− :: (MonadIO m)
201− => Word8
202− -> Stream m (MutArray Word8)
203− -> Stream m (MutArray Word8)
204−compactOnByteSuffix byte =
205− -- XXX use spliceExp and rightSize?
206− Stream.splitInnerBySuffix
207− (\arr -> byteLength arr == 0) (breakOn byte) splice
core/src/Streamly/Internal/Data/MutArray/Generic.hs+30−65
@@ -19,14 +19,14 @@ module Streamly.Internal.Data.MutArray.Generic
19 , nil
19 , nil
20
20
21 -- *** Uninitialized Arrays
21 -- *** Uninitialized Arrays
22− , emptyOf
22+ , new
23 -- , newArrayWith
23 -- , newArrayWith
24
24
25 -- *** From streams
25 -- *** From streams
26− , unsafeCreateOf
26+ , writeNUnsafe
27− , createOf
27+ , writeN
28− , createWith -- createOfMin/createMin/createGE?
28+ , writeWith
29− , create
29+ , write
30 , fromStreamN
30 , fromStreamN
31 , fromStream
31 , fromStream
32 , fromPureStream
32 , fromPureStream
@@ -160,13 +160,6 @@ module Streamly.Internal.Data.MutArray.Generic
160 -- , appendSliceFrom
160 -- , appendSliceFrom
161
161
162 , clone
162 , clone
163−
164− -- * Deprecated
165− , new
166− , writeNUnsafe
167− , writeN
168− , writeWith
169− , write
170 )
163 )
171where
164where
172
165
@@ -243,13 +236,13 @@ bottomElement =
243-- XXX Would be nice if GHC can provide something like newUninitializedArray# so
236-- XXX Would be nice if GHC can provide something like newUninitializedArray# so
244-- that we do not have to write undefined or error in the whole array.
237-- that we do not have to write undefined or error in the whole array.
245
238
246−-- | @emptyOf count@ allocates a zero length array that can be extended to hold
239+-- | @new count@ allocates a zero length array that can be extended to hold
247-- up to 'count' items without reallocating.
240-- up to 'count' items without reallocating.
248--
241--
249-- /Pre-release/
242-- /Pre-release/
250−{-# INLINE emptyOf #-}
243+{-# INLINE new #-}
251−emptyOf :: MonadIO m => Int -> m (MutArray a)
244+new :: MonadIO m => Int -> m (MutArray a)
252−emptyOf n@(I# n#) =
245+new n@(I# n#) =
253 liftIO
246 liftIO
254 $ IO
247 $ IO
255 $ \s# ->
248 $ \s# ->
@@ -258,12 +251,6 @@ emptyOf n@(I# n#) =
258 let ma = MutArray arr# 0 0 n
251 let ma = MutArray arr# 0 0 n
259 in (# s1#, ma #)
252 in (# s1#, ma #)
260
253
261−-- XXX Deprecate in major
262−-- {-# DEPRECATED new "Please use emptyOf instead." #-}
263−{-# INLINE new #-}
264−new :: MonadIO m => Int -> m (MutArray a)
265−new = emptyOf
266−
267-- XXX This could be pure?
254-- XXX This could be pure?
268
255
269-- |
256-- |
@@ -331,7 +318,7 @@ putIndices arr = FL.foldlM' step (return ())
331
318
332 where
319 where
333
320
334− step () (i, x) = putIndex i arr x
321+ step () (i, x) = liftIO (putIndex i arr x)
335
322
336-- | Modify a given index of an array using a modifier function without checking
323-- | Modify a given index of an array using a modifier function without checking
337-- the bounds.
324-- the bounds.
@@ -602,16 +589,16 @@ readRev arr@MutArray{..} =
602arrayChunkSize :: Int
589arrayChunkSize :: Int
603arrayChunkSize = 1024
590arrayChunkSize = 1024
604
591
605−-- | Like 'createOf' but does not check the array bounds when writing. The fold
592+-- | Like 'writeN' but does not check the array bounds when writing. The fold
606-- driver must not call the step function more than 'n' times otherwise it will
593-- driver must not call the step function more than 'n' times otherwise it will
607-- corrupt the memory and crash. This function exists mainly because any
594-- corrupt the memory and crash. This function exists mainly because any
608-- conditional in the step function blocks fusion causing 10x performance
595-- conditional in the step function blocks fusion causing 10x performance
609-- slowdown.
596-- slowdown.
610--
597--
611-- /Pre-release/
598-- /Pre-release/
612−{-# INLINE_NORMAL unsafeCreateOf #-}
599+{-# INLINE_NORMAL writeNUnsafe #-}
613−unsafeCreateOf :: MonadIO m => Int -> Fold m a (MutArray a)
600+writeNUnsafe :: MonadIO m => Int -> Fold m a (MutArray a)
614−unsafeCreateOf n = Fold step initial return return
601+writeNUnsafe n = Fold step initial return return
615
602
616 where
603 where
617
604
@@ -619,81 +606,59 @@ unsafeCreateOf n = Fold step initial return return
619
606
620 step arr x = FL.Partial <$> snocUnsafe arr x
607 step arr x = FL.Partial <$> snocUnsafe arr x
621
608
622−{-# DEPRECATED writeNUnsafe "Please use unsafeCreateOf instead." #-}
623−{-# INLINE writeNUnsafe #-}
624−writeNUnsafe :: MonadIO m => Int -> Fold m a (MutArray a)
625−writeNUnsafe = unsafeCreateOf
626−
627−-- | @createOf n@ folds a maximum of @n@ elements from the input stream to an
609+-- | @writeN n@ folds a maximum of @n@ elements from the input stream to an
628-- 'Array'.
610-- 'Array'.
629--
611--
630−-- >>> createOf n = Fold.take n (MutArray.unsafeCreateOf n)
612+-- >>> writeN n = Fold.take n (MutArray.writeNUnsafe n)
631--
613--
632-- /Pre-release/
614-- /Pre-release/
633−{-# INLINE_NORMAL createOf #-}
615+{-# INLINE_NORMAL writeN #-}
634−createOf :: MonadIO m => Int -> Fold m a (MutArray a)
635−createOf n = FL.take n $ unsafeCreateOf n
636−
637−-- XXX Deprecate in major
638−-- {-# DEPRECATED writeN "Please use createOf instead." #-}
639−{-# INLINE writeN #-}
640writeN :: MonadIO m => Int -> Fold m a (MutArray a)
616writeN :: MonadIO m => Int -> Fold m a (MutArray a)
641−writeN = createOf
617+writeN n = FL.take n $ writeNUnsafe n
642
618
643-- >>> f n = MutArray.writeAppendWith (* 2) (MutArray.pinnedNew n)
619-- >>> f n = MutArray.writeAppendWith (* 2) (MutArray.pinnedNew n)
644-- >>> writeWith n = Fold.rmapM MutArray.rightSize (f n)
620-- >>> writeWith n = Fold.rmapM MutArray.rightSize (f n)
645-- >>> writeWith n = Fold.rmapM MutArray.fromArrayStreamK (MutArray.writeChunks n)
621-- >>> writeWith n = Fold.rmapM MutArray.fromArrayStreamK (MutArray.writeChunks n)
646
622
647−-- | @createWith minCount@ folds the whole input to a single array. The array
623+-- | @writeWith minCount@ folds the whole input to a single array. The array
648-- starts at a size big enough to hold minCount elements, the size is doubled
624-- starts at a size big enough to hold minCount elements, the size is doubled
649-- every time the array needs to be grown.
625-- every time the array needs to be grown.
650--
626--
651-- /Caution! Do not use this on infinite streams./
627-- /Caution! Do not use this on infinite streams./
652--
628--
653-- /Pre-release/
629-- /Pre-release/
654−{-# INLINE_NORMAL createWith #-}
630+{-# INLINE_NORMAL writeWith #-}
655−createWith :: MonadIO m => Int -> Fold m a (MutArray a)
631+writeWith :: MonadIO m => Int -> Fold m a (MutArray a)
656-- writeWith n = FL.rmapM rightSize $ writeAppendWith (* 2) (pinnedNew n)
632-- writeWith n = FL.rmapM rightSize $ writeAppendWith (* 2) (pinnedNew n)
657−createWith elemCount = FL.rmapM extract $ FL.foldlM' step initial
633+writeWith elemCount = FL.rmapM extract $ FL.foldlM' step initial
658
634
659 where
635 where
660
636
661 initial = do
637 initial = do
662− when (elemCount < 0) $ error "createWith: elemCount is negative"
638+ when (elemCount < 0) $ error "writeWith: elemCount is negative"
663− new elemCount
639+ liftIO $ new elemCount
664
640
665 step arr@(MutArray _ start end bound) x
641 step arr@(MutArray _ start end bound) x
666 | end == bound = do
642 | end == bound = do
667 let oldSize = end - start
643 let oldSize = end - start
668 newSize = max (oldSize * 2) 1
644 newSize = max (oldSize * 2) 1
669− arr1 <- realloc newSize arr
645+ arr1 <- liftIO $ realloc newSize arr
670 snocUnsafe arr1 x
646 snocUnsafe arr1 x
671 step arr x = snocUnsafe arr x
647 step arr x = snocUnsafe arr x
672
648
673− -- extract = rightSize
649+ -- extract = liftIO . rightSize
674 extract = return
650 extract = return
675
651
676−{-# DEPRECATED writeWith "Please use createWith instead." #-}
677−{-# INLINE writeWith #-}
678−writeWith :: MonadIO m => Int -> Fold m a (MutArray a)
679−writeWith = createWith
680−
681-- | Fold the whole input to a single array.
652-- | Fold the whole input to a single array.
682--
653--
683−-- Same as 'createWith' using an initial array size of 'arrayChunkSize' bytes
654+-- Same as 'writeWith' using an initial array size of 'arrayChunkSize' bytes
684-- rounded up to the element size.
655-- rounded up to the element size.
685--
656--
686-- /Caution! Do not use this on infinite streams./
657-- /Caution! Do not use this on infinite streams./
687--
658--
688−{-# INLINE create #-}
689−create :: MonadIO m => Fold m a (MutArray a)
690−create = writeWith arrayChunkSize
691−
692−-- XXX Deprecate in major
693−-- {-# DEPRECATED write "Please use create instead." #-}
694{-# INLINE write #-}
659{-# INLINE write #-}
695write :: MonadIO m => Fold m a (MutArray a)
660write :: MonadIO m => Fold m a (MutArray a)
696−write = create
661+write = writeWith arrayChunkSize
697
662
698-- | Create a 'MutArray' from the first @n@ elements of a stream. The
663-- | Create a 'MutArray' from the first @n@ elements of a stream. The
699-- array is allocated to size @n@, if the stream terminates before @n@
664-- array is allocated to size @n@, if the stream terminates before @n@
@@ -718,7 +683,7 @@ fromList xs = fromStream $ D.fromList xs
718{-# INLINABLE fromPureStream #-}
683{-# INLINABLE fromPureStream #-}
719fromPureStream :: MonadIO m => Stream Identity a -> m (MutArray a)
684fromPureStream :: MonadIO m => Stream Identity a -> m (MutArray a)
720fromPureStream xs =
685fromPureStream xs =
721− D.fold write $ D.morphInner (return . runIdentity) xs
686+ liftIO $ D.fold write $ D.morphInner (return . runIdentity) xs
722
687
723-------------------------------------------------------------------------------
688-------------------------------------------------------------------------------
724-- Chunking
689-- Chunking
@@ -850,7 +815,7 @@ putSliceUnsafe src srcStart dst dstStart len = liftIO $ do
850
815
851{-# INLINE clone #-}
816{-# INLINE clone #-}
852clone :: MonadIO m => MutArray a -> m (MutArray a)
817clone :: MonadIO m => MutArray a -> m (MutArray a)
853−clone src = do
818+clone src = liftIO $ do
854 let len = arrLen src
819 let len = arrLen src
855 dst <- new len
820 dst <- new len
856 putSliceUnsafe src 0 dst 0 len
821 putSliceUnsafe src 0 dst 0 len
core/src/Streamly/Internal/Data/MutArray/Stream.hs+195−11
@@ -12,7 +12,6 @@
12-- keep this as a separate module and release it.
12-- keep this as a separate module and release it.
13--
13--
14module Streamly.Internal.Data.MutArray.Stream
14module Streamly.Internal.Data.MutArray.Stream
15−{-# DEPRECATED "Please use \"Streamly.Internal.Data.MutArray\" instead." #-}
16 (
15 (
17 -- * Generation
16 -- * Generation
18 MArray.chunksOf
17 MArray.chunksOf
@@ -22,7 +21,7 @@ module Streamly.Internal.Data.MutArray.Stream
22
21
23 -- * Compaction
22 -- * Compaction
24 , packArraysChunksOf
23 , packArraysChunksOf
25− , MArray.SpliceState (..)
24+ , SpliceState (..)
26 , lpackArraysChunksOf
25 , lpackArraysChunksOf
27 , compact -- chunksCompact
26 , compact -- chunksCompact
28 , compactLE
27 , compactLE
@@ -36,12 +35,19 @@ module Streamly.Internal.Data.MutArray.Stream
36 )
35 )
37where
36where
38
37
38+#include "inline.hs"
39+#include "ArrayMacros.h"
40+
39import Control.Monad.IO.Class (MonadIO(..))
41import Control.Monad.IO.Class (MonadIO(..))
42+import Control.Monad (when)
43+import Data.Bifunctor (first)
44+import Data.Proxy (Proxy(..))
40−import Streamly.Internal.Data.Unbox (Unbox)
45+import Streamly.Internal.Data.Unbox (Unbox, sizeOf)
41import Streamly.Internal.Data.MutArray.Type (MutArray(..))
46import Streamly.Internal.Data.MutArray.Type (MutArray(..))
42import Streamly.Internal.Data.Fold.Type (Fold(..))
47import Streamly.Internal.Data.Fold.Type (Fold(..))
43import Streamly.Internal.Data.Parser (ParseError)
48import Streamly.Internal.Data.Parser (ParseError)
44import Streamly.Internal.Data.Stream.Type (Stream)
49import Streamly.Internal.Data.Stream.Type (Stream)
50+import Streamly.Internal.Data.Tuple.Strict (Tuple'(..))
45
51
46import qualified Streamly.Internal.Data.MutArray as MArray
52import qualified Streamly.Internal.Data.MutArray as MArray
47import qualified Streamly.Internal.Data.Fold.Type as FL
53import qualified Streamly.Internal.Data.Fold.Type as FL
@@ -52,6 +58,12 @@ import qualified Streamly.Internal.Data.Stream as D
52-- Compact
58-- Compact
53-------------------------------------------------------------------------------
59-------------------------------------------------------------------------------
54
60
61+data SpliceState s arr
62+ = SpliceInitial s
63+ | SpliceBuffering s arr
64+ | SpliceYielding arr (SpliceState s arr)
65+ | SpliceFinish
66+
55-- XXX This can be removed once compactLEFold/compactLE are implemented.
67-- XXX This can be removed once compactLEFold/compactLE are implemented.
56--
68--
57-- | This mutates the first array (if it has space) to append values from the
69-- | This mutates the first array (if it has space) to append values from the
@@ -66,18 +78,117 @@ import qualified Streamly.Internal.Data.Stream as D
66-- actual array size may be less than the specified chunk size.
78-- actual array size may be less than the specified chunk size.
67--
79--
68-- @since 0.7.0
80-- @since 0.7.0
69−{-# INLINE packArraysChunksOf #-}
81+{-# INLINE_NORMAL packArraysChunksOf #-}
70packArraysChunksOf :: (MonadIO m, Unbox a)
82packArraysChunksOf :: (MonadIO m, Unbox a)
71 => Int -> D.Stream m (MutArray a) -> D.Stream m (MutArray a)
83 => Int -> D.Stream m (MutArray a) -> D.Stream m (MutArray a)
72−packArraysChunksOf = MArray.compactLE
84+packArraysChunksOf n (D.Stream step state) =
85+ D.Stream step' (SpliceInitial state)
86+
87+ where
88+
89+ {-# INLINE_LATE step' #-}
90+ step' gst (SpliceInitial st) = do
91+ when (n <= 0) $
92+ -- XXX we can pass the module string from the higher level API
93+ error $ "Streamly.Internal.Data.MutArray.Type.packArraysChunksOf: the size of "
94+ ++ "arrays [" ++ show n ++ "] must be a natural number"
95+ r <- step gst st
96+ case r of
97+ D.Yield arr s -> return $
98+ let len = MArray.byteLength arr
99+ in if len >= n
100+ then D.Skip (SpliceYielding arr (SpliceInitial s))
101+ else D.Skip (SpliceBuffering s arr)
102+ D.Skip s -> return $ D.Skip (SpliceInitial s)
103+ D.Stop -> return D.Stop
104+
105+ step' gst (SpliceBuffering st buf) = do
106+ r <- step gst st
107+ case r of
108+ D.Yield arr s -> do
109+ let len = MArray.byteLength buf + MArray.byteLength arr
110+ if len > n
111+ then return $
112+ D.Skip (SpliceYielding buf (SpliceBuffering s arr))
113+ else do
114+ buf' <- if MArray.byteCapacity buf < n
115+ then liftIO $ MArray.realloc n buf
116+ else return buf
117+ buf'' <- MArray.spliceUnsafe buf' arr
118+ return $ D.Skip (SpliceBuffering s buf'')
119+ D.Skip s -> return $ D.Skip (SpliceBuffering s buf)
120+ D.Stop -> return $ D.Skip (SpliceYielding buf SpliceFinish)
121+
122+ step' _ SpliceFinish = return D.Stop
123+
124+ step' _ (SpliceYielding arr next) = return $ D.Yield arr next
73
125
74-- XXX Remove this once compactLEFold is implemented
126-- XXX Remove this once compactLEFold is implemented
75-- lpackArraysChunksOf = Fold.many compactLEFold
127-- lpackArraysChunksOf = Fold.many compactLEFold
76--
128--
77−{-# INLINE lpackArraysChunksOf #-}
129+{-# INLINE_NORMAL lpackArraysChunksOf #-}
78lpackArraysChunksOf :: (MonadIO m, Unbox a)
130lpackArraysChunksOf :: (MonadIO m, Unbox a)
79 => Int -> Fold m (MutArray a) () -> Fold m (MutArray a) ()
131 => Int -> Fold m (MutArray a) () -> Fold m (MutArray a) ()
80−lpackArraysChunksOf = MArray.lCompactGE
132+lpackArraysChunksOf n (Fold step1 initial1 _ final1) =
133+ Fold step initial extract final
134+
135+ where
136+
137+ initial = do
138+ when (n <= 0) $
139+ -- XXX we can pass the module string from the higher level API
140+ error $ "Streamly.Internal.Data.MutArray.Type.packArraysChunksOf: the size of "
141+ ++ "arrays [" ++ show n ++ "] must be a natural number"
142+
143+ r <- initial1
144+ return $ first (Tuple' Nothing) r
145+
146+ step (Tuple' Nothing r1) arr =
147+ let len = MArray.byteLength arr
148+ in if len >= n
149+ then do
150+ r <- step1 r1 arr
151+ case r of
152+ FL.Done _ -> return $ FL.Done ()
153+ FL.Partial s -> do
154+ _ <- final1 s
155+ res <- initial1
156+ return $ first (Tuple' Nothing) res
157+ else return $ FL.Partial $ Tuple' (Just arr) r1
158+
159+ step (Tuple' (Just buf) r1) arr = do
160+ let len = MArray.byteLength buf + MArray.byteLength arr
161+ buf' <- if MArray.byteCapacity buf < len
162+ then liftIO $ MArray.realloc (max n len) buf
163+ else return buf
164+ buf'' <- MArray.spliceUnsafe buf' arr
165+
166+ -- XXX this is common in both the equations of step
167+ if len >= n
168+ then do
169+ r <- step1 r1 buf''
170+ case r of
171+ FL.Done _ -> return $ FL.Done ()
172+ FL.Partial s -> do
173+ _ <- final1 s
174+ res <- initial1
175+ return $ first (Tuple' Nothing) res
176+ else return $ FL.Partial $ Tuple' (Just buf'') r1
177+
178+ -- XXX Several folds do extract >=> final, therefore, we need to make final
179+ -- return "m b" rather than using extract post it if we want extract to be
180+ -- partial.
181+ --
182+ -- extract forces the pending buffer to be sent to the fold which is not
183+ -- what we want.
184+ extract _ = error "lpackArraysChunksOf: not designed for scanning"
185+
186+ final (Tuple' Nothing r1) = final1 r1
187+ final (Tuple' (Just buf) r1) = do
188+ r <- step1 r1 buf
189+ case r of
190+ FL.Partial rr -> final1 rr
191+ FL.Done _ -> return ()
81
192
82-- XXX Same as compactLE, to be removed once that is implemented.
193-- XXX Same as compactLE, to be removed once that is implemented.
83--
194--
@@ -97,11 +208,48 @@ compact = packArraysChunksOf
97-- actual array size may be less than the specified chunk size.
208-- actual array size may be less than the specified chunk size.
98--
209--
99-- /Internal/
210-- /Internal/
100−{-# INLINE compactLEParserD #-}
211+{-# INLINE_NORMAL compactLEParserD #-}
101compactLEParserD ::
212compactLEParserD ::
102 forall m a. (MonadIO m, Unbox a)
213 forall m a. (MonadIO m, Unbox a)
103 => Int -> ParserD.Parser (MutArray a) m (MutArray a)
214 => Int -> ParserD.Parser (MutArray a) m (MutArray a)
104−compactLEParserD = MArray.pCompactLE
215+compactLEParserD n = ParserD.Parser step initial extract
216+
217+ where
218+
219+ nBytes = n * SIZE_OF(a)
220+
221+ initial =
222+ return
223+ $ if n <= 0
224+ then error
225+ $ functionPath
226+ ++ ": the size of arrays ["
227+ ++ show n ++ "] must be a natural number"
228+ else ParserD.IPartial Nothing
229+
230+ step Nothing arr =
231+ return
232+ $ let len = MArray.byteLength arr
233+ in if len >= nBytes
234+ then ParserD.Done 0 arr
235+ else ParserD.Partial 0 (Just arr)
236+ step (Just buf) arr =
237+ let len = MArray.byteLength buf + MArray.byteLength arr
238+ in if len > nBytes
239+ then return $ ParserD.Done 1 buf
240+ else do
241+ buf1 <-
242+ if MArray.byteCapacity buf < nBytes
243+ then liftIO $ MArray.realloc nBytes buf
244+ else return buf
245+ buf2 <- MArray.spliceUnsafe buf1 arr
246+ return $ ParserD.Partial 0 (Just buf2)
247+
248+ extract Nothing = return $ ParserD.Done 0 MArray.nil
249+ extract (Just buf) = return $ ParserD.Done 0 buf
250+
251+ functionPath =
252+ "Streamly.Internal.Data.Stream.MutChunked.compactLEParserD"
105
253
106-- | Coalesce adjacent arrays in incoming stream to form bigger arrays of a
254-- | Coalesce adjacent arrays in incoming stream to form bigger arrays of a
107-- minimum specified size. Note that if all the arrays in the stream together
255-- minimum specified size. Note that if all the arrays in the stream together
@@ -110,11 +258,47 @@ compactLEParserD = MArray.pCompactLE
110-- the specified size we stop coalescing further.
258-- the specified size we stop coalescing further.
111--
259--
112-- /Internal/
260-- /Internal/
113−{-# INLINE compactGEFold #-}
261+{-# INLINE_NORMAL compactGEFold #-}
114compactGEFold ::
262compactGEFold ::
115 forall m a. (MonadIO m, Unbox a)
263 forall m a. (MonadIO m, Unbox a)
116 => Int -> FL.Fold m (MutArray a) (MutArray a)
264 => Int -> FL.Fold m (MutArray a) (MutArray a)
117−compactGEFold = MArray.fCompactGE
265+compactGEFold n = Fold step initial extract extract
266+
267+ where
268+
269+ nBytes = n * SIZE_OF(a)
270+
271+ initial =
272+ return
273+ $ if n < 0
274+ then error
275+ $ functionPath
276+ ++ ": the size of arrays ["
277+ ++ show n ++ "] must be a natural number"
278+ else FL.Partial Nothing
279+
280+ step Nothing arr =
281+ return
282+ $ let len = MArray.byteLength arr
283+ in if len >= nBytes
284+ then FL.Done arr
285+ else FL.Partial (Just arr)
286+ step (Just buf) arr = do
287+ let len = MArray.byteLength buf + MArray.byteLength arr
288+ buf1 <-
289+ if MArray.byteCapacity buf < len
290+ then liftIO $ MArray.realloc (max len nBytes) buf
291+ else return buf
292+ buf2 <- MArray.spliceUnsafe buf1 arr
293+ if len >= n
294+ then return $ FL.Done buf2
295+ else return $ FL.Partial (Just buf2)
296+
297+ extract Nothing = return MArray.nil
298+ extract (Just buf) = return buf
299+
300+ functionPath =
301+ "Streamly.Internal.Data.Stream.MutChunked.compactGEFold"
118
302
119-- | Coalesce adjacent arrays in incoming stream to form bigger arrays of a
303-- | Coalesce adjacent arrays in incoming stream to form bigger arrays of a
120-- maximum specified size in bytes.
304-- maximum specified size in bytes.
core/src/Streamly/Internal/Data/MutArray/Type.hs+351−1059
@@ -31,57 +31,39 @@ module Streamly.Internal.Data.MutArray.Type
31 -- ** Type
31 -- ** Type
32 -- $arrayNotes
32 -- $arrayNotes
33 MutArray (..)
33 MutArray (..)
34−
34+ , MutByteArray
35− -- ** Conversion
35+ , MutableByteArray
36− -- *** Pinned and Unpinned
37 , pin
36 , pin
38 , unpin
37 , unpin
39 , isPinned
38 , isPinned
40
39
41− -- ** Casting
40+ -- -- * Constructing and Writing
42− , cast
43− , castUnsafe -- XXX unsafeCast
44− , asBytes
45− , unsafePinnedAsPtr
46− , unsafeAsPtr
47−
48 -- ** Construction
41 -- ** Construction
49− , empty
42+ , nil
50−
51− -- *** New
52− -- | New arrays are always empty arrays with some reserve capacity to
53− -- extend the length without reallocating.
54− , emptyOf
55− , newArrayWith -- emptyAlignedWith
56− , pinnedEmptyOf
57− , pinnedNewAligned -- XXX not required
58− -- , new -- uninitialized array of specified length
59−
60− -- *** Cloning
61− , clone
62− , pinnedClone
63
43
64− -- *** Slicing
44+ -- *** Uninitialized Arrays
65− -- | Get a subarray without copying
45+ , pinnedNew
66− , getSliceUnsafe -- XXX unsafeGetSlice
46+ , pinnedNewBytes
67− , getSlice
47+ , pinnedNewAligned
68− , splitAt -- XXX should be able to express using getSlice
48+ , new
69− , breakOn
49+ , newArrayWith
70
50
71− -- *** Stream Folds
51+ -- *** From streams
72 , ArrayUnsafe (..)
52 , ArrayUnsafe (..)
73− , unsafeCreateOfWith
53+ , writeNWithUnsafe
74− , unsafeCreateOf
54+ , writeNWith
75− , unsafePinnedCreateOf
55+ , writeNUnsafe
76− , pinnedCreateOf
56+ , pinnedWriteNUnsafe
77− , createOfWith
57+ , writeN
78− , createOf
58+ , pinnedWriteN
79− , revCreateOf
59+ , pinnedWriteNAligned
80−
60+
81− , pinnedCreate
61+ , writeWith
82− , createWith
62+ , write
83− , create
63+ , pinnedWrite
84− -- , revCreate
64+
65+ , writeRevN
66+ -- , writeRev
85
67
86 -- *** From containers
68 -- *** From containers
87 , fromListN
69 , fromListN
@@ -90,18 +72,18 @@ module Streamly.Internal.Data.MutArray.Type
90 , pinnedFromList
72 , pinnedFromList
91 , fromListRevN
73 , fromListRevN
92 , fromListRev
74 , fromListRev
93− , fromStreamN
75+ , fromStreamDN
94− , fromStream
76+ , fromStreamD
95 , fromPureStreamN
77 , fromPureStreamN
96 , fromPureStream
78 , fromPureStream
97 , fromByteStr#
79 , fromByteStr#
98 , fromPtrN
80 , fromPtrN
99− , fromChunksK
81+ , fromArrayStreamK
100− , fromChunksRealloced -- fromSmallChunks
82+ , fromArrayStreamRealloced
101
83
102 -- ** Random writes
84 -- ** Random writes
103 , putIndex
85 , putIndex
104− , putIndexUnsafe -- XXX unsafePutIndex
86+ , putIndexUnsafe
105 , putIndices
87 , putIndices
106 -- , putFromThenTo
88 -- , putFromThenTo
107 -- , putFrom -- start writing at the given position
89 -- , putFrom -- start writing at the given position
@@ -109,69 +91,76 @@ module Streamly.Internal.Data.MutArray.Type
109 -- , putFromTo
91 -- , putFromTo
110 -- , putFromRev
92 -- , putFromRev
111 -- , putUptoRev
93 -- , putUptoRev
112− , modifyIndexUnsafe -- XXX unsafeModifyIndex
94+ , modifyIndexUnsafe
113 , modifyIndex
95 , modifyIndex
114 , modifyIndices
96 , modifyIndices
115 , modify
97 , modify
116 , swapIndices
98 , swapIndices
117 , unsafeSwapIndices
99 , unsafeSwapIndices
118
100
119− -- ** Reading
101+ -- ** Growing and Shrinking
102+ -- | Arrays grow only at the end, though it is possible to grow on both sides
103+ -- and therefore have a cons as well as snoc. But that will require two
104+ -- bounds in the array representation.
120
105
121− -- *** Indexing
106+ -- *** Appending elements
122− , getIndex
107+ , snocWith
123− , getIndexUnsafe -- XXX unsafeGetIndex
108+ , snoc
124− -- , getFromThenTo
109+ , snocLinear
125− , getIndexRev -- getRevIndex?
110+ , snocMay
126− , indexReader
111+ , snocUnsafe
127− , indexReaderWith
128
112
129− -- *** To Streams
113+ -- *** Appending streams
114+ , writeAppendNUnsafe
115+ , writeAppendN
116+ , writeAppendWith
117+ , writeAppend
118+
119+ -- ** Eliminating and Reading
120+
121+ -- *** To streams
122+ , reader
123+ , readerRevWith
124+ , readerRev
125+
126+ -- *** To containers
127+ , toStreamDWith
128+ , toStreamDRevWith
129+ , toStreamKWith
130+ , toStreamKRevWith
130 , read
131 , read
131 , readRev
132 , readRev
132− , toStreamWith
133− , toStreamRevWith
134 , toStreamK
133 , toStreamK
135− , toStreamKWith
136 , toStreamKRev
134 , toStreamKRev
137− , toStreamKRevWith
138−
139− -- *** To Containers
140 , toList
135 , toList
141
136
142− -- *** Unfolds
143 -- experimental
137 -- experimental
144 , producerWith
138 , producerWith
145 , producer
139 , producer
146
140
147− , reader
141+ -- *** Random reads
148− , readerRevWith
142+ , getIndex
149− , readerRev
143+ , getIndexUnsafe
150−
144+ , getIndices
151− -- ** Size and Capacity
145+ , getIndicesD
152− -- *** Size
146+ -- , getFromThenTo
153− , length
147+ , getIndexRev
154− , byteLength
155−
156− -- *** Capacity
157− -- , capacity
158− , byteCapacity
159− , bytesFree
160
148
161− -- *** Capacity Management
149+ -- ** Memory Management
162 , blockSize
150 , blockSize
163 , arrayChunkBytes
151 , arrayChunkBytes
164 , allocBytesToElemCount
152 , allocBytesToElemCount
165− , realloc -- this is "resize"
153+ , realloc
166− , grow
154+ , resize
167− , growExp
155+ , resizeExp
168 , rightSize
156 , rightSize
169
157
170− -- ** Folding
158+ -- ** Size
171− , foldl'
159+ , length
172− , foldr
160+ , byteLength
173− , byteCmp
161+ -- , capacity
174− , byteEq
162+ , byteCapacity
163+ , bytesFree
175
164
176 -- ** In-place Mutation Algorithms
165 -- ** In-place Mutation Algorithms
177 , strip
166 , strip
@@ -183,82 +172,58 @@ module Streamly.Internal.Data.MutArray.Type
183 , mergeBy
172 , mergeBy
184 , bubble
173 , bubble
185
174
186− -- ** Growing and Shrinking
175+ -- ** Casting
187− -- | Arrays grow only at the end, though it is possible to grow on both
176+ , cast
188− -- sides and therefore have a cons as well as snoc. But that will require
177+ , castUnsafe
189− -- both lower and upper bound in the array representation.
178+ , asBytes
190−
179+ , asPtrUnsafe
191− -- *** Appending elements
180+ , asUnpinnedPtrUnsafe
192− , snocWith
193− , snoc
194− , snocLinear
195− , snocMay
196− , snocUnsafe -- XXX unsafeSnoc
197−
198− -- *** Appending streams
199− , unsafeAppendN
200− , appendN
201− , appendWith
202− , append
203−
204− -- *** Appending arrays
205− , spliceCopy
206− , spliceWith
207− , splice
208− , spliceExp
209− , spliceUnsafe -- XXX unsafeSplice
210− -- , putSlice
211− -- , appendSlice
212− -- , appendSliceFrom
213−
214− -- ** Serialization using Unbox
215− , pokeAppend
216− , pokeAppendMay
217− , pokeSkipUnsafe -- unsafePokeSkip
218
181
219− -- ** Deserialization using Unbox
182+ -- ** Folding
220− , peekUncons
183+ , foldl'
221− , peekUnconsUnsafe -- unsafePeekUncons
184+ , foldr
222− , peekSkipUnsafe -- unsafePeekSkip
185+ , cmp
186+ , byteCmp
187+ , byteEq
223
188
224− -- Arrays of arrays
189+ -- ** Arrays of arrays
225 -- We can add dimensionality parameter to the array type to get
190 -- We can add dimensionality parameter to the array type to get
226 -- multidimensional arrays. Multidimensional arrays would just be a
191 -- multidimensional arrays. Multidimensional arrays would just be a
227 -- convenience wrapper on top of single dimensional arrays.
192 -- convenience wrapper on top of single dimensional arrays.
228
193
229− -- ** Streams of Arrays
194+ -- | Operations dealing with multiple arrays, streams of arrays or
230− -- *** Chunk
195+ -- multidimensional array representations.
231− -- | Group a stream into arrays.
196+
197+ -- *** Construct from streams
232 , chunksOf
198 , chunksOf
233 , pinnedChunksOf
199 , pinnedChunksOf
234 , buildChunks
200 , buildChunks
235
201
236− -- *** Split
202+ -- *** Eliminate to streams
237− -- | Split an array into slices.
203+ , concatChunks
204+ , concatChunksRev
238
205
206+ -- *** Construct from arrays
207+ -- get chunks without copying
208+ , getSliceUnsafe
209+ , getSlice
239 -- , getSlicesFromLenN
210 -- , getSlicesFromLenN
240− , splitOn
211+ , splitAt -- XXX should be able to express using getSlice
241− -- , slicesOf
212+ , breakOn
242−
213+
243− -- *** Concat
214+ -- ** Cloning arrays
244− -- | Append the arrays in a stream to form a stream of elements.
215+ , clone
245− , concatWith
216+ , pinnedClone
246− , concatRevWith
217+
247− , concat
218+ -- ** Appending arrays
248− , concatRev
219+ , spliceCopy
249−
220+ , spliceWith
250− -- *** Compact
221+ , splice
251− -- | Append the arrays in a stream to form a stream of larger arrays.
222+ , spliceExp
252− , SpliceState (..)
223+ , spliceUnsafe
253− , pCompactLE
224+ -- , putSlice
254− , pPinnedCompactLE
225+ -- , appendSlice
255− , compactLeAs
226+ -- , appendSliceFrom
256− , fCompactGE
257− , fPinnedCompactGE
258− , lCompactGE
259− , lPinnedCompactGE
260− , compactGE
261− , compactEQ
262
227
263 -- ** Utilities
228 -- ** Utilities
264 , roundUpToPower2
229 , roundUpToPower2
@@ -267,37 +232,9 @@ module Streamly.Internal.Data.MutArray.Type
267 , c_memchr
232 , c_memchr
268
233
269 -- * Deprecated
234 -- * Deprecated
270− , asPtrUnsafe
271 , writeChunks
235 , writeChunks
272 , flattenArrays
236 , flattenArrays
273 , flattenArraysRev
237 , flattenArraysRev
274− , fromArrayStreamK
275− , fromStreamDN
276− , fromStreamD
277− , cmp
278− , getIndices
279− , getIndicesWith
280− , resize
281− , resizeExp
282− , nil
283− , new
284− , pinnedNew
285− , pinnedNewBytes
286− , writeAppendNUnsafe
287− , writeAppendN
288− , writeAppendWith
289− , writeAppend
290− , writeNWithUnsafe
291− , writeNWith
292− , writeNUnsafe
293− , pinnedWriteNUnsafe
294− , writeN
295− , pinnedWriteN
296− , pinnedWriteNAligned -- XXX not required
297− , writeWith
298− , write
299− , pinnedWrite
300− , writeRevN
301 )
238 )
302where
239where
303
240
@@ -308,7 +245,6 @@ where
308
245
309import Control.Monad (when, void)
246import Control.Monad (when, void)
310import Control.Monad.IO.Class (MonadIO(..))
247import Control.Monad.IO.Class (MonadIO(..))
311−import Data.Bifunctor (first)
312import Data.Bits (shiftR, (.|.), (.&.))
248import Data.Bits (shiftR, (.|.), (.&.))
313import Data.Functor.Identity (Identity(..))
249import Data.Functor.Identity (Identity(..))
314import Data.Proxy (Proxy(..))
250import Data.Proxy (Proxy(..))
@@ -317,6 +253,7 @@ import Foreign.C.Types (CSize(..), CInt(..))
317import Foreign.Ptr (plusPtr, minusPtr, nullPtr)
253import Foreign.Ptr (plusPtr, minusPtr, nullPtr)
318import Streamly.Internal.Data.MutByteArray.Type
254import Streamly.Internal.Data.MutByteArray.Type
319 ( MutByteArray(..)
255 ( MutByteArray(..)
256+ , MutableByteArray
320 , PinnedState(..)
257 , PinnedState(..)
321 , getMutableByteArray#
258 , getMutableByteArray#
322 , putSliceUnsafe
259 , putSliceUnsafe
@@ -335,17 +272,13 @@ import GHC.Ptr (Ptr(..))
335import Streamly.Internal.Data.Fold.Type (Fold(..))
272import Streamly.Internal.Data.Fold.Type (Fold(..))
336import Streamly.Internal.Data.Producer.Type (Producer (..))
273import Streamly.Internal.Data.Producer.Type (Producer (..))
337import Streamly.Internal.Data.Stream.Type (Stream)
274import Streamly.Internal.Data.Stream.Type (Stream)
338−import Streamly.Internal.Data.Parser.Type (Parser (..))
339import Streamly.Internal.Data.StreamK.Type (StreamK)
275import Streamly.Internal.Data.StreamK.Type (StreamK)
340import Streamly.Internal.Data.SVar.Type (adaptState, defState)
276import Streamly.Internal.Data.SVar.Type (adaptState, defState)
341−import Streamly.Internal.Data.Tuple.Strict (Tuple'(..))
342import Streamly.Internal.Data.Unfold.Type (Unfold(..))
277import Streamly.Internal.Data.Unfold.Type (Unfold(..))
343import Streamly.Internal.System.IO (arrayPayloadSize, defaultChunkSize)
278import Streamly.Internal.System.IO (arrayPayloadSize, defaultChunkSize)
344
279
345import qualified Streamly.Internal.Data.Fold.Type as FL
280import qualified Streamly.Internal.Data.Fold.Type as FL
346import qualified Streamly.Internal.Data.MutByteArray.Type as Unboxed
281import qualified Streamly.Internal.Data.MutByteArray.Type as Unboxed
347−import qualified Streamly.Internal.Data.Parser.Type as Parser
348−-- import qualified Streamly.Internal.Data.Fold.Type as Fold
349import qualified Streamly.Internal.Data.Producer as Producer
282import qualified Streamly.Internal.Data.Producer as Producer
350import qualified Streamly.Internal.Data.Stream.Type as D
283import qualified Streamly.Internal.Data.Stream.Type as D
351import qualified Streamly.Internal.Data.Stream.Lift as D
284import qualified Streamly.Internal.Data.Stream.Lift as D
@@ -353,7 +286,7 @@ import qualified Streamly.Internal.Data.StreamK.Type as K
353import qualified Prelude
286import qualified Prelude
354
287
355import Prelude hiding
288import Prelude hiding
356− (Foldable(..), concat, read, unlines, splitAt, reverse, truncate)
289+ (Foldable(..), read, unlines, splitAt, reverse, truncate)
357
290
358#include "DocTestDataMutArray.hs"
291#include "DocTestDataMutArray.hs"
359
292
@@ -479,8 +412,6 @@ isPinned MutArray{..} = Unboxed.isPinned arrContents
479-- we need more than that. See stg_pinnedNewAlignedByteArrayzh and
412-- we need more than that. See stg_pinnedNewAlignedByteArrayzh and
480-- allocatePinned in GHC source.
413-- allocatePinned in GHC source.
481
414
482−-- XXX Rename to emptyAlignedWith, alignSize should be first arg.
483−
484-- | @newArrayWith allocator alignment count@ allocates a new array of zero
415-- | @newArrayWith allocator alignment count@ allocates a new array of zero
485-- length and with a capacity to hold @count@ elements, using @allocator
416-- length and with a capacity to hold @count@ elements, using @allocator
486-- size alignment@ as the memory allocator function.
417-- size alignment@ as the memory allocator function.
@@ -504,25 +435,12 @@ newArrayWith alloc alignSize count = do
504 , arrBound = size
435 , arrBound = size
505 }
436 }
506
437
507−-- For arrays "nil" sounds a bit odd. empty is better. The only problem with
508−-- empty is that it is also used by the Alternative type class. But assuming we
509−-- will mostly import the Array module qualified this should be fine.
510−
511−-- | Create an empty array.
512−empty ::
513−#ifdef DEVBUILD
514− Unbox a =>
515−#endif
516− MutArray a
517−empty = MutArray Unboxed.empty 0 0 0
518−
519−{-# DEPRECATED nil "Please use empty instead." #-}
520nil ::
438nil ::
521#ifdef DEVBUILD
439#ifdef DEVBUILD
522 Unbox a =>
440 Unbox a =>
523#endif
441#endif
524 MutArray a
442 MutArray a
525−nil = empty
443+nil = MutArray Unboxed.nil 0 0 0
526
444
527{-# INLINE newBytesAs #-}
445{-# INLINE newBytesAs #-}
528newBytesAs :: MonadIO m =>
446newBytesAs :: MonadIO m =>
@@ -539,13 +457,12 @@ newBytesAs ps bytes = do
539 , arrBound = bytes
457 , arrBound = bytes
540 }
458 }
541
459
542−-- | Allocates a pinned empty array that with a reserved capacity of bytes.
460+-- | Allocates a pinned empty array that can hold 'count' items. The memory of
543−-- The memory of the array is uninitialized and the allocation is aligned as
461+-- the array is uninitialized and the allocation is aligned as per the
544−-- per the 'Unboxed' instance of the type.
462+-- 'Unboxed' instance of the type.
545--
463--
546-- /Pre-release/
464-- /Pre-release/
547{-# INLINE pinnedNewBytes #-}
465{-# INLINE pinnedNewBytes #-}
548−{-# DEPRECATED pinnedNewBytes "Please use pinnedEmptyOf with appropriate calculation" #-}
549pinnedNewBytes :: MonadIO m =>
466pinnedNewBytes :: MonadIO m =>
550#ifdef DEVBUILD
467#ifdef DEVBUILD
551 Unbox a =>
468 Unbox a =>
@@ -570,31 +487,21 @@ newAs ps =
570 (error "new: alignment is not used in unpinned arrays.")
487 (error "new: alignment is not used in unpinned arrays.")
571
488
572-- XXX can unaligned allocation be more efficient when alignment is not needed?
489-- XXX can unaligned allocation be more efficient when alignment is not needed?
573−
490+--
574−-- | Allocates a pinned array of zero length but growable to the specified
491+-- | Allocates an empty pinned array that can hold 'count' items. The memory of
575−-- capacity without reallocation.
492+-- the array is uninitialized and the allocation is aligned as per the 'Unboxed'
576−{-# INLINE pinnedEmptyOf #-}
493+-- instance of the type.
577−pinnedEmptyOf :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a)
494+--
578−pinnedEmptyOf = newAs Pinned
579−
580−-- XXX Deprecate in major
581−-- {-# DEPRECATED pinnedNew "Please use pinnedEmptyOf instead." #-}
582{-# INLINE pinnedNew #-}
495{-# INLINE pinnedNew #-}
583pinnedNew :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a)
496pinnedNew :: forall m a. (MonadIO m, Unbox a) => Int -> m (MutArray a)
584−pinnedNew = pinnedEmptyOf
497+pinnedNew = newAs Pinned
585
498
586−-- | Allocates an unpinned array of zero length but growable to the specified
499+-- | Allocates an empty unpinned array that can hold 'count' items. The memory
587−-- capacity without reallocation.
500+-- of the array is uninitialized.
588--
501--
589−{-# INLINE emptyOf #-}
590−emptyOf :: (MonadIO m, Unbox a) => Int -> m (MutArray a)
591−emptyOf = newAs Unpinned
592−
593−-- XXX Deprecate in major
594−-- {-# DEPRECATED new "Please use emptyOf instead." #-}
595{-# INLINE new #-}
502{-# INLINE new #-}
596new :: (MonadIO m, Unbox a) => Int -> m (MutArray a)
503new :: (MonadIO m, Unbox a) => Int -> m (MutArray a)
597−new = emptyOf
504+new = newAs Unpinned
598
505
599-------------------------------------------------------------------------------
506-------------------------------------------------------------------------------
600-- Random writes
507-- Random writes
@@ -642,7 +549,7 @@ putIndices arr = FL.foldlM' step (return ())
642
549
643 where
550 where
644
551
645− step () (i, x) = putIndex i arr x
552+ step () (i, x) = liftIO (putIndex i arr x)
646
553
647-- | Modify a given index of an array using a modifier function.
554-- | Modify a given index of an array using a modifier function.
648--
555--
@@ -838,19 +745,22 @@ arrayChunkBytes = 1024
838roundDownTo :: Int -> Int -> Int
745roundDownTo :: Int -> Int -> Int
839roundDownTo elemSize size = size - (size `mod` elemSize)
746roundDownTo elemSize size = size - (size `mod` elemSize)
840
747
748+-- XXX See if resizing can be implemented by reading the old array as a stream
749+-- and then using writeN to the new array.
750+--
841-- NOTE: we are passing elemSize explicitly to avoid an Unboxed constraint.
751-- NOTE: we are passing elemSize explicitly to avoid an Unboxed constraint.
842-- Since this is not inlined Unboxed consrraint leads to dictionary passing
752-- Since this is not inlined Unboxed consrraint leads to dictionary passing
843-- which complicates some inspection tests.
753-- which complicates some inspection tests.
844--
754--
845−{-# NOINLINE reallocExplicitAs #-}
755+{-# NOINLINE reallocExplicit #-}
846−reallocExplicitAs :: PinnedState -> Int -> Int -> MutArray a -> IO (MutArray a)
756+reallocExplicit :: Int -> Int -> MutArray a -> IO (MutArray a)
847−reallocExplicitAs ps elemSize newCapacityInBytes MutArray{..} = do
757+reallocExplicit elemSize newCapacityInBytes MutArray{..} = do
848 assertM(arrEnd <= arrBound)
758 assertM(arrEnd <= arrBound)
849
759
850 -- Allocate new array
760 -- Allocate new array
851 let newCapMaxInBytes = roundUpLargeArray newCapacityInBytes
761 let newCapMaxInBytes = roundUpLargeArray newCapacityInBytes
852 contents <-
762 contents <-
853− if ps == Pinned
763+ if Unboxed.isPinned arrContents
854 then Unboxed.pinnedNew newCapMaxInBytes
764 then Unboxed.pinnedNew newCapMaxInBytes
855 else Unboxed.new newCapMaxInBytes
765 else Unboxed.new newCapMaxInBytes
856 let !(MutByteArray mbarrFrom#) = arrContents
766 let !(MutByteArray mbarrFrom#) = arrContents
@@ -875,10 +785,6 @@ reallocExplicitAs ps elemSize newCapacityInBytes MutArray{..} = do
875 , arrBound = newCapInBytes
785 , arrBound = newCapInBytes
876 }
786 }
877
787
878−-- XXX Should these be called reallocBytes etc?
879−-- XXX We may also need reallocAs to allocate as pinned/unpinned explicitly. In
880−-- fact clone/pinnedClone can be implemented using reallocAs.
881−
882-- | @realloc newCapacity array@ reallocates the array to the specified
788-- | @realloc newCapacity array@ reallocates the array to the specified
883-- capacity in bytes.
789-- capacity in bytes.
884--
790--
@@ -890,12 +796,7 @@ reallocExplicitAs ps elemSize newCapacityInBytes MutArray{..} = do
890-- If the original array is pinned, the newly allocated array is also pinned.
796-- If the original array is pinned, the newly allocated array is also pinned.
891{-# INLINABLE realloc #-}
797{-# INLINABLE realloc #-}
892realloc :: forall m a. (MonadIO m, Unbox a) => Int -> MutArray a -> m (MutArray a)
798realloc :: forall m a. (MonadIO m, Unbox a) => Int -> MutArray a -> m (MutArray a)
893−realloc bytes arr =
894− let ps =
895− if isPinned arr
896− then Pinned
897− else Unpinned
898− in liftIO $ reallocExplicitAs ps (SIZE_OF(a)) bytes arr
799+realloc bytes arr = liftIO $ reallocExplicit (SIZE_OF(a)) bytes arr
899
800
900-- | @reallocWith label capSizer minIncrBytes array@. The label is used
801-- | @reallocWith label capSizer minIncrBytes array@. The label is used
901-- in error messages and the capSizer is used to determine the capacity of the
802-- in error messages and the capSizer is used to determine the capacity of the
@@ -918,14 +819,14 @@ reallocWith label capSizer minIncrBytes arr = do
918 where
819 where
919
820
920 badSize newSize =
821 badSize newSize =
921− Prelude.concat
822+ concat
922 [ label
823 [ label
923 , ": new array size (in bytes) is less than required size "
824 , ": new array size (in bytes) is less than required size "
924 , show newSize
825 , show newSize
925 , ". Please check the sizing function passed."
826 , ". Please check the sizing function passed."
926 ]
827 ]
927
828
928−-- | @grow newCapacity array@ changes the total capacity of the array so that
829+-- | @resize newCapacity array@ changes the total capacity of the array so that
929-- it is enough to hold the specified number of elements. Nothing is done if
830-- it is enough to hold the specified number of elements. Nothing is done if
930-- the specified capacity is less than the length of the array.
831-- the specified capacity is less than the length of the array.
931--
832--
@@ -933,46 +834,34 @@ reallocWith label capSizer minIncrBytes arr = do
933-- the block size (4K).
834-- the block size (4K).
934--
835--
935-- /Pre-release/
836-- /Pre-release/
936−{-# INLINE grow #-}
837+{-# INLINE resize #-}
937−grow :: forall m a. (MonadIO m, Unbox a) =>
838+resize :: forall m a. (MonadIO m, Unbox a) =>
938 Int -> MutArray a -> m (MutArray a)
839 Int -> MutArray a -> m (MutArray a)
939−grow nElems arr@MutArray{..} = do
840+resize nElems arr@MutArray{..} = do
940 let req = SIZE_OF(a) * nElems
841 let req = SIZE_OF(a) * nElems
941− cap = arrBound - arrStart
842+ len = arrEnd - arrStart
942− if req < cap
843+ if req < len
943 then return arr
844 then return arr
944 else realloc req arr
845 else realloc req arr
945
846
946−{-# DEPRECATED resize "Please use grow instead." #-}
947−{-# INLINE resize #-}
948−resize :: forall m a. (MonadIO m, Unbox a) =>
949− Int -> MutArray a -> m (MutArray a)
950−resize = grow
951−
952−-- | Like 'grow' but if the requested byte capacity is more than
847+-- | Like 'resize' but if the byte capacity is more than 'largeObjectThreshold'
953−-- 'largeObjectThreshold' then it is rounded up to the closest power of 2.
848+-- then it is rounded up to the closest power of 2.
954--
849--
955-- /Pre-release/
850-- /Pre-release/
956−{-# INLINE growExp #-}
851+{-# INLINE resizeExp #-}
957−growExp :: forall m a. (MonadIO m, Unbox a) =>
852+resizeExp :: forall m a. (MonadIO m, Unbox a) =>
958 Int -> MutArray a -> m (MutArray a)
853 Int -> MutArray a -> m (MutArray a)
959−growExp nElems arr@MutArray{..} = do
854+resizeExp nElems arr@MutArray{..} = do
960 let req = roundUpLargeArray (SIZE_OF(a) * nElems)
855 let req = roundUpLargeArray (SIZE_OF(a) * nElems)
961 req1 =
856 req1 =
962 if req > largeObjectThreshold
857 if req > largeObjectThreshold
963 then roundUpToPower2 req
858 then roundUpToPower2 req
964 else req
859 else req
965− cap = arrBound - arrStart
860+ len = arrEnd - arrStart
966− if req1 < cap
861+ if req1 < len
967 then return arr
862 then return arr
968 else realloc req1 arr
863 else realloc req1 arr
969
864
970−{-# DEPRECATED resizeExp "Please use growExp instead." #-}
971−{-# INLINE resizeExp #-}
972−resizeExp :: forall m a. (MonadIO m, Unbox a) =>
973− Int -> MutArray a -> m (MutArray a)
974−resizeExp = growExp
975−
976-- | Resize the allocated memory to drop any reserved free space at the end of
865-- | Resize the allocated memory to drop any reserved free space at the end of
977-- the array and reallocate it to reduce wastage.
866-- the array and reallocate it to reduce wastage.
978--
867--
@@ -1037,7 +926,7 @@ snocUnsafe arr@MutArray{..} = snocNewEnd (INDEX_NEXT(arrEnd,a)) arr
1037{-# INLINE snocMay #-}
926{-# INLINE snocMay #-}
1038snocMay :: forall m a. (MonadIO m, Unbox a) =>
927snocMay :: forall m a. (MonadIO m, Unbox a) =>
1039 MutArray a -> a -> m (Maybe (MutArray a))
928 MutArray a -> a -> m (Maybe (MutArray a))
1040−snocMay arr@MutArray{..} x = do
929+snocMay arr@MutArray{..} x = liftIO $ do
1041 let newEnd = INDEX_NEXT(arrEnd,a)
930 let newEnd = INDEX_NEXT(arrEnd,a)
1042 if newEnd <= arrBound
931 if newEnd <= arrBound
1043 then Just <$> snocNewEnd newEnd arr x
932 then Just <$> snocNewEnd newEnd arr x
@@ -1051,7 +940,7 @@ snocWithRealloc :: forall m a. (MonadIO m, Unbox a) =>
1051 -> a
940 -> a
1052 -> m (MutArray a)
941 -> m (MutArray a)
1053snocWithRealloc sizer arr x = do
942snocWithRealloc sizer arr x = do
1054− arr1 <- reallocWith "snocWith" sizer (SIZE_OF(a)) arr
943+ arr1 <- liftIO $ reallocWith "snocWith" sizer (SIZE_OF(a)) arr
1055 snocUnsafe arr1 x
944 snocUnsafe arr1 x
1056
945
1057-- | @snocWith sizer arr elem@ mutates @arr@ to append @elem@. The length of
946-- | @snocWith sizer arr elem@ mutates @arr@ to append @elem@. The length of
@@ -1073,7 +962,7 @@ snocWith :: forall m a. (MonadIO m, Unbox a) =>
1073 -> MutArray a
962 -> MutArray a
1074 -> a
963 -> a
1075 -> m (MutArray a)
964 -> m (MutArray a)
1076−snocWith allocSize arr x = do
965+snocWith allocSize arr x = liftIO $ do
1077 let newEnd = INDEX_NEXT(arrEnd arr,a)
966 let newEnd = INDEX_NEXT(arrEnd arr,a)
1078 if newEnd <= arrBound arr
967 if newEnd <= arrBound arr
1079 then snocNewEnd newEnd arr x
968 then snocNewEnd newEnd arr x
@@ -1117,126 +1006,6 @@ snoc = snocWith f
1117 then oldSize * 2
1006 then oldSize * 2
1118 else roundUpToPower2 oldSize * 2
1007 else roundUpToPower2 oldSize * 2
1119
1008
1120−-------------------------------------------------------------------------------
1121−-- Serialization/Deserialization
1122−-------------------------------------------------------------------------------
1123−
1124−{-# INLINE pokeNewEnd #-}
1125−pokeNewEnd :: (MonadIO m, Unbox a) =>
1126− Int -> MutArray Word8 -> a -> m (MutArray Word8)
1127−pokeNewEnd newEnd arr@MutArray{..} x = liftIO $ do
1128− assert (newEnd <= arrBound) (return ())
1129− liftIO $ pokeAt arrEnd arrContents x
1130− return $ arr {arrEnd = newEnd}
1131−
1132−-- | Really really unsafe, unboxes a Haskell type and appends the resulting
1133−-- bytes to the byte array, may cause silent data corruption or if you are
1134−-- lucky a segfault if the array does not have enough space to append the
1135−-- element.
1136−--
1137−-- /Internal/
1138−{-# INLINE pokeAppendUnsafe #-}
1139−pokeAppendUnsafe :: forall m a. (MonadIO m, Unbox a) =>
1140− MutArray Word8 -> a -> m (MutArray Word8)
1141−pokeAppendUnsafe arr@MutArray{..} = pokeNewEnd (arrEnd + SIZE_OF(a)) arr
1142−
1143−-- | Skip the specified number of bytes in the array. The data in the skipped
1144−-- region remains uninitialzed.
1145−{-# INLINE pokeSkipUnsafe #-}
1146−pokeSkipUnsafe :: Int -> MutArray Word8 -> MutArray Word8
1147−pokeSkipUnsafe n arr@MutArray{..} = do
1148− let newEnd = arrEnd + n
1149− in assert (newEnd <= arrBound) (arr {arrEnd = newEnd})
1150−
1151−-- | Like 'pokeAppend' but does not grow the array when pre-allocated array
1152−-- capacity becomes full.
1153−--
1154−-- /Internal/
1155−{-# INLINE pokeAppendMay #-}
1156−pokeAppendMay :: forall m a. (MonadIO m, Unbox a) =>
1157− MutArray Word8 -> a -> m (Maybe (MutArray Word8))
1158−pokeAppendMay arr@MutArray{..} x = liftIO $ do
1159− let newEnd = arrEnd + SIZE_OF(a)
1160− if newEnd <= arrBound
1161− then Just <$> pokeNewEnd newEnd arr x
1162− else return Nothing
1163−
1164−{-# NOINLINE pokeWithRealloc #-}
1165−pokeWithRealloc :: forall m a. (MonadIO m, Unbox a) =>
1166− (Int -> Int)
1167− -> MutArray Word8
1168− -> a
1169− -> m (MutArray Word8)
1170−pokeWithRealloc sizer arr x = do
1171− arr1 <- liftIO $ reallocWith "pokeWithRealloc" sizer (SIZE_OF(a)) arr
1172− pokeAppendUnsafe arr1 x
1173−
1174−{-# INLINE pokeAppendWith #-}
1175−pokeAppendWith :: forall m a. (MonadIO m, Unbox a) =>
1176− (Int -> Int)
1177− -> MutArray Word8
1178− -> a
1179− -> m (MutArray Word8)
1180−pokeAppendWith allocSize arr x = liftIO $ do
1181− let newEnd = arrEnd arr + SIZE_OF(a)
1182− if newEnd <= arrBound arr
1183− then pokeNewEnd newEnd arr x
1184− else pokeWithRealloc allocSize arr x
1185−
1186−-- | Unbox a Haskell type and append the resulting bytes to a mutable byte
1187−-- array. The array is grown exponentially when more space is needed.
1188−--
1189−-- Definition:
1190−--
1191−-- >>> pokeAppend arr x = MutArray.castUnsafe <$> MutArray.snoc (MutArray.castUnsafe arr) x
1192−--
1193−{-# INLINE pokeAppend #-}
1194−pokeAppend :: forall m a. (MonadIO m, Unbox a) =>
1195− MutArray Word8 -> a -> m (MutArray Word8)
1196−pokeAppend = pokeAppendWith f
1197−
1198− where
1199−
1200− f oldSize =
1201− if isPower2 oldSize
1202− then oldSize * 2
1203− else roundUpToPower2 oldSize * 2
1204−
1205−-- | Really really unsafe, create a Haskell value from an unboxed byte array,
1206−-- does not check if the array is big enough, may return garbage or if you are
1207−-- lucky may cause a segfault.
1208−--
1209−-- /Internal/
1210−{-# INLINE peekUnconsUnsafe #-}
1211−peekUnconsUnsafe :: forall m a. (MonadIO m, Unbox a) =>
1212− MutArray Word8 -> m (a, MutArray Word8)
1213−peekUnconsUnsafe MutArray{..} = do
1214− let start1 = arrStart + SIZE_OF(a)
1215− assert (start1 <= arrEnd) (return ())
1216− liftIO $ do
1217− r <- peekAt arrStart arrContents
1218− return (r, MutArray arrContents start1 arrEnd arrBound)
1219−
1220−-- | Discard the specified number of bytes in the array.
1221−{-# INLINE peekSkipUnsafe #-}
1222−peekSkipUnsafe :: Int -> MutArray Word8 -> MutArray Word8
1223−peekSkipUnsafe n MutArray{..} =
1224− let start1 = arrStart + n
1225− in assert (start1 <= arrEnd) (MutArray arrContents start1 arrEnd arrBound)
1226−
1227−-- | Create a Haskell value from its unboxed representation from the head of a
1228−-- byte array, return the value and the remaining array.
1229−{-# INLINE peekUncons #-}
1230−peekUncons :: forall m a. (MonadIO m, Unbox a) =>
1231− MutArray Word8 -> m (Maybe a, MutArray Word8)
1232−peekUncons arr@MutArray{..} = do
1233− let start1 = arrStart + SIZE_OF(a)
1234− if start1 > arrEnd
1235− then return (Nothing, arr)
1236− else liftIO $ do
1237− r <- peekAt arrStart arrContents
1238− return (Just r, MutArray arrContents start1 arrEnd arrBound)
1239−
1240-------------------------------------------------------------------------------
1009-------------------------------------------------------------------------------
1241-- Random reads
1010-- Random reads
1242-------------------------------------------------------------------------------
1011-------------------------------------------------------------------------------
@@ -1279,10 +1048,15 @@ getIndexRev i MutArray{..} = do
1279data GetIndicesState contents start end st =
1048data GetIndicesState contents start end st =
1280 GetIndicesState contents start end st
1049 GetIndicesState contents start end st
1281
1050
1282−{-# INLINE indexReaderWith #-}
1051+-- | Given an unfold that generates array indices, read the elements on those
1052+-- indices from the supplied MutArray. An error is thrown if an index is out of
1053+-- bounds.
1054+--
1055+-- /Pre-release/
1056+{-# INLINE getIndicesD #-}
1283−indexReaderWith :: (Monad m, Unbox a) =>
1057+getIndicesD :: (Monad m, Unbox a) =>
1284 (forall b. IO b -> m b) -> D.Stream m Int -> Unfold m (MutArray a) a
1058 (forall b. IO b -> m b) -> D.Stream m Int -> Unfold m (MutArray a) a
1285−indexReaderWith liftio (D.Stream stepi sti) = Unfold step inject
1059+getIndicesD liftio (D.Stream stepi sti) = Unfold step inject
1286
1060
1287 where
1061 where
1288
1062
@@ -1301,26 +1075,9 @@ indexReaderWith liftio (D.Stream stepi sti) = Unfold step inject
1301 D.Skip s -> return $ D.Skip (GetIndicesState contents start end s)
1075 D.Skip s -> return $ D.Skip (GetIndicesState contents start end s)
1302 D.Stop -> return D.Stop
1076 D.Stop -> return D.Stop
1303
1077
1304−{-# DEPRECATED getIndicesWith "Please use indexReaderWith instead." #-}
1305−{-# INLINE getIndicesWith #-}
1306−getIndicesWith :: (Monad m, Unbox a) =>
1307− (forall b. IO b -> m b) -> D.Stream m Int -> Unfold m (MutArray a) a
1308−getIndicesWith = indexReaderWith
1309−
1310−-- | Given an unfold that generates array indices, read the elements on those
1311−-- indices from the supplied MutArray. An error is thrown if an index is out of
1312−-- bounds.
1313−--
1314−-- /Pre-release/
1315−{-# INLINE indexReader #-}
1316−indexReader :: (MonadIO m, Unbox a) => Stream m Int -> Unfold m (MutArray a) a
1317−indexReader = indexReaderWith liftIO
1318−
1319−-- XXX DO NOT REMOVE, change the signature to use Stream instead of unfold
1320−{-# DEPRECATED getIndices "Please use indexReader instead." #-}
1321{-# INLINE getIndices #-}
1078{-# INLINE getIndices #-}
1322getIndices :: (MonadIO m, Unbox a) => Stream m Int -> Unfold m (MutArray a) a
1079getIndices :: (MonadIO m, Unbox a) => Stream m Int -> Unfold m (MutArray a) a
1323−getIndices = indexReader
1080+getIndices = getIndicesD liftIO
1324
1081
1325-------------------------------------------------------------------------------
1082-------------------------------------------------------------------------------
1326-- Subarrays
1083-- Subarrays
@@ -1615,7 +1372,7 @@ chunksOfAs ps n (D.Stream step state) =
1615--
1372--
1616-- Same as the following but may be more efficient:
1373-- Same as the following but may be more efficient:
1617--
1374--
1618−-- >>> chunksOf n = Stream.foldMany (MutArray.createOf n)
1375+-- >>> chunksOf n = Stream.foldMany (MutArray.writeN n)
1619--
1376--
1620-- /Pre-release/
1377-- /Pre-release/
1621{-# INLINE_NORMAL chunksOf #-}
1378{-# INLINE_NORMAL chunksOf #-}
@@ -1624,14 +1381,14 @@ chunksOf :: forall m a. (MonadIO m, Unbox a)
1624-- XXX the idiomatic implementation leads to large regression in the D.reverse'
1381-- XXX the idiomatic implementation leads to large regression in the D.reverse'
1625-- benchmark. It seems it has difficulty producing optimized code when
1382-- benchmark. It seems it has difficulty producing optimized code when
1626-- converting to StreamK. Investigate GHC optimizations.
1383-- converting to StreamK. Investigate GHC optimizations.
1627−-- chunksOf n = D.foldMany (createOf n)
1384+-- chunksOf n = D.foldMany (writeN n)
1628chunksOf = chunksOfAs Unpinned
1385chunksOf = chunksOfAs Unpinned
1629
1386
1630-- | Like 'chunksOf' but creates pinned arrays.
1387-- | Like 'chunksOf' but creates pinned arrays.
1631{-# INLINE_NORMAL pinnedChunksOf #-}
1388{-# INLINE_NORMAL pinnedChunksOf #-}
1632pinnedChunksOf :: forall m a. (MonadIO m, Unbox a)
1389pinnedChunksOf :: forall m a. (MonadIO m, Unbox a)
1633 => Int -> D.Stream m a -> D.Stream m (MutArray a)
1390 => Int -> D.Stream m a -> D.Stream m (MutArray a)
1634−-- pinnedChunksOf n = D.foldMany (pinnedCreateOf n)
1391+-- pinnedChunksOf n = D.foldMany (pinnedWriteN n)
1635pinnedChunksOf = chunksOfAs Pinned
1392pinnedChunksOf = chunksOfAs Pinned
1636
1393
1637-- | When we are buffering a stream of unknown size into an array we do not
1394-- | When we are buffering a stream of unknown size into an array we do not
@@ -1664,10 +1421,16 @@ data FlattenState s contents a =
1664 OuterLoop s
1421 OuterLoop s
1665 | InnerLoop s contents !Int !Int
1422 | InnerLoop s contents !Int !Int
1666
1423
1424+-- | Use the "reader" unfold instead.
1425+--
1426+-- @concatChunks = unfoldMany reader@
1427+--
1428+-- We can try this if there are any fusion issues in the unfold.
1429+--
1667−{-# INLINE_NORMAL concatWith #-}
1430+{-# INLINE_NORMAL concatChunks #-}
1668−concatWith :: forall m a. (Monad m, Unbox a)
1431+concatChunks :: forall m a. (MonadIO m, Unbox a)
1669− => (forall b. IO b -> m b) -> D.Stream m (MutArray a) -> D.Stream m a
1432+ => D.Stream m (MutArray a) -> D.Stream m a
1670−concatWith liftio (D.Stream step state) = D.Stream step' (OuterLoop state)
1433+concatChunks (D.Stream step state) = D.Stream step' (OuterLoop state)
1671
1434
1672 where
1435 where
1673
1436
@@ -1684,30 +1447,24 @@ concatWith liftio (D.Stream step state) = D.Stream step' (OuterLoop state)
1684 return $ D.Skip $ OuterLoop st
1447 return $ D.Skip $ OuterLoop st
1685
1448
1686 step' _ (InnerLoop st contents p end) = do
1449 step' _ (InnerLoop st contents p end) = do
1687− x <- liftio $ peekAt p contents
1450+ x <- liftIO $ peekAt p contents
1688 return $ D.Yield x (InnerLoop st contents (INDEX_NEXT(p,a)) end)
1451 return $ D.Yield x (InnerLoop st contents (INDEX_NEXT(p,a)) end)
1689
1452
1453+{-# DEPRECATED flattenArrays "Please use \"unfoldMany reader\" instead." #-}
1454+flattenArrays :: forall m a. (MonadIO m, Unbox a)
1455+ => D.Stream m (MutArray a) -> D.Stream m a
1456+flattenArrays = concatChunks
1457+
1690−-- | Use the "reader" unfold instead.
1458+-- | Use the "readerRev" unfold instead.
1691--
1459--
1692−-- @concat = unfoldMany reader@
1460+-- @concatChunks = unfoldMany readerRev@
1693--
1461--
1694-- We can try this if there are any fusion issues in the unfold.
1462-- We can try this if there are any fusion issues in the unfold.
1695--
1463--
1696−{-# INLINE_NORMAL concat #-}
1464+{-# INLINE_NORMAL concatChunksRev #-}
1697−concat :: forall m a. (MonadIO m, Unbox a)
1465+concatChunksRev :: forall m a. (MonadIO m, Unbox a)
1698 => D.Stream m (MutArray a) -> D.Stream m a
1466 => D.Stream m (MutArray a) -> D.Stream m a
1699−concat = concatWith liftIO
1700−
1701−{-# DEPRECATED flattenArrays "Please use \"unfoldMany reader\" instead." #-}
1702−{-# INLINE flattenArrays #-}
1703−flattenArrays :: forall m a. (MonadIO m, Unbox a)
1704− => D.Stream m (MutArray a) -> D.Stream m a
1705−flattenArrays = concat
1706−
1707−{-# INLINE_NORMAL concatRevWith #-}
1708−concatRevWith :: forall m a. (Monad m, Unbox a)
1709− => (forall b. IO b -> m b) -> D.Stream m (MutArray a) -> D.Stream m a
1710−concatRevWith liftio (D.Stream step state) = D.Stream step' (OuterLoop state)
1467+concatChunksRev (D.Stream step state) = D.Stream step' (OuterLoop state)
1711
1468
1712 where
1469 where
1713
1470
@@ -1725,26 +1482,14 @@ concatRevWith liftio (D.Stream step state) = D.Stream step' (OuterLoop state)
1725 return $ D.Skip $ OuterLoop st
1482 return $ D.Skip $ OuterLoop st
1726
1483
1727 step' _ (InnerLoop st contents p start) = do
1484 step' _ (InnerLoop st contents p start) = do
1728− x <- liftio $ peekAt p contents
1485+ x <- liftIO $ peekAt p contents
1729 let cur = INDEX_PREV(p,a)
1486 let cur = INDEX_PREV(p,a)
1730 return $ D.Yield x (InnerLoop st contents cur start)
1487 return $ D.Yield x (InnerLoop st contents cur start)
1731
1488
1732−-- | Use the "readerRev" unfold instead.
1733−--
1734−-- @concat = unfoldMany readerRev@
1735−--
1736−-- We can try this if there are any fusion issues in the unfold.
1737−--
1738−{-# INLINE_NORMAL concatRev #-}
1739−concatRev :: forall m a. (MonadIO m, Unbox a)
1740− => D.Stream m (MutArray a) -> D.Stream m a
1741−concatRev = concatRevWith liftIO
1742−
1743{-# DEPRECATED flattenArraysRev "Please use \"unfoldMany readerRev\" instead." #-}
1489{-# DEPRECATED flattenArraysRev "Please use \"unfoldMany readerRev\" instead." #-}
1744−{-# INLINE flattenArraysRev #-}
1745flattenArraysRev :: forall m a. (MonadIO m, Unbox a)
1490flattenArraysRev :: forall m a. (MonadIO m, Unbox a)
1746 => D.Stream m (MutArray a) -> D.Stream m a
1491 => D.Stream m (MutArray a) -> D.Stream m a
1747−flattenArraysRev = concatRev
1492+flattenArraysRev = concatChunksRev
1748
1493
1749-------------------------------------------------------------------------------
1494-------------------------------------------------------------------------------
1750-- Unfolds
1495-- Unfolds
@@ -1863,11 +1608,11 @@ toList MutArray{..} = liftIO $ go arrStart
1863 x <- peekAt p arrContents
1608 x <- peekAt p arrContents
1864 (:) x <$> go (INDEX_NEXT(p,a))
1609 (:) x <$> go (INDEX_NEXT(p,a))
1865
1610
1866−{-# INLINE_NORMAL toStreamWith #-}
1611+{-# INLINE_NORMAL toStreamDWith #-}
1867−toStreamWith ::
1612+toStreamDWith ::
1868 forall m a. (Monad m, Unbox a)
1613 forall m a. (Monad m, Unbox a)
1869 => (forall b. IO b -> m b) -> MutArray a -> D.Stream m a
1614 => (forall b. IO b -> m b) -> MutArray a -> D.Stream m a
1870−toStreamWith liftio MutArray{..} = D.Stream step arrStart
1615+toStreamDWith liftio MutArray{..} = D.Stream step arrStart
1871
1616
1872 where
1617 where
1873
1618
@@ -1883,7 +1628,7 @@ toStreamWith liftio MutArray{..} = D.Stream step arrStart
1883--
1628--
1884{-# INLINE_NORMAL read #-}
1629{-# INLINE_NORMAL read #-}
1885read :: forall m a. (MonadIO m, Unbox a) => MutArray a -> D.Stream m a
1630read :: forall m a. (MonadIO m, Unbox a) => MutArray a -> D.Stream m a
1886−read = toStreamWith liftIO
1631+read = toStreamDWith liftIO
1887
1632
1888{-# INLINE toStreamKWith #-}
1633{-# INLINE toStreamKWith #-}
1889toStreamKWith ::
1634toStreamKWith ::
@@ -1902,11 +1647,11 @@ toStreamKWith liftio MutArray{..} = go arrStart
1902toStreamK :: forall m a. (MonadIO m, Unbox a) => MutArray a -> StreamK m a
1647toStreamK :: forall m a. (MonadIO m, Unbox a) => MutArray a -> StreamK m a
1903toStreamK = toStreamKWith liftIO
1648toStreamK = toStreamKWith liftIO
1904
1649
1905−{-# INLINE_NORMAL toStreamRevWith #-}
1650+{-# INLINE_NORMAL toStreamDRevWith #-}
1906−toStreamRevWith ::
1651+toStreamDRevWith ::
1907 forall m a. (Monad m, Unbox a)
1652 forall m a. (Monad m, Unbox a)
1908 => (forall b. IO b -> m b) -> MutArray a -> D.Stream m a
1653 => (forall b. IO b -> m b) -> MutArray a -> D.Stream m a
1909−toStreamRevWith liftio MutArray{..} =
1654+toStreamDRevWith liftio MutArray{..} =
1910 let p = INDEX_PREV(arrEnd,a)
1655 let p = INDEX_PREV(arrEnd,a)
1911 in D.Stream step p
1656 in D.Stream step p
1912
1657
@@ -1924,7 +1669,7 @@ toStreamRevWith liftio MutArray{..} =
1924--
1669--
1925{-# INLINE_NORMAL readRev #-}
1670{-# INLINE_NORMAL readRev #-}
1926readRev :: forall m a. (MonadIO m, Unbox a) => MutArray a -> D.Stream m a
1671readRev :: forall m a. (MonadIO m, Unbox a) => MutArray a -> D.Stream m a
1927−readRev = toStreamRevWith liftIO
1672+readRev = toStreamDRevWith liftIO
1928
1673
1929{-# INLINE toStreamKRevWith #-}
1674{-# INLINE toStreamKRevWith #-}
1930toStreamKRevWith ::
1675toStreamKRevWith ::
@@ -1973,7 +1718,7 @@ foldr f z arr = D.foldr f z $ read arr
1973
1718
1974-- XXX Keep the bound intact to not lose any free space? Perf impact?
1719-- XXX Keep the bound intact to not lose any free space? Perf impact?
1975
1720
1976−-- | @unsafeAppendN n arr@ appends up to @n@ input items to the supplied
1721+-- | @writeAppendNUnsafe n arr@ appends up to @n@ input items to the supplied
1977-- array.
1722-- array.
1978--
1723--
1979-- Unsafe: Do not drive the fold beyond @n@ elements, it will lead to memory
1724-- Unsafe: Do not drive the fold beyond @n@ elements, it will lead to memory
@@ -1982,12 +1727,13 @@ foldr f z arr = D.foldr f z $ read arr
1982-- Any free space left in the array after appending @n@ elements is lost.
1727-- Any free space left in the array after appending @n@ elements is lost.
1983--
1728--
1984-- /Internal/
1729-- /Internal/
1985−{-# INLINE_NORMAL unsafeAppendN #-}
1730+{-# INLINE_NORMAL writeAppendNUnsafe #-}
1986−unsafeAppendN :: forall m a. (MonadIO m, Unbox a) =>
1731+writeAppendNUnsafe :: forall m a. (MonadIO m, Unbox a) =>
1987 Int
1732 Int
1988 -> m (MutArray a)
1733 -> m (MutArray a)
1989 -> Fold m a (MutArray a)
1734 -> Fold m a (MutArray a)
1735+writeAppendNUnsafe n action =
1990−unsafeAppendN n action = fmap fromArrayUnsafe $ FL.foldlM' step initial
1736+ fmap fromArrayUnsafe $ FL.foldlM' step initial
1991
1737
1992 where
1738 where
1993
1739
@@ -2000,7 +1746,7 @@ unsafeAppendN n action = fmap fromArrayUnsafe $ FL.foldlM' step initial
2000 -- otherwise we lose that space.
1746 -- otherwise we lose that space.
2001 arr1 <-
1747 arr1 <-
2002 if free < needed
1748 if free < needed
2003− then noinline reallocWith "unsafeAppendN" (+ needed) needed arr
1749+ then noinline reallocWith "writeAppendNUnsafeWith" (+ needed) needed arr
2004 else return arr
1750 else return arr
2005 return $ toArrayUnsafe arr1
1751 return $ toArrayUnsafe arr1
2006
1752
@@ -2008,51 +1754,30 @@ unsafeAppendN n action = fmap fromArrayUnsafe $ FL.foldlM' step initial
2008 liftIO $ pokeAt end contents x
1754 liftIO $ pokeAt end contents x
2009 return $ ArrayUnsafe contents start (INDEX_NEXT(end,a))
1755 return $ ArrayUnsafe contents start (INDEX_NEXT(end,a))
2010
1756
2011−{-# DEPRECATED writeAppendNUnsafe "Please use unsafeAppendN instead." #-}
2012−{-# INLINE writeAppendNUnsafe #-}
2013−writeAppendNUnsafe :: forall m a. (MonadIO m, Unbox a) =>
2014− Int
2015− -> m (MutArray a)
2016− -> Fold m a (MutArray a)
2017−writeAppendNUnsafe = unsafeAppendN
2018−
2019-- | Append @n@ elements to an existing array. Any free space left in the array
1757-- | Append @n@ elements to an existing array. Any free space left in the array
2020-- after appending @n@ elements is lost.
1758-- after appending @n@ elements is lost.
2021--
1759--
2022−-- >>> appendN n initial = Fold.take n (MutArray.unsafeAppendN n initial)
1760+-- >>> writeAppendN n initial = Fold.take n (MutArray.writeAppendNUnsafe n initial)
2023--
1761--
2024−{-# INLINE_NORMAL appendN #-}
1762+{-# INLINE_NORMAL writeAppendN #-}
2025−appendN :: forall m a. (MonadIO m, Unbox a) =>
2026− Int -> m (MutArray a) -> Fold m a (MutArray a)
2027−appendN n initial = FL.take n (unsafeAppendN n initial)
2028−
2029−-- XXX Deprecate in major
2030−-- {-# DEPRECATED writeAppendN "Please use appendN instead." #-}
2031−{-# INLINE writeAppendN #-}
2032writeAppendN :: forall m a. (MonadIO m, Unbox a) =>
1763writeAppendN :: forall m a. (MonadIO m, Unbox a) =>
2033 Int -> m (MutArray a) -> Fold m a (MutArray a)
1764 Int -> m (MutArray a) -> Fold m a (MutArray a)
2034−writeAppendN = appendN
1765+writeAppendN n initial = FL.take n (writeAppendNUnsafe n initial)
2035
1766
2036−-- | @appendWith realloc action@ mutates the array generated by @action@ to
1767+-- | @writeAppendWith realloc action@ mutates the array generated by @action@ to
2037-- append the input stream. If there is no reserved space available in the
1768-- append the input stream. If there is no reserved space available in the
2038-- array it is reallocated to a size in bytes determined by @realloc oldSize@,
1769-- array it is reallocated to a size in bytes determined by @realloc oldSize@,
2039-- where @oldSize@ is the current size of the array in bytes.
1770-- where @oldSize@ is the current size of the array in bytes.
2040--
1771--
2041-- Note that the returned array may be a mutated version of original array.
1772-- Note that the returned array may be a mutated version of original array.
2042--
1773--
2043−-- >>> appendWith sizer = Fold.foldlM' (MutArray.snocWith sizer)
1774+-- >>> writeAppendWith sizer = Fold.foldlM' (MutArray.snocWith sizer)
2044--
1775--
2045-- /Pre-release/
1776-- /Pre-release/
2046−{-# INLINE appendWith #-}
2047−appendWith :: forall m a. (MonadIO m, Unbox a) =>
2048− (Int -> Int) -> m (MutArray a) -> Fold m a (MutArray a)
2049−appendWith sizer = FL.foldlM' (snocWith sizer)
2050−
2051−{-# DEPRECATED writeAppendWith "Please use appendWith instead." #-}
2052{-# INLINE writeAppendWith #-}
1777{-# INLINE writeAppendWith #-}
2053writeAppendWith :: forall m a. (MonadIO m, Unbox a) =>
1778writeAppendWith :: forall m a. (MonadIO m, Unbox a) =>
2054 (Int -> Int) -> m (MutArray a) -> Fold m a (MutArray a)
1779 (Int -> Int) -> m (MutArray a) -> Fold m a (MutArray a)
2055−writeAppendWith = appendWith
1780+writeAppendWith sizer = FL.foldlM' (snocWith sizer)
2056
1781
2057-- | @append action@ mutates the array generated by @action@ to append the
1782-- | @append action@ mutates the array generated by @action@ to append the
2058-- input stream. If there is no reserved space available in the array it is
1783-- input stream. If there is no reserved space available in the array it is
@@ -2060,33 +1785,26 @@ writeAppendWith = appendWith
2060--
1785--
2061-- Note that the returned array may be a mutated version of original array.
1786-- Note that the returned array may be a mutated version of original array.
2062--
1787--
2063−-- >>> append = MutArray.appendWith (* 2)
1788+-- >>> writeAppend = MutArray.writeAppendWith (* 2)
2064--
1789--
2065−{-# INLINE append #-}
2066−append :: forall m a. (MonadIO m, Unbox a) =>
2067− m (MutArray a) -> Fold m a (MutArray a)
2068−append = appendWith (* 2)
2069−
2070−-- XXX Deprecate in major
2071−-- {-# DEPRECATED writeAppend "Please use append instead." #-}
2072{-# INLINE writeAppend #-}
1790{-# INLINE writeAppend #-}
2073writeAppend :: forall m a. (MonadIO m, Unbox a) =>
1791writeAppend :: forall m a. (MonadIO m, Unbox a) =>
2074 m (MutArray a) -> Fold m a (MutArray a)
1792 m (MutArray a) -> Fold m a (MutArray a)
2075−writeAppend = append
1793+writeAppend = writeAppendWith (* 2)
2076
1794
2077-- XXX We can carry bound as well in the state to make sure we do not lose the
1795-- XXX We can carry bound as well in the state to make sure we do not lose the
2078-- remaining capacity. Need to check perf impact.
1796-- remaining capacity. Need to check perf impact.
2079--
1797--
2080−-- | Like 'unsafeCreateOf' but takes a new array allocator @alloc size@
1798+-- | Like 'writeNUnsafe' but takes a new array allocator @alloc size@ function
2081−-- function as argument.
1799+-- as argument.
2082--
1800--
2083−-- >>> unsafeCreateOfWith alloc n = MutArray.unsafeAppendN (alloc n) n
1801+-- >>> writeNWithUnsafe alloc n = MutArray.writeAppendNUnsafe (alloc n) n
2084--
1802--
2085-- /Pre-release/
1803-- /Pre-release/
2086−{-# INLINE_NORMAL unsafeCreateOfWith #-}
1804+{-# INLINE_NORMAL writeNWithUnsafe #-}
2087−unsafeCreateOfWith :: forall m a. (MonadIO m, Unbox a)
1805+writeNWithUnsafe :: forall m a. (MonadIO m, Unbox a)
2088 => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
1806 => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
2089−unsafeCreateOfWith alloc n = fromArrayUnsafe <$> FL.foldlM' step initial
1807+writeNWithUnsafe alloc n = fromArrayUnsafe <$> FL.foldlM' step initial
2090
1808
2091 where
1809 where
2092
1810
@@ -2097,64 +1815,40 @@ unsafeCreateOfWith alloc n = fromArrayUnsafe <$> FL.foldlM' step initial
2097 return
1815 return
2098 $ ArrayUnsafe contents start (INDEX_NEXT(end,a))
1816 $ ArrayUnsafe contents start (INDEX_NEXT(end,a))
2099
1817
2100−{-# DEPRECATED writeNWithUnsafe "Please use unsafeCreateOfWith instead." #-}
2101−{-# INLINE writeNWithUnsafe #-}
2102−writeNWithUnsafe :: forall m a. (MonadIO m, Unbox a)
2103− => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
2104−writeNWithUnsafe = unsafeCreateOfWith
2105−
2106{-# INLINE_NORMAL writeNUnsafeAs #-}
1818{-# INLINE_NORMAL writeNUnsafeAs #-}
2107writeNUnsafeAs :: forall m a. (MonadIO m, Unbox a)
1819writeNUnsafeAs :: forall m a. (MonadIO m, Unbox a)
2108 => PinnedState -> Int -> Fold m a (MutArray a)
1820 => PinnedState -> Int -> Fold m a (MutArray a)
2109−writeNUnsafeAs ps = unsafeCreateOfWith (newAs ps)
1821+writeNUnsafeAs ps = writeNWithUnsafe (newAs ps)
2110
1822
2111−-- | Like 'createOf' but does not check the array bounds when writing. The fold
1823+-- | Like 'writeN' but does not check the array bounds when writing. The fold
2112-- driver must not call the step function more than 'n' times otherwise it will
1824-- driver must not call the step function more than 'n' times otherwise it will
2113-- corrupt the memory and crash. This function exists mainly because any
1825-- corrupt the memory and crash. This function exists mainly because any
2114-- conditional in the step function blocks fusion causing 10x performance
1826-- conditional in the step function blocks fusion causing 10x performance
2115-- slowdown.
1827-- slowdown.
2116--
1828--
2117−-- >>> unsafeCreateOf = MutArray.unsafeCreateOfWith MutArray.emptyOf
1829+-- >>> writeNUnsafe = MutArray.writeNWithUnsafe MutArray.new
2118--
1830--
2119−{-# INLINE_NORMAL unsafeCreateOf #-}
2120−unsafeCreateOf :: forall m a. (MonadIO m, Unbox a)
2121− => Int -> Fold m a (MutArray a)
2122−unsafeCreateOf = writeNUnsafeAs Unpinned
2123−
2124−{-# DEPRECATED writeNUnsafe "Please use unsafeCreateOf instead." #-}
2125−{-# INLINE writeNUnsafe #-}
1831+{-# INLINE_NORMAL writeNUnsafe #-}
2126writeNUnsafe :: forall m a. (MonadIO m, Unbox a)
1832writeNUnsafe :: forall m a. (MonadIO m, Unbox a)
2127 => Int -> Fold m a (MutArray a)
1833 => Int -> Fold m a (MutArray a)
2128−writeNUnsafe = unsafeCreateOf
1834+writeNUnsafe = writeNUnsafeAs Unpinned
2129−
2130−-- | Like 'unsafeCreateOf' but creates a pinned array.
2131−{-# INLINE_NORMAL unsafePinnedCreateOf #-}
2132−unsafePinnedCreateOf :: forall m a. (MonadIO m, Unbox a)
2133− => Int -> Fold m a (MutArray a)
2134−unsafePinnedCreateOf = writeNUnsafeAs Pinned
2135
1835
2136−{-# DEPRECATED pinnedWriteNUnsafe "Please use unsafePinnedCreateOf instead." #-}
1836+-- | Like 'writeNUnsafe' but creates a pinned array.
2137−{-# INLINE pinnedWriteNUnsafe #-}
1837+{-# INLINE_NORMAL pinnedWriteNUnsafe #-}
2138pinnedWriteNUnsafe :: forall m a. (MonadIO m, Unbox a)
1838pinnedWriteNUnsafe :: forall m a. (MonadIO m, Unbox a)
2139 => Int -> Fold m a (MutArray a)
1839 => Int -> Fold m a (MutArray a)
2140−pinnedWriteNUnsafe = unsafePinnedCreateOf
1840+pinnedWriteNUnsafe = writeNUnsafeAs Pinned
2141
1841
2142−-- | @createOfWith alloc n@ folds a maximum of @n@ elements into an array
1842+-- | @writeNWith alloc n@ folds a maximum of @n@ elements into an array
2143-- allocated using the @alloc@ function.
1843-- allocated using the @alloc@ function.
2144--
1844--
2145−-- >>> createOfWith alloc n = Fold.take n (MutArray.unsafeCreateOfWith alloc n)
1845+-- >>> writeNWith alloc n = Fold.take n (MutArray.writeNWithUnsafe alloc n)
2146−-- >>> createOfWith alloc n = MutArray.appendN (alloc n) n
1846+-- >>> writeNWith alloc n = MutArray.writeAppendN (alloc n) n
2147--
1847--
2148−{-# INLINE_NORMAL createOfWith #-}
1848+{-# INLINE_NORMAL writeNWith #-}
2149−createOfWith :: forall m a. (MonadIO m, Unbox a)
2150− => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
2151−createOfWith alloc n = FL.take n (unsafeCreateOfWith alloc n)
2152−
2153−-- {-# DEPRECATED writeNWith "Please use createOfWith instead." #-}
2154−{-# INLINE writeNWith #-}
2155writeNWith :: forall m a. (MonadIO m, Unbox a)
1849writeNWith :: forall m a. (MonadIO m, Unbox a)
2156 => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
1850 => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
2157−writeNWith = createOfWith
1851+writeNWith alloc n = FL.take n (writeNWithUnsafe alloc n)
2158
1852
2159{-# INLINE_NORMAL writeNAs #-}
1853{-# INLINE_NORMAL writeNAs #-}
2160writeNAs ::
1854writeNAs ::
@@ -2162,42 +1856,28 @@ writeNAs ::
2162 => PinnedState
1856 => PinnedState
2163 -> Int
1857 -> Int
2164 -> Fold m a (MutArray a)
1858 -> Fold m a (MutArray a)
2165−writeNAs ps = createOfWith (newAs ps)
1859+writeNAs ps = writeNWith (newAs ps)
2166
1860
2167−-- | @createOf n@ folds a maximum of @n@ elements from the input stream to an
1861+-- | @writeN n@ folds a maximum of @n@ elements from the input stream to an
2168-- 'MutArray'.
1862-- 'MutArray'.
2169--
1863--
2170−-- >>> createOf = MutArray.createOfWith MutArray.new
1864+-- >>> writeN = MutArray.writeNWith MutArray.new
2171−-- >>> createOf n = Fold.take n (MutArray.unsafeCreateOf n)
1865+-- >>> writeN n = Fold.take n (MutArray.writeNUnsafe n)
2172−-- >>> createOf n = MutArray.appendN n (MutArray.emptyOf n)
1866+-- >>> writeN n = MutArray.writeAppendN n (MutArray.new n)
2173--
1867--
2174−{-# INLINE_NORMAL createOf #-}
1868+{-# INLINE_NORMAL writeN #-}
2175−createOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
2176−createOf = writeNAs Unpinned
2177−
2178−-- XXX Deprecate in major
2179−-- {-# DEPRECATED writeN "Please use createOf instead." #-}
2180−{-# INLINE writeN #-}
2181writeN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
1869writeN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
2182−writeN = createOf
1870+writeN = writeNAs Unpinned
2183
1871
2184−-- | Like 'createOf' but creates a pinned array.
1872+-- | Like 'writeN' but creates a pinned array.
2185−{-# INLINE_NORMAL pinnedCreateOf #-}
2186−pinnedCreateOf ::
2187− forall m a. (MonadIO m, Unbox a)
2188− => Int
2189− -> Fold m a (MutArray a)
2190−pinnedCreateOf = writeNAs Pinned
2191−
2192−{-# DEPRECATED pinnedWriteN "Please use pinnedCreateOf instead." #-}
2193−{-# INLINE pinnedWriteN #-}
1873+{-# INLINE_NORMAL pinnedWriteN #-}
2194pinnedWriteN ::
1874pinnedWriteN ::
2195 forall m a. (MonadIO m, Unbox a)
1875 forall m a. (MonadIO m, Unbox a)
2196 => Int
1876 => Int
2197 -> Fold m a (MutArray a)
1877 -> Fold m a (MutArray a)
2198−pinnedWriteN = pinnedCreateOf
1878+pinnedWriteN = writeNAs Pinned
2199
1879
2200−-- | Like unsafeCreateOfWith but writes the array in reverse order.
1880+-- | Like writeNWithUnsafe but writes the array in reverse order.
2201--
1881--
2202-- /Internal/
1882-- /Internal/
2203{-# INLINE_NORMAL writeRevNWithUnsafe #-}
1883{-# INLINE_NORMAL writeRevNWithUnsafe #-}
@@ -2218,7 +1898,7 @@ writeRevNWithUnsafe alloc n = fromArrayUnsafe <$> FL.foldlM' step initial
2218 return
1898 return
2219 $ ArrayUnsafe contents ptr end
1899 $ ArrayUnsafe contents ptr end
2220
1900
2221−-- | Like createOfWith but writes the array in reverse order.
1901+-- | Like writeNWith but writes the array in reverse order.
2222--
1902--
2223-- /Internal/
1903-- /Internal/
2224{-# INLINE_NORMAL writeRevNWith #-}
1904{-# INLINE_NORMAL writeRevNWith #-}
@@ -2226,36 +1906,31 @@ writeRevNWith :: forall m a. (MonadIO m, Unbox a)
2226 => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
1906 => (Int -> m (MutArray a)) -> Int -> Fold m a (MutArray a)
2227writeRevNWith alloc n = FL.take n (writeRevNWithUnsafe alloc n)
1907writeRevNWith alloc n = FL.take n (writeRevNWithUnsafe alloc n)
2228
1908
2229−-- | Like 'createOf' but writes the array in reverse order.
1909+-- | Like writeN but writes the array in reverse order.
2230--
1910--
2231-- /Pre-release/
1911-- /Pre-release/
2232−{-# INLINE_NORMAL revCreateOf #-}
1912+{-# INLINE_NORMAL writeRevN #-}
2233−revCreateOf :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
2234−revCreateOf = writeRevNWith new
2235−
2236−{-# DEPRECATED writeRevN "Please use revCreateOf instead." #-}
2237−{-# INLINE writeRevN #-}
2238writeRevN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
1913writeRevN :: forall m a. (MonadIO m, Unbox a) => Int -> Fold m a (MutArray a)
2239−writeRevN = revCreateOf
1914+writeRevN = writeRevNWith new
2240
1915
2241-- | @pinnedWriteNAligned align n@ folds a maximum of @n@ elements from the
1916-- | @pinnedWriteNAligned align n@ folds a maximum of @n@ elements from the
2242-- input stream to a 'MutArray' aligned to the given size.
1917-- input stream to a 'MutArray' aligned to the given size.
2243--
1918--
2244−-- >>> pinnedWriteNAligned align = MutArray.createOfWith (MutArray.pinnedNewAligned align)
1919+-- >>> pinnedWriteNAligned align = MutArray.writeNWith (MutArray.pinnedNewAligned align)
2245−-- >>> pinnedWriteNAligned align n = MutArray.appendN n (MutArray.pinnedNewAligned align n)
1920+-- >>> pinnedWriteNAligned align n = MutArray.writeAppendN n (MutArray.pinnedNewAligned align n)
2246--
1921--
2247-- /Pre-release/
1922-- /Pre-release/
2248--
1923--
2249{-# INLINE_NORMAL pinnedWriteNAligned #-}
1924{-# INLINE_NORMAL pinnedWriteNAligned #-}
2250pinnedWriteNAligned :: forall m a. (MonadIO m, Unbox a)
1925pinnedWriteNAligned :: forall m a. (MonadIO m, Unbox a)
2251 => Int -> Int -> Fold m a (MutArray a)
1926 => Int -> Int -> Fold m a (MutArray a)
2252−pinnedWriteNAligned align = createOfWith (pinnedNewAligned align)
1927+pinnedWriteNAligned align = writeNWith (pinnedNewAligned align)
2253
1928
2254-- XXX Buffer to a list instead?
1929-- XXX Buffer to a list instead?
2255
1930
2256-- | Buffer a stream into a stream of arrays.
1931-- | Buffer a stream into a stream of arrays.
2257--
1932--
2258−-- >>> buildChunks n = Fold.many (MutArray.createOf n) Fold.toStreamK
1933+-- >>> buildChunks n = Fold.many (MutArray.writeN n) Fold.toStreamK
2259--
1934--
2260-- Breaking an array into an array stream can be useful to consume a large
1935-- Breaking an array into an array stream can be useful to consume a large
2261-- array sequentially such that memory of the array is released incrementatlly.
1936-- array sequentially such that memory of the array is released incrementatlly.
@@ -2267,10 +1942,9 @@ pinnedWriteNAligned align = createOfWith (pinnedNewAligned align)
2267{-# INLINE_NORMAL buildChunks #-}
1942{-# INLINE_NORMAL buildChunks #-}
2268buildChunks :: (MonadIO m, Unbox a) =>
1943buildChunks :: (MonadIO m, Unbox a) =>
2269 Int -> Fold m a (StreamK n (MutArray a))
1944 Int -> Fold m a (StreamK n (MutArray a))
2270−buildChunks n = FL.many (createOf n) FL.toStreamK
1945+buildChunks n = FL.many (writeN n) FL.toStreamK
2271
1946
2272{-# DEPRECATED writeChunks "Please use buildChunks instead." #-}
1947{-# DEPRECATED writeChunks "Please use buildChunks instead." #-}
2273−{-# INLINE writeChunks #-}
2274writeChunks :: (MonadIO m, Unbox a) =>
1948writeChunks :: (MonadIO m, Unbox a) =>
2275 Int -> Fold m a (StreamK n (MutArray a))
1949 Int -> Fold m a (StreamK n (MutArray a))
2276writeChunks = buildChunks
1950writeChunks = buildChunks
@@ -2278,29 +1952,29 @@ writeChunks = buildChunks
2278{-# INLINE_NORMAL writeWithAs #-}
1952{-# INLINE_NORMAL writeWithAs #-}
2279writeWithAs :: forall m a. (MonadIO m, Unbox a)
1953writeWithAs :: forall m a. (MonadIO m, Unbox a)
2280 => PinnedState -> Int -> Fold m a (MutArray a)
1954 => PinnedState -> Int -> Fold m a (MutArray a)
2281−-- writeWithAs ps n = FL.rmapM rightSize $ appendWith (* 2) (newAs ps n)
1955+-- writeWithAs ps n = FL.rmapM rightSize $ writeAppendWith (* 2) (newAs ps n)
2282writeWithAs ps elemCount =
1956writeWithAs ps elemCount =
2283 FL.rmapM extract $ FL.foldlM' step initial
1957 FL.rmapM extract $ FL.foldlM' step initial
2284
1958
2285 where
1959 where
2286
1960
2287 initial = do
1961 initial = do
2288− when (elemCount < 0) $ error "createWith: elemCount is negative"
1962+ when (elemCount < 0) $ error "writeWith: elemCount is negative"
2289− newAs ps elemCount
1963+ liftIO $ newAs ps elemCount
2290
1964
2291 step arr@(MutArray _ start end bound) x
1965 step arr@(MutArray _ start end bound) x
2292 | INDEX_NEXT(end,a) > bound = do
1966 | INDEX_NEXT(end,a) > bound = do
2293 let oldSize = end - start
1967 let oldSize = end - start
2294 newSize = max (oldSize * 2) 1
1968 newSize = max (oldSize * 2) 1
2295− arr1 <- liftIO $ reallocExplicitAs ps (SIZE_OF(a)) newSize arr
1969+ arr1 <- liftIO $ reallocExplicit (SIZE_OF(a)) newSize arr
2296 snocUnsafe arr1 x
1970 snocUnsafe arr1 x
2297 step arr x = snocUnsafe arr x
1971 step arr x = snocUnsafe arr x
2298
1972
2299 extract = liftIO . rightSize
1973 extract = liftIO . rightSize
2300
1974
2301−-- XXX Compare createWith with fromStreamD which uses an array of streams
1975+-- XXX Compare writeWith with fromStreamD which uses an array of streams
2302-- implementation. We can write this using buildChunks above if that is faster.
1976-- implementation. We can write this using buildChunks above if that is faster.
2303−-- If createWith is faster then we should use that to implement
1977+-- If writeWith is faster then we should use that to implement
2304-- fromStreamD.
1978-- fromStreamD.
2305--
1979--
2306-- XXX The realloc based implementation needs to make one extra copy if we use
1980-- XXX The realloc based implementation needs to make one extra copy if we use
@@ -2315,56 +1989,39 @@ writeWithAs ps elemCount =
2315-- XXX check if GHC's memory allocator is efficient enough. We can try the C
1989-- XXX check if GHC's memory allocator is efficient enough. We can try the C
2316-- malloc to compare against.
1990-- malloc to compare against.
2317
1991
2318−-- | @createWith minCount@ folds the whole input to a single array. The array
1992+-- | @writeWith minCount@ folds the whole input to a single array. The array
2319-- starts at a size big enough to hold minCount elements, the size is doubled
1993-- starts at a size big enough to hold minCount elements, the size is doubled
2320-- every time the array needs to be grown.
1994-- every time the array needs to be grown.
2321--
1995--
2322-- /Caution! Do not use this on infinite streams./
1996-- /Caution! Do not use this on infinite streams./
2323--
1997--
2324−-- >>> f n = MutArray.appendWith (* 2) (MutArray.emptyOf n)
1998+-- >>> f n = MutArray.writeAppendWith (* 2) (MutArray.new n)
2325−-- >>> createWith n = Fold.rmapM MutArray.rightSize (f n)
1999+-- >>> writeWith n = Fold.rmapM MutArray.rightSize (f n)
2326−-- >>> createWith n = Fold.rmapM MutArray.fromChunksK (MutArray.buildChunks n)
2000+-- >>> writeWith n = Fold.rmapM MutArray.fromArrayStreamK (MutArray.buildChunks n)
2327--
2001--
2328-- /Pre-release/
2002-- /Pre-release/
2329−{-# INLINE_NORMAL createWith #-}
2003+{-# INLINE_NORMAL writeWith #-}
2330−createWith :: forall m a. (MonadIO m, Unbox a)
2331− => Int -> Fold m a (MutArray a)
2332−-- createWith n = FL.rmapM rightSize $ appendWith (* 2) (emptyOf n)
2333−createWith = writeWithAs Unpinned
2334−
2335−{-# DEPRECATED writeWith "Please use createWith instead." #-}
2336−{-# INLINE writeWith #-}
2337writeWith :: forall m a. (MonadIO m, Unbox a)
2004writeWith :: forall m a. (MonadIO m, Unbox a)
2338 => Int -> Fold m a (MutArray a)
2005 => Int -> Fold m a (MutArray a)
2339−writeWith = createWith
2006+-- writeWith n = FL.rmapM rightSize $ writeAppendWith (* 2) (new n)
2007+writeWith = writeWithAs Unpinned
2340
2008
2341-- | Fold the whole input to a single array.
2009-- | Fold the whole input to a single array.
2342--
2010--
2343−-- Same as 'createWith' using an initial array size of 'arrayChunkBytes' bytes
2011+-- Same as 'writeWith' using an initial array size of 'arrayChunkBytes' bytes
2344-- rounded up to the element size.
2012-- rounded up to the element size.
2345--
2013--
2346-- /Caution! Do not use this on infinite streams./
2014-- /Caution! Do not use this on infinite streams./
2347--
2015--
2348−{-# INLINE create #-}
2349−create :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
2350−create = createWith (allocBytesToElemCount (undefined :: a) arrayChunkBytes)
2351−
2352−-- XXX Deprecate in major
2353−-- {-# DEPRECATED write "Please use create instead." #-}
2354{-# INLINE write #-}
2016{-# INLINE write #-}
2355write :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
2017write :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
2356−write = create
2018+write = writeWith (allocBytesToElemCount (undefined :: a) arrayChunkBytes)
2357
2019
2358−-- | Like 'create' but creates a pinned array.
2020+-- | Like 'write' but creates a pinned array.
2359−{-# INLINE pinnedCreate #-}
2360−pinnedCreate :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
2361−pinnedCreate =
2362− writeWithAs Pinned (allocBytesToElemCount (undefined :: a) arrayChunkBytes)
2363−
2364−{-# DEPRECATED pinnedWrite "Please use pinnedCreate instead." #-}
2365{-# INLINE pinnedWrite #-}
2021{-# INLINE pinnedWrite #-}
2366pinnedWrite :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
2022pinnedWrite :: forall m a. (MonadIO m, Unbox a) => Fold m a (MutArray a)
2367−pinnedWrite = pinnedCreate
2023+pinnedWrite =
2024+ writeWithAs Pinned (allocBytesToElemCount (undefined :: a) arrayChunkBytes)
2368
2025
2369-------------------------------------------------------------------------------
2026-------------------------------------------------------------------------------
2370-- construct from streams, known size
2027-- construct from streams, known size
@@ -2374,7 +2031,7 @@ pinnedWrite = pinnedCreate
2374fromStreamDNAs :: forall m a. (MonadIO m, Unbox a)
2031fromStreamDNAs :: forall m a. (MonadIO m, Unbox a)
2375 => PinnedState -> Int -> D.Stream m a -> m (MutArray a)
2032 => PinnedState -> Int -> D.Stream m a -> m (MutArray a)
2376fromStreamDNAs ps limit str = do
2033fromStreamDNAs ps limit str = do
2377− (arr :: MutArray a) <- newAs ps limit
2034+ (arr :: MutArray a) <- liftIO $ newAs ps limit
2378 end <- D.foldlM' (fwrite (arrContents arr)) (return $ arrEnd arr) $ D.take limit str
2035 end <- D.foldlM' (fwrite (arrContents arr)) (return $ arrEnd arr) $ D.take limit str
2379 return $ arr {arrEnd = end}
2036 return $ arr {arrEnd = end}
2380
2037
@@ -2384,21 +2041,15 @@ fromStreamDNAs ps limit str = do
2384 liftIO $ pokeAt ptr arrContents x
2041 liftIO $ pokeAt ptr arrContents x
2385 return $ INDEX_NEXT(ptr,a)
2042 return $ INDEX_NEXT(ptr,a)
2386
2043
2387−-- | Use the 'createOf' fold instead.
2044+-- | Use the 'writeN' fold instead.
2388--
2045--
2389−-- >>> fromStreamN n = Stream.fold (MutArray.createOf n)
2046+-- >>> fromStreamDN n = Stream.fold (MutArray.writeN n)
2390--
2047--
2391−{-# INLINE_NORMAL fromStreamN #-}
2392−fromStreamN :: forall m a. (MonadIO m, Unbox a)
2393− => Int -> D.Stream m a -> m (MutArray a)
2394−-- fromStreamDN n = D.fold (createOf n)
2395−fromStreamN = fromStreamDNAs Unpinned
2396−
2397−{-# DEPRECATED fromStreamDN "Please use fromStreamN instead." #-}
2398−{-# INLINE fromStreamDN #-}
2048+{-# INLINE_NORMAL fromStreamDN #-}
2399fromStreamDN :: forall m a. (MonadIO m, Unbox a)
2049fromStreamDN :: forall m a. (MonadIO m, Unbox a)
2400 => Int -> D.Stream m a -> m (MutArray a)
2050 => Int -> D.Stream m a -> m (MutArray a)
2051+-- fromStreamDN n = D.fold (writeN n)
2401−fromStreamDN = fromStreamN
2052+fromStreamDN = fromStreamDNAs Unpinned
2402
2053
2403-- | Create a 'MutArray' from the first N elements of a list. The array is
2054-- | Create a 'MutArray' from the first N elements of a list. The array is
2404-- allocated to size N, if the list terminates before N elements then the
2055-- allocated to size N, if the list terminates before N elements then the
@@ -2418,20 +2069,20 @@ pinnedFromListN n xs = fromStreamDNAs Pinned n $ D.fromList xs
2418-- /Pre-release/
2069-- /Pre-release/
2419{-# INLINE fromListRevN #-}
2070{-# INLINE fromListRevN #-}
2420fromListRevN :: (MonadIO m, Unbox a) => Int -> [a] -> m (MutArray a)
2071fromListRevN :: (MonadIO m, Unbox a) => Int -> [a] -> m (MutArray a)
2421−fromListRevN n xs = D.fold (revCreateOf n) $ D.fromList xs
2072+fromListRevN n xs = D.fold (writeRevN n) $ D.fromList xs
2422
2073
2423-- | Convert a pure stream in Identity monad to a mutable array.
2074-- | Convert a pure stream in Identity monad to a mutable array.
2424{-# INLINABLE fromPureStreamN #-}
2075{-# INLINABLE fromPureStreamN #-}
2425fromPureStreamN :: (MonadIO m, Unbox a) =>
2076fromPureStreamN :: (MonadIO m, Unbox a) =>
2426 Int -> Stream Identity a -> m (MutArray a)
2077 Int -> Stream Identity a -> m (MutArray a)
2427fromPureStreamN n xs =
2078fromPureStreamN n xs =
2428− D.fold (createOf n) $ D.morphInner (return . runIdentity) xs
2079+ liftIO $ D.fold (writeN n) $ D.morphInner (return . runIdentity) xs
2429
2080
2430-- | Convert a pure stream in Identity monad to a mutable array.
2081-- | Convert a pure stream in Identity monad to a mutable array.
2431{-# INLINABLE fromPureStream #-}
2082{-# INLINABLE fromPureStream #-}
2432fromPureStream :: (MonadIO m, Unbox a) => Stream Identity a -> m (MutArray a)
2083fromPureStream :: (MonadIO m, Unbox a) => Stream Identity a -> m (MutArray a)
2433fromPureStream xs =
2084fromPureStream xs =
2434− D.fold create $ D.morphInner (return . runIdentity) xs
2085+ liftIO $ D.fold write $ D.morphInner (return . runIdentity) xs
2435
2086
2436{-# INLINABLE fromPtrN #-}
2087{-# INLINABLE fromPtrN #-}
2437fromPtrN :: MonadIO m => Int -> Ptr Word8 -> m (MutArray Word8)
2088fromPtrN :: MonadIO m => Int -> Ptr Word8 -> m (MutArray Word8)
@@ -2440,7 +2091,7 @@ fromPtrN len addr = do
2440 -- XXX We can implement a stream copy in a similar way by streaming Word64
2091 -- XXX We can implement a stream copy in a similar way by streaming Word64
2441 -- first and then remaining Word8.
2092 -- first and then remaining Word8.
2442 arr <- new len
2093 arr <- new len
2443− _ <- unsafeAsPtr arr
2094+ _ <- asUnpinnedPtrUnsafe arr
2444 (\ptr -> liftIO $ c_memcpy ptr addr (fromIntegral len))
2095 (\ptr -> liftIO $ c_memcpy ptr addr (fromIntegral len))
2445 return (arr {arrEnd = len})
2096 return (arr {arrEnd = len})
2446
2097
@@ -2456,7 +2107,7 @@ fromByteStr# addr = do
2456 len <- liftIO $ c_strlen (Ptr addr)
2107 len <- liftIO $ c_strlen (Ptr addr)
2457 let lenInt = fromIntegral len
2108 let lenInt = fromIntegral len
2458 arr <- new lenInt
2109 arr <- new lenInt
2459− _ <- unsafeAsPtr arr (\ptr -> liftIO $ c_memcpy ptr (Ptr addr) len)
2110+ _ <- asUnpinnedPtrUnsafe arr (\ptr -> liftIO $ c_memcpy ptr (Ptr addr) len)
2460 return (arr {arrEnd = lenInt})
2111 return (arr {arrEnd = lenInt})
2461
2112
2462-------------------------------------------------------------------------------
2113-------------------------------------------------------------------------------
@@ -2466,18 +2117,17 @@ fromByteStr# addr = do
2466-- XXX Both of these implementations of splicing seem to perform equally well.
2117-- XXX Both of these implementations of splicing seem to perform equally well.
2467-- We need to perform benchmarks over a range of sizes though.
2118-- We need to perform benchmarks over a range of sizes though.
2468
2119
2469−-- | Also see 'fromChunksK'.
2120+{-# INLINE fromArrayStreamRealloced #-}
2470−{-# INLINE fromChunksRealloced #-}
2471−fromChunksRealloced :: forall m a. (MonadIO m, Unbox a)
2121+fromArrayStreamRealloced :: forall m a. (MonadIO m, Unbox a)
2472 => Stream m (MutArray a) -> m (MutArray a)
2122 => Stream m (MutArray a) -> m (MutArray a)
2473−fromChunksRealloced s = do
2123+fromArrayStreamRealloced s = do
2474 res <- D.uncons s
2124 res <- D.uncons s
2475 case res of
2125 case res of
2476 Just (a, strm) -> do
2126 Just (a, strm) -> do
2477 arr <- D.foldlM' spliceExp (pure a) strm
2127 arr <- D.foldlM' spliceExp (pure a) strm
2478 -- Reallocation is exponential so there may be 50% empty space in
2128 -- Reallocation is exponential so there may be 50% empty space in
2479 -- worst case. One more reallocation to reclaim the space.
2129 -- worst case. One more reallocation to reclaim the space.
2480− rightSize arr
2130+ liftIO $ rightSize arr
2481 Nothing -> pure nil
2131 Nothing -> pure nil
2482
2132
2483-------------------------------------------------------------------------------
2133-------------------------------------------------------------------------------
@@ -2491,72 +2141,46 @@ arrayStreamKLength as = K.foldl' (+) 0 (K.map length as)
2491-- | Convert an array stream to an array. Note that this requires peak memory
2141-- | Convert an array stream to an array. Note that this requires peak memory
2492-- that is double the size of the array stream.
2142-- that is double the size of the array stream.
2493--
2143--
2494−{-# INLINE fromChunkskAs #-}
2144+{-# INLINE fromArrayStreamKAs #-}
2495−fromChunkskAs :: (Unbox a, MonadIO m) =>
2145+fromArrayStreamKAs :: (Unbox a, MonadIO m) =>
2496 PinnedState -> StreamK m (MutArray a) -> m (MutArray a)
2146 PinnedState -> StreamK m (MutArray a) -> m (MutArray a)
2497−fromChunkskAs ps as = do
2147+fromArrayStreamKAs ps as = do
2498 len <- arrayStreamKLength as
2148 len <- arrayStreamKLength as
2499 arr <- newAs ps len
2149 arr <- newAs ps len
2500 -- XXX is StreamK fold faster or StreamD fold?
2150 -- XXX is StreamK fold faster or StreamD fold?
2501 K.foldlM' spliceUnsafe (pure arr) as
2151 K.foldlM' spliceUnsafe (pure arr) as
2502 -- fromStreamDN len $ D.unfoldMany reader $ D.fromStreamK as
2152 -- fromStreamDN len $ D.unfoldMany reader $ D.fromStreamK as
2503
2153
2504−-- XXX Need to compare this with fromChunks and fromChunkList and keep the
2505−-- fastest or simplest one if all are equally fast.
2506−
2507-- | Convert an array stream to an array. Note that this requires peak memory
2154-- | Convert an array stream to an array. Note that this requires peak memory
2508-- that is double the size of the array stream.
2155-- that is double the size of the array stream.
2509--
2156--
2510−-- Also see 'fromChunksRealloced'.
2511−--
2512−{-# INLINE fromChunksK #-}
2513−fromChunksK :: (Unbox a, MonadIO m) =>
2514− StreamK m (MutArray a) -> m (MutArray a)
2515−fromChunksK = fromChunkskAs Unpinned
2516−
2517−{-# DEPRECATED fromArrayStreamK "Please use fromChunksK instead." #-}
2518{-# INLINE fromArrayStreamK #-}
2157{-# INLINE fromArrayStreamK #-}
2519fromArrayStreamK :: (Unbox a, MonadIO m) =>
2158fromArrayStreamK :: (Unbox a, MonadIO m) =>
2520 StreamK m (MutArray a) -> m (MutArray a)
2159 StreamK m (MutArray a) -> m (MutArray a)
2521−fromArrayStreamK = fromChunksK
2160+fromArrayStreamK = fromArrayStreamKAs Unpinned
2522
2161
2523{-# INLINE fromStreamDAs #-}
2162{-# INLINE fromStreamDAs #-}
2524fromStreamDAs ::
2163fromStreamDAs ::
2525 (MonadIO m, Unbox a) => PinnedState -> D.Stream m a -> m (MutArray a)
2164 (MonadIO m, Unbox a) => PinnedState -> D.Stream m a -> m (MutArray a)
2526fromStreamDAs ps m =
2165fromStreamDAs ps m =
2527− arrayStreamKFromStreamDAs Unpinned m >>= fromChunkskAs ps
2166+ arrayStreamKFromStreamDAs Unpinned m >>= fromArrayStreamKAs ps
2528
2167
2529−-- | Create an 'Array' from a stream. This is useful when we want to create a
2530−-- single array from a stream of unknown size. 'createOf' is at least twice
2531−-- as efficient when the size is already known.
2532−--
2533−-- Note that if the input stream is too large memory allocation for the array
2534−-- may fail. When the stream size is not known, `chunksOf` followed by
2535−-- processing of indvidual arrays in the resulting stream should be preferred.
2536−--
2537−-- /Pre-release/
2538−{-# INLINE fromStream #-}
2539−fromStream :: (MonadIO m, Unbox a) => Stream m a -> m (MutArray a)
2540−fromStream = fromStreamDAs Unpinned
2541−
2542−-- fromStream (Stream m) = P.fold create m
2543-- CAUTION: a very large number (millions) of arrays can degrade performance
2168-- CAUTION: a very large number (millions) of arrays can degrade performance
2544-- due to GC overhead because we need to buffer the arrays before we flatten
2169-- due to GC overhead because we need to buffer the arrays before we flatten
2545-- all the arrays.
2170-- all the arrays.
2546--
2171--
2547−-- XXX Compare if this is faster or "fold create".
2172+-- XXX Compare if this is faster or "fold write".
2548--
2173--
2549-- | We could take the approach of doubling the memory allocation on each
2174-- | We could take the approach of doubling the memory allocation on each
2550-- overflow. This would result in more or less the same amount of copying as in
2175-- overflow. This would result in more or less the same amount of copying as in
2551-- the chunking approach. However, if we have to shrink in the end then it may
2176-- the chunking approach. However, if we have to shrink in the end then it may
2552-- result in an extra copy of the entire data.
2177-- result in an extra copy of the entire data.
2553--
2178--
2554−-- >>> fromStreamD = StreamD.fold MutArray.create
2179+-- >>> fromStreamD = StreamD.fold MutArray.write
2555--
2180--
2556{-# INLINE fromStreamD #-}
2181{-# INLINE fromStreamD #-}
2557−{-# DEPRECATED fromStreamD "Please use fromStream instead." #-}
2558fromStreamD :: (MonadIO m, Unbox a) => D.Stream m a -> m (MutArray a)
2182fromStreamD :: (MonadIO m, Unbox a) => D.Stream m a -> m (MutArray a)
2559−fromStreamD = fromStream
2183+fromStreamD = fromStreamDAs Unpinned
2560
2184
2561-- | Create a 'MutArray' from a list. The list must be of finite size.
2185-- | Create a 'MutArray' from a list. The list must be of finite size.
2562--
2186--
@@ -2581,10 +2205,6 @@ fromListRev xs = fromListRevN (Prelude.length xs) xs
2581-- Cloning
2205-- Cloning
2582-------------------------------------------------------------------------------
2206-------------------------------------------------------------------------------
2583
2207
2584−-- Arrays are aligned on 64-bit boundaries. The fastest way to copy an array is
2585−-- to unsafeCast it to Word64, read it, write it to Word64 array and unsafeCast
2586−-- it again. We can use SIMD read/write as well.
2587−
2588{-# INLINE cloneAs #-}
2208{-# INLINE cloneAs #-}
2589cloneAs ::
2209cloneAs ::
2590 ( MonadIO m
2210 ( MonadIO m
@@ -2594,7 +2214,7 @@ cloneAs ::
2594 )
2214 )
2595 => PinnedState -> MutArray a -> m (MutArray a)
2215 => PinnedState -> MutArray a -> m (MutArray a)
2596cloneAs ps src =
2216cloneAs ps src =
2597− do
2217+ liftIO $ do
2598 let startSrc = arrStart src
2218 let startSrc = arrStart src
2599 srcLen = arrEnd src - startSrc
2219 srcLen = arrEnd src - startSrc
2600 newArrContents <-
2220 newArrContents <-
@@ -2633,16 +2253,17 @@ spliceCopy :: forall m a. MonadIO m =>
2633 Unbox a =>
2253 Unbox a =>
2634#endif
2254#endif
2635 MutArray a -> MutArray a -> m (MutArray a)
2255 MutArray a -> MutArray a -> m (MutArray a)
2636−spliceCopy arr1 arr2 = do
2256+spliceCopy arr1 arr2 = liftIO $ do
2637 let start1 = arrStart arr1
2257 let start1 = arrStart arr1
2638 start2 = arrStart arr2
2258 start2 = arrStart arr2
2639 len1 = arrEnd arr1 - start1
2259 len1 = arrEnd arr1 - start1
2640 len2 = arrEnd arr2 - start2
2260 len2 = arrEnd arr2 - start2
2641− let len = len1 + len2
2261+ let newLen = len1 + len2
2642 newArrContents <-
2262 newArrContents <-
2643 if Unboxed.isPinned (arrContents arr1)
2263 if Unboxed.isPinned (arrContents arr1)
2644− then liftIO $ Unboxed.pinnedNew len
2264+ then Unboxed.pinnedNew newLen
2645− else liftIO $ Unboxed.new len
2265+ else Unboxed.new newLen
2266+ let len = len1 + len2
2646 putSliceUnsafe (arrContents arr1) start1 newArrContents 0 len1
2267 putSliceUnsafe (arrContents arr1) start1 newArrContents 0 len1
2647 putSliceUnsafe (arrContents arr2) start2 newArrContents len1 len2
2268 putSliceUnsafe (arrContents arr2) start2 newArrContents len1 len2
2648 return $ MutArray newArrContents 0 len len
2269 return $ MutArray newArrContents 0 len len
@@ -2654,7 +2275,7 @@ spliceCopy arr1 arr2 = do
2654spliceUnsafe :: MonadIO m =>
2275spliceUnsafe :: MonadIO m =>
2655 MutArray a -> MutArray a -> m (MutArray a)
2276 MutArray a -> MutArray a -> m (MutArray a)
2656spliceUnsafe dst src =
2277spliceUnsafe dst src =
2657− do
2278+ liftIO $ do
2658 let startSrc = arrStart src
2279 let startSrc = arrStart src
2659 srcLen = arrEnd src - startSrc
2280 srcLen = arrEnd src - startSrc
2660 endDst = arrEnd dst
2281 endDst = arrEnd dst
@@ -2676,7 +2297,7 @@ spliceWith :: forall m a. (MonadIO m, Unbox a) =>
2676 (Int -> Int -> Int) -> MutArray a -> MutArray a -> m (MutArray a)
2297 (Int -> Int -> Int) -> MutArray a -> MutArray a -> m (MutArray a)
2677spliceWith sizer dst@(MutArray _ start end bound) src = do
2298spliceWith sizer dst@(MutArray _ start end bound) src = do
2678{-
2299{-
2679− let f = appendWith (`sizer` byteLength src) (return dst)
2300+ let f = writeAppendWith (`sizer` byteLength src) (return dst)
2680 in D.fold f (toStreamD src)
2301 in D.fold f (toStreamD src)
2681-}
2302-}
2682 assert (end <= bound) (return ())
2303 assert (end <= bound) (return ())
@@ -2692,7 +2313,7 @@ spliceWith sizer dst@(MutArray _ start end bound) src = do
2692 $ "splice: newSize is less than the total size "
2313 $ "splice: newSize is less than the total size "
2693 ++ "of arrays being appended. Please check the "
2314 ++ "of arrays being appended. Please check the "
2694 ++ "sizer function passed."
2315 ++ "sizer function passed."
2695− realloc newSizeInBytes dst
2316+ liftIO $ realloc newSizeInBytes dst
2696 else return dst
2317 else return dst
2697 spliceUnsafe dst1 src
2318 spliceUnsafe dst1 src
2698
2319
@@ -2729,22 +2350,11 @@ spliceExp = spliceWith (\l1 l2 -> max (l1 * 2) (l1 + l2))
2729-- Splitting
2350-- Splitting
2730-------------------------------------------------------------------------------
2351-------------------------------------------------------------------------------
2731
2352
2732−-- | Generate a stream of array slices using a predicate. The array element
2733−-- matching the predicate is dropped.
2734−--
2735−-- /Pre-release/
2736−{-# INLINE splitOn #-}
2737−splitOn :: (MonadIO m, Unbox a) =>
2738− (a -> Bool) -> MutArray a -> Stream m (MutArray a)
2739−splitOn predicate arr =
2740− fmap (\(i, len) -> getSliceUnsafe i len arr)
2741− $ D.indexOnSuffix predicate (read arr)
2742−
2743-- | Drops the separator byte
2353-- | Drops the separator byte
2744{-# INLINE breakOn #-}
2354{-# INLINE breakOn #-}
2745breakOn :: MonadIO m
2355breakOn :: MonadIO m
2746 => Word8 -> MutArray Word8 -> m (MutArray Word8, Maybe (MutArray Word8))
2356 => Word8 -> MutArray Word8 -> m (MutArray Word8, Maybe (MutArray Word8))
2747−breakOn sep arr@MutArray{..} = unsafeAsPtr arr $ \p -> liftIO $ do
2357+breakOn sep arr@MutArray{..} = asUnpinnedPtrUnsafe arr $ \p -> liftIO $ do
2748 -- XXX We do not need memchr here, we can use a Haskell equivalent.
2358 -- XXX We do not need memchr here, we can use a Haskell equivalent.
2749 -- Need efficient stream based primitives that work on Word64.
2359 -- Need efficient stream based primitives that work on Word64.
2750 loc <- c_memchr p sep (fromIntegral $ byteLength arr)
2360 loc <- c_memchr p sep (fromIntegral $ byteLength arr)
@@ -2767,41 +2377,32 @@ breakOn sep arr@MutArray{..} = unsafeAsPtr arr $ \p -> liftIO $ do
2767 }
2377 }
2768 )
2378 )
2769
2379
2770−-- | Like 'splitAt' but does not check whether the index is valid.
2771−--
2772−{-# INLINE unsafeSplitAt #-}
2773−unsafeSplitAt :: forall a. Unbox a =>
2774− Int -> MutArray a -> (MutArray a, MutArray a)
2775−unsafeSplitAt i MutArray{..} =
2776− let off = i * SIZE_OF(a)
2777− p = arrStart + off
2778− in ( MutArray
2779− { arrContents = arrContents
2780− , arrStart = arrStart
2781− , arrEnd = p
2782− , arrBound = p
2783− }
2784− , MutArray
2785− { arrContents = arrContents
2786− , arrStart = p
2787− , arrEnd = arrEnd
2788− , arrBound = arrBound
2789− }
2790− )
2791−
2792-- | Create two slices of an array without copying the original array. The
2380-- | Create two slices of an array without copying the original array. The
2793-- specified index @i@ is the first index of the second slice.
2381-- specified index @i@ is the first index of the second slice.
2794--
2382--
2795−{-# INLINE splitAt #-}
2796splitAt :: forall a. Unbox a => Int -> MutArray a -> (MutArray a, MutArray a)
2383splitAt :: forall a. Unbox a => Int -> MutArray a -> (MutArray a, MutArray a)
2797−splitAt i arr =
2384+splitAt i arr@MutArray{..} =
2798 let maxIndex = length arr - 1
2385 let maxIndex = length arr - 1
2799 in if i < 0
2386 in if i < 0
2800 then error "sliceAt: negative array index"
2387 then error "sliceAt: negative array index"
2801 else if i > maxIndex
2388 else if i > maxIndex
2802 then error $ "sliceAt: specified array index " ++ show i
2389 then error $ "sliceAt: specified array index " ++ show i
2803 ++ " is beyond the maximum index " ++ show maxIndex
2390 ++ " is beyond the maximum index " ++ show maxIndex
2804− else unsafeSplitAt i arr
2391+ else let off = i * SIZE_OF(a)
2392+ p = arrStart + off
2393+ in ( MutArray
2394+ { arrContents = arrContents
2395+ , arrStart = arrStart
2396+ , arrEnd = p
2397+ , arrBound = p
2398+ }
2399+ , MutArray
2400+ { arrContents = arrContents
2401+ , arrStart = p
2402+ , arrEnd = arrEnd
2403+ , arrBound = arrBound
2404+ }
2405+ )
2805
2406
2806-------------------------------------------------------------------------------
2407-------------------------------------------------------------------------------
2807-- Casting
2408-- Casting
@@ -2851,13 +2452,9 @@ cast arr =
2851-- guarantees that unsafe calls will be performed in the calling thread. Making
2452-- guarantees that unsafe calls will be performed in the calling thread. Making
2852-- it safe to pass heap-allocated objects to unsafe functions.
2453-- it safe to pass heap-allocated objects to unsafe functions.
2853
2454
2854−-- XXX Should we just name it asPtr, the unsafety is implicit for any pointer
2455+-- Should we just name it asPtr, the unsafety is implicit for any pointer
2855-- operations. And we are safe from Haskell perspective because we will be
2456-- operations. And we are safe from Haskell perspective because we will be
2856-- pinning the memory.
2457-- pinning the memory.
2857−--
2858−-- XXX we cannot pass the length of the ptr here as in some cases it may not be
2859−-- available e.g. a null terminated C string. However, we can create another
2860−-- flavor of the API e.g. asPtrN.
2861
2458
2862-- | Use a @MutArray a@ as @Ptr a@. This is useful when we want to pass an
2459-- | Use a @MutArray a@ as @Ptr a@. This is useful when we want to pass an
2863-- array as a pointer to some operating system call or to a "safe" FFI call.
2460-- array as a pointer to some operating system call or to a "safe" FFI call.
@@ -2875,21 +2472,16 @@ cast arr =
2875--
2472--
2876-- /Pre-release/
2473-- /Pre-release/
2877--
2474--
2878−{-# INLINE unsafePinnedAsPtr #-}
2879−unsafePinnedAsPtr :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
2880−unsafePinnedAsPtr arr f =
2881− Unboxed.unsafePinnedAsPtr
2882− (arrContents arr) (\ptr -> f (ptr `plusPtr` arrStart arr))
2883−
2884−{-# DEPRECATED asPtrUnsafe "Please use unsafePinnedAsPtr instead." #-}
2885{-# INLINE asPtrUnsafe #-}
2475{-# INLINE asPtrUnsafe #-}
2886asPtrUnsafe :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
2476asPtrUnsafe :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
2887−asPtrUnsafe = unsafePinnedAsPtr
2477+asPtrUnsafe arr f =
2478+ Unboxed.asPtrUnsafe
2479+ (arrContents arr) (\ptr -> f (ptr `plusPtr` arrStart arr))
2888
2480
2889−{-# INLINE unsafeAsPtr #-}
2481+{-# INLINE asUnpinnedPtrUnsafe #-}
2890−unsafeAsPtr :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
2482+asUnpinnedPtrUnsafe :: MonadIO m => MutArray a -> (Ptr a -> m b) -> m b
2891−unsafeAsPtr arr f =
2483+asUnpinnedPtrUnsafe arr f =
2892− Unboxed.unsafeAsPtr
2484+ Unboxed.asUnpinnedPtrUnsafe
2893 (arrContents arr) (\ptr -> f (ptr `plusPtr` arrStart arr))
2485 (arrContents arr) (\ptr -> f (ptr `plusPtr` arrStart arr))
2894
2486
2895-------------------------------------------------------------------------------
2487-------------------------------------------------------------------------------
@@ -2907,26 +2499,28 @@ unsafeAsPtr arr f =
2907-- /Pre-release/
2499-- /Pre-release/
2908{-# INLINE byteCmp #-}
2500{-# INLINE byteCmp #-}
2909byteCmp :: MonadIO m => MutArray a -> MutArray a -> m Ordering
2501byteCmp :: MonadIO m => MutArray a -> MutArray a -> m Ordering
2910−byteCmp arr1 arr2 = do
2502+byteCmp arr1 arr2 =
2503+ liftIO
2504+ $ do
2911− let marr1 = getMutableByteArray# (arrContents arr1)
2505+ let marr1 = getMutableByteArray# (arrContents arr1)
2912− marr2 = getMutableByteArray# (arrContents arr2)
2506+ marr2 = getMutableByteArray# (arrContents arr2)
2913− !(I# st1#) = arrStart arr1
2507+ !(I# st1#) = arrStart arr1
2914− !(I# st2#) = arrStart arr2
2508+ !(I# st2#) = arrStart arr2
2915− !(I# len#) = byteLength arr1
2509+ !(I# len#) = byteLength arr1
2916− case compare (byteLength arr1) (byteLength arr2) of
2510+ case compare (byteLength arr1) (byteLength arr2) of
2917− EQ -> do
2511+ EQ -> do
2918− r <- liftIO $ IO $ \s# ->
2512+ r <- liftIO $ IO $ \s# ->
2919− let res =
2513+ let res =
2920− I#
2514+ I#
2921− (compareByteArrays#
2515+ (compareByteArrays#
2922− (unsafeCoerce# marr1)
2516+ (unsafeCoerce# marr1)
2923− st1#
2517+ st1#
2924− (unsafeCoerce# marr2)
2518+ (unsafeCoerce# marr2)
2925− st2#
2519+ st2#
2926− len#)
2520+ len#)
2927− in (# s#, res #)
2521+ in (# s#, res #)
2928− return $ compare r 0
2522+ return $ compare r 0
2929− x -> return x
2523+ x -> return x
2930
2524
2931{-# INLINE cmp #-}
2525{-# INLINE cmp #-}
2932{-# DEPRECATED cmp "Please use byteCmp instead." #-}
2526{-# DEPRECATED cmp "Please use byteCmp instead." #-}
@@ -2943,309 +2537,7 @@ byteEq :: MonadIO m => MutArray a -> MutArray a -> m Bool
2943byteEq arr1 arr2 = fmap (EQ ==) $ byteCmp arr1 arr2
2537byteEq arr1 arr2 = fmap (EQ ==) $ byteCmp arr1 arr2
2944
2538
2945-------------------------------------------------------------------------------
2539-------------------------------------------------------------------------------
2946−-- Compact
2540+-- NFData
2947−-------------------------------------------------------------------------------
2948−
2949−-- Note: LE versions avoid an extra copy compared to GE. LE parser trades
2950−-- backtracking one array in lieu of avoiding a copy. However, LE and GE both
2951−-- can leave some memory unused. They can split the last array to fit it
2952−-- exactly in the space.
2953−
2954−{-# INLINE_NORMAL pCompactLeAs #-}
2955−pCompactLeAs ::
2956− forall m a. (MonadIO m, Unbox a)
2957− => PinnedState -> Int -> Parser (MutArray a) m (MutArray a)
2958−pCompactLeAs ps maxElems = Parser step initial extract
2959−
2960− where
2961−
2962− maxBytes = maxElems * SIZE_OF(a)
2963−
2964− functionName = "Streamly.Internal.Data.MutArray.pCompactLE"
2965−
2966− initial =
2967− return
2968− $ if maxElems <= 0
2969− then error
2970− $ functionName
2971− ++ ": the size of arrays ["
2972− ++ show maxElems ++ "] must be a natural number"
2973− else Parser.IPartial Nothing
2974−
2975− step Nothing arr =
2976− return
2977− $ let len = byteLength arr
2978− in if len >= maxBytes
2979− then Parser.Done 0 arr
2980− else Parser.Partial 0 (Just arr)
2981− -- XXX Split the last array to use the space more compactly.
2982− step (Just buf) arr =
2983− let len = byteLength buf + byteLength arr
2984− in if len > maxBytes
2985− then return $ Parser.Done 1 buf
2986− else do
2987− buf1 <-
2988− if byteCapacity buf < maxBytes
2989− then liftIO $ reallocExplicitAs
2990− ps (SIZE_OF(a)) maxBytes buf
2991− else return buf
2992− buf2 <- spliceUnsafe buf1 arr
2993− return $ Parser.Partial 0 (Just buf2)
2994−
2995− extract Nothing = return $ Parser.Done 0 nil
2996− extract (Just buf) = return $ Parser.Done 0 buf
2997−
2998−-- | Parser @pCompactLE maxElems@ coalesces adjacent arrays in the input stream
2999−-- only if the combined size would be less than or equal to @maxElems@
3000−-- elements. Note that it won't split an array if the original array is already
3001−-- larger than maxElems.
3002−--
3003−-- @maxElems@ must be greater than 0.
3004−--
3005−-- Generates unpinned arrays irrespective of the pinning status of input
3006−-- arrays.
3007−--
3008−-- /Internal/
3009−{-# INLINE pCompactLE #-}
3010−pCompactLE ::
3011− forall m a. (MonadIO m, Unbox a)
3012− => Int -> Parser (MutArray a) m (MutArray a)
3013−pCompactLE = pCompactLeAs Unpinned
3014−
3015−-- | Pinned version of 'pCompactLE'.
3016−{-# INLINE pPinnedCompactLE #-}
3017−pPinnedCompactLE ::
3018− forall m a. (MonadIO m, Unbox a)
3019− => Int -> Parser (MutArray a) m (MutArray a)
3020−pPinnedCompactLE = pCompactLeAs Pinned
3021−
3022−data SpliceState s arr
3023− = SpliceInitial s
3024− | SpliceBuffering s arr
3025− | SpliceYielding arr (SpliceState s arr)
3026− | SpliceFinish
3027−
3028−-- This mutates the first array (if it has space) to append values from the
3029−-- second one. This would work for immutable arrays as well because an
3030−-- immutable array never has additional space so a new array is allocated
3031−-- instead of mutating it.
3032−
3033−{-# INLINE_NORMAL compactLeAs #-}
3034−compactLeAs :: forall m a. (MonadIO m, Unbox a)
3035− => PinnedState -> Int -> D.Stream m (MutArray a) -> D.Stream m (MutArray a)
3036−compactLeAs ps maxElems (D.Stream step state) =
3037− D.Stream step' (SpliceInitial state)
3038−
3039− where
3040−
3041− maxBytes = maxElems * SIZE_OF(a)
3042−
3043− functionName = "Streamly.Internal.Data.MutArray.rCompactLE"
3044−
3045− {-# INLINE_LATE step' #-}
3046− step' gst (SpliceInitial st) = do
3047− when (maxElems <= 0) $
3048− -- XXX we can pass the module string from the higher level API
3049− error $ functionName ++ ": the size of arrays [" ++ show maxElems
3050− ++ "] must be a natural number"
3051− r <- step gst st
3052− case r of
3053− D.Yield arr s -> return $
3054− let len = byteLength arr
3055− in if len >= maxBytes
3056− then D.Skip (SpliceYielding arr (SpliceInitial s))
3057− else D.Skip (SpliceBuffering s arr)
3058− D.Skip s -> return $ D.Skip (SpliceInitial s)
3059− D.Stop -> return D.Stop
3060−
3061− -- XXX Split the last array to use the space more compactly.
3062− step' gst (SpliceBuffering st buf) = do
3063− r <- step gst st
3064− case r of
3065− D.Yield arr s -> do
3066− let len = byteLength buf + byteLength arr
3067− if len > maxBytes
3068− then return $
3069− D.Skip (SpliceYielding buf (SpliceBuffering s arr))
3070− else do
3071− buf1 <- if byteCapacity buf < maxBytes
3072− then liftIO $ reallocExplicitAs
3073− ps (SIZE_OF(a)) maxBytes buf
3074− else return buf
3075− buf2 <- spliceUnsafe buf1 arr
3076− return $ D.Skip (SpliceBuffering s buf2)
3077− D.Skip s -> return $ D.Skip (SpliceBuffering s buf)
3078− D.Stop -> return $ D.Skip (SpliceYielding buf SpliceFinish)
3079−
3080− step' _ SpliceFinish = return D.Stop
3081−
3082− step' _ (SpliceYielding arr next) = return $ D.Yield arr next
3083−
3084−
3085−{-# INLINE_NORMAL fCompactGeAs #-}
3086−fCompactGeAs ::
3087− forall m a. (MonadIO m, Unbox a)
3088− => PinnedState -> Int -> FL.Fold m (MutArray a) (MutArray a)
3089−fCompactGeAs ps minElems = Fold step initial extract extract
3090−
3091− where
3092−
3093− minBytes = minElems * SIZE_OF(a)
3094−
3095− functionName = "Streamly.Internal.Data.MutArray.fCompactGE"
3096−
3097− initial =
3098− return
3099− $ if minElems < 0
3100− then error
3101− $ functionName
3102− ++ ": the size of arrays ["
3103− ++ show minElems ++ "] must be a natural number"
3104− else FL.Partial Nothing
3105−
3106− step Nothing arr =
3107− return
3108− $ let len = byteLength arr
3109− in if len >= minBytes
3110− then FL.Done arr
3111− else FL.Partial (Just arr)
3112− -- XXX Buffer arrays as a list to avoid copy and reallocations
3113− step (Just buf) arr = do
3114− let len = byteLength buf + byteLength arr
3115− buf1 <-
3116− if byteCapacity buf < len
3117− then liftIO $ reallocExplicitAs
3118− ps (SIZE_OF(a)) (max minBytes len) buf
3119− else return buf
3120− buf2 <- spliceUnsafe buf1 arr
3121− if len >= minBytes
3122− then return $ FL.Done buf2
3123− else return $ FL.Partial (Just buf2)
3124−
3125− extract Nothing = return nil
3126− extract (Just buf) = return buf
3127−
3128−-- | Fold @fCompactGE minElems@ coalesces adjacent arrays in the input stream
3129−-- until the size becomes greater than or equal to @minElems@.
3130−--
3131−-- Generates unpinned arrays irrespective of the pinning status of input
3132−-- arrays.
3133−{-# INLINE fCompactGE #-}
3134−fCompactGE ::
3135− forall m a. (MonadIO m, Unbox a)
3136− => Int -> FL.Fold m (MutArray a) (MutArray a)
3137−fCompactGE = fCompactGeAs Unpinned
3138−
3139−-- | Pinned version of 'fCompactGE'.
3140−{-# INLINE fPinnedCompactGE #-}
3141−fPinnedCompactGE ::
3142− forall m a. (MonadIO m, Unbox a)
3143− => Int -> FL.Fold m (MutArray a) (MutArray a)
3144−fPinnedCompactGE = fCompactGeAs Pinned
3145−
3146−{-# INLINE_NORMAL lCompactGeAs #-}
3147−lCompactGeAs :: forall m a. (MonadIO m, Unbox a)
3148− => PinnedState -> Int -> Fold m (MutArray a) () -> Fold m (MutArray a) ()
3149−-- The fold version turns out to be a little bit slower.
3150−-- lCompactGeAs ps n = FL.many (fCompactGeAs ps n)
3151−lCompactGeAs ps minElems (Fold step1 initial1 _ final1) =
3152− Fold step initial extract final
3153−
3154− where
3155−
3156− minBytes = minElems * SIZE_OF(a)
3157−
3158− functionName = "Streamly.Internal.Data.MutArray.lCompactGE"
3159−
3160− initial = do
3161− when (minElems <= 0) $
3162− -- XXX we can pass the module string from the higher level API
3163− error $ functionName ++ ": the size of arrays ["
3164− ++ show minElems ++ "] must be a natural number"
3165−
3166− r <- initial1
3167− return $ first (Tuple' Nothing) r
3168−
3169− {-# INLINE runInner #-}
3170− runInner len acc buf =
3171− if len >= minBytes
3172− then do
3173− r <- step1 acc buf
3174− case r of
3175− FL.Done _ -> return $ FL.Done ()
3176− FL.Partial s -> do
3177− _ <- final1 s
3178− res <- initial1
3179− return $ first (Tuple' Nothing) res
3180− else return $ FL.Partial $ Tuple' (Just buf) acc
3181−
3182− step (Tuple' Nothing r1) arr =
3183− runInner (byteLength arr) r1 arr
3184−
3185− -- XXX Buffer arrays as a list to avoid copy and reallocations
3186− step (Tuple' (Just buf) r1) arr = do
3187− let len = byteLength buf + byteLength arr
3188− buf1 <- if byteCapacity buf < len
3189− then liftIO $ reallocExplicitAs
3190− ps (SIZE_OF(a)) (max minBytes len) buf
3191− else return buf
3192− buf2 <- spliceUnsafe buf1 arr
3193− runInner len r1 buf2
3194−
3195− -- XXX Several folds do extract >=> final, therefore, we need to make final
3196− -- return "m b" rather than using extract post it if we want extract to be
3197− -- partial.
3198− --
3199− -- extract forces the pending buffer to be sent to the fold which is not
3200− -- what we want.
3201− extract _ = error "lCompactGE: not designed for scanning"
3202−
3203− final (Tuple' Nothing r1) = final1 r1
3204− final (Tuple' (Just buf) r1) = do
3205− r <- step1 r1 buf
3206− case r of
3207− FL.Partial rr -> final1 rr
3208− FL.Done _ -> return ()
3209−
3210−-- | Like 'compactGE' but for transforming folds instead of stream.
3211−--
3212−-- >>> lCompactGE n = Fold.many (MutArray.fCompactGE n)
3213−--
3214−-- Generates unpinned arrays irrespective of the pinning status of input
3215−-- arrays.
3216−{-# INLINE lCompactGE #-}
3217−lCompactGE :: forall m a. (MonadIO m, Unbox a)
3218− => Int -> Fold m (MutArray a) () -> Fold m (MutArray a) ()
3219−lCompactGE = lCompactGeAs Unpinned
3220−
3221−-- | Pinned version of 'lCompactGE'.
3222−{-# INLINE lPinnedCompactGE #-}
3223−lPinnedCompactGE :: forall m a. (MonadIO m, Unbox a)
3224− => Int -> Fold m (MutArray a) () -> Fold m (MutArray a) ()
3225−lPinnedCompactGE = lCompactGeAs Pinned
3226−
3227−-- | @compactGE n stream@ coalesces adjacent arrays in the @stream@ until
3228−-- the size becomes greater than or equal to @n@.
3229−--
3230−-- >>> compactGE n = Stream.foldMany (MutArray.fCompactGE n)
3231−--
3232−{-# INLINE compactGE #-}
3233−compactGE ::
3234− (MonadIO m, Unbox a)
3235− => Int -> Stream m (MutArray a) -> Stream m (MutArray a)
3236−compactGE n = D.foldMany (fCompactGE n)
3237−
3238−-- | 'compactEQ n' coalesces adajacent arrays in the input stream to
3239−-- arrays of exact size @n@.
3240−--
3241−-- /Unimplemented/
3242−{-# INLINE compactEQ #-}
3243−compactEQ :: -- (MonadIO m, Unbox a) =>
3244− Int -> Stream m (MutArray a) -> Stream m (MutArray a)
3245−compactEQ _n = undefined -- D.parseManyD (pCompactEQ n)
3246−
3247−-------------------------------------------------------------------------------
3248−-- In-place mutation algorithms
3249-------------------------------------------------------------------------------
2541-------------------------------------------------------------------------------
3250
2542
3251-- | Strip elements which match with predicate from both ends.
2543-- | Strip elements which match with predicate from both ends.
core/src/Streamly/Internal/Data/MutByteArray/Type.hs+16−40
@@ -13,7 +13,7 @@ module Streamly.Internal.Data.MutByteArray.Type
13 -- ** MutByteArray
13 -- ** MutByteArray
14 MutByteArray(..)
14 MutByteArray(..)
15 , MutableByteArray
15 , MutableByteArray
16− , getMutableByteArray# -- XXX getMutByteArray#
16+ , getMutableByteArray#
17
17
18 -- ** Pinning
18 -- ** Pinning
19 , PinnedState(..)
19 , PinnedState(..)
@@ -22,24 +22,20 @@ module Streamly.Internal.Data.MutByteArray.Type
22 , unpin
22 , unpin
23
23
24 -- ** Allocation
24 -- ** Allocation
25− , empty
25+ , nil
26− , newBytesAs -- XXX should be removed
26+ , newBytesAs
27 , new
27 , new
28 , pinnedNew
28 , pinnedNew
29− , pinnedNewAlignedBytes -- XXX should be removed
29+ , pinnedNewAlignedBytes
30
30
31 -- ** Access
31 -- ** Access
32− , sizeOfMutableByteArray -- XXX length
32+ , sizeOfMutableByteArray
33 , putSliceUnsafe
33 , putSliceUnsafe
34 , cloneSliceUnsafeAs
34 , cloneSliceUnsafeAs
35 , cloneSliceUnsafe
35 , cloneSliceUnsafe
36 , pinnedCloneSliceUnsafe
36 , pinnedCloneSliceUnsafe
37− , unsafePinnedAsPtr
38− , unsafeAsPtr
39−
40− -- ** Deprecated
41 , asPtrUnsafe
37 , asPtrUnsafe
42− , nil
38+ , asUnpinnedPtrUnsafe
43 ) where
39 ) where
44
40
45import Control.Monad.IO.Class (MonadIO(..))
41import Control.Monad.IO.Class (MonadIO(..))
@@ -58,7 +54,7 @@ import GHC.Exts
58
54
59data PinnedState
55data PinnedState
60 = Pinned
56 = Pinned
61− | Unpinned deriving (Show, Eq)
57+ | Unpinned
62
58
63-- XXX can use UnliftedNewtypes
59-- XXX can use UnliftedNewtypes
64
60
@@ -87,9 +83,6 @@ touch :: MutByteArray -> IO ()
87touch (MutByteArray contents) =
83touch (MutByteArray contents) =
88 IO $ \s -> case touch# contents s of s' -> (# s', () #)
84 IO $ \s -> case touch# contents s of s' -> (# s', () #)
89
85
90−-- XXX Some functions in this module are "IO" and others are "m", we need to
91−-- make it consistent.
92−
93-- XXX We can provide another API for "unsafe" FFI calls passing an unlifted
86-- XXX We can provide another API for "unsafe" FFI calls passing an unlifted
94-- pointer to the FFI call. For unsafe calls we do not need to pin the array.
87-- pointer to the FFI call. For unsafe calls we do not need to pin the array.
95-- We can pass an unlifted pointer to the FFI routine to avoid GC kicking in
88-- We can pass an unlifted pointer to the FFI routine to avoid GC kicking in
@@ -118,9 +111,9 @@ touch (MutByteArray contents) =
118--
111--
119-- /Pre-release/
112-- /Pre-release/
120--
113--
121−{-# INLINE unsafePinnedAsPtr #-}
114+{-# INLINE asPtrUnsafe #-}
122−unsafePinnedAsPtr :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
115+asPtrUnsafe :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
123−unsafePinnedAsPtr arr f = do
116+asPtrUnsafe arr f = do
124 contents <- liftIO $ pin arr
117 contents <- liftIO $ pin arr
125 let !ptr = Ptr (byteArrayContents#
118 let !ptr = Ptr (byteArrayContents#
126 (unsafeCoerce# (getMutableByteArray# contents)))
119 (unsafeCoerce# (getMutableByteArray# contents)))
@@ -128,15 +121,10 @@ unsafePinnedAsPtr arr f = do
128 liftIO $ touch contents
121 liftIO $ touch contents
129 return r
122 return r
130
123
131−{-# DEPRECATED asPtrUnsafe "Please use unsafePinnedAsPtr instead." #-}
132−{-# INLINE asPtrUnsafe #-}
133−asPtrUnsafe :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
134−asPtrUnsafe = unsafePinnedAsPtr
135−
136-- | For use with unsafe FFI functions. Does not force pin the array memory.
124-- | For use with unsafe FFI functions. Does not force pin the array memory.
137−{-# INLINE unsafeAsPtr #-}
125+{-# INLINE asUnpinnedPtrUnsafe #-}
138−unsafeAsPtr :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
126+asUnpinnedPtrUnsafe :: MonadIO m => MutByteArray -> (Ptr a -> m b) -> m b
139−unsafeAsPtr arr f = do
127+asUnpinnedPtrUnsafe arr f = do
140 let !ptr = Ptr (byteArrayContents#
128 let !ptr = Ptr (byteArrayContents#
141 (unsafeCoerce# (getMutableByteArray# arr)))
129 (unsafeCoerce# (getMutableByteArray# arr)))
142 r <- f ptr
130 r <- f ptr
@@ -147,16 +135,10 @@ unsafeAsPtr arr f = do
147-- Creation
135-- Creation
148--------------------------------------------------------------------------------
136--------------------------------------------------------------------------------
149
137
150−{-# NOINLINE empty #-}
138+{-# NOINLINE nil #-}
151−empty :: MutByteArray
152−empty = unsafePerformIO $ new 0
153−
154−{-# DEPRECATED nil "Please use empty instead" #-}
155nil :: MutByteArray
139nil :: MutByteArray
156−nil = empty
140+nil = unsafePerformIO $ new 0
157
141
158−-- XXX add "newRounded" to round up the large size to the next page boundary
159−-- and return the allocated size.
160{-# INLINE new #-}
142{-# INLINE new #-}
161new :: Int -> IO MutByteArray
143new :: Int -> IO MutByteArray
162new nbytes | nbytes < 0 =
144new nbytes | nbytes < 0 =
@@ -170,7 +152,7 @@ new (I# nbytes) = IO $ \s ->
170{-# INLINE pinnedNew #-}
152{-# INLINE pinnedNew #-}
171pinnedNew :: Int -> IO MutByteArray
153pinnedNew :: Int -> IO MutByteArray
172pinnedNew nbytes | nbytes < 0 =
154pinnedNew nbytes | nbytes < 0 =
173− errorWithoutStackTrace "pinnedNew: size must be >= 0"
155+ errorWithoutStackTrace "pinnedNewByteArray: size must be >= 0"
174pinnedNew (I# nbytes) = IO $ \s ->
156pinnedNew (I# nbytes) = IO $ \s ->
175 case newPinnedByteArray# nbytes s of
157 case newPinnedByteArray# nbytes s of
176 (# s', mbarr# #) ->
158 (# s', mbarr# #) ->
@@ -196,12 +178,6 @@ newBytesAs Pinned = pinnedNew
196-- Copying
178-- Copying
197-------------------------------------------------------------------------------
179-------------------------------------------------------------------------------
198
180
199−-- Note: Array copy is more efficient than streaming copy.
200−-- CopyMutableByteArray# translates to genMemcpy in GHC/CmmToAsm/X86/CodeGen.hs
201−-- glibc memcpy copies bytes/words/pages - unrolls the loops:
202−-- https://github.com/bminor/glibc/blob/4290aed05135ae4c0272006442d147f2155e70d7/string/memcpy.c
203−-- https://github.com/bminor/glibc/blob/4290aed05135ae4c0272006442d147f2155e70d7/string/wordcopy.c
204−
205-- | Put a sub range of a source array into a subrange of a destination array.
181-- | Put a sub range of a source array into a subrange of a destination array.
206-- This is not safe as it does not check the bounds of neither the src array
182-- This is not safe as it does not check the bounds of neither the src array
207-- nor the destination array.
183-- nor the destination array.
core/src/Streamly/Internal/Data/Serialize/TH.hs+1−5
@@ -7,11 +7,7 @@
7-- Maintainer : streamly@composewell.com
7-- Maintainer : streamly@composewell.com
8-- Stability : experimental
8-- Stability : experimental
9-- Portability : GHC
9-- Portability : GHC
10−
10+--
11−-- XXX Instead of applying the product constructor in one go can we apply it
12−-- one at a time in case of too many arguments, compiler may not have to save
13−-- them in local vars.
14−
15module Streamly.Internal.Data.Serialize.TH
11module Streamly.Internal.Data.Serialize.TH
16 (
12 (
17 -- Deriving
13 -- Deriving
core/src/Streamly/Internal/Data/Stream/Container.hs+48−56
@@ -11,17 +11,16 @@
11
11
12module Streamly.Internal.Data.Stream.Container
12module Streamly.Internal.Data.Stream.Container
13 (
13 (
14− -- * Deduplication
14+ nub
15− ordNub
16
15
17− -- * Joins
16+ -- * Joins for unconstrained types
18− , leftJoin
17+ , joinLeftGeneric
19− , outerJoin
18+ , joinOuterGeneric
20
19
21− -- * Ord Joins
20+ -- * Joins with Ord constraint
22− , innerOrdJoin
21+ , joinInner
23− , leftOrdJoin
22+ , joinLeft
24− , outerOrdJoin
23+ , joinOuter
25 )
24 )
26where
25where
27
26
@@ -48,15 +47,12 @@ import qualified Streamly.Internal.Data.Stream.Transformer as Stream
48
47
49#include "DocTestDataStream.hs"
48#include "DocTestDataStream.hs"
50
49
51−-- | @nub@ specialized to 'Ord' types for better performance. Returns a
52−-- subsequence of the stream removing any duplicate elements.
53−--
54−-- The memory used is proportional to the number of unique elements in the
50+-- | The memory used is proportional to the number of unique elements in the
55−-- stream. One way to limit the memory is to use @take@ on the resulting
51+-- stream. If we want to limit the memory we can just use "take" to limit the
56−-- stream to limit the unique elements in the stream.
52+-- uniq elements in the stream.
57−{-# INLINE_NORMAL ordNub #-}
53+{-# INLINE_NORMAL nub #-}
58−ordNub :: (Monad m, Ord a) => Stream m a -> Stream m a
54+nub :: (Monad m, Ord a) => Stream m a -> Stream m a
59−ordNub (Stream step1 state1) = Stream step (Set.empty, state1)
55+nub (Stream step1 state1) = Stream step (Set.empty, state1)
60
56
61 where
57 where
62
58
@@ -82,8 +78,8 @@ toMap =
82--
78--
83-- XXX An IntMap may be faster when the keys are Int.
79-- XXX An IntMap may be faster when the keys are Int.
84-- XXX Use hashmap instead of map?
80-- XXX Use hashmap instead of map?
85−
81+--
86−-- | 'innerJoin' specialized to 'Ord' types for better performance.
82+-- | Like 'joinInner' but uses a 'Map' for efficiency.
87--
83--
88-- If the input streams have duplicate keys, the behavior is undefined.
84-- If the input streams have duplicate keys, the behavior is undefined.
89--
85--
@@ -94,10 +90,10 @@ toMap =
94-- Time: O(m + n)
90-- Time: O(m + n)
95--
91--
96-- /Pre-release/
92-- /Pre-release/
97−{-# INLINE innerOrdJoin #-}
93+{-# INLINE joinInner #-}
98−innerOrdJoin :: (Monad m, Ord k) =>
94+joinInner :: (Monad m, Ord k) =>
99 Stream m (k, a) -> Stream m (k, b) -> Stream m (k, a, b)
95 Stream m (k, a) -> Stream m (k, b) -> Stream m (k, a, b)
100−innerOrdJoin s1 s2 =
96+joinInner s1 s2 =
101 Stream.concatEffect $ do
97 Stream.concatEffect $ do
102 km <- toMap s2
98 km <- toMap s2
103 pure $ Stream.mapMaybe (joinAB km) s1
99 pure $ Stream.mapMaybe (joinAB km) s1
@@ -110,33 +106,32 @@ innerOrdJoin s1 s2 =
110 Nothing -> Nothing
106 Nothing -> Nothing
111
107
112-- XXX We can do this concurrently.
108-- XXX We can do this concurrently.
113−-- XXX Check performance of StreamD vs StreamK
114-- XXX If the second stream is sorted and passed as an Array or a seek capable
109-- XXX If the second stream is sorted and passed as an Array or a seek capable
115-- stream then we could use binary search if we have an Ord instance or
110-- stream then we could use binary search if we have an Ord instance or
116-- Ordering returning function. The time complexity would then become (m x log
111-- Ordering returning function. The time complexity would then become (m x log
117-- n).
112-- n).
118
113
119−-- | Like 'innerJoin' but emits @(a, Just b)@ whenever a and b are equal, for
114+-- XXX Check performance of StreamD vs StreamK
115+
116+-- | Like 'joinInner' but emit @(a, Just b)@, and additionally, for those @a@'s
120−-- those @a@'s that are not equal to any @b@ emits @(a, Nothing)@.
117+-- that are not equal to any @b@ emit @(a, Nothing)@.
121−--
122−-- This is a generalization of 'innerJoin' to include all elements from the
123−-- left stream and not just those which have an equal in the right stream. This
124−-- is not a commutative operation, the order of the stream arguments matters.
125--
118--
126−-- All the caveats mentioned in 'innerJoin' apply here as well. Right join is
119+-- The second stream is evaluated multiple times. If the stream is a
127−-- not provided because it is just a flipped left join:
120+-- consume-once stream then the caller should cache it in an 'Data.Array.Array'
121+-- before calling this function. Caching may also improve performance if the
122+-- stream is expensive to evaluate.
128--
123--
129−-- >>> rightJoin eq = flip (Stream.leftJoin eq)
124+-- >>> joinRightGeneric eq = flip (Stream.joinLeftGeneric eq)
130--
125--
131-- Space: O(n) assuming the second stream is cached in memory.
126-- Space: O(n) assuming the second stream is cached in memory.
132--
127--
133-- Time: O(m x n)
128-- Time: O(m x n)
134--
129--
135-- /Unimplemented/
130-- /Unimplemented/
136−{-# INLINE leftJoin #-}
131+{-# INLINE joinLeftGeneric #-}
137−leftJoin :: Monad m =>
132+joinLeftGeneric :: Monad m =>
138 (a -> b -> Bool) -> Stream m a -> Stream m b -> Stream m (a, Maybe b)
133 (a -> b -> Bool) -> Stream m a -> Stream m b -> Stream m (a, Maybe b)
139−leftJoin eq s1 s2 = Stream.evalStateT (return False) $ unCross $ do
134+joinLeftGeneric eq s1 s2 = Stream.evalStateT (return False) $ unCross $ do
140 a <- mkCross (Stream.liftInner s1)
135 a <- mkCross (Stream.liftInner s1)
141 -- XXX should we use StreamD monad here?
136 -- XXX should we use StreamD monad here?
142 -- XXX Is there a better way to perform some action at the end of a loop
137 -- XXX Is there a better way to perform some action at the end of a loop
@@ -157,17 +152,19 @@ leftJoin eq s1 s2 = Stream.evalStateT (return False) $ unCross $ do
157 else mkCross Stream.nil
152 else mkCross Stream.nil
158 Nothing -> return (a, Nothing)
153 Nothing -> return (a, Nothing)
159
154
160−-- | 'leftJoin' specialized to 'Ord' types for better performance.
155+-- XXX rename to joinLeftOrd?
156+
157+-- | A more efficient 'joinLeft' using a hashmap for efficiency.
161--
158--
162-- Space: O(n)
159-- Space: O(n)
163--
160--
164-- Time: O(m + n)
161-- Time: O(m + n)
165--
162--
166-- /Pre-release/
163-- /Pre-release/
167−{-# INLINE leftOrdJoin #-}
164+{-# INLINE joinLeft #-}
168−leftOrdJoin :: (Ord k, Monad m) =>
165+joinLeft :: (Ord k, Monad m) =>
169 Stream m (k, a) -> Stream m (k, b) -> Stream m (k, a, Maybe b)
166 Stream m (k, a) -> Stream m (k, b) -> Stream m (k, a, Maybe b)
170−leftOrdJoin s1 s2 =
167+joinLeft s1 s2 =
171 Stream.concatEffect $ do
168 Stream.concatEffect $ do
172 km <- toMap s2
169 km <- toMap s2
173 return $ fmap (joinAB km) s1
170 return $ fmap (joinAB km) s1
@@ -180,19 +177,14 @@ leftOrdJoin s1 s2 =
180 Nothing -> (k, a, Nothing)
177 Nothing -> (k, a, Nothing)
181
178
182-- XXX We can do this concurrently.
179-- XXX We can do this concurrently.
183−-- XXX Check performance of StreamD vs StreamK cross operation.
184
180
181+-- XXX Check performance of StreamD vs StreamK
182+
185−-- | Like 'leftJoin' but emits a @(Just a, Just b)@. Like 'leftJoin', for those
183+-- | Like 'joinLeft' but emits a @(Just a, Just b)@. Like 'joinLeft', for those
186-- @a@'s that are not equal to any @b@ emit @(Just a, Nothing)@, but
184-- @a@'s that are not equal to any @b@ emit @(Just a, Nothing)@, but
187-- additionally, for those @b@'s that are not equal to any @a@ emit @(Nothing,
185-- additionally, for those @b@'s that are not equal to any @a@ emit @(Nothing,
188-- Just b)@.
186-- Just b)@.
189--
187--
190−-- This is a generalization of left join to include all the elements from the
191−-- right stream as well, in other words it is a combination of left and right
192−-- joins. This is a commutative operation. The order of stream arguments can be
193−-- changed without affecting results, except for the ordering of elements in
194−-- the resulting tuple.
195−--
196-- For space efficiency use the smaller stream as the second stream.
188-- For space efficiency use the smaller stream as the second stream.
197--
189--
198-- Space: O(n)
190-- Space: O(n)
@@ -200,15 +192,15 @@ leftOrdJoin s1 s2 =
200-- Time: O(m x n)
192-- Time: O(m x n)
201--
193--
202-- /Pre-release/
194-- /Pre-release/
203−{-# INLINE outerJoin #-}
195+{-# INLINE joinOuterGeneric #-}
204−outerJoin :: MonadIO m =>
196+joinOuterGeneric :: MonadIO m =>
205 (a -> b -> Bool)
197 (a -> b -> Bool)
206 -> Stream m a
198 -> Stream m a
207 -> Stream m b
199 -> Stream m b
208 -> Stream m (Maybe a, Maybe b)
200 -> Stream m (Maybe a, Maybe b)
209−outerJoin eq s1 s2 =
201+joinOuterGeneric eq s1 s =
210 Stream.concatEffect $ do
202 Stream.concatEffect $ do
211− inputArr <- Array.fromStream s2
203+ inputArr <- Array.fromStream s
212 let len = Array.length inputArr
204 let len = Array.length inputArr
213 foundArr <-
205 foundArr <-
214 Stream.fold
206 Stream.fold
@@ -262,18 +254,18 @@ outerJoin eq s1 s2 =
262-- a flag. At the end go through @Stream m b@ and find those that are not in that
254-- a flag. At the end go through @Stream m b@ and find those that are not in that
263-- hash to return (Nothing, b).
255-- hash to return (Nothing, b).
264
256
265−-- | 'outerJoin' specialized to 'Ord' types for better performance.
257+-- | Like 'joinOuter' but uses a 'Map' for efficiency.
266--
258--
267-- Space: O(m + n)
259-- Space: O(m + n)
268--
260--
269-- Time: O(m + n)
261-- Time: O(m + n)
270--
262--
271-- /Pre-release/
263-- /Pre-release/
272−{-# INLINE outerOrdJoin #-}
264+{-# INLINE joinOuter #-}
273−outerOrdJoin ::
265+joinOuter ::
274 (Ord k, MonadIO m) =>
266 (Ord k, MonadIO m) =>
275 Stream m (k, a) -> Stream m (k, b) -> Stream m (k, Maybe a, Maybe b)
267 Stream m (k, a) -> Stream m (k, b) -> Stream m (k, Maybe a, Maybe b)
276−outerOrdJoin s1 s2 =
268+joinOuter s1 s2 =
277 Stream.concatEffect $ do
269 Stream.concatEffect $ do
278 km1 <- kvFold s1
270 km1 <- kvFold s1
279 km2 <- kvFold s2
271 km2 <- kvFold s2
core/src/Streamly/Internal/Data/Stream/Eliminate.hs+25−33
@@ -13,24 +13,36 @@
13--
13--
14module Streamly.Internal.Data.Stream.Eliminate
14module Streamly.Internal.Data.Stream.Eliminate
15 (
15 (
16− -- * Running a Parser
16+ -- * Running a 'Fold'
17+ fold
18+
19+ -- -- * Running a 'Parser'
17− parse
20+ , parse
18 , parseD
21 , parseD
19 , parseBreak
22 , parseBreak
20 , parseBreakD
23 , parseBreakD
21
24
22− -- * Deconstruction
25+ -- * Stream Deconstruction
23 , uncons
26 , uncons
24
27
25 -- * Right Folds
28 -- * Right Folds
29+ , foldrM
30+ , foldr
31+ , foldrMx
26 , foldr1
32 , foldr1
27
33
34+ -- * Left Folds
35+ , foldlM'
36+ , foldl'
37+ , foldlMx'
38+ , foldlx'
39+
28 -- * Specific Fold Functions
40 -- * Specific Fold Functions
41+ , drain
29 , mapM_ -- Map and Fold
42 , mapM_ -- Map and Fold
30 , null
43 , null
31 , head
44 , head
32 , headElse
45 , headElse
33− , init
34 , tail
46 , tail
35 , last
47 , last
36 , elem
48 , elem
@@ -48,9 +60,16 @@ module Streamly.Internal.Data.Stream.Eliminate
48 , the
60 , the
49
61
50 -- * To containers
62 -- * To containers
63+ , toList
51 , toListRev
64 , toListRev
52
65
53 -- * Multi-Stream Folds
66 -- * Multi-Stream Folds
67+ -- ** Comparisons
68+ -- | These should probably be expressed using zipping operations.
69+ , eqBy
70+ , cmpBy
71+
72+ -- ** Substreams
54 -- | These should probably be expressed using parsers.
73 -- | These should probably be expressed using parsers.
55 , isPrefixOf
74 , isPrefixOf
56 , isInfixOf
75 , isInfixOf
@@ -71,7 +90,7 @@ import Foreign.Storable (Storable)
71import GHC.Exts (SpecConstrAnnotation(..))
90import GHC.Exts (SpecConstrAnnotation(..))
72import GHC.Types (SPEC(..))
91import GHC.Types (SPEC(..))
73import Streamly.Internal.Data.Parser (ParseError(..))
92import Streamly.Internal.Data.Parser (ParseError(..))
74−import Streamly.Internal.Data.SVar.Type (adaptState, defState)
93+import Streamly.Internal.Data.SVar.Type (defState)
75import Streamly.Internal.Data.Unbox (Unbox)
94import Streamly.Internal.Data.Unbox (Unbox)
76
95
77import Streamly.Internal.Data.Maybe.Strict (Maybe'(..))
96import Streamly.Internal.Data.Maybe.Strict (Maybe'(..))
@@ -86,7 +105,7 @@ import qualified Streamly.Internal.Data.Stream.Transform as StreamD
86
105
87import Prelude hiding
106import Prelude hiding
88 ( Foldable(..), all, any, head, last, lookup, mapM, mapM_
107 ( Foldable(..), all, any, head, last, lookup, mapM, mapM_
89− , notElem, splitAt, init, tail, (!!))
108+ , notElem, splitAt, tail, (!!))
90import Data.Foldable (length)
109import Data.Foldable (length)
91import Streamly.Internal.Data.Stream.Type
110import Streamly.Internal.Data.Stream.Type
92
111
@@ -372,35 +391,9 @@ head = foldrM (\x _ -> return (Just x)) (return Nothing)
372headElse :: Monad m => a -> Stream m a -> m a
391headElse :: Monad m => a -> Stream m a -> m a
373headElse a = foldrM (\x _ -> return x) (return a)
392headElse a = foldrM (\x _ -> return x) (return a)
374
393
375−{-# INLINE_NORMAL init #-}
376−init :: Monad m => Stream m a -> m (Maybe (Stream m a))
377−init stream = do
378− r <- uncons stream
379− case r of
380− Nothing -> return Nothing
381− Just (h, Stream step1 state1) ->
382− return $ Just $ Stream step (h, state1)
383−
384− where
385−
386− step gst (a, s1) = do
387− res <- step1 (adaptState gst) s1
388− return $
389− case res of
390− Yield x s -> Yield a (x, s)
391− Skip s -> Skip (a, s)
392− Stop -> Stop
393−
394−-- | Same as:
395−--
396−-- >>> tail = fmap (fmap snd) . Stream.uncons
397−--
398-- Does not fuse, has the same performance as the StreamK version.
394-- Does not fuse, has the same performance as the StreamK version.
399−--
400{-# INLINE_NORMAL tail #-}
395{-# INLINE_NORMAL tail #-}
401tail :: Monad m => Stream m a -> m (Maybe (Stream m a))
396tail :: Monad m => Stream m a -> m (Maybe (Stream m a))
402−tail = fmap (fmap snd) . uncons
403−{-
404tail (UnStream step state) = go SPEC state
397tail (UnStream step state) = go SPEC state
405 where
398 where
406 go !_ st = do
399 go !_ st = do
@@ -409,7 +402,6 @@ tail (UnStream step state) = go SPEC state
409 Yield _ s -> return (Just $ Stream step s)
402 Yield _ s -> return (Just $ Stream step s)
410 Skip s -> go SPEC s
403 Skip s -> go SPEC s
411 Stop -> return Nothing
404 Stop -> return Nothing
412−-}
413
405
414-- XXX will it fuse? need custom impl?
406-- XXX will it fuse? need custom impl?
415{-# INLINE_NORMAL last #-}
407{-# INLINE_NORMAL last #-}
core/src/Streamly/Internal/Data/Stream/Exception.hs+6−9
@@ -9,20 +9,17 @@
9
9
10module Streamly.Internal.Data.Stream.Exception
10module Streamly.Internal.Data.Stream.Exception
11 (
11 (
12− -- * Resources
13− before
14− , afterIO
15− , afterUnsafe
16− , finallyIO
17− , finallyUnsafe
18− , gbracket_
12+ gbracket_
19 , gbracket
13 , gbracket
14+ , before
15+ , afterUnsafe
16+ , afterIO
20 , bracketUnsafe
17 , bracketUnsafe
21 , bracketIO3
18 , bracketIO3
22 , bracketIO
19 , bracketIO
23−
24− -- * Exceptions
25 , onException
20 , onException
21+ , finallyUnsafe
22+ , finallyIO
26 , ghandle
23 , ghandle
27 , handle
24 , handle
28 )
25 )
core/src/Streamly/Internal/Data/Stream/Generate.hs+12
@@ -16,13 +16,20 @@ module Streamly.Internal.Data.Stream.Generate
16 (
16 (
17 -- * Primitives
17 -- * Primitives
18 nil
18 nil
19+ , nilM
19 , cons
20 , cons
21+ , consM
22+
23+ -- * From 'Unfold'
24+ , unfold
20
25
21 -- * Unfolding
26 -- * Unfolding
22 , unfoldr
27 , unfoldr
23 , unfoldrM
28 , unfoldrM
24
29
25 -- * From Values
30 -- * From Values
31+ , fromPure
32+ , fromEffect
26 , repeat
33 , repeat
27 , repeatM
34 , repeatM
28 , replicate
35 , replicate
@@ -88,6 +95,7 @@ module Streamly.Internal.Data.Stream.Generate
88 -- * From Containers
95 -- * From Containers
89 -- | Transform an input structure into a stream.
96 -- | Transform an input structure into a stream.
90
97
98+ , fromList
91 , fromListM
99 , fromListM
92 , fromFoldable
100 , fromFoldable
93 , fromFoldableM
101 , fromFoldableM
@@ -96,6 +104,10 @@ module Streamly.Internal.Data.Stream.Generate
96 , fromPtr
104 , fromPtr
97 , fromPtrN
105 , fromPtrN
98 , fromByteStr#
106 , fromByteStr#
107+
108+ -- * Conversions
109+ , fromStreamK
110+ , toStreamK
99 )
111 )
100where
112where
101
113
core/src/Streamly/Internal/Data/Stream/Nesting.hs+139−10
@@ -55,6 +55,11 @@ module Streamly.Internal.Data.Stream.Nesting
55 -- yields an element. A special case of unfoldRoundRobin.
55 -- yields an element. A special case of unfoldRoundRobin.
56 , roundRobin -- interleaveFair?/ParallelFair
56 , roundRobin -- interleaveFair?/ParallelFair
57
57
58+ -- *** Zipping
59+ -- | Zip corresponding elements of two streams.
60+ , zipWith
61+ , zipWithM
62+
58 -- *** Merging
63 -- *** Merging
59 -- | Interleave elements from two streams based on a condition.
64 -- | Interleave elements from two streams based on a condition.
60 , mergeBy
65 , mergeBy
@@ -71,10 +76,17 @@ module Streamly.Internal.Data.Stream.Nesting
71 -- unfoldMany: Unfold m a b -> t m a -> t m b
76 -- unfoldMany: Unfold m a b -> t m a -> t m b
72 -- @
77 -- @
73
78
79+ -- *** ConcatMap
80+ -- | Generate streams by mapping a stream generator on each element of an
81+ -- input stream, append the resulting streams and flatten.
82+ , concatMap
83+ , concatMapM
84+
74 -- *** ConcatUnfold
85 -- *** ConcatUnfold
75 -- | Generate streams by using an unfold on each element of an input
86 -- | Generate streams by using an unfold on each element of an input
76 -- stream, append the resulting streams and flatten. A special case of
87 -- stream, append the resulting streams and flatten. A special case of
77 -- gintercalate.
88 -- gintercalate.
89+ , unfoldMany
78 , ConcatUnfoldInterleaveState (..)
90 , ConcatUnfoldInterleaveState (..)
79 , unfoldInterleave
91 , unfoldInterleave
80 , unfoldRoundRobin
92 , unfoldRoundRobin
@@ -106,8 +118,11 @@ module Streamly.Internal.Data.Stream.Nesting
106
118
107 -- ** Folding
119 -- ** Folding
108 -- | Apply folds on a stream.
120 -- | Apply folds on a stream.
121+ , foldMany
122+ , refoldMany
109 , foldSequence
123 , foldSequence
110 , foldIterateM
124 , foldIterateM
125+ , refoldIterateM
111
126
112 -- ** Parsing
127 -- ** Parsing
113 -- | Parsing is opposite to flattening. 'parseMany' is dual to concatMap or
128 -- | Parsing is opposite to flattening. 'parseMany' is dual to concatMap or
@@ -124,6 +139,7 @@ module Streamly.Internal.Data.Stream.Nesting
124
139
125 -- ** Grouping
140 -- ** Grouping
126 -- | Group segments of a stream and fold. Special case of parsing.
141 -- | Group segments of a stream and fold. Special case of parsing.
142+ , groupsOf
127 , groupsBy
143 , groupsBy
128 , groupsWhile
144 , groupsWhile
129 , groupsRollingBy
145 , groupsRollingBy
@@ -131,8 +147,9 @@ module Streamly.Internal.Data.Stream.Nesting
131 -- ** Splitting
147 -- ** Splitting
132 -- | A special case of parsing.
148 -- | A special case of parsing.
133 , wordsBy
149 , wordsBy
134− , splitOnSeq -- XXX splitOnSeg
150+ , splitOnSeq
135− , splitOnSuffixSeq -- XXX splitOnSegSuffix, splitOnTrailer
151+ , splitOnSuffixSeq
152+ , sliceOnSuffix
136
153
137 -- XXX Implement these as folds or parsers instead.
154 -- XXX Implement these as folds or parsers instead.
138 , splitOnSuffixSeqAny
155 , splitOnSuffixSeqAny
@@ -141,8 +158,9 @@ module Streamly.Internal.Data.Stream.Nesting
141
158
142 -- * Transform (Nested Containers)
159 -- * Transform (Nested Containers)
143 -- | Opposite to compact in ArrayStream
160 -- | Opposite to compact in ArrayStream
144− , splitInnerBy -- XXX innerSplitOn
161+ , splitInnerBy
145− , splitInnerBySuffix -- XXX innerSplitOnSuffix
162+ , splitInnerBySuffix
163+ , intersectBySorted
146
164
147 -- * Reduce By Streams
165 -- * Reduce By Streams
148 , dropPrefix
166 , dropPrefix
@@ -164,9 +182,12 @@ import Fusion.Plugin.Types (Fuse(..))
164import GHC.Types (SPEC(..))
182import GHC.Types (SPEC(..))
165
183
166import Streamly.Internal.Data.Array.Type (Array(..))
184import Streamly.Internal.Data.Array.Type (Array(..))
185+import Streamly.Internal.Data.Fold.Step (Step(..))
167import Streamly.Internal.Data.Fold.Type (Fold(..))
186import Streamly.Internal.Data.Fold.Type (Fold(..))
168import Streamly.Internal.Data.Parser (ParseError(..))
187import Streamly.Internal.Data.Parser (ParseError(..))
188+import Streamly.Internal.Data.Refold.Type (Refold(..))
169import Streamly.Internal.Data.SVar.Type (adaptState)
189import Streamly.Internal.Data.SVar.Type (adaptState)
190+import Streamly.Internal.Data.Tuple.Strict (Tuple'(..))
170import Streamly.Internal.Data.Unbox (Unbox, sizeOf)
191import Streamly.Internal.Data.Unbox (Unbox, sizeOf)
171import Streamly.Internal.Data.Unfold.Type (Unfold(..))
192import Streamly.Internal.Data.Unfold.Type (Unfold(..))
172
193
@@ -592,6 +613,49 @@ mergeFstBy :: -- Monad m =>
592mergeFstBy _f _m1 _m2 = undefined
613mergeFstBy _f _m1 _m2 = undefined
593 -- fromStreamK $ D.mergeFstBy f (toStreamD m1) (toStreamD m2)
614 -- fromStreamK $ D.mergeFstBy f (toStreamD m1) (toStreamD m2)
594
615
616+-------------------------------------------------------------------------------
617+-- Intersection of sorted streams
618+-------------------------------------------------------------------------------
619+
620+-- Assuming the streams are sorted in ascending order
621+{-# INLINE_NORMAL intersectBySorted #-}
622+intersectBySorted :: Monad m
623+ => (a -> a -> Ordering) -> Stream m a -> Stream m a -> Stream m a
624+intersectBySorted cmp (Stream stepa ta) (Stream stepb tb) =
625+ Stream step
626+ ( ta -- left stream state
627+ , tb -- right stream state
628+ , Nothing -- left value
629+ , Nothing -- right value
630+ )
631+
632+ where
633+
634+ {-# INLINE_LATE step #-}
635+ -- step 1, fetch the first value
636+ step gst (sa, sb, Nothing, b) = do
637+ r <- stepa gst sa
638+ return $ case r of
639+ Yield a sa' -> Skip (sa', sb, Just a, b) -- step 2/3
640+ Skip sa' -> Skip (sa', sb, Nothing, b)
641+ Stop -> Stop
642+
643+ -- step 2, fetch the second value
644+ step gst (sa, sb, a@(Just _), Nothing) = do
645+ r <- stepb gst sb
646+ return $ case r of
647+ Yield b sb' -> Skip (sa, sb', a, Just b) -- step 3
648+ Skip sb' -> Skip (sa, sb', a, Nothing)
649+ Stop -> Stop
650+
651+ -- step 3, compare the two values
652+ step _ (sa, sb, Just a, Just b) = do
653+ let res = cmp a b
654+ return $ case res of
655+ GT -> Skip (sa, sb, Just a, Nothing) -- step 2
656+ LT -> Skip (sa, sb, Nothing, Just b) -- step 1
657+ EQ -> Yield a (sa, sb, Nothing, Just b) -- step 1
658+
595------------------------------------------------------------------------------
659------------------------------------------------------------------------------
596-- Combine N Streams - unfoldMany
660-- Combine N Streams - unfoldMany
597------------------------------------------------------------------------------
661------------------------------------------------------------------------------
@@ -1230,6 +1294,77 @@ foldIterateM func seed0 (Stream step state) =
1230 stepOuter _ (FIterYield a next) = return $ Yield a next
1294 stepOuter _ (FIterYield a next) = return $ Yield a next
1231 stepOuter _ FIterStop = return Stop
1295 stepOuter _ FIterStop = return Stop
1232
1296
1297+{-# ANN type CIterState Fuse #-}
1298+data CIterState s f fs b
1299+ = CIterInit s f
1300+ | CIterConsume s fs
1301+ | CIterYield b (CIterState s f fs b)
1302+ | CIterStop
1303+
1304+-- | Like 'foldIterateM' but using the 'Refold' type instead. This could be
1305+-- much more efficient due to stream fusion.
1306+--
1307+-- /Internal/
1308+{-# INLINE_NORMAL refoldIterateM #-}
1309+refoldIterateM ::
1310+ Monad m => Refold m b a b -> m b -> Stream m a -> Stream m b
1311+refoldIterateM (Refold fstep finject fextract) initial (Stream step state) =
1312+ Stream stepOuter (CIterInit state initial)
1313+
1314+ where
1315+
1316+ {-# INLINE iterStep #-}
1317+ iterStep st action = do
1318+ res <- action
1319+ return
1320+ $ Skip
1321+ $ case res of
1322+ FL.Partial fs -> CIterConsume st fs
1323+ FL.Done fb -> CIterYield fb $ CIterInit st (return fb)
1324+
1325+ {-# INLINE_LATE stepOuter #-}
1326+ stepOuter _ (CIterInit st action) = do
1327+ iterStep st (action >>= finject)
1328+ stepOuter gst (CIterConsume st fs) = do
1329+ r <- step (adaptState gst) st
1330+ case r of
1331+ Yield x s -> iterStep s (fstep fs x)
1332+ Skip s -> return $ Skip $ CIterConsume s fs
1333+ Stop -> do
1334+ b <- fextract fs
1335+ return $ Skip $ CIterYield b CIterStop
1336+ stepOuter _ (CIterYield a next) = return $ Yield a next
1337+ stepOuter _ CIterStop = return Stop
1338+
1339+-- "n" elements at the end are dropped by the fold.
1340+{-# INLINE sliceBy #-}
1341+sliceBy :: Monad m => Fold m a Int -> Int -> Refold m (Int, Int) a (Int, Int)
1342+sliceBy (Fold step1 initial1 extract1 _final) n = Refold step inject extract
1343+
1344+ where
1345+
1346+ inject (i, len) = do
1347+ r <- initial1
1348+ return $ case r of
1349+ Partial s -> Partial $ Tuple' (i + len + n) s
1350+ Done l -> Done (i, l)
1351+
1352+ step (Tuple' i s) x = do
1353+ r <- step1 s x
1354+ return $ case r of
1355+ Partial s1 -> Partial $ Tuple' i s1
1356+ Done len -> Done (i, len)
1357+
1358+ extract (Tuple' i s) = (i,) <$> extract1 s
1359+
1360+{-# INLINE sliceOnSuffix #-}
1361+sliceOnSuffix :: Monad m => (a -> Bool) -> Stream m a -> Stream m (Int, Int)
1362+sliceOnSuffix predicate =
1363+ -- Scan the stream with the given refold
1364+ refoldIterateM
1365+ (sliceBy (FL.takeEndBy_ predicate FL.length) 1)
1366+ (return (-1, 0))
1367+
1233------------------------------------------------------------------------------
1368------------------------------------------------------------------------------
1234-- Parsing
1369-- Parsing
1235------------------------------------------------------------------------------
1370------------------------------------------------------------------------------
@@ -2986,8 +3121,6 @@ splitInnerBySuffix isEmpty splitter joiner (Stream step1 state1) =
2986--
3121--
2987-- Space: @O(1)@
3122-- Space: @O(1)@
2988--
3123--
2989−-- See also stripPrefix.
2990−--
2991-- /Unimplemented/
3124-- /Unimplemented/
2992{-# INLINE dropPrefix #-}
3125{-# INLINE dropPrefix #-}
2993dropPrefix ::
3126dropPrefix ::
@@ -3000,8 +3133,6 @@ dropPrefix = error "Not implemented yet!"
3000--
3133--
3001-- Space: @O(n)@ where n is the length of the infix.
3134-- Space: @O(n)@ where n is the length of the infix.
3002--
3135--
3003−-- See also stripInfix.
3004−--
3005-- /Unimplemented/
3136-- /Unimplemented/
3006{-# INLINE dropInfix #-}
3137{-# INLINE dropInfix #-}
3007dropInfix ::
3138dropInfix ::
@@ -3014,8 +3145,6 @@ dropInfix = error "Not implemented yet!"
3014--
3145--
3015-- Space: @O(n)@ where n is the length of the suffix.
3146-- Space: @O(n)@ where n is the length of the suffix.
3016--
3147--
3017−-- See also stripSuffix.
3018−--
3019-- /Unimplemented/
3148-- /Unimplemented/
3020{-# INLINE dropSuffix #-}
3149{-# INLINE dropSuffix #-}
3021dropSuffix ::
3150dropSuffix ::
core/src/Streamly/Internal/Data/Stream/Top.hs+115−243
@@ -8,73 +8,38 @@
8-- Portability : GHC
8-- Portability : GHC
9--
9--
10-- Top level module that can depend on all other lower level Stream modules.
10-- Top level module that can depend on all other lower level Stream modules.
11−--
12−-- Design notes:
13−--
14−-- The order of arguments in the join operations should ideally be opposite. It
15−-- should be such that the infinite stream is the last one. The transformation
16−-- should be on the last argument, so if you curry the functions with all other
17−-- arguments we get a @Stream -> Stream@ function. The first stream argument
18−-- may be considered as a config or modifier for the operation.
19−--
20−-- Benefit of changing the order is that we get a more intuitive Stream ->
21−-- Stream transformation after currying all other arguments. The inner loop
22−-- streams become arguments for the transformation, more like local modifiers
23−-- for the global outer stream as the last argument. Thus we can continue using
24−-- transformations on the outer stream in a composed pipeline. Otherwise we can
25−-- use flip to flip the order.
26−--
27−-- The fact that the inner stream can be used in the loop multiple times also
28−-- tells that this is not the real effectful stream, it is more like a pure
29−-- stream or an array. In fact we may consider using an Identity streams as
30−-- inner streams in which case these functions will not look nice.
31−--
32−-- Downsides:
33−--
34−-- * Maybe less intuitive to think about, because we usually think the first
35−-- stream as the outer loop and second as the inner.
36−-- * Zip and merge operations will continue using the opposite order.
37−-- * Need to change the order of cross, crossWith operations as well
38−-- * It will be inconsistent with Data.List. The functions cannot be used as
39−-- intuitive operators.
40−--
41−-- The choice is similar to concatMap vs bind. concatMap is pipeline
42−-- composition friendly but bind is user intuition friendly. Another option is
43−-- to have other functions with a different argument order e.g. flippedCross
44−-- instead of cross.
45−--
46−-- If we change the order we have to make sure that we have a consistent
47−-- convention for set-like and the cross join operations.
48
11
49module Streamly.Internal.Data.Stream.Top
12module Streamly.Internal.Data.Stream.Top
50 (
13 (
14+ -- * Transformation
51− -- * Sampling
15+ -- ** Sampling
52 -- | Value agnostic filtering.
16 -- | Value agnostic filtering.
53 strideFromThen
17 strideFromThen
54
18
55− -- * Straight Joins
19+ -- * Nesting
20+ -- ** Set like operations
56− -- | These are set-like operations but not exactly set operations because
21+ -- | These are not exactly set operations because streams are not
57− -- streams are not necessarily sets, they may have duplicated elements.
22+ -- necessarily sets, they may have duplicated elements. These operations
58− -- These operations are generic i.e. they work on streams of unconstrained
23+ -- are generic i.e. they work on streams of unconstrained types, therefore,
59− -- types, therefore, they have quadratic performance characterstics. For
24+ -- they have quadratic performance characterstics. For better performance
60− -- better performance using Set or Map structures see the
61− -- Streamly.Internal.Data.Stream.Container module.
25+ -- using Set structures see the Streamly.Internal.Data.Stream.Container
62− , intersectBy
26+ -- module.
63− , deleteFirstsBy
27+ , filterInStreamGenericBy
64− , unionBy
28+ , deleteInStreamGenericBy
65−
29+ , unionWithStreamGenericBy
30+
66− -- Set like operations on sorted streams
31+ -- ** Set like operations on sorted streams
67− , sortedIntersectBy
32+ , filterInStreamAscBy
68− , sortedDeleteFirstsBy
33+ , deleteInStreamAscBy
69− , sortedUnionBy
34+ , unionWithStreamAscBy
70−
35+
71− -- * Cross Joins
36+ -- ** Join operations
72− , innerJoin
37+ , joinInnerGeneric
73−
38+
74− -- Joins on sorted stream
39+ -- * Joins on sorted stream
75− , innerSortedJoin
40+ , joinInnerAscBy
76− , leftSortedJoin
41+ , joinLeftAscBy
77− , outerSortedJoin
42+ , joinOuterAscBy
78 )
43 )
79where
44where
80
45
@@ -83,7 +48,7 @@ where
83import Control.Monad.IO.Class (MonadIO(..))
48import Control.Monad.IO.Class (MonadIO(..))
84import Data.IORef (newIORef, readIORef, modifyIORef')
49import Data.IORef (newIORef, readIORef, modifyIORef')
85import Streamly.Internal.Data.Fold.Type (Fold)
50import Streamly.Internal.Data.Fold.Type (Fold)
86−import Streamly.Internal.Data.Stream.Type (Stream(..), Step(..), cross)
51+import Streamly.Internal.Data.Stream.Type (Stream, cross)
87
52
88import qualified Data.List as List
53import qualified Data.List as List
89import qualified Streamly.Internal.Data.Fold as Fold
54import qualified Streamly.Internal.Data.Fold as Fold
@@ -145,40 +110,29 @@ strideFromThen offset stride =
145-- binary search if we have an Ord instance or Ordering returning function. The
110-- binary search if we have an Ord instance or Ordering returning function. The
146-- time complexity would then become (m x log n).
111-- time complexity would then become (m x log n).
147
112
148−-- | Like 'cross' but emits only those tuples where @a == b@ using the supplied
113+-- | Like 'cross' but emits only those tuples where @a == b@ using the
149−-- equality predicate. This is essentially a @cross intersection@ of two
114+-- supplied equality predicate.
150−-- streams.
151--
115--
152-- Definition:
116-- Definition:
153--
117--
154−-- >>> innerJoin eq s1 s2 = Stream.filter (\(a, b) -> a `eq` b) $ Stream.cross s1 s2
118+-- >>> joinInnerGeneric eq s1 s2 = Stream.filter (\(a, b) -> a `eq` b) $ Stream.cross s1 s2
155−--
156−-- The second (inner) stream must be finite. Moreover, it must be either pure
157−-- or capable of multiple evaluations. If not then the caller should cache it
158−-- in an 'Data.Array.Array', if the type does not have an 'Unbox' instance then
159−-- use the Generic 'Data.Array.Generic.Array'. Convert the array to stream
160−-- before calling this function. Caching may also improve performance if the
161−-- stream is expensive to evaluate.
162--
119--
163−-- If you care about performance this function should be your last choice among
120+-- You should almost always prefer @joinInnerOrd@ over 'joinInnerGeneric' if
164−-- all inner joins. 'Streamly.Internal.Data.Unfold.innerJoin' is a much faster
165−-- fused alternative. 'innerSortedJoin' is a faster alternative when streams
166−-- are sorted. 'innerOrdJoin' is an order of magnitude faster alternative when
121+-- possible. @joinInnerOrd@ is an order of magnitude faster but may take more
167−-- the type has an 'Ord' instance.
122+-- space for caching the second stream.
168--
123--
169−-- Note: Conceptually, this is a commutative operation. Result includes all the
124+-- See 'Streamly.Internal.Data.Unfold.joinInnerGeneric' for a much faster fused
170−-- elements from the left and the right stream. The order of streams can be
125+-- alternative.
171−-- changed without affecting results, except for the ordering within the tuple.
172--
126--
173-- Time: O(m x n)
127-- Time: O(m x n)
174--
128--
175-- /Pre-release/
129-- /Pre-release/
176−{-# INLINE innerJoin #-}
130+{-# INLINE joinInnerGeneric #-}
177−innerJoin :: Monad m =>
131+joinInnerGeneric :: Monad m =>
178 (a -> b -> Bool) -> Stream m a -> Stream m b -> Stream m (a, b)
132 (a -> b -> Bool) -> Stream m a -> Stream m b -> Stream m (a, b)
179−innerJoin eq s1 s2 = Stream.filter (\(a, b) -> a `eq` b) $ cross s1 s2
133+joinInnerGeneric eq s1 s2 = Stream.filter (\(a, b) -> a `eq` b) $ cross s1 s2
180{-
134{-
181−innerJoin eq s1 s2 = do
135+joinInnerGeneric eq s1 s2 = do
182 -- ConcatMap works faster than bind
136 -- ConcatMap works faster than bind
183 Stream.concatMap (\a ->
137 Stream.concatMap (\a ->
184 Stream.concatMap (\b ->
138 Stream.concatMap (\b ->
@@ -189,44 +143,44 @@ innerJoin eq s1 s2 = do
189 ) s1
143 ) s1
190-}
144-}
191
145
192−-- | A more efficient 'innerJoin' for sorted streams.
146+-- | A more efficient 'joinInner' for sorted streams.
193--
147--
194-- Space: O(1)
148-- Space: O(1)
195--
149--
196-- Time: O(m + n)
150-- Time: O(m + n)
197--
151--
198-- /Unimplemented/
152-- /Unimplemented/
199−{-# INLINE innerSortedJoin #-}
153+{-# INLINE joinInnerAscBy #-}
200−innerSortedJoin ::
154+joinInnerAscBy ::
201 (a -> b -> Ordering) -> Stream m a -> Stream m b -> Stream m (a, b)
155 (a -> b -> Ordering) -> Stream m a -> Stream m b -> Stream m (a, b)
202−innerSortedJoin = undefined
156+joinInnerAscBy = undefined
203
157
204−-- | A more efficient 'leftJoin' for sorted streams.
158+-- | A more efficient 'joinLeft' for sorted streams.
205--
159--
206-- Space: O(1)
160-- Space: O(1)
207--
161--
208-- Time: O(m + n)
162-- Time: O(m + n)
209--
163--
210-- /Unimplemented/
164-- /Unimplemented/
211−{-# INLINE leftSortedJoin #-}
165+{-# INLINE joinLeftAscBy #-}
212−leftSortedJoin :: -- Monad m =>
166+joinLeftAscBy :: -- Monad m =>
213 (a -> b -> Ordering) -> Stream m a -> Stream m b -> Stream m (a, Maybe b)
167 (a -> b -> Ordering) -> Stream m a -> Stream m b -> Stream m (a, Maybe b)
214−leftSortedJoin _eq _s1 _s2 = undefined
168+joinLeftAscBy _eq _s1 _s2 = undefined
215
169
216−-- | A more efficient 'outerJoin' for sorted streams.
170+-- | A more efficient 'joinOuter' for sorted streams.
217--
171--
218-- Space: O(1)
172-- Space: O(1)
219--
173--
220-- Time: O(m + n)
174-- Time: O(m + n)
221--
175--
222-- /Unimplemented/
176-- /Unimplemented/
223−{-# INLINE outerSortedJoin #-}
177+{-# INLINE joinOuterAscBy #-}
224−outerSortedJoin :: -- Monad m =>
178+joinOuterAscBy :: -- Monad m =>
225 (a -> b -> Ordering)
179 (a -> b -> Ordering)
226 -> Stream m a
180 -> Stream m a
227 -> Stream m b
181 -> Stream m b
228 -> Stream m (Maybe a, Maybe b)
182 -> Stream m (Maybe a, Maybe b)
229−outerSortedJoin _eq _s1 _s2 = undefined
183+joinOuterAscBy _eq _s1 _s2 = undefined
230
184
231------------------------------------------------------------------------------
185------------------------------------------------------------------------------
232-- Set operations (special joins)
186-- Set operations (special joins)
@@ -236,8 +190,8 @@ outerSortedJoin _eq _s1 _s2 = undefined
236-- the best would be to use an Array with linear search. If the second stream
190-- the best would be to use an Array with linear search. If the second stream
237-- is sorted we can also use a binary search, using Ord constraint.
191-- is sorted we can also use a binary search, using Ord constraint.
238
192
239−-- | Keep only those elements in the first stream that are present in the
193+-- | Keep only those elements in the second stream that are present in the
240−-- second stream too. The second stream is folded to a container using the
194+-- first stream too. The first stream is folded to a container using the
241-- supplied fold and then the elements in the container are looked up using the
195-- supplied fold and then the elements in the container are looked up using the
242-- supplied lookup function.
196-- supplied lookup function.
243--
197--
@@ -252,30 +206,23 @@ filterStreamWith :: Monad m =>
252filterStreamWith fld member s1 s2 =
206filterStreamWith fld member s1 s2 =
253 Stream.concatEffect
207 Stream.concatEffect
254 $ do
208 $ do
255− xs <- Stream.fold fld s2
209+ xs <- Stream.fold fld s1
256− return $ Stream.filter (`member` xs) s1
210+ return $ Stream.filter (`member` xs) s2
257−
258−-- XXX instead of folding the second stream to a list we could use it directly.
259−-- If the user wants they can generate the stream from an array and also call
260−-- uniq or nub on it. We can provide a convenience Stream -> Stream to cache
261−-- a finite stream in an array and serve it from the cache. The user can decide
262−-- what is best based on the context. They can also choose to use a boxed or
263−-- unboxed array for caching. To force caching we can make the second stream
264−-- monad type Identity. But that may be less flexible. One option is to use
265−-- cachedIntersectBy etc for automatic caching.
266
211
267−-- | 'intersectBy' returns a subsequence of the first stream which intersects
212+-- | 'filterInStreamGenericBy' retains only those elements in the second stream that
268−-- with the second stream. Note that this is not a commutative operation unlike
213+-- are present in the first stream.
269−-- a set intersection, because of duplicate elements in the stream the order of
270−-- the streams matters. This is similar to 'Data.List.intersectBy'. Note that
271−-- intersectBy is a special case of 'innerJoin'.
272--
214--
273−-- >>> f s1 s2 = Stream.fold Fold.toList $ Stream.intersectBy (==) (Stream.fromList s1) (Stream.fromList s2)
215+-- >>> Stream.fold Fold.toList $ Stream.filterInStreamGenericBy (==) (Stream.fromList [1,2,2,4]) (Stream.fromList [2,1,1,3])
274−-- >>> f [1,3,4,4,5]) [2,3,4,5,5]
216+-- [2,1,1]
275−-- [3,4,4,5]
276--
217--
218+-- >>> Stream.fold Fold.toList $ Stream.filterInStreamGenericBy (==) (Stream.fromList [2,1,1,3]) (Stream.fromList [1,2,2,4])
219+-- [1,2,2]
220+--
221+-- Similar to the list intersectBy operation but with the stream argument order
222+-- flipped.
223+--
277−-- First stream can be infinite, the second stream must be finite and must be
224+-- The first stream must be finite and must not block. Second stream is
278−-- capable of multiple evaluations.
225+-- processed only after the first stream is fully realized.
279--
226--
280-- Space: O(n) where @n@ is the number of elements in the second stream.
227-- Space: O(n) where @n@ is the number of elements in the second stream.
281--
228--
@@ -283,87 +230,46 @@ filterStreamWith fld member s1 s2 =
283-- @n@ is the number of elements in the second stream.
230-- @n@ is the number of elements in the second stream.
284--
231--
285-- /Pre-release/
232-- /Pre-release/
286−{-# INLINE intersectBy #-}
233+{-# INLINE filterInStreamGenericBy #-}
287−intersectBy :: Monad m =>
234+filterInStreamGenericBy :: Monad m =>
288 (a -> a -> Bool) -> Stream m a -> Stream m a -> Stream m a
235 (a -> a -> Bool) -> Stream m a -> Stream m a -> Stream m a
289−intersectBy eq =
236+filterInStreamGenericBy eq =
290 -- XXX Use an (unboxed) array instead.
237 -- XXX Use an (unboxed) array instead.
291 filterStreamWith
238 filterStreamWith
292 (Fold.scanMaybe (Fold.uniqBy eq) Fold.toListRev)
239 (Fold.scanMaybe (Fold.uniqBy eq) Fold.toListRev)
293 (List.any . eq)
240 (List.any . eq)
294
241
295−-------------------------------------------------------------------------------
296−-- Intersection of sorted streams
297−-------------------------------------------------------------------------------
298−
299−-- XXX The sort order is not important as long both the streams have the same
300−-- sort order. We need to move only in one direction in each stream.
301−-- XXX Fix the argument order to use the same behavior as intersectBy.
302−
303−-- | Like 'intersectBy' but assumes that the input streams are sorted in
242+-- | Like 'filterInStreamGenericBy' but assumes that the input streams are sorted in
304-- ascending order. To use it on streams sorted in descending order pass an
243-- ascending order. To use it on streams sorted in descending order pass an
305-- inverted comparison function returning GT for less than and LT for greater
244-- inverted comparison function returning GT for less than and LT for greater
306-- than.
245-- than.
307--
246--
308−-- Both streams can be infinite.
309−--
310-- Space: O(1)
247-- Space: O(1)
311--
248--
312-- Time: O(m+n)
249-- Time: O(m+n)
313--
250--
314-- /Pre-release/
251-- /Pre-release/
315−{-# INLINE_NORMAL sortedIntersectBy #-}
252+{-# INLINE filterInStreamAscBy #-}
316−sortedIntersectBy :: Monad m =>
253+filterInStreamAscBy :: Monad m =>
317 (a -> a -> Ordering) -> Stream m a -> Stream m a -> Stream m a
254 (a -> a -> Ordering) -> Stream m a -> Stream m a -> Stream m a
318−sortedIntersectBy cmp (Stream stepa ta) (Stream stepb tb) =
255+filterInStreamAscBy eq s1 s2 = Stream.intersectBySorted eq s2 s1
319− Stream step
320− ( ta -- left stream state
321− , tb -- right stream state
322− , Nothing -- left value
323− , Nothing -- right value
324− )
325−
326− where
327
256
328− {-# INLINE_LATE step #-}
257+-- | Delete all elements of the first stream from the seconds stream. If an
329− -- step 1, fetch the first value
258+-- element occurs multiple times in the first stream as many occurrences of it
330− step gst (sa, sb, Nothing, b) = do
259+-- are deleted from the second stream.
331− r <- stepa gst sa
332− return $ case r of
333− Yield a sa' -> Skip (sa', sb, Just a, b) -- step 2/3
334− Skip sa' -> Skip (sa', sb, Nothing, b)
335− Stop -> Stop
336−
337− -- step 2, fetch the second value
338− step gst (sa, sb, a@(Just _), Nothing) = do
339− r <- stepb gst sb
340− return $ case r of
341− Yield b sb' -> Skip (sa, sb', a, Just b) -- step 3
342− Skip sb' -> Skip (sa, sb', a, Nothing)
343− Stop -> Stop
344−
345− -- step 3, compare the two values
346− step _ (sa, sb, Just a, Just b) = do
347− let res = cmp a b
348− return $ case res of
349− GT -> Skip (sa, sb, Just a, Nothing) -- step 2
350− LT -> Skip (sa, sb, Nothing, Just b) -- step 1
351− EQ -> Yield a (sa, sb, Nothing, Just b) -- step 1
352−
353−-- | Returns a subsequence of the first stream, deleting first occurrences of
354−-- those elements that are present in the second stream. Note that this is not
355−-- a commutative operation. This is similar to the 'Data.List.deleteFirstsBy'.
356--
260--
357−-- >>> f xs ys = Stream.fold Fold.toList $ Stream.deleteFirstsBy (==) (Stream.fromList xs) (Stream.fromList ys)
261+-- >>> Stream.fold Fold.toList $ Stream.deleteInStreamGenericBy (==) (Stream.fromList [1,2,3]) (Stream.fromList [1,2,2])
358−-- >>> f [1,2,2,3,3,5] [1,2,2,3,4]
359−-- [2,3,5]
262+-- [2]
360--
263--
361−-- The following holds:
264+-- The following laws hold:
362--
265--
363−-- > deleteFirstsBy (==) (Stream.nub s2 `append` s1) s2 === s1
266+-- > deleteInStreamGenericBy (==) s1 (s1 `append` s2) === s2
364−-- > deleteFirstsBy (==) (Stream.nub s2 `interleave` s1) s2 === s1
267+-- > deleteInStreamGenericBy (==) s1 (s1 `interleave` s2) === s2
365--
268--
366−-- First stream can be infinite, second stream must be finite.
269+-- Same as the list 'Data.List.//' operation but with argument order flipped.
270+--
271+-- The first stream must be finite and must not block. Second stream is
272+-- processed only after the first stream is fully realized.
367--
273--
368-- Space: O(m) where @m@ is the number of elements in the first stream.
274-- Space: O(m) where @m@ is the number of elements in the first stream.
369--
275--
@@ -371,83 +277,58 @@ sortedIntersectBy cmp (Stream stepa ta) (Stream stepb tb) =
371-- @n@ is the number of elements in the second stream.
277-- @n@ is the number of elements in the second stream.
372--
278--
373-- /Pre-release/
279-- /Pre-release/
374−{-# INLINE deleteFirstsBy #-}
280+{-# INLINE deleteInStreamGenericBy #-}
375−deleteFirstsBy :: Monad m =>
281+deleteInStreamGenericBy :: Monad m =>
376 (a -> a -> Bool) -> Stream m a -> Stream m a -> Stream m a
282 (a -> a -> Bool) -> Stream m a -> Stream m a -> Stream m a
377−deleteFirstsBy eq s2 s1 =
283+deleteInStreamGenericBy eq s1 s2 =
378− -- XXX s2 can be a sorted mutable array and we can use binary
284+ Stream.concatEffect
379− -- search to find. Mark the element deleted, count the deletions
285+ $ do
380− -- and reconsolidate the array when a min number of elements is
286+ -- This may work well if s1 is small
381− -- deleted.
287+ -- If s1 is big we can go through s1, deleting elements from s2 and
382−
288+ -- not emitting an element if it was successfully deleted from s2.
383− -- XXX Use StreamK or list as second argument instead of Stream to avoid
289+ -- we will need a deleteBy that can return whether the element was
384− -- concatEffect?
290+ -- deleted or not.
385− Stream.concatEffect $ do
386− xs <- Stream.toList s1
291+ xs <- Stream.fold Fold.toList s2
387− -- It reverses the list but that is fine.
292+ let f = Fold.foldl' (flip (List.deleteBy eq)) xs
388− let del x =
293+ fmap Stream.fromList $ Stream.fold f s1
389− List.foldl' (\(ys,res) y ->
390− if x `eq` y
391− then (ys, True)
392− else (x:ys, res)) ([], False)
393− g (ys,_) x =
394− let (ys1, deleted) = del x ys
395− in if deleted
396− then (ys1, Nothing)
397− else (ys1, Just x)
398− in return
399− $ Stream.catMaybes
400− $ fmap snd
401− $ Stream.postscanl' g (xs, Nothing) s2
402
294
403−-- | A more efficient 'deleteFirstsBy' for streams sorted in ascending order.
295+-- | A more efficient 'deleteInStreamGenericBy' for streams sorted in ascending order.
404−--
405−-- Both streams can be infinite.
406--
296--
407-- Space: O(1)
297-- Space: O(1)
408--
298--
409-- /Unimplemented/
299-- /Unimplemented/
410−{-# INLINE sortedDeleteFirstsBy #-}
300+{-# INLINE deleteInStreamAscBy #-}
411−sortedDeleteFirstsBy :: -- (Monad m) =>
301+deleteInStreamAscBy :: -- (Monad m) =>
412 (a -> a -> Ordering) -> Stream m a -> Stream m a -> Stream m a
302 (a -> a -> Ordering) -> Stream m a -> Stream m a -> Stream m a
413−sortedDeleteFirstsBy _eq _s1 _s2 = undefined
303+deleteInStreamAscBy _eq _s1 _s2 = undefined
414
304
415-- XXX Remove the MonadIO constraint. We can just cache one stream and then
305-- XXX Remove the MonadIO constraint. We can just cache one stream and then
416-- implement using differenceEqBy.
306-- implement using differenceEqBy.
417
307
418−-- | Returns the first stream appended with those unique elements from the
308+-- | This essentially appends to the second stream all the occurrences of
419−-- second stream that are not already present in the first stream. Note that
309+-- elements in the first stream that are not already present in the second
420−-- this is not a commutative operation unlike a set union, argument order
310+-- stream.
421−-- matters. The behavior is similar to the 'Data.List.unionBy'.
422--
311--
423-- Equivalent to the following except that @s2@ is evaluated only once:
312-- Equivalent to the following except that @s2@ is evaluated only once:
424--
313--
425−-- >>> unionBy eq s1 s2 = s1 `Stream.append` Stream.deleteFirstsBy eq s1 (Stream.nub s2)
314+-- >>> unionWithStreamGenericBy eq s1 s2 = s2 `Stream.append` (Stream.deleteInStreamGenericBy eq s2 s1)
426--
315--
427-- Example:
316-- Example:
428--
317--
429−-- >>> f s1 s2 = Stream.fold Fold.toList $ Stream.unionBy (==) (Stream.fromList s1) (Stream.fromList s2)
318+-- >>> Stream.fold Fold.toList $ Stream.unionWithStreamGenericBy (==) (Stream.fromList [1,1,2,3]) (Stream.fromList [1,2,2,4])
430−-- >>> f [1,2,2,4] [1,1,2,3,3]
431-- [1,2,2,4,3]
319-- [1,2,2,4,3]
432--
320--
433−-- First stream can be infinite, but second stream must be finite. Note that if
434−-- the first stream is infinite the union means just the first stream. Thus
435−-- union is useful only when both streams are finite. See 'sortedUnionBy' where
436−-- union can work on infinite streams if they are sorted.
437−--
438-- Space: O(n)
321-- Space: O(n)
439--
322--
440-- Time: O(m x n)
323-- Time: O(m x n)
441--
324--
442-- /Pre-release/
325-- /Pre-release/
443−{-# INLINE unionBy #-}
326+{-# INLINE unionWithStreamGenericBy #-}
444−unionBy :: MonadIO m =>
327+unionWithStreamGenericBy :: MonadIO m =>
445 (a -> a -> Bool) -> Stream m a -> Stream m a -> Stream m a
328 (a -> a -> Bool) -> Stream m a -> Stream m a -> Stream m a
446−unionBy eq s2 s1 =
329+unionWithStreamGenericBy eq s1 s2 =
447 Stream.concatEffect
330 Stream.concatEffect
448 $ do
331 $ do
449− -- XXX use a rewrite rule such that if a list converted to stream
450− -- is passed to unionBy then this becomes an identity operation.
451 xs <- Stream.fold Fold.toList s1
332 xs <- Stream.fold Fold.toList s1
452 -- XXX we can use postscanlMAfter' instead of IORef
333 -- XXX we can use postscanlMAfter' instead of IORef
453 ref <- liftIO $ newIORef $! List.nubBy eq xs
334 ref <- liftIO $ newIORef $! List.nubBy eq xs
@@ -460,21 +341,12 @@ unionBy eq s2 s1 =
460 return $ Stream.fromList xs1
341 return $ Stream.fromList xs1
461 return $ Stream.mapM f s2 `Stream.append` s3
342 return $ Stream.mapM f s2 `Stream.append` s3
462
343
463−-- | A more efficient 'unionBy' for sorted streams.
344+-- | A more efficient 'unionWithStreamGenericBy' for sorted streams.
464−--
465−-- Note that the behavior is different from 'unionBy'. In 'unionBy' we append
466−-- the unique elements from second stream only after exhausting the first one
467−-- whereas in sorted streams we can determine unique elements early even when
468−-- we are going through the first stream. Thus the result is an interleaving of
469−-- the two streams, merging those elements from the second stream that are not
470−-- present in the first.
471--
345--
472-- Space: O(1)
346-- Space: O(1)
473--
347--
474−-- Both streams can be infinite.
475−--
476-- /Unimplemented/
348-- /Unimplemented/
477−{-# INLINE sortedUnionBy #-}
349+{-# INLINE unionWithStreamAscBy #-}
478−sortedUnionBy :: -- (Monad m) =>
350+unionWithStreamAscBy :: -- (Monad m) =>
479 (a -> a -> Ordering) -> Stream m a -> Stream m a -> Stream m a
351 (a -> a -> Ordering) -> Stream m a -> Stream m a -> Stream m a
480−sortedUnionBy _eq _s1 _s2 = undefined
352+unionWithStreamAscBy _eq _s1 _s2 = undefined
core/src/Streamly/Internal/Data/Stream/Transform.hs+27−53
@@ -21,6 +21,8 @@ module Streamly.Internal.Data.Stream.Transform
21
21
22 -- * Mapping
22 -- * Mapping
23 -- | Stateless one-to-one maps.
23 -- | Stateless one-to-one maps.
24+ , map
25+ , mapM
24 , sequence
26 , sequence
25
27
26 -- * Mapping Effects
28 -- * Mapping Effects
@@ -73,7 +75,7 @@ module Streamly.Internal.Data.Stream.Transform
73 , scanMaybe
75 , scanMaybe
74 , filter
76 , filter
75 , filterM
77 , filterM
76− , deleteBy -- deleteOnceBy?
78+ , deleteBy
77 , uniqBy
79 , uniqBy
78 , uniq
80 , uniq
79 , prune
81 , prune
@@ -81,8 +83,9 @@ module Streamly.Internal.Data.Stream.Transform
81
83
82 -- * Trimming
84 -- * Trimming
83 -- | Produce a subset of the stream trimmed at ends.
85 -- | Produce a subset of the stream trimmed at ends.
84− , initNonEmpty
86+ , take
85− , tailNonEmpty
87+ , takeWhile
88+ , takeWhileM
86 , takeWhileLast
89 , takeWhileLast
87 , takeWhileAround
90 , takeWhileAround
88 , drop
91 , drop
@@ -129,6 +132,7 @@ module Streamly.Internal.Data.Stream.Transform
129 -- * Searching
132 -- * Searching
130 , findIndices
133 , findIndices
131 , elemIndices
134 , elemIndices
135+ , slicesBy
132
136
133 -- * Rolling map
137 -- * Rolling map
134 -- | Map using the previous element.
138 -- | Map using the previous element.
@@ -1070,55 +1074,6 @@ repeated = undefined
1070-- Trimming
1074-- Trimming
1071------------------------------------------------------------------------------
1075------------------------------------------------------------------------------
1072
1076
1073−-- | init for non-empty streams, fails for empty stream case.
1074−--
1075−{-# INLINE initNonEmpty #-}
1076−initNonEmpty :: Monad m => Stream m a -> Stream m a
1077−initNonEmpty (Stream step1 state1) = Stream step (Nothing, state1)
1078−
1079− where
1080−
1081− step gst (Nothing, s1) = do
1082− r <- step1 (adaptState gst) s1
1083− return $
1084− case r of
1085− Yield x s -> Skip (Just x, s)
1086− Skip s -> Skip (Nothing, s)
1087− Stop -> error "initNonEmpty: empty Stream"
1088−
1089− step gst (Just a, s1) = do
1090− r <- step1 (adaptState gst) s1
1091− return $
1092− case r of
1093− Yield x s -> Yield a (Just x, s)
1094− Skip s -> Skip (Just a, s)
1095− Stop -> Stop
1096−
1097−-- | tail for non-empty streams, fails for empty stream case.
1098−--
1099−-- See also 'tail' for a non-partial version of this function..
1100−{-# INLINE tailNonEmpty #-}
1101−tailNonEmpty :: Monad m => Stream m a -> Stream m a
1102−tailNonEmpty (Stream step1 state1) = Stream step (Nothing, state1)
1103−
1104− where
1105−
1106− step gst (Nothing, s1) = do
1107− r <- step1 (adaptState gst) s1
1108− return $
1109− case r of
1110− Yield x s -> Skip (Just x, s)
1111− Skip s -> Skip (Nothing, s)
1112− Stop -> error "tailNonEmpty: empty Stream"
1113−
1114− step gst (Just a, s1) = do
1115− r <- step1 (adaptState gst) s1
1116− return $
1117− case r of
1118− Yield x s -> Yield x (Just x, s)
1119− Skip s -> Skip (Just a, s)
1120− Stop -> Stop
1121−
1122-- | Take all consecutive elements at the end of the stream for which the
1077-- | Take all consecutive elements at the end of the stream for which the
1123-- predicate is true.
1078-- predicate is true.
1124--
1079--
@@ -1582,7 +1537,7 @@ reverse m = Stream step Nothing
1582{-# INLINE reverseUnbox #-}
1537{-# INLINE reverseUnbox #-}
1583reverseUnbox :: (MonadIO m, Unbox a) => Stream m a -> Stream m a
1538reverseUnbox :: (MonadIO m, Unbox a) => Stream m a -> Stream m a
1584reverseUnbox =
1539reverseUnbox =
1585− A.concatRev -- unfoldMany A.readerRev
1540+ A.concatChunksRev -- unfoldMany A.readerRev
1586 . fromStreamK
1541 . fromStreamK
1587 . K.reverse
1542 . K.reverse
1588 . toStreamK
1543 . toStreamK
@@ -1754,6 +1709,25 @@ findIndices p (Stream step state) = Stream step' (state, 0)
1754elemIndices :: (Monad m, Eq a) => a -> Stream m a -> Stream m Int
1709elemIndices :: (Monad m, Eq a) => a -> Stream m a -> Stream m Int
1755elemIndices a = findIndices (== a)
1710elemIndices a = findIndices (== a)
1756
1711
1712+{-# INLINE_NORMAL slicesBy #-}
1713+slicesBy :: Monad m => (a -> Bool) -> Stream m a -> Stream m (Int, Int)
1714+slicesBy p (Stream step1 state1) = Stream step (Just (state1, 0, 0))
1715+
1716+ where
1717+
1718+ {-# INLINE_LATE step #-}
1719+ step gst (Just (st, i, len)) = i `seq` len `seq` do
1720+ r <- step1 (adaptState gst) st
1721+ return
1722+ $ case r of
1723+ Yield x s ->
1724+ if p x
1725+ then Yield (i, len + 1) (Just (s, i + len + 1, 0))
1726+ else Skip (Just (s, i, len + 1))
1727+ Skip s -> Skip (Just (s, i, len))
1728+ Stop -> if len == 0 then Stop else Yield (i, len) Nothing
1729+ step _ Nothing = return Stop
1730+
1757------------------------------------------------------------------------------
1731------------------------------------------------------------------------------
1758-- Rolling map
1732-- Rolling map
1759------------------------------------------------------------------------------
1733------------------------------------------------------------------------------
core/src/Streamly/Internal/Data/Stream/Transformer.hs+1−2
@@ -11,11 +11,10 @@
11
11
12module Streamly.Internal.Data.Stream.Transformer
12module Streamly.Internal.Data.Stream.Transformer
13 (
13 (
14− -- * Fold to Transformer Monad
15 foldlT
14 foldlT
16 , foldrT
15 , foldrT
17
16
18− -- * Inner Monad Operations
17+ -- * Transform Inner Monad
19 , liftInner
18 , liftInner
20 , runReaderT
19 , runReaderT
21 , usingReaderT
20 , usingReaderT
core/src/Streamly/Internal/Data/Stream/Type.hs+3−129
@@ -1,11 +1,5 @@
1{-# LANGUAGE CPP #-}
1{-# LANGUAGE CPP #-}
2−{-# LANGUAGE PatternSynonyms #-}
3−{-# LANGUAGE TypeFamilies #-}
4−-- Must come after TypeFamilies, otherwise it is re-enabled.
5−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
6−{-# LANGUAGE NoMonoLocalBinds #-}
7{-# LANGUAGE UndecidableInstances #-}
2{-# LANGUAGE UndecidableInstances #-}
8−{-# LANGUAGE ViewPatterns #-}
9
3
10-- |
4-- |
11-- Module : Streamly.Internal.Data.Stream.Type
5-- Module : Streamly.Internal.Data.Stream.Type
@@ -22,18 +16,18 @@
22
16
23module Streamly.Internal.Data.Stream.Type
17module Streamly.Internal.Data.Stream.Type
24 (
18 (
25− -- * Type
19+ -- * The stream type
26 Step (..)
20 Step (..)
27 -- XXX UnStream is exported to avoid a performance issue in some
21 -- XXX UnStream is exported to avoid a performance issue in some
28 -- combinators if we use the pattern synonym "Stream".
22 -- combinators if we use the pattern synonym "Stream".
29 , Stream (Stream, UnStream)
23 , Stream (Stream, UnStream)
30
24
31− -- * CrossStream
25+ -- * CrossStream type wrapper
32 , CrossStream
26 , CrossStream
33 , unCross
27 , unCross
34 , mkCross
28 , mkCross
35
29
36− -- * To StreamK
30+ -- * Conversion to StreamK
37 , fromStreamK
31 , fromStreamK
38 , toStreamK
32 , toStreamK
39
33
@@ -91,7 +85,6 @@ module Streamly.Internal.Data.Stream.Type
91
85
92 -- * Combining Two Streams
86 -- * Combining Two Streams
93 -- ** Zipping
87 -- ** Zipping
94− -- | Zip corresponding elements of two streams.
95 , zipWithM
88 , zipWithM
96 , zipWith
89 , zipWith
97
90
@@ -107,8 +100,6 @@ module Streamly.Internal.Data.Stream.Type
107 , unfoldMany
100 , unfoldMany
108
101
109 -- * Concat
102 -- * Concat
110− -- | Generate streams by mapping a stream generator on each element of an
111− -- input stream, append the resulting streams and flatten.
112 , concatEffect
103 , concatEffect
113 , concatMap
104 , concatMap
114 , concatMapM
105 , concatMapM
@@ -132,22 +123,14 @@ module Streamly.Internal.Data.Stream.Type
132 , foldManyPost
123 , foldManyPost
133 , groupsOf
124 , groupsOf
134 , refoldMany
125 , refoldMany
135− , refoldIterateM
136
126
137 -- * Fold Iterate
127 -- * Fold Iterate
138 , reduceIterateBfs
128 , reduceIterateBfs
139 , foldIterateBfs
129 , foldIterateBfs
140
130
141− -- * Splitting
142− , indexOnSuffix
143−
144 -- * Multi-stream folds
131 -- * Multi-stream folds
145− -- | These should probably be expressed using zipping operations.
146 , eqBy
132 , eqBy
147 , cmpBy
133 , cmpBy
148−
149− -- * Deprecated
150− , sliceOnSuffix
151 )
134 )
152where
135where
153
136
@@ -179,7 +162,6 @@ import Streamly.Internal.Data.Maybe.Strict (Maybe'(..), toMaybe)
179import Streamly.Internal.Data.Refold.Type (Refold(..))
162import Streamly.Internal.Data.Refold.Type (Refold(..))
180import Streamly.Internal.Data.Stream.Step (Step (..))
163import Streamly.Internal.Data.Stream.Step (Step (..))
181import Streamly.Internal.Data.SVar.Type (State, adaptState, defState)
164import Streamly.Internal.Data.SVar.Type (State, adaptState, defState)
182−import Streamly.Internal.Data.Tuple.Strict (Tuple'(..))
183import Streamly.Internal.Data.Unfold.Type (Unfold(..))
165import Streamly.Internal.Data.Unfold.Type (Unfold(..))
184
166
185import qualified Streamly.Internal.Data.Fold.Type as FL hiding (foldr)
167import qualified Streamly.Internal.Data.Fold.Type as FL hiding (foldr)
@@ -572,12 +554,8 @@ foldAdd f =
572-- >>> Stream.foldrM step (return False) s
554-- >>> Stream.foldrM step (return False) s
573-- True
555-- True
574--
556--
575−-- >>> import Control.Monad (join)
576−-- >>> foldrM f z = join $ Stream.foldr f z
577−--
578{-# INLINE_NORMAL foldrM #-}
557{-# INLINE_NORMAL foldrM #-}
579foldrM :: Monad m => (a -> m b -> m b) -> m b -> Stream m a -> m b
558foldrM :: Monad m => (a -> m b -> m b) -> m b -> Stream m a -> m b
580−-- foldrM f z = join . Streamly.Internal.Data.Stream.StreamD.Type.foldr f z
581foldrM f z (Stream step state) = go SPEC state
559foldrM f z (Stream step state) = go SPEC state
582 where
560 where
583 {-# INLINE_LATE go #-}
561 {-# INLINE_LATE go #-}
@@ -1996,110 +1974,6 @@ refoldMany (Refold fstep inject extract) action (Stream step state) =
1996 step' _ (FoldManyYield b next) = return $ Yield b next
1974 step' _ (FoldManyYield b next) = return $ Yield b next
1997 step' _ FoldManyDone = return Stop
1975 step' _ FoldManyDone = return Stop
1998
1976
1999−{-# ANN type CIterState Fuse #-}
2000−data CIterState s f fs b
2001− = CIterInit s f
2002− | CIterConsume s fs
2003− | CIterYield b (CIterState s f fs b)
2004− | CIterStop
2005−
2006−-- | Like 'foldIterateM' but using the 'Refold' type instead. This could be
2007−-- much more efficient due to stream fusion.
2008−--
2009−-- /Internal/
2010−{-# INLINE_NORMAL refoldIterateM #-}
2011−refoldIterateM ::
2012− Monad m => Refold m b a b -> m b -> Stream m a -> Stream m b
2013−refoldIterateM (Refold fstep finject fextract) initial (Stream step state) =
2014− Stream stepOuter (CIterInit state initial)
2015−
2016− where
2017−
2018− {-# INLINE iterStep #-}
2019− iterStep st action = do
2020− res <- action
2021− return
2022− $ Skip
2023− $ case res of
2024− FL.Partial fs -> CIterConsume st fs
2025− FL.Done fb -> CIterYield fb $ CIterInit st (return fb)
2026−
2027− {-# INLINE_LATE stepOuter #-}
2028− stepOuter _ (CIterInit st action) = do
2029− iterStep st (action >>= finject)
2030− stepOuter gst (CIterConsume st fs) = do
2031− r <- step (adaptState gst) st
2032− case r of
2033− Yield x s -> iterStep s (fstep fs x)
2034− Skip s -> return $ Skip $ CIterConsume s fs
2035− Stop -> do
2036− b <- fextract fs
2037− return $ Skip $ CIterYield b CIterStop
2038− stepOuter _ (CIterYield a next) = return $ Yield a next
2039− stepOuter _ CIterStop = return Stop
2040−
2041−-- | The refold @indexerBy f n@ takes an (index, len) tuple as initial input,
2042−-- and returns @(index + len + n, b)@ as output where @b@ is the output of the
2043−-- fold.
2044−{-# INLINE indexerBy #-}
2045−indexerBy :: Monad m =>
2046− Fold m a Int -> Int -> Refold m (Int, Int) a (Int, Int)
2047−indexerBy (Fold step1 initial1 extract1 _final) n =
2048− Refold step inject extract
2049−
2050− where
2051−
2052− inject (i, len) = do
2053− r <- initial1
2054− return $ case r of
2055− FL.Partial s -> FL.Partial $ Tuple' (i + len + n) s
2056− FL.Done l -> FL.Done (i, l)
2057−
2058− step (Tuple' i s) x = do
2059− r <- step1 s x
2060− return $ case r of
2061− FL.Partial s1 -> FL.Partial $ Tuple' i s1
2062− FL.Done len -> FL.Done (i, len)
2063−
2064− extract (Tuple' i s) = (i,) <$> extract1 s
2065−
2066−-- | Like 'splitOnSuffix' but generates a stream of (index, len) tuples marking
2067−-- the places where the predicate matches in the stream.
2068−--
2069−-- /Pre-release/
2070−{-# INLINE indexOnSuffix #-}
2071−indexOnSuffix :: Monad m =>
2072− (a -> Bool) -> Stream m a -> Stream m (Int, Int)
2073−indexOnSuffix predicate =
2074− -- Scan the stream with the given refold
2075− refoldIterateM
2076− (indexerBy (FL.takeEndBy_ predicate FL.length) 1)
2077− (return (-1, 0))
2078−
2079−-- Alternate implementation
2080−{-# INLINE_NORMAL _indexOnSuffix #-}
2081−_indexOnSuffix :: Monad m => (a -> Bool) -> Stream m a -> Stream m (Int, Int)
2082−_indexOnSuffix p (Stream step1 state1) = Stream step (Just (state1, 0, 0))
2083−
2084− where
2085−
2086− {-# INLINE_LATE step #-}
2087− step gst (Just (st, i, len)) = i `seq` len `seq` do
2088− r <- step1 (adaptState gst) st
2089− return
2090− $ case r of
2091− Yield x s ->
2092− if p x
2093− then Yield (i, len + 1) (Just (s, i + len + 1, 0))
2094− else Skip (Just (s, i, len + 1))
2095− Skip s -> Skip (Just (s, i, len))
2096− Stop -> if len == 0 then Stop else Yield (i, len) Nothing
2097− step _ Nothing = return Stop
2098−
2099−{-# DEPRECATED sliceOnSuffix "Please use indexOnSuffix instead." #-}
2100−sliceOnSuffix :: Monad m => (a -> Bool) -> Stream m a -> Stream m (Int, Int)
2101−sliceOnSuffix = indexOnSuffix
2102−
2103------------------------------------------------------------------------------
1977------------------------------------------------------------------------------
2104-- Stream with a cross product style monad instance
1978-- Stream with a cross product style monad instance
2105------------------------------------------------------------------------------
1979------------------------------------------------------------------------------
core/src/Streamly/Internal/Data/StreamK.hs+8−19
@@ -16,15 +16,16 @@ module Streamly.Internal.Data.StreamK
16 --
16 --
17 -- $setup
17 -- $setup
18
18
19+ -- * The stream type
19 module Streamly.Internal.Data.StreamK.Type
20 module Streamly.Internal.Data.StreamK.Type
20− -- * Transformer
21 , module Streamly.Internal.Data.StreamK.Transformer
21 , module Streamly.Internal.Data.StreamK.Transformer
22
22
23− -- * From containers
23+ , StreamK(..)
24 , fromList
24 , fromList
25 , fromStream
25 , fromStream
26+ , toStream
26
27
27− -- * Specialized Generation
28+ -- ** Specialized Generation
28 , repeatM
29 , repeatM
29 , replicate
30 , replicate
30 , replicateM
31 , replicateM
@@ -66,13 +67,13 @@ module Streamly.Internal.Data.StreamK
66 , find
67 , find
67 , (!!)
68 , (!!)
68
69
69− -- ** To Containers
70− , toList
71− , toStream
72−
73 -- ** Map and Fold
70 -- ** Map and Fold
74 , mapM_
71 , mapM_
75
72
73+ -- ** Conversions
74+ , toList
75+ , hoist
76+
76 -- * Transformation
77 -- * Transformation
77 -- ** By folding (scans)
78 -- ** By folding (scans)
78 , scanl'
79 , scanl'
@@ -99,7 +100,6 @@ module Streamly.Internal.Data.StreamK
99
100
100 -- ** Reordering
101 -- ** Reordering
101 , sortBy
102 , sortBy
102− , sortOn
103
103
104 -- ** Map and Filter
104 -- ** Map and Filter
105 , mapMaybe
105 , mapMaybe
@@ -115,9 +115,6 @@ module Streamly.Internal.Data.StreamK
115 -- ** Transformation comprehensions
115 -- ** Transformation comprehensions
116 , the
116 , the
117
117
118− -- ** Transforming Inner Monad
119− , hoist
120−
121 -- * Exceptions
118 -- * Exceptions
122 , handle
119 , handle
123
120
@@ -134,7 +131,6 @@ import Control.Exception (mask_, Exception)
134import Control.Monad (void, join)
131import Control.Monad (void, join)
135import Control.Monad.Catch (MonadCatch)
132import Control.Monad.Catch (MonadCatch)
136import Control.Monad.IO.Class (MonadIO(..))
133import Control.Monad.IO.Class (MonadIO(..))
137−import Data.Ord (comparing)
138import Data.Proxy (Proxy(..))
134import Data.Proxy (Proxy(..))
139import GHC.Types (SPEC(..))
135import GHC.Types (SPEC(..))
140import Streamly.Internal.Data.Array.Type (Array(..))
136import Streamly.Internal.Data.Array.Type (Array(..))
@@ -1721,10 +1717,3 @@ sortBy cmp =
1721 . Stream.catRights -- its a non-failing backtracking parser
1717 . Stream.catRights -- its a non-failing backtracking parser
1722 . Stream.parseMany (fmap (either id id) p)
1718 . Stream.parseMany (fmap (either id id) p)
1723 . Stream.fromStreamK
1719 . Stream.fromStreamK
1724−
1725−{-# INLINE sortOn #-}
1726−sortOn :: (Monad m, Ord b) => (a -> b) -> StreamK m a -> StreamK m a
1727−sortOn f =
1728− fmap snd
1729− . sortBy (comparing fst)
1730− . fmap (\x -> let y = f x in y `seq` (y, x))
core/src/Streamly/Internal/Data/StreamK/Type.hs+11−60
@@ -1,8 +1,4 @@
1{-# LANGUAGE CPP #-}
1{-# LANGUAGE CPP #-}
2−{-# LANGUAGE TypeFamilies #-}
3−-- Must come after TypeFamilies, otherwise it is re-enabled.
4−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
5−{-# LANGUAGE NoMonoLocalBinds #-}
6{-# LANGUAGE UndecidableInstances #-}
2{-# LANGUAGE UndecidableInstances #-}
7-- |
3-- |
8-- Module : Streamly.Internal.Data.StreamK.Type
4-- Module : Streamly.Internal.Data.StreamK.Type
@@ -97,11 +93,8 @@ module Streamly.Internal.Data.StreamK.Type
97 -- ** Specific Folds
93 -- ** Specific Folds
98 , drain
94 , drain
99 , null
95 , null
100− , headNonEmpty
101 , tail
96 , tail
102− , tailNonEmpty
103 , init
97 , init
104− , initNonEmpty
105
98
106 -- * Mapping
99 -- * Mapping
107 , map
100 , map
@@ -1814,42 +1807,14 @@ iterateMWith cns step = go
1814 !next <- s
1807 !next <- s
1815 foldStreamShared st stp sng yld (return next `cns` go (step next))
1808 foldStreamShared st stp sng yld (return next `cns` go (step next))
1816
1809
1817−-- | head for non-empty streams, fails for empty stream case.
1810+{-# INLINE headPartial #-}
1818−--
1819−{-# INLINE headNonEmpty #-}
1820−headNonEmpty :: Monad m => StreamK m a -> m a
1811+headPartial :: Monad m => StreamK m a -> m a
1821−headNonEmpty = foldrM (\x _ -> return x) (error "headNonEmpty: empty stream")
1812+headPartial = foldrM (\x _ -> return x) (error "head of nil")
1822−
1823−-- | init for non-empty streams, fails for empty stream case.
1824−--
1825−-- See also 'init' for a non-partial version of this function..
1826−{-# INLINE initNonEmpty #-}
1827−initNonEmpty :: Stream m a -> Stream m a
1828−initNonEmpty = go0
1829−
1830− where
1831−
1832− go0 m = mkStream $ \st yld sng stp ->
1833− let stop = error "initNonEmpty: Empty Stream."
1834− single _ = stp
1835− yieldk a r = foldStream st yld sng stp (go1 a r)
1836− in foldStream st yieldk single stop m
1837−
1838− go1 a r = mkStream $ \st yld sng stp ->
1839− let stop = stp
1840− single _ = sng a
1841− yieldk a1 r1 = yld a (go1 a1 r1)
1842− in foldStream st yieldk single stop r
1843
1813
1844−-- | tail for non-empty streams, fails for empty stream case.
1814+{-# INLINE tailPartial #-}
1845−--
1846−-- See also 'tail' for a non-partial version of this function..
1847−--
1848−-- Note: this is same as "drop 1" with error on empty stream.
1849−{-# INLINE tailNonEmpty #-}
1850−tailNonEmpty :: StreamK m a -> StreamK m a
1815+tailPartial :: StreamK m a -> StreamK m a
1851−tailNonEmpty m = mkStream $ \st yld sng stp ->
1816+tailPartial m = mkStream $ \st yld sng stp ->
1852− let stop = error "tailNonEmpty: empty stream"
1817+ let stop = error "tail of nil"
1853 single _ = stp
1818 single _ = stp
1854 yieldk _ r = foldStream st yld sng stp r
1819 yieldk _ r = foldStream st yld sng stp r
1855 in foldStream st yieldk single stop m
1820 in foldStream st yieldk single stop m
@@ -1914,10 +1879,10 @@ mfix f = mkStream $ \st yld sng stp ->
1914 where
1879 where
1915
1880
1916 -- fix the head element of the stream
1881 -- fix the head element of the stream
1917− xs = fix (f . headNonEmpty)
1882+ xs = fix (f . headPartial)
1918
1883
1919 -- now fix the tail recursively
1884 -- now fix the tail recursively
1920− ys = mfix (tailNonEmpty . f)
1885+ ys = mfix (tailPartial . f)
1921
1886
1922-------------------------------------------------------------------------------
1887-------------------------------------------------------------------------------
1923-- Conversions
1888-- Conversions
@@ -1948,15 +1913,6 @@ uncons m =
1948 yieldk a r = pure (Just (a, r))
1913 yieldk a r = pure (Just (a, r))
1949 in foldStream defState yieldk single stop m
1914 in foldStream defState yieldk single stop m
1950
1915
1951−-- Note that this is not a StreamK -> StreamK because then we cannot handle the
1952−-- empty stream case without making this a partial function.
1953−--
1954−-- See tailNonEmpty as well above.
1955−
1956−-- | Same as:
1957−--
1958−-- >>> tail = fmap (fmap snd) StreamK.uncons
1959−--
1960{-# INLINE tail #-}
1916{-# INLINE tail #-}
1961tail :: Applicative m => StreamK m a -> m (Maybe (StreamK m a))
1917tail :: Applicative m => StreamK m a -> m (Maybe (StreamK m a))
1962tail =
1918tail =
@@ -1965,14 +1921,9 @@ tail =
1965 yieldk _ r = pure $ Just r
1921 yieldk _ r = pure $ Just r
1966 in foldStream defState yieldk single stop
1922 in foldStream defState yieldk single stop
1967
1923
1968−-- Note that this is not a StreamK -> StreamK because then we cannot handle the
1924+-- | Extract all but the last element of the stream, if any.
1969−-- empty stream case without making this a partial function.
1970--
1925--
1971−-- XXX How do we implement unsnoc? Make StreamK a monad and return the
1926+-- Note: This will end up buffering the entire stream.
1972−-- remaining stream as a result value in the monad?
1973−
1974−-- | Extract all but the last element of the stream, if any. This will end up
1975−-- evaluating the last element as well to find out that it is last.
1976--
1927--
1977-- /Pre-release/
1928-- /Pre-release/
1978{-# INLINE init #-}
1929{-# INLINE init #-}
core/src/Streamly/Internal/Data/Time/Units.hs+4
@@ -1,3 +1,7 @@
1+{-# LANGUAGE DataKinds #-}
2+{-# LANGUAGE PolyKinds #-}
3+{-# LANGUAGE UnboxedTuples #-}
4+
1-- |
5-- |
2-- Module : Streamly.Internal.Data.Time.Units
6-- Module : Streamly.Internal.Data.Time.Units
3-- Copyright : (c) 2019 Composewell Technologies
7-- Copyright : (c) 2019 Composewell Technologies
core/src/Streamly/Internal/Data/Unbox.hs+1−4
@@ -1,8 +1,5 @@
1{-# LANGUAGE DataKinds #-}
1{-# LANGUAGE DataKinds #-}
2−{-# LANGUAGE TypeFamilies #-}
2+{-# LANGUAGE DefaultSignatures #-}
3−-- Must come after TypeFamilies, otherwise it is re-enabled.
4−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
5−{-# LANGUAGE NoMonoLocalBinds #-}
6{-# LANGUAGE UnboxedTuples #-}
3{-# LANGUAGE UnboxedTuples #-}
7{-# LANGUAGE UndecidableInstances #-}
4{-# LANGUAGE UndecidableInstances #-}
8
5
core/src/Streamly/Internal/Data/Unfold.hs+4−6
@@ -82,7 +82,7 @@ module Streamly.Internal.Data.Unfold
82 , dropWhileM
82 , dropWhileM
83
83
84 -- ** Cross product
84 -- ** Cross product
85− , innerJoin
85+ , joinInnerGeneric
86
86
87 -- ** Resource Management
87 -- ** Resource Management
88 -- | 'bracket' is the most general resource management operation, all other
88 -- | 'bracket' is the most general resource management operation, all other
@@ -677,12 +677,10 @@ dropWhileM f (Unfold step inject) = Unfold step' inject'
677dropWhile :: Monad m => (b -> Bool) -> Unfold m a b -> Unfold m a b
677dropWhile :: Monad m => (b -> Bool) -> Unfold m a b -> Unfold m a b
678dropWhile f = dropWhileM (return . f)
678dropWhile f = dropWhileM (return . f)
679
679
680−-- | Cross intersection of two unfolds. See
681−-- 'Streamly.Internal.Data.Stream.innerJoin' for more details.
682−{-# INLINE_NORMAL innerJoin #-}
680+{-# INLINE_NORMAL joinInnerGeneric #-}
683−innerJoin :: Monad m =>
681+joinInnerGeneric :: Monad m =>
684 (b -> c -> Bool) -> Unfold m a b -> Unfold m a c -> Unfold m a (b, c)
682 (b -> c -> Bool) -> Unfold m a b -> Unfold m a c -> Unfold m a (b, c)
685−innerJoin eq s1 s2 = filter (\(a, b) -> a `eq` b) $ cross s1 s2
683+joinInnerGeneric eq s1 s2 = filter (\(a, b) -> a `eq` b) $ cross s1 s2
686
684
687------------------------------------------------------------------------------
685------------------------------------------------------------------------------
688-- Exceptions
686-- Exceptions
core/src/Streamly/Internal/FileSystem/File.hs+9−4
@@ -103,14 +103,15 @@ import qualified Control.Monad.Catch as MC
103import qualified System.IO as SIO
103import qualified System.IO as SIO
104
104
105import Streamly.Data.Fold (groupsOf, drain)
105import Streamly.Data.Fold (groupsOf, drain)
106−import Streamly.Internal.Data.Array.Type (Array(..))
106+import Streamly.Internal.Data.Array.Type (Array(..), pinnedWriteNUnsafe)
107import Streamly.Internal.Data.Fold.Type (Fold(..))
107import Streamly.Internal.Data.Fold.Type (Fold(..))
108import Streamly.Data.Stream (Stream)
108import Streamly.Data.Stream (Stream)
109+import Streamly.Internal.Data.Unbox (Unbox)
109import Streamly.Internal.Data.Unfold.Type (Unfold(..))
110import Streamly.Internal.Data.Unfold.Type (Unfold(..))
110-- import Streamly.String (encodeUtf8, decodeUtf8, foldLines)
111-- import Streamly.String (encodeUtf8, decodeUtf8, foldLines)
111import Streamly.Internal.System.IO (defaultChunkSize)
112import Streamly.Internal.System.IO (defaultChunkSize)
112
113
113−import qualified Streamly.Internal.Data.Array as A
114+import qualified Streamly.Data.Array as A
114import qualified Streamly.Data.Stream as S
115import qualified Streamly.Data.Stream as S
115import qualified Streamly.Data.Unfold as UF
116import qualified Streamly.Data.Unfold as UF
116import qualified Streamly.Internal.Data.Array.Type as IA (pinnedChunksOf)
117import qualified Streamly.Internal.Data.Array.Type as IA (pinnedChunksOf)
@@ -338,6 +339,10 @@ readWithBufferOf = readerWith
338reader :: (MonadIO m, MonadCatch m) => Unfold m FilePath Word8
339reader :: (MonadIO m, MonadCatch m) => Unfold m FilePath Word8
339reader = UF.many A.reader (usingFile FH.chunkReader)
340reader = UF.many A.reader (usingFile FH.chunkReader)
340
341
342+{-# INLINE concatChunks #-}
343+concatChunks :: (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
344+concatChunks = S.unfoldMany A.reader
345+
341-- | Generate a stream of bytes from a file specified by path. The stream ends
346-- | Generate a stream of bytes from a file specified by path. The stream ends
342-- when EOF is encountered. File is locked using multiple reader and single
347-- when EOF is encountered. File is locked using multiple reader and single
343-- writer locking mode.
348-- writer locking mode.
@@ -346,7 +351,7 @@ reader = UF.many A.reader (usingFile FH.chunkReader)
346--
351--
347{-# INLINE read #-}
352{-# INLINE read #-}
348read :: (MonadIO m, MonadCatch m) => FilePath -> Stream m Word8
353read :: (MonadIO m, MonadCatch m) => FilePath -> Stream m Word8
349−read file = A.concat $ withFile file ReadMode FH.readChunks
354+read file = concatChunks $ withFile file ReadMode FH.readChunks
350
355
351{-# DEPRECATED toBytes "Please use 'read' instead" #-}
356{-# DEPRECATED toBytes "Please use 'read' instead" #-}
352{-# INLINE toBytes #-}
357{-# INLINE toBytes #-}
@@ -462,7 +467,7 @@ writeChunks path = Fold step initial extract final
462writeWith :: (MonadIO m, MonadCatch m)
467writeWith :: (MonadIO m, MonadCatch m)
463 => Int -> FilePath -> Fold m Word8 ()
468 => Int -> FilePath -> Fold m Word8 ()
464writeWith n path =
469writeWith n path =
465− groupsOf n (A.unsafePinnedCreateOf n) (writeChunks path)
470+ groupsOf n (pinnedWriteNUnsafe n) (writeChunks path)
466
471
467{-# DEPRECATED writeWithBufferOf "Please use 'writeWith' instead" #-}
472{-# DEPRECATED writeWithBufferOf "Please use 'writeWith' instead" #-}
468{-# INLINE writeWithBufferOf #-}
473{-# INLINE writeWithBufferOf #-}
core/src/Streamly/Internal/FileSystem/Handle.hs+28−21
@@ -40,8 +40,8 @@ module Streamly.Internal.FileSystem.Handle
40
40
41 -- * Streams
41 -- * Streams
42 , read
42 , read
43− , readWith -- readConcatChunksOf
43+ , readWith
44− , readChunksWith -- readChunksOf
44+ , readChunksWith
45 , readChunks
45 , readChunks
46
46
47 -- * Unfolds
47 -- * Unfolds
@@ -59,10 +59,10 @@ module Streamly.Internal.FileSystem.Handle
59 -- , writeUtf8ByLines
59 -- , writeUtf8ByLines
60 -- , writeByFrames
60 -- , writeByFrames
61 -- , writeLines
61 -- , writeLines
62− , writeWith -- writeChunksOf
62+ , writeWith
63 , writeChunks
63 , writeChunks
64− , writeChunksWith -- writeCompactChunksOf
64+ , writeChunksWith
65− , writeMaybesWith -- writeCompactJustsOf
65+ , writeMaybesWith
66
66
67 -- * Refolds
67 -- * Refolds
68 , writer
68 , writer
@@ -131,13 +131,16 @@ import Streamly.Internal.Data.Fold (Fold)
131import Streamly.Internal.Data.Refold.Type (Refold(..))
131import Streamly.Internal.Data.Refold.Type (Refold(..))
132import Streamly.Internal.Data.Unfold.Type (Unfold(..))
132import Streamly.Internal.Data.Unfold.Type (Unfold(..))
133import Streamly.Internal.Data.Array.Type
133import Streamly.Internal.Data.Array.Type
134− (Array(..), unsafeFreezeWithShrink, byteLength)
134+ (Array(..), pinnedWriteNUnsafe, unsafeFreezeWithShrink, byteLength)
135import Streamly.Internal.Data.Stream.Type (Stream)
135import Streamly.Internal.Data.Stream.Type (Stream)
136+import Streamly.Internal.Data.Array.Stream (lpackArraysChunksOf)
136-- import Streamly.String (encodeUtf8, decodeUtf8, foldLines)
137-- import Streamly.String (encodeUtf8, decodeUtf8, foldLines)
137import Streamly.Internal.System.IO (defaultChunkSize)
138import Streamly.Internal.System.IO (defaultChunkSize)
138
139
139import qualified Streamly.Data.Fold as FL
140import qualified Streamly.Data.Fold as FL
140−import qualified Streamly.Internal.Data.Array as A
141+import qualified Streamly.Data.Array as A
142+import qualified Streamly.Internal.Data.Array.Type as A
143+import qualified Streamly.Internal.Data.Array.Stream as AS
141import qualified Streamly.Internal.Data.MutArray.Type as MArray
144import qualified Streamly.Internal.Data.MutArray.Type as MArray
142import qualified Streamly.Internal.Data.Refold.Type as Refold
145import qualified Streamly.Internal.Data.Refold.Type as Refold
143import qualified Streamly.Internal.Data.Fold.Type as FL(refoldMany)
146import qualified Streamly.Internal.Data.Fold.Type as FL(refoldMany)
@@ -166,8 +169,6 @@ import qualified Streamly.Internal.Data.StreamK.Type as K (mkStream)
166-- Array IO (Input)
169-- Array IO (Input)
167-------------------------------------------------------------------------------
170-------------------------------------------------------------------------------
168
171
169−-- XXX add an API that compacts the arrays to an exact size.
170−
171-- | Read a 'ByteArray' consisting of one or more bytes from a file handle. If
172-- | Read a 'ByteArray' consisting of one or more bytes from a file handle. If
172-- no data is available on the handle it blocks until at least one byte becomes
173-- no data is available on the handle it blocks until at least one byte becomes
173-- available. If any data is available then it immediately returns that data
174-- available. If any data is available then it immediately returns that data
@@ -177,9 +178,9 @@ import qualified Streamly.Internal.Data.StreamK.Type as K (mkStream)
177{-# INLINABLE getChunk #-}
178{-# INLINABLE getChunk #-}
178getChunk :: MonadIO m => Int -> Handle -> m (Array Word8)
179getChunk :: MonadIO m => Int -> Handle -> m (Array Word8)
179getChunk size h = liftIO $ do
180getChunk size h = liftIO $ do
180− arr :: MArray.MutArray Word8 <- MArray.pinnedEmptyOf size
181+ arr <- MArray.pinnedNewBytes size
181 -- ptr <- mallocPlainForeignPtrAlignedBytes size (alignment (undefined :: Word8))
182 -- ptr <- mallocPlainForeignPtrAlignedBytes size (alignment (undefined :: Word8))
182− MArray.unsafePinnedAsPtr arr $ \p -> do
183+ MArray.asPtrUnsafe arr $ \p -> do
183 n <- hGetBufSome h p size
184 n <- hGetBufSome h p size
184 -- XXX shrink only if the diff is significant
185 -- XXX shrink only if the diff is significant
185 return $
186 return $
@@ -337,6 +338,10 @@ readerWith = UF.many A.reader chunkReaderWith
337readWithBufferOf :: MonadIO m => Unfold m (Int, Handle) Word8
338readWithBufferOf :: MonadIO m => Unfold m (Int, Handle) Word8
338readWithBufferOf = readerWith
339readWithBufferOf = readerWith
339
340
341+{-# INLINE concatChunks #-}
342+concatChunks :: (Monad m, Unbox a) => Stream m (Array a) -> Stream m a
343+concatChunks = S.unfoldMany A.reader
344+
340-- | @readWith bufsize handle@ reads a byte stream from a file
345-- | @readWith bufsize handle@ reads a byte stream from a file
341-- handle, reads are performed in chunks of up to @bufsize@.
346-- handle, reads are performed in chunks of up to @bufsize@.
342--
347--
@@ -345,7 +350,7 @@ readWithBufferOf = readerWith
345-- /Pre-release/
350-- /Pre-release/
346{-# INLINE readWith #-}
351{-# INLINE readWith #-}
347readWith :: MonadIO m => Int -> Handle -> Stream m Word8
352readWith :: MonadIO m => Int -> Handle -> Stream m Word8
348−readWith size h = A.concat $ readChunksWith size h
353+readWith size h = concatChunks $ readChunksWith size h
349
354
350-- | Unfolds a file handle into a byte stream. IO requests to the device are
355-- | Unfolds a file handle into a byte stream. IO requests to the device are
351-- performed in sizes of
356-- performed in sizes of
@@ -364,7 +369,7 @@ reader = UF.many A.reader chunkReader
364-- /Pre-release/
369-- /Pre-release/
365{-# INLINE read #-}
370{-# INLINE read #-}
366read :: MonadIO m => Handle -> Stream m Word8
371read :: MonadIO m => Handle -> Stream m Word8
367−read = A.concat . readChunks
372+read = concatChunks . readChunks
368
373
369-------------------------------------------------------------------------------
374-------------------------------------------------------------------------------
370-- Writing
375-- Writing
@@ -379,12 +384,12 @@ read = A.concat . readChunks
379{-# INLINABLE putChunk #-}
384{-# INLINABLE putChunk #-}
380putChunk :: MonadIO m => Handle -> Array a -> m ()
385putChunk :: MonadIO m => Handle -> Array a -> m ()
381putChunk _ arr | byteLength arr == 0 = return ()
386putChunk _ arr | byteLength arr == 0 = return ()
382−putChunk h arr = A.unsafePinnedAsPtr arr $ \ptr ->
387+putChunk h arr = A.asPtrUnsafe arr $ \ptr ->
383 liftIO $ hPutBuf h ptr aLen
388 liftIO $ hPutBuf h ptr aLen
384
389
385 where
390 where
386
391
387− -- XXX We should have the length passed by unsafePinnedAsPtr itself.
392+ -- XXX We should have the length passed by asPtrUnsafe itself.
388 aLen = A.byteLength arr
393 aLen = A.byteLength arr
389
394
390-------------------------------------------------------------------------------
395-------------------------------------------------------------------------------
@@ -416,7 +421,7 @@ putChunks h = S.fold (FL.drainMapM (putChunk h))
416{-# INLINE putChunksWith #-}
421{-# INLINE putChunksWith #-}
417putChunksWith :: (MonadIO m, Unbox a)
422putChunksWith :: (MonadIO m, Unbox a)
418 => Int -> Handle -> Stream m (Array a) -> m ()
423 => Int -> Handle -> Stream m (Array a) -> m ()
419−putChunksWith n h xs = putChunks h $ A.compactLE n xs
424+putChunksWith n h xs = putChunks h $ AS.compact n xs
420
425
421-- > putBytesWith n h m = Handle.putChunks h $ A.pinnedChunksOf n m
426-- > putBytesWith n h m = Handle.putChunks h $ A.pinnedChunksOf n m
422
427
@@ -456,6 +461,8 @@ writeChunks h = FL.drainMapM (putChunk h)
456chunkWriter :: MonadIO m => Refold m Handle (Array a) ()
461chunkWriter :: MonadIO m => Refold m Handle (Array a) ()
457chunkWriter = Refold.drainBy putChunk
462chunkWriter = Refold.drainBy putChunk
458
463
464+-- XXX lpackArraysChunksOf should be written idiomatically
465+
459-- | @writeChunksWith bufsize handle@ writes a stream of arrays
466-- | @writeChunksWith bufsize handle@ writes a stream of arrays
460-- to @handle@ after coalescing the adjacent arrays in chunks of @bufsize@.
467-- to @handle@ after coalescing the adjacent arrays in chunks of @bufsize@.
461-- We never split an array, if a single array is bigger than the specified size
468-- We never split an array, if a single array is bigger than the specified size
@@ -465,7 +472,7 @@ chunkWriter = Refold.drainBy putChunk
465{-# INLINE writeChunksWith #-}
472{-# INLINE writeChunksWith #-}
466writeChunksWith :: (MonadIO m, Unbox a)
473writeChunksWith :: (MonadIO m, Unbox a)
467 => Int -> Handle -> Fold m (Array a) ()
474 => Int -> Handle -> Fold m (Array a) ()
468−writeChunksWith n h = A.lCompactGE n (writeChunks h)
475+writeChunksWith n h = lpackArraysChunksOf n (writeChunks h)
469
476
470-- | Same as 'writeChunksWith'
477-- | Same as 'writeChunksWith'
471--
478--
@@ -489,11 +496,11 @@ writeChunksWithBufferOf = writeChunksWith
489-- Bytes in the input stream are collected into a buffer until we have a chunk
496-- Bytes in the input stream are collected into a buffer until we have a chunk
490-- of @reqSize@ and then written to the IO device.
497-- of @reqSize@ and then written to the IO device.
491--
498--
492−-- >>> writeWith n h = Fold.groupsOf n (Array.unsafeCreateOf n) (Handle.writeChunks h)
499+-- >>> writeWith n h = Fold.groupsOf n (Array.writeNUnsafe n) (Handle.writeChunks h)
493--
500--
494{-# INLINE writeWith #-}
501{-# INLINE writeWith #-}
495writeWith :: MonadIO m => Int -> Handle -> Fold m Word8 ()
502writeWith :: MonadIO m => Int -> Handle -> Fold m Word8 ()
496−writeWith n h = FL.groupsOf n (A.unsafePinnedCreateOf n) (writeChunks h)
503+writeWith n h = FL.groupsOf n (pinnedWriteNUnsafe n) (writeChunks h)
497
504
498-- | Same as 'writeWith'
505-- | Same as 'writeWith'
499--
506--
@@ -511,7 +518,7 @@ writeWithBufferOf = writeWith
511writeMaybesWith :: (MonadIO m )
518writeMaybesWith :: (MonadIO m )
512 => Int -> Handle -> Fold m (Maybe Word8) ()
519 => Int -> Handle -> Fold m (Maybe Word8) ()
513writeMaybesWith n h =
520writeMaybesWith n h =
514− let writeNJusts = FL.lmap fromJust $ A.pinnedCreateOf n
521+ let writeNJusts = FL.lmap fromJust $ A.pinnedWriteN n
515 writeOnNothing = FL.takeEndBy_ isNothing writeNJusts
522 writeOnNothing = FL.takeEndBy_ isNothing writeNJusts
516 in FL.many writeOnNothing (writeChunks h)
523 in FL.many writeOnNothing (writeChunks h)
517
524
@@ -521,7 +528,7 @@ writeMaybesWith n h =
521{-# INLINE writerWith #-}
528{-# INLINE writerWith #-}
522writerWith :: MonadIO m => Int -> Refold m Handle Word8 ()
529writerWith :: MonadIO m => Int -> Refold m Handle Word8 ()
523writerWith n =
530writerWith n =
524− FL.refoldMany (FL.take n $ A.unsafePinnedCreateOf n) chunkWriter
531+ FL.refoldMany (FL.take n $ pinnedWriteNUnsafe n) chunkWriter
525
532
526-- | Write a byte stream to a file handle. Accumulates the input in chunks of
533-- | Write a byte stream to a file handle. Accumulates the input in chunks of
527-- up to 'Streamly.Internal.Data.Array.Type.defaultChunkSize' before writing
534-- up to 'Streamly.Internal.Data.Array.Type.defaultChunkSize' before writing
core/src/Streamly/Internal/FileSystem/Path.hs+4−36
@@ -36,7 +36,7 @@
36module Streamly.Internal.FileSystem.Path
36module Streamly.Internal.FileSystem.Path
37 (
37 (
38 -- * Path Types
38 -- * Path Types
39− Path (..)
39+ Path
40 , File
40 , File
41 , Dir
41 , Dir
42 , Abs
42 , Abs
@@ -82,11 +82,6 @@ module Streamly.Internal.FileSystem.Path
82 , toChars
82 , toChars
83
83
84 -- * Operations
84 -- * Operations
85− -- Do we need to export the separator functions? They are not essential if
86− -- operations to split and combine paths are provided. If someone wants to
87− -- work on paths at low level then they know what they are.
88− , primarySeparator
89− , isSeparator
90 , extendPath
85 , extendPath
91 , extendDir
86 , extendDir
92 )
87 )
@@ -94,7 +89,6 @@ where
94
89
95import Control.Exception (Exception)
90import Control.Exception (Exception)
96import Control.Monad.Catch (MonadThrow(..))
91import Control.Monad.Catch (MonadThrow(..))
97−import Data.Char (chr)
98import Data.Functor.Identity (Identity(..))
92import Data.Functor.Identity (Identity(..))
99import Data.Word (Word8)
93import Data.Word (Word8)
100#if defined(mingw32_HOST_OS) || defined(__MINGW32__)
94#if defined(mingw32_HOST_OS) || defined(__MINGW32__)
@@ -157,15 +151,6 @@ instance Exception PathException
157-- | A type representing file system paths for directories or files.
151-- | A type representing file system paths for directories or files.
158newtype Path = Path (Array WORD_TYPE) -- deriving Eq
152newtype Path = Path (Array WORD_TYPE) -- deriving Eq
159
153
160−-- Show instance prints raw bytes without any decoding for rountdtripping.
161−-- Should we print this as a string instead, may be useful for ascii chars but
162−-- utf8 encoded chars may be unprintable. Better use toString if you want to
163−-- pretty print the path.
164−{-
165−instance Show Path where
166− show (Path x) = show x
167−-}
168−
169-- XXX Do we need a type for file or dir Name as names cannot have the
154-- XXX Do we need a type for file or dir Name as names cannot have the
170-- separator char and there may be other restrictions on names? For example,
155-- separator char and there may be other restrictions on names? For example,
171-- length restriction. A file name cannot be "." or "..". We can use the types
156-- length restriction. A file name cannot be "." or "..". We can use the types
@@ -453,25 +438,8 @@ mkRelFile = undefined
453-- Operations
438-- Operations
454------------------------------------------------------------------------------
439------------------------------------------------------------------------------
455
440
456−separatorWord :: WORD_TYPE
441+separator :: WORD_TYPE
457−separatorWord = SEPARATOR
442+separator = SEPARATOR
458−
459−-- Portable definition for exporting.
460−
461−-- | Primary path separator character, @/@ on Posix and @\\@ on Windows.
462−-- Windows supports @/@ too as a separator. Please use 'isSeparator' for
463−-- testing if a char is a separator char.
464−primarySeparator :: Char
465−primarySeparator = chr (SEPARATOR)
466−
467−-- | On Posix only @/@ is a path separator but in windows it could be either
468−-- @/@ or @\\@.
469−isSeparator :: Char -> Bool
470−#if defined(mingw32_HOST_OS) || defined(__MINGW32__)
471−isSeparator c = (c == '/') || (c == '\\')
472−#else
473−isSeparator = (== '/')
474−#endif
475
443
476-- If we append an absolute path it may fail with an error if the 'Path'
444-- If we append an absolute path it may fail with an error if the 'Path'
477-- implementation stores absolute path information (a leading separator char).
445-- implementation stores absolute path information (a leading separator char).
@@ -497,7 +465,7 @@ extendPath (Path a) (Path b) =
497 newArr = unsafePerformIO $ do
465 newArr = unsafePerformIO $ do
498 arr <- MutArray.new len
466 arr <- MutArray.new len
499 arr1 <- MutArray.spliceUnsafe arr (Array.unsafeThaw a)
467 arr1 <- MutArray.spliceUnsafe arr (Array.unsafeThaw a)
500− arr2 <- MutArray.snocUnsafe arr1 separatorWord
468+ arr2 <- MutArray.snocUnsafe arr1 separator
501 arr3 <- MutArray.spliceUnsafe arr2 (Array.unsafeThaw b)
469 arr3 <- MutArray.spliceUnsafe arr2 (Array.unsafeThaw b)
502 return (Array.unsafeFreeze arr3)
470 return (Array.unsafeFreeze arr3)
503 in Path newArr
471 in Path newArr
core/src/Streamly/Internal/Unicode/Stream.hs+2−2
@@ -111,7 +111,7 @@ import GHC.IO.Encoding.Failure (isSurrogate)
111import GHC.Ptr (Ptr (..), plusPtr)
111import GHC.Ptr (Ptr (..), plusPtr)
112import System.IO.Unsafe (unsafePerformIO)
112import System.IO.Unsafe (unsafePerformIO)
113import Streamly.Internal.Data.Array.Type (Array(..))
113import Streamly.Internal.Data.Array.Type (Array(..))
114−import Streamly.Internal.Data.MutByteArray.Type (MutByteArray)
114+import Streamly.Internal.Data.MutArray.Type (MutByteArray)
115import Streamly.Internal.Data.Fold (Fold)
115import Streamly.Internal.Data.Fold (Fold)
116import Streamly.Internal.Data.Parser (Parser)
116import Streamly.Internal.Data.Parser (Parser)
117import Streamly.Internal.Data.Stream (Stream)
117import Streamly.Internal.Data.Stream (Stream)
@@ -1057,7 +1057,7 @@ stripHead = Stream.dropWhile isSpace
1057-- >>> Stream.fold Fold.toList $ Unicode.lines Fold.toList (Stream.fromList "lines\nthis\nstring\n\n\n")
1057-- >>> Stream.fold Fold.toList $ Unicode.lines Fold.toList (Stream.fromList "lines\nthis\nstring\n\n\n")
1058-- ["lines","this","string","",""]
1058-- ["lines","this","string","",""]
1059--
1059--
1060−-- >>> lines f = Stream.foldMany (Fold.takeEndBy_ (== '\n') f)
1060+-- > lines = Stream.splitOnSuffix (== '\n')
1061--
1061--
1062-- /Pre-release/
1062-- /Pre-release/
1063{-# INLINE lines #-}
1063{-# INLINE lines #-}
core/src/Streamly/Internal/Unicode/String.hs+7−7
@@ -39,14 +39,14 @@ module Streamly.Internal.Unicode.String
39 --
39 --
40 -- $setup
40 -- $setup
41
41
42− str
42+ str
43 ) where
43 ) where
44
44
45
45
46import Control.Applicative (Alternative(..))
46import Control.Applicative (Alternative(..))
47import Control.Exception (displayException)
47import Control.Exception (displayException)
48import Data.Functor.Identity (runIdentity)
48import Data.Functor.Identity (runIdentity)
49−import Streamly.Internal.Data.Parser (Parser, ParseError)
49+import Streamly.Internal.Data.Parser (Parser)
50
50
51import Language.Haskell.TH
51import Language.Haskell.TH
52import Language.Haskell.TH.Quote
52import Language.Haskell.TH.Quote
@@ -106,12 +106,9 @@ strSegmentExp (StrVar name) = do
106strExp :: [StrSegment] -> Q Exp
106strExp :: [StrSegment] -> Q Exp
107strExp xs = appE [| concat |] $ listE $ map strSegmentExp xs
107strExp xs = appE [| concat |] $ listE $ map strSegmentExp xs
108
108
109−parseStr :: String -> Either ParseError [StrSegment]
110−parseStr = runIdentity . Stream.parse strParser . Stream.fromList
111−
112expandVars :: String -> Q Exp
109expandVars :: String -> Q Exp
113−expandVars input =
110+expandVars ln =
114− case parseStr input of
111+ case runIdentity $ Stream.parse strParser (Stream.fromList ln) of
115 Left e ->
112 Left e ->
116 fail $ "str QuasiQuoter parse error: " ++ displayException e
113 fail $ "str QuasiQuoter parse error: " ++ displayException e
117 Right x ->
114 Right x ->
@@ -144,6 +141,9 @@ expandVars input =
144-- :}
141-- :}
145-- "hello world!"
142-- "hello world!"
146--
143--
144+-- Bugs: because of a bug in parsers, a lone # at the end of input gets
145+-- removed.
146+--
147str :: QuasiQuoter
147str :: QuasiQuoter
148str =
148str =
149 QuasiQuoter
149 QuasiQuoter
core/streamly-core.cabal+10−14
@@ -1,6 +1,6 @@
1cabal-version: 2.2
1cabal-version: 2.2
2name: streamly-core
2name: streamly-core
3−version: 0.2.2
3+version: 0.2.1
4synopsis: Streaming, parsers, arrays, serialization and more
4synopsis: Streaming, parsers, arrays, serialization and more
5description:
5description:
6 For upgrading to streamly-0.9.0+ please read the
6 For upgrading to streamly-0.9.0+ please read the
@@ -116,7 +116,6 @@ extra-doc-files:
116 docs/*.md
116 docs/*.md
117 docs/ApiChangelogs/0.1.0.txt
117 docs/ApiChangelogs/0.1.0.txt
118 docs/ApiChangelogs/0.1.0-0.2.0.txt
118 docs/ApiChangelogs/0.1.0-0.2.0.txt
119− docs/ApiChangelogs/0.2.0-0.2.2.txt
120
119
121source-repository head
120source-repository head
122 type: git
121 type: git
@@ -218,6 +217,8 @@ common compile-options
218common default-extensions
217common default-extensions
219 default-extensions:
218 default-extensions:
220 BangPatterns
219 BangPatterns
220+ CApiFFI
221+ CPP
221 ConstraintKinds
222 ConstraintKinds
222 DeriveDataTypeable
223 DeriveDataTypeable
223 DeriveGeneric
224 DeriveGeneric
@@ -228,29 +229,24 @@ common default-extensions
228 GeneralizedNewtypeDeriving
229 GeneralizedNewtypeDeriving
229 InstanceSigs
230 InstanceSigs
230 KindSignatures
231 KindSignatures
232+ LambdaCase
233+ MagicHash
231 MultiParamTypeClasses
234 MultiParamTypeClasses
235+ PatternSynonyms
232 RankNTypes
236 RankNTypes
237+ RecordWildCards
233 ScopedTypeVariables
238 ScopedTypeVariables
234 StandaloneDeriving
239 StandaloneDeriving
235 TupleSections
240 TupleSections
236 TypeApplications
241 TypeApplications
242+ TypeFamilies
237 TypeOperators
243 TypeOperators
244+ ViewPatterns
238
245
239− -- Not GHC2021
240− CApiFFI
241− CPP
242− DefaultSignatures
243− LambdaCase
244− MagicHash
245− RecordWildCards
246−
247− -- TypeFamilies is required by IsList, IsMap type classes and
248− -- Unbox generic deriving code.
249− -- TypeFamilies
250 -- MonoLocalBinds, enabled by TypeFamilies, causes performance
246 -- MonoLocalBinds, enabled by TypeFamilies, causes performance
251 -- regressions. Disable it. This must come after TypeFamilies,
247 -- regressions. Disable it. This must come after TypeFamilies,
252 -- otherwise TypeFamilies will enable it again.
248 -- otherwise TypeFamilies will enable it again.
253− -- NoMonoLocalBinds
249+ NoMonoLocalBinds
254
250
255 -- UndecidableInstances -- Does not show any perf impact
251 -- UndecidableInstances -- Does not show any perf impact
256 -- UnboxedTuples -- interferes with (#.)
252 -- UnboxedTuples -- interferes with (#.)
docs/Developer/optimization-guidelines.md−12
@@ -191,18 +191,6 @@ the stages of a loop, it is often not useful to inline the whole loop
191itself, in fact we may have to occasionally use a `NOINLINE` so that the
191itself, in fact we may have to occasionally use a `NOINLINE` so that the
192compiler does not inline it.
192compiler does not inline it.
193
193
194−We need to be careful about NOINLINE on polymorphic functions. When
195−NOINLINE is used, the function cannot be specialized causing huge
196−performance degradation. To avoid that we can either make the
197−function monomorphic or sometimes using `NOINLINE [0]` can do the
198−trick. `NOINLINE [0]` blocks inlining in earlier phases but lets it
199−specialize in the last phase, inlining in the last phase is left to
200−the compiler. `INLINE [0]` may sound the same as `NOINLINE [0]`,
201−however, it behaves differently because we ask the compiler to INLINE
202−it compulsorily and it may not give us the desired results. The
203−Data.Fold.writeLastN benchmark is one such case where `NOINLINE [0]`
204−provides much better performance than `INLINE [0]`.
205−
206### NoSpecConstr
194### NoSpecConstr
207
195
208It is not always useful to specialize function calls for all constructors, some
196It is not always useful to specialize function calls for all constructors, some
docs/User/Project/Changelog.md+1−1
@@ -2,7 +2,7 @@
2
2
3<!-- See rendered changelog at https://streamly.composewell.com -->
3<!-- See rendered changelog at https://streamly.composewell.com -->
4
4
5−## 0.10.1 (Jan 2024)
5+## Unreleased
6
6
7* Fix TH macros in `Streamly.Data.Stream.MkType` for GHC 9.6 and above.
7* Fix TH macros in `Streamly.Data.Stream.MkType` for GHC 9.6 and above.
8
8
docs/User/Project/README.md−1
@@ -1,7 +1,6 @@
1# [Streamly][]: Idiomatic Haskell with C-Like Performance
1# [Streamly][]: Idiomatic Haskell with C-Like Performance
2
2
3[![Gitter chat](https://badges.gitter.im/composewell/gitter.svg)](https://gitter.im/composewell/streamly)
3[![Gitter chat](https://badges.gitter.im/composewell/gitter.svg)](https://gitter.im/composewell/streamly)
4−[![Hackage](https://img.shields.io/hackage/v/streamly-core.svg?style=flat)](https://hackage.haskell.org/package/streamly-core)
5[![Hackage](https://img.shields.io/hackage/v/streamly.svg?style=flat)](https://hackage.haskell.org/package/streamly)
4[![Hackage](https://img.shields.io/hackage/v/streamly.svg?style=flat)](https://hackage.haskell.org/package/streamly)
6
5
7## Upgrading to 0.9.0+
6## Upgrading to 0.9.0+
src/Streamly/Internal/Data/IsMap/HashMap.hs−5
@@ -1,8 +1,3 @@
1−{-# LANGUAGE TypeFamilies #-}
2−-- Must come after TypeFamilies, otherwise it is re-enabled.
3−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
4−{-# LANGUAGE NoMonoLocalBinds #-}
5−
6{-# OPTIONS_GHC -Wno-orphans #-}
1{-# OPTIONS_GHC -Wno-orphans #-}
7
2
8-- |
3-- |
src/Streamly/Internal/Data/Stream/IsStream/Common.hs+1−1
@@ -529,7 +529,7 @@ reverse' :: (IsStream t, MonadIO m, Unbox a) => t m a -> t m a
529-- reverse' s = fromStreamD $ D.reverse' $ toStreamD s
529-- reverse' s = fromStreamD $ D.reverse' $ toStreamD s
530reverse' =
530reverse' =
531 fromStreamD
531 fromStreamD
532− . A.concatRev -- unfoldMany A.readerRev
532+ . A.concatChunksRev -- unfoldMany A.readerRev
533 . D.fromStreamK
533 . D.fromStreamK
534 . K.reverse
534 . K.reverse
535 . D.toStreamK
535 . D.toStreamK
src/Streamly/Internal/Data/Stream/IsStream/Expand.hs−5
@@ -1,8 +1,3 @@
1−{-# LANGUAGE TypeFamilies #-}
2−-- Must come after TypeFamilies, otherwise it is re-enabled.
3−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
4−{-# LANGUAGE NoMonoLocalBinds #-}
5−
6{-# OPTIONS_GHC -Wno-deprecations #-}
1{-# OPTIONS_GHC -Wno-deprecations #-}
7
2
8-- |
3-- |
src/Streamly/Internal/Data/Stream/IsStream/Top.hs+1−1
@@ -649,7 +649,7 @@ intersectBySorted :: (IsStream t, Monad m) =>
649 (a -> a -> Ordering) -> t m a -> t m a -> t m a
649 (a -> a -> Ordering) -> t m a -> t m a -> t m a
650intersectBySorted eq s1 =
650intersectBySorted eq s1 =
651 IsStream.fromStreamD
651 IsStream.fromStreamD
652− . StreamD.sortedIntersectBy eq (IsStream.toStreamD s1)
652+ . StreamD.intersectBySorted eq (IsStream.toStreamD s1)
653 . IsStream.toStreamD
653 . IsStream.toStreamD
654
654
655-- Roughly joinLeft s1 s2 = s1 `difference` s2 + s1 `intersection` s2
655-- Roughly joinLeft s1 s2 = s1 `difference` s2 + s1 `intersection` s2
src/Streamly/Internal/Data/Stream/Serial.hs−5
@@ -1,9 +1,4 @@
1−{-# LANGUAGE TypeFamilies #-}
2−-- Must come after TypeFamilies, otherwise it is re-enabled.
3−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
4−{-# LANGUAGE NoMonoLocalBinds #-}
5{-# LANGUAGE UndecidableInstances #-}
1{-# LANGUAGE UndecidableInstances #-}
6−
7{-# OPTIONS_GHC -Wno-deprecations #-}
2{-# OPTIONS_GHC -Wno-deprecations #-}
8{-# OPTIONS_GHC -Wno-redundant-constraints #-}
3{-# OPTIONS_GHC -Wno-redundant-constraints #-}
9
4
src/Streamly/Internal/Data/Stream/Zip.hs−5
@@ -1,9 +1,4 @@
1−{-# LANGUAGE TypeFamilies #-}
2−-- Must come after TypeFamilies, otherwise it is re-enabled.
3−-- MonoLocalBinds enabled by TypeFamilies causes perf regressions in general.
4−{-# LANGUAGE NoMonoLocalBinds #-}
5{-# LANGUAGE UndecidableInstances #-}
1{-# LANGUAGE UndecidableInstances #-}
6−
7{-# OPTIONS_GHC -Wno-deprecations #-}
2{-# OPTIONS_GHC -Wno-deprecations #-}
8
3
9-- |
4-- |
src/Streamly/Internal/FileSystem/Event.hs−3
@@ -20,9 +20,6 @@
20-- * "Streamly.Internal.FileSystem.Event.Linux"
20-- * "Streamly.Internal.FileSystem.Event.Linux"
21-- * "Streamly.Internal.FileSystem.Event.Windows"
21-- * "Streamly.Internal.FileSystem.Event.Windows"
22
22
23−-- XXX Need to ensure that the signatures of the exported APIs are same on all
24−-- platforms.
25−
26module Streamly.Internal.FileSystem.Event
23module Streamly.Internal.FileSystem.Event
27 (
24 (
28 -- * Creating a Watch
25 -- * Creating a Watch
src/Streamly/Internal/FileSystem/Event/Darwin.hs+1−1
@@ -451,7 +451,7 @@ openWatch Config{..} paths = do
451
451
452 withPathName :: Array Word8 -> (PathName -> IO a) -> IO a
452 withPathName :: Array Word8 -> (PathName -> IO a) -> IO a
453 withPathName arr act = do
453 withPathName arr act = do
454− A.unsafePinnedAsPtr arr $ \ptr ->
454+ A.asPtrUnsafe arr $ \ptr ->
455 let pname = PathName (castPtr ptr) (fromIntegral (A.length arr))
455 let pname = PathName (castPtr ptr) (fromIntegral (A.length arr))
456 in act pname
456 in act pname
457
457
src/Streamly/Internal/FileSystem/Event/Linux.hs+2−2
@@ -188,7 +188,7 @@ import qualified Streamly.FileSystem.Handle as FH
188import qualified Streamly.Unicode.Stream as U
188import qualified Streamly.Unicode.Stream as U
189
189
190import qualified Streamly.Internal.Data.Array as A
190import qualified Streamly.Internal.Data.Array as A
191− ( fromStream, asCStringUnsafe, unsafePinnedAsPtr
191+ ( fromStream, asCStringUnsafe, asPtrUnsafe
192 , getSliceUnsafe, read
192 , getSliceUnsafe, read
193 )
193 )
194import qualified Streamly.Internal.FileSystem.Dir as Dir (readDirs)
194import qualified Streamly.Internal.FileSystem.Dir as Dir (readDirs)
@@ -809,7 +809,7 @@ readOneEvent :: Config -> Watch -> Parser Word8 IO Event
809readOneEvent cfg wt@(Watch _ wdMap) = do
809readOneEvent cfg wt@(Watch _ wdMap) = do
810 let headerLen = sizeOf (undefined :: CInt) + 12
810 let headerLen = sizeOf (undefined :: CInt) + 12
811 arr <- PR.takeEQ headerLen (A.writeN headerLen)
811 arr <- PR.takeEQ headerLen (A.writeN headerLen)
812− (ewd, eflags, cookie, pathLen) <- PR.fromEffect $ A.unsafePinnedAsPtr arr readHeader
812+ (ewd, eflags, cookie, pathLen) <- PR.fromEffect $ A.asPtrUnsafe arr readHeader
813 -- XXX need the "initial" in parsers to return a step type so that "take 0"
813 -- XXX need the "initial" in parsers to return a step type so that "take 0"
814 -- can return without an input. otherwise if pathLen is 0 we will keep
814 -- can return without an input. otherwise if pathLen is 0 we will keep
815 -- waiting to read one more char before we return this event.
815 -- waiting to read one more char before we return this event.
src/Streamly/Internal/FileSystem/FD.hs+5−5
@@ -130,7 +130,7 @@ import qualified GHC.IO.Device as RawIO
130import Streamly.Data.Array (Array, Unbox)
130import Streamly.Data.Array (Array, Unbox)
131import Streamly.Data.Stream (Stream)
131import Streamly.Data.Stream (Stream)
132
132
133−import Streamly.Internal.Data.Array (byteLength, unsafeFreeze, unsafePinnedAsPtr)
133+import Streamly.Internal.Data.Array (byteLength, unsafeFreeze, asPtrUnsafe)
134import Streamly.Internal.System.IO (defaultChunkSize)
134import Streamly.Internal.System.IO (defaultChunkSize)
135
135
136#if !defined(mingw32_HOST_OS)
136#if !defined(mingw32_HOST_OS)
@@ -147,7 +147,7 @@ import qualified Streamly.Internal.System.IOVec.Type as RawIO
147import qualified Streamly.Data.Array as A
147import qualified Streamly.Data.Array as A
148import qualified Streamly.Data.Fold as FL
148import qualified Streamly.Data.Fold as FL
149import qualified Streamly.Internal.Data.MutArray as MArray
149import qualified Streamly.Internal.Data.MutArray as MArray
150− (MutArray(..), unsafePinnedAsPtr, pinnedNewBytes)
150+ (MutArray(..), asPtrUnsafe, pinnedNewBytes)
151import qualified Streamly.Internal.Data.Array.Stream as AS
151import qualified Streamly.Internal.Data.Array.Stream as AS
152import qualified Streamly.Internal.Data.Stream as S
152import qualified Streamly.Internal.Data.Stream as S
153import qualified Streamly.Internal.Data.Stream as D
153import qualified Streamly.Internal.Data.Stream as D
@@ -220,7 +220,7 @@ readArrayUpto :: Int -> Handle -> IO (Array Word8)
220readArrayUpto size (Handle fd) = do
220readArrayUpto size (Handle fd) = do
221 arr <- MArray.pinnedNewBytes size
221 arr <- MArray.pinnedNewBytes size
222 -- ptr <- mallocPlainForeignPtrAlignedBytes size (alignment (undefined :: Word8))
222 -- ptr <- mallocPlainForeignPtrAlignedBytes size (alignment (undefined :: Word8))
223− MArray.unsafePinnedAsPtr arr $ \p -> do
223+ MArray.asPtrUnsafe arr $ \p -> do
224 -- n <- hGetBufSome h p size
224 -- n <- hGetBufSome h p size
225#if MIN_VERSION_base(4,15,0)
225#if MIN_VERSION_base(4,15,0)
226 n <- RawIO.read fd p 0 size
226 n <- RawIO.read fd p 0 size
@@ -244,7 +244,7 @@ readArrayUpto size (Handle fd) = do
244writeArray :: Unbox a => Handle -> Array a -> IO ()
244writeArray :: Unbox a => Handle -> Array a -> IO ()
245writeArray _ arr | A.length arr == 0 = return ()
245writeArray _ arr | A.length arr == 0 = return ()
246writeArray (Handle fd) arr =
246writeArray (Handle fd) arr =
247− unsafePinnedAsPtr arr $ \p ->
247+ asPtrUnsafe arr $ \p ->
248 -- RawIO.writeAll fd (castPtr p) aLen
248 -- RawIO.writeAll fd (castPtr p) aLen
249#if MIN_VERSION_base(4,15,0)
249#if MIN_VERSION_base(4,15,0)
250 RawIO.write fd (castPtr p) 0 aLen
250 RawIO.write fd (castPtr p) 0 aLen
@@ -270,7 +270,7 @@ writeArray (Handle fd) arr =
270writeIOVec :: Handle -> Array RawIO.IOVec -> IO ()
270writeIOVec :: Handle -> Array RawIO.IOVec -> IO ()
271writeIOVec _ iov | A.length iov == 0 = return ()
271writeIOVec _ iov | A.length iov == 0 = return ()
272writeIOVec (Handle fd) iov =
272writeIOVec (Handle fd) iov =
273− unsafePinnedAsPtr iov $ \p ->
273+ asPtrUnsafe iov $ \p ->
274 RawIO.writevAll fd p (A.length iov)
274 RawIO.writevAll fd p (A.length iov)
275-}
275-}
276#endif
276#endif
src/Streamly/Internal/Network/Inet/TCP.hs+3−3
@@ -116,6 +116,7 @@ import Prelude hiding (read)
116import Streamly.Internal.Control.Concurrent (MonadAsync)
116import Streamly.Internal.Control.Concurrent (MonadAsync)
117import Streamly.Internal.Control.ForkLifted (fork)
117import Streamly.Internal.Control.ForkLifted (fork)
118import Streamly.Data.Array (Array)
118import Streamly.Data.Array (Array)
119+import Streamly.Internal.Data.Array (pinnedWriteNUnsafe)
119import Streamly.Internal.Data.Fold ( Fold(..) )
120import Streamly.Internal.Data.Fold ( Fold(..) )
120import Streamly.Data.Stream (Stream)
121import Streamly.Data.Stream (Stream)
121import Streamly.Internal.Data.Tuple.Strict (Tuple'(..))
122import Streamly.Internal.Data.Tuple.Strict (Tuple'(..))
@@ -131,8 +132,7 @@ import qualified Streamly.Data.Array as A
131import qualified Streamly.Data.Fold as FL
132import qualified Streamly.Data.Fold as FL
132import qualified Streamly.Data.Stream as S
133import qualified Streamly.Data.Stream as S
133import qualified Streamly.Data.Unfold as UF
134import qualified Streamly.Data.Unfold as UF
134−import qualified Streamly.Internal.Data.Array as A
135+import qualified Streamly.Internal.Data.Array as A (pinnedChunksOf)
135− (pinnedChunksOf, unsafePinnedCreateOf)
136import qualified Streamly.Internal.Data.Unfold as UF (bracketIO)
136import qualified Streamly.Internal.Data.Unfold as UF (bracketIO)
137import qualified Streamly.Internal.Data.Fold as FL (Step(..), reduce)
137import qualified Streamly.Internal.Data.Fold as FL (Step(..), reduce)
138
138
@@ -435,7 +435,7 @@ writeWithBufferOf
435 -> PortNumber
435 -> PortNumber
436 -> Fold m Word8 ()
436 -> Fold m Word8 ()
437writeWithBufferOf n addr port =
437writeWithBufferOf n addr port =
438− FL.groupsOf n (A.unsafePinnedCreateOf n) (writeChunks addr port)
438+ FL.groupsOf n (pinnedWriteNUnsafe n) (writeChunks addr port)
439
439
440-- | Write a stream to the supplied IPv4 host address and port number.
440-- | Write a stream to the supplied IPv4 host address and port number.
441--
441--
src/Streamly/Internal/Network/Socket.hs+10−11
@@ -87,6 +87,7 @@ import Prelude hiding (read)
87import qualified Network.Socket as Net
87import qualified Network.Socket as Net
88
88
89import Streamly.Internal.Data.Array (Array(..))
89import Streamly.Internal.Data.Array (Array(..))
90+import Streamly.Internal.Data.Array.Stream (lpackArraysChunksOf)
90import Streamly.Data.Fold (Fold)
91import Streamly.Data.Fold (Fold)
91import Streamly.Data.Stream (Stream)
92import Streamly.Data.Stream (Stream)
92import Streamly.Internal.Data.Unfold (Unfold(..))
93import Streamly.Internal.Data.Unfold (Unfold(..))
@@ -98,10 +99,10 @@ import qualified Streamly.Data.Fold as FL
98import qualified Streamly.Data.Stream as S
99import qualified Streamly.Data.Stream as S
99import qualified Streamly.Data.Unfold as UF
100import qualified Streamly.Data.Unfold as UF
100import qualified Streamly.Internal.Data.Array as A
101import qualified Streamly.Internal.Data.Array as A
101− ( unsafeFreeze, unsafePinnedAsPtr, byteLength, pinnedChunksOf,
102+ ( unsafeFreeze, asPtrUnsafe, byteLength, pinnedChunksOf,
102− pinnedCreateOf, unsafePinnedCreateOf, lCompactGE )
103+ pinnedWriteN, pinnedWriteNUnsafe )
103import qualified Streamly.Internal.Data.MutArray as MArray
104import qualified Streamly.Internal.Data.MutArray as MArray
104− (MutArray(..), unsafePinnedAsPtr, pinnedEmptyOf)
105+ (MutArray(..), asPtrUnsafe, pinnedNewBytes)
105import qualified Streamly.Internal.Data.Stream as S (fromStreamK, Stream(..), Step(..))
106import qualified Streamly.Internal.Data.Stream as S (fromStreamK, Stream(..), Step(..))
106import qualified Streamly.Internal.Data.StreamK as K (mkStream)
107import qualified Streamly.Internal.Data.StreamK as K (mkStream)
107
108
@@ -252,8 +253,6 @@ accept tcpListenQ spec addr =
252-- Array IO (Input)
253-- Array IO (Input)
253-------------------------------------------------------------------------------
254-------------------------------------------------------------------------------
254
255
255−-- XXX add an API that compacts the arrays to an exact size.
256−
257{-# INLINABLE readArrayUptoWith #-}
256{-# INLINABLE readArrayUptoWith #-}
258readArrayUptoWith
257readArrayUptoWith
259 :: (h -> Ptr Word8 -> Int -> IO Int)
258 :: (h -> Ptr Word8 -> Int -> IO Int)
@@ -261,9 +260,9 @@ readArrayUptoWith
261 -> h
260 -> h
262 -> IO (Array Word8)
261 -> IO (Array Word8)
263readArrayUptoWith f size h = do
262readArrayUptoWith f size h = do
264− arr <- MArray.pinnedEmptyOf size
263+ arr <- MArray.pinnedNewBytes size
265 -- ptr <- mallocPlainForeignPtrAlignedBytes size (alignment (undefined :: Word8))
264 -- ptr <- mallocPlainForeignPtrAlignedBytes size (alignment (undefined :: Word8))
266− MArray.unsafePinnedAsPtr arr $ \p -> do
265+ MArray.asPtrUnsafe arr $ \p -> do
267 n <- f h p size
266 n <- f h p size
268 let v = A.unsafeFreeze
267 let v = A.unsafeFreeze
269 $ arr { MArray.arrEnd = n, MArray.arrBound = size }
268 $ arr { MArray.arrEnd = n, MArray.arrBound = size }
@@ -311,7 +310,7 @@ writeArrayWith :: Unbox a
311 -> Array a
310 -> Array a
312 -> IO ()
311 -> IO ()
313writeArrayWith _ _ arr | A.length arr == 0 = return ()
312writeArrayWith _ _ arr | A.length arr == 0 = return ()
314−writeArrayWith f h arr = A.unsafePinnedAsPtr arr $ \ptr -> f h (castPtr ptr) aLen
313+writeArrayWith f h arr = A.asPtrUnsafe arr $ \ptr -> f h (castPtr ptr) aLen
315
314
316 where
315 where
317
316
@@ -474,7 +473,7 @@ writeChunks h = FL.drainMapM (liftIO . putChunk h)
474{-# INLINE writeChunksWith #-}
473{-# INLINE writeChunksWith #-}
475writeChunksWith :: (MonadIO m, Unbox a)
474writeChunksWith :: (MonadIO m, Unbox a)
476 => Int -> Socket -> Fold m (Array a) ()
475 => Int -> Socket -> Fold m (Array a) ()
477−writeChunksWith n h = A.lCompactGE n (writeChunks h)
476+writeChunksWith n h = lpackArraysChunksOf n (writeChunks h)
478
477
479-- | Same as 'writeChunksWith'
478-- | Same as 'writeChunksWith'
480--
479--
@@ -505,7 +504,7 @@ putBytesWith n h m = putChunks h $ A.pinnedChunksOf n m
505--
504--
506{-# INLINE writeWith #-}
505{-# INLINE writeWith #-}
507writeWith :: MonadIO m => Int -> Socket -> Fold m Word8 ()
506writeWith :: MonadIO m => Int -> Socket -> Fold m Word8 ()
508−writeWith n h = FL.groupsOf n (A.unsafePinnedCreateOf n) (writeChunks h)
507+writeWith n h = FL.groupsOf n (A.pinnedWriteNUnsafe n) (writeChunks h)
509
508
510-- | Same as 'writeWith'
509-- | Same as 'writeWith'
511--
510--
@@ -523,7 +522,7 @@ writeWithBufferOf = writeWith
523writeMaybesWith :: (MonadIO m )
522writeMaybesWith :: (MonadIO m )
524 => Int -> Socket -> Fold m (Maybe Word8) ()
523 => Int -> Socket -> Fold m (Maybe Word8) ()
525writeMaybesWith n h =
524writeMaybesWith n h =
526− let writeNJusts = FL.lmap fromJust $ A.pinnedCreateOf n
525+ let writeNJusts = FL.lmap fromJust $ A.pinnedWriteN n
527 writeOnNothing = FL.takeEndBy_ isNothing writeNJusts
526 writeOnNothing = FL.takeEndBy_ isNothing writeNJusts
528 in FL.many writeOnNothing (writeChunks h)
527 in FL.many writeOnNothing (writeChunks h)
529
528
streamly.cabal+11−11
@@ -1,6 +1,6 @@
1cabal-version: 2.2
1cabal-version: 2.2
2name: streamly
2name: streamly
3−version: 0.10.1
3+version: 0.10.0
4synopsis: Streaming, dataflow programming and declarative concurrency
4synopsis: Streaming, dataflow programming and declarative concurrency
5description:
5description:
6 For upgrading to streamly-0.9.0+ please read the
6 For upgrading to streamly-0.9.0+ please read the
@@ -294,6 +294,8 @@ common compile-options
294common default-extensions
294common default-extensions
295 default-extensions:
295 default-extensions:
296 BangPatterns
296 BangPatterns
297+ CApiFFI
298+ CPP
297 ConstraintKinds
299 ConstraintKinds
298 DeriveDataTypeable
300 DeriveDataTypeable
299 DeriveGeneric
301 DeriveGeneric
@@ -304,25 +306,23 @@ common default-extensions
304 GeneralizedNewtypeDeriving
306 GeneralizedNewtypeDeriving
305 InstanceSigs
307 InstanceSigs
306 KindSignatures
308 KindSignatures
309+ LambdaCase
310+ MagicHash
307 MultiParamTypeClasses
311 MultiParamTypeClasses
312+ PatternSynonyms
308 RankNTypes
313 RankNTypes
314+ RecordWildCards
309 ScopedTypeVariables
315 ScopedTypeVariables
310 TupleSections
316 TupleSections
311 TypeApplications
317 TypeApplications
318+ TypeFamilies
312 TypeOperators
319 TypeOperators
320+ ViewPatterns
313
321
314− -- Not GHC2021
315− CApiFFI
316− CPP
317− LambdaCase
318− MagicHash
319− RecordWildCards
320−
321− -- TypeFamilies -- required by IsHashMap type class
322 -- MonoLocalBinds, enabled by TypeFamilies, causes performance
322 -- MonoLocalBinds, enabled by TypeFamilies, causes performance
323 -- regressions. Disable it. This must come after TypeFamilies,
323 -- regressions. Disable it. This must come after TypeFamilies,
324 -- otherwise TypeFamilies will enable it again.
324 -- otherwise TypeFamilies will enable it again.
325− -- NoMonoLocalBinds
325+ NoMonoLocalBinds
326
326
327 -- UndecidableInstances -- Does not show any perf impact
327 -- UndecidableInstances -- Does not show any perf impact
328 -- UnboxedTuples -- interferes with (#.)
328 -- UnboxedTuples -- interferes with (#.)
@@ -513,7 +513,7 @@ library
513 , template-haskell >= 2.14 && < 2.22
513 , template-haskell >= 2.14 && < 2.22
514
514
515 -- The core streamly package
515 -- The core streamly package
516− , streamly-core == 0.2.2
516+ , streamly-core >= 0.2.0 && < 0.2.2
517
517
518 , hashable >= 1.3 && < 1.5
518 , hashable >= 1.3 && < 1.5
519 , unordered-containers >= 0.2 && < 0.3
519 , unordered-containers >= 0.2 && < 0.3
test/Streamly/Test/Data/Array.hs+2−2
@@ -185,7 +185,7 @@ testUnsafeIndxedFromList inp =
185testAsPtrUnsafeMA :: IO ()
185testAsPtrUnsafeMA :: IO ()
186testAsPtrUnsafeMA = do
186testAsPtrUnsafeMA = do
187 arr <- MA.fromList ([0 .. 99] :: [Int])
187 arr <- MA.fromList ([0 .. 99] :: [Int])
188− MA.unsafePinnedAsPtr arr (getList (0 :: Int)) `shouldReturn` [0 .. 99]
188+ MA.asPtrUnsafe arr (getList (0 :: Int)) `shouldReturn` [0 .. 99]
189
189
190 where
190 where
191
191
@@ -229,7 +229,7 @@ main =
229 prop "read . write === id" testFoldUnfold
229 prop "read . write === id" testFoldUnfold
230 prop "fromList" testFromList
230 prop "fromList" testFromList
231 prop "foldMany with writeNUnsafe concats to original"
231 prop "foldMany with writeNUnsafe concats to original"
232− (foldManyWith (\n -> Fold.take n (A.unsafeCreateOf n)))
232+ (foldManyWith (\n -> Fold.take n (A.writeNUnsafe n)))
233 describe "unsafeSlice" $ do
233 describe "unsafeSlice" $ do
234 it "partial" $ unsafeSlice 2 4 [1..10]
234 it "partial" $ unsafeSlice 2 4 [1..10]
235 it "none" $ unsafeSlice 10 0 [1..10]
235 it "none" $ unsafeSlice 10 0 [1..10]