swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-11-24 10:12:42 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor(es/minifier): Remove unnecessary code (#6575)

Browse Source
This commit is contained in:
IWANABETHATGUY 2022-12-05 08:14:51 +08:00 committed by GitHub
parent 2379fc1fd9
commit 586bfd5480
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 66 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/swc_ecma_minifier/src/lib.rs
View File

@ -171,7 +171,7 @@ pub fn optimize(
options.compress.as_ref(),
comments,
marks,
extra.unresolved_mark,
// extra.unresolved_mark,
));
debug_assert_valid(&n);
}

130
crates/swc_ecma_minifier/src/metadata/mod.rs
View File

@ -1,6 +1,6 @@
use swc_common::{
comments::{Comment, CommentKind, Comments},
EqIgnoreSpan, Mark, Span, SyntaxContext,
EqIgnoreSpan, Span, SyntaxContext,
};
use swc_ecma_ast::*;
use swc_ecma_utils::find_pat_ids;
@ -18,13 +18,13 @@ pub(crate) fn info_marker<'a>(
options: Option<&'a CompressOptions>,
comments: Option<&'a dyn Comments>,
marks: Marks,
unresolved_mark: Mark,
// unresolved_mark: Mark,
) -> impl 'a + VisitMut {
InfoMarker {
options,
comments,
marks,
unresolved_mark,
// unresolved_mark,
state: Default::default(),
}
}
@ -40,7 +40,7 @@ struct InfoMarker<'a> {
comments: Option<&'a dyn Comments>,
marks: Marks,
unresolved_mark: Mark,
// unresolved_mark: Mark,
state: State,
}
@ -178,12 +178,12 @@ impl VisitMut for InfoMarker<'_> {
)
})
{
if is_standalone(&mut n.function, self.unresolved_mark) {
// self.state.is_bundle = true;
// if is_standalone(&mut n.function, self.unresolved_mark) {
// // self.state.is_bundle = true;
// n.function.span =
// n.function.span.apply_mark(self.marks.standalone);
}
// // n.function.span =
// // n.function.span.apply_mark(self.marks.standalone);
// }
}
}
@ -267,71 +267,71 @@ impl Visit for TopLevelBindingCollector {
}
}
fn is_standalone<N>(n: &mut N, unresolved_mark: Mark) -> bool
where
N: VisitMutWith<IdentCollector>,
{
let unresolved_ctxt = SyntaxContext::empty().apply_mark(unresolved_mark);
// fn is_standalone<N>(n: &mut N, unresolved_mark: Mark) -> bool
// where
// N: VisitMutWith<IdentCollector>,
// {
// let unresolved_ctxt = SyntaxContext::empty().apply_mark(unresolved_mark);
let bindings = {
let mut v = IdentCollector {
ids: Default::default(),
for_binding: true,
is_pat_decl: false,
};
n.visit_mut_with(&mut v);
v.ids
};
// let bindings = {
// let mut v = IdentCollector {
// ids: Default::default(),
// for_binding: true,
// is_pat_decl: false,
// };
// n.visit_mut_with(&mut v);
// v.ids
// };
let used = {
let mut v = IdentCollector {
ids: Default::default(),
for_binding: false,
is_pat_decl: false,
};
n.visit_mut_with(&mut v);
v.ids
};
// let used = {
// let mut v = IdentCollector {
// ids: Default::default(),
// for_binding: false,
// is_pat_decl: false,
// };
// n.visit_mut_with(&mut v);
// v.ids
// };
for used_id in &used {
if used_id.0.starts_with("__WEBPACK_EXTERNAL_MODULE_") {
continue;
}
// for used_id in &used {
// if used_id.0.starts_with("__WEBPACK_EXTERNAL_MODULE_") {
// continue;
// }
match &*used_id.0 {
"__webpack_require__" | "exports" => continue,
_ => {}
}
// match &*used_id.0 {
// "__webpack_require__" | "exports" => continue,
// _ => {}
// }
if used_id.1 == unresolved_ctxt {
// if cfg!(feature = "debug") {
// debug!("bundle: Ignoring {}{:?} (top level)", used_id.0,
// used_id.1); }
continue;
}
// if used_id.1 == unresolved_ctxt {
// // if cfg!(feature = "debug") {
// // debug!("bundle: Ignoring {}{:?} (top level)", used_id.0,
// // used_id.1); }
// continue;
// }
if bindings.contains(used_id) {
// if cfg!(feature = "debug") {
// debug!(
// "bundle: Ignoring {}{:?} (local to fn)",
// used_id.0,
// used_id.1
// );
// }
continue;
}
// if bindings.contains(used_id) {
// // if cfg!(feature = "debug") {
// // debug!(
// // "bundle: Ignoring {}{:?} (local to fn)",
// // used_id.0,
// // used_id.1
// // );
// // }
// continue;
// }
trace_op!(
"bundle: Due to {}{:?}, it's not a bundle",
used_id.0,
used_id.1
);
// trace_op!(
// "bundle: Due to {}{:?}, it's not a bundle",
// used_id.0,
// used_id.1
// );
return false;
}
// return false;
// }
true
}
// true
// }
struct IdentCollector {
ids: Vec<Id>,