swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-11-28 02:29:04 +03:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

feat(es/parser): Disallow tagged tpl in optional chaining (#7515)

Browse Source
This commit is contained in:
Pig Fang 2023-06-12 09:37:39 +08:00 committed by GitHub
parent b46bcf3f50
commit 6c00a2422a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/swc_ecma_parser/src/error.rs
View File

@ -195,6 +195,7 @@ pub enum SyntaxError {
TsBindingPatCannotBeOptional, TsBindingPatCannotBeOptional,
SuperCallOptional, SuperCallOptional,
OptChainCannotFollowConstructorCall, OptChainCannotFollowConstructorCall,
TaggedTplInOptChain,
TrailingCommaInsideImport, TrailingCommaInsideImport,
@ -470,6 +471,9 @@ impl SyntaxError {
SyntaxError::OptChainCannotFollowConstructorCall => { SyntaxError::OptChainCannotFollowConstructorCall => {
"Constructor in/after an optional chaining is not allowed.".into() "Constructor in/after an optional chaining is not allowed.".into()
} }
SyntaxError::TaggedTplInOptChain => {
"Tagged template literal is not allowed in optional chain.".into()
}
SyntaxError::TsInvalidParamPropPat => { SyntaxError::TsInvalidParamPropPat => {
"Typescript parameter property must be an identifier or assignment pattern".into() "Typescript parameter property must be an identifier or assignment pattern".into()
} }

5
crates/swc_ecma_parser/src/parser/expr.rs
View File

@ -1060,6 +1060,11 @@ impl<I: Tokens> Parser<I> {
let tpl = Box::new(self.parse_tpl(true)?); let tpl = Box::new(self.parse_tpl(true)?);
let span = span!(self, tagged_tpl_start); let span = span!(self, tagged_tpl_start);
if tag.is_opt_chain() {
self.emit_err(span, SyntaxError::TaggedTplInOptChain);
}
Ok(TaggedTpl { Ok(TaggedTpl {
span, span,
tag, tag,

1
crates/swc_ecma_parser/tests/errors/optional-chaining/tagged-template.js Normal file
View File

@ -0,0 +1 @@
a?.b``

6
crates/swc_ecma_parser/tests/errors/optional-chaining/tagged-template.js.swc-stderr Normal file
View File

@ -0,0 +1,6 @@
x Tagged template literal is not allowed in optional chain.
,-[$DIR/tests/errors/optional-chaining/tagged-template.js:1:1]
1 | a?.b``
: ^^^^^^
`----