swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-11-21 21:41:48 +03:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix(bindings/node): Add VisitTsPropertySignature (#9670)
Some checks are pending
CI / Cargo fmt (push) Waiting to run
Details
CI / Cargo clippy (push) Waiting to run
Details
CI / Check license of dependencies (push) Waiting to run
Details
CI / Check (macos-latest) (push) Waiting to run
Details
CI / Check (ubuntu-latest) (push) Waiting to run
Details
CI / Check (windows-latest) (push) Waiting to run
Details
CI / Test wasm (binding_core_wasm) (push) Waiting to run
Details
CI / Test wasm (binding_minifier_wasm) (push) Waiting to run
Details
CI / Test wasm (binding_typescript_wasm) (push) Waiting to run
Details
CI / List crates (push) Waiting to run
Details
CI / Test - ${{ matrix.settings.crate }} - ${{ matrix.settings.os }} (push) Blocked by required conditions
Details
CI / Test node bindings - ${{ matrix.os }} (macos-latest) (push) Waiting to run
Details
CI / Test node bindings - ${{ matrix.os }} (windows-latest) (push) Waiting to run
Details
CI / Test with @swc/cli (push) Waiting to run
Details
CI / Miri (better_scoped_tls) (push) Waiting to run
Details
CI / Miri (string_enum) (push) Waiting to run
Details
CI / Miri (swc) (push) Waiting to run
Details
CI / Miri (swc_bundler) (push) Waiting to run
Details
CI / Done (push) Blocked by required conditions
Details
Benchmark / Bench everything (push) Waiting to run
Details
Publish crates (auto) / Publish cargo crates (push) Waiting to run
Details

Browse Source 
**Description:**

As per PR #8955

> TsPropertySignature can not have params, type params, or an initializer.

This PR cleans up these fields from ts definition and visitor
This commit is contained in:
James Zhan 2024-10-24 18:35:35 +11:00 committed by GitHub
parent ba2a942f56
commit 715c42c0bf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/core/src/Visitor.ts
View File

@ -797,7 +797,6 @@ export class Visitor {
return n;
}
visitTsPropertySignature(n: TsPropertySignature): TsPropertySignature {
n.params = this.visitTsFnParameters(n.params);
n.typeAnnotation = this.visitTsTypeAnnotation(n.typeAnnotation);
return n;
}

4
packages/types/index.ts
View File

@ -2426,11 +2426,7 @@ export interface TsPropertySignature extends Node, HasSpan {
computed: boolean;
optional: boolean;
init?: Expression;
params: TsFnParameter[];
typeAnnotation?: TsTypeAnnotation;
typeParams?: TsTypeParameterDeclaration;
}
export interface TsGetterSignature extends Node, HasSpan {