swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-12-28 08:04:43 +03:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix(es/transform/optimization): Prevent inlining of vars used as RHS in logical expressions (#3907)

Browse Source
This commit is contained in:
William Tetlow 2022-03-07 20:18:48 +00:00 committed by GitHub
parent a64473dc34
commit 782a874696
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/swc_ecma_transforms_optimization/src/simplify/inlining/mod.rs
View File

@ -339,6 +339,15 @@ impl VisitMut for Inlining<'_> {
}
}
}
if let Expr::Bin(b) = node {
match b.op {
BinaryOp::LogicalAnd | BinaryOp::LogicalOr => {
self.visit_with_child(ScopeKind::Cond, &mut b.right);
}
_ => {}
}
}
}
fn visit_mut_fn_decl(&mut self, node: &mut FnDecl) {

10
crates/swc_ecma_transforms_optimization/tests/expr-simplifier/issue-3816/input.js Normal file
View File

@ -0,0 +1,10 @@
/** @license React v17.0.2
* react-jsx-runtime.profiling.min.js
*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
'use strict';require("object-assign");var f=require("react"),g=60103;exports.Fragment=60107;if("function"===typeof Symbol&&Symbol.for){var h=Symbol.for;g=h("react.element");exports.Fragment=h("react.fragment")}var m=f.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.ReactCurrentOwner,n=Object.prototype.hasOwnProperty,p={key:!0,ref:!0,__self:!0,__source:!0};
function q(c,a,k){var b,d={},e=null,l=null;void 0!==k&&(e=""+k);void 0!==a.key&&(e=""+a.key);void 0!==a.ref&&(l=a.ref);for(b in a)n.call(a,b)&&!p.hasOwnProperty(b)&&(d[b]=a[b]);if(c&&c.defaultProps)for(b in a=c.defaultProps,a)void 0===d[b]&&(d[b]=a[b]);return{$$typeof:g,type:c,key:e,ref:l,props:d,_owner:m.current}}exports.jsx=q;exports.jsxs=q;

33
crates/swc_ecma_transforms_optimization/tests/expr-simplifier/issue-3816/output.js Normal file
View File

@ -0,0 +1,33 @@
"use strict";
require("object-assign");
var f = require("react"), g = 60103;
exports.Fragment = 60107;
if ("function" === typeof Symbol && Symbol.for) {
var h = Symbol.for;
g = h("react.element");
exports.Fragment = h("react.fragment");
}
var m = f.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.ReactCurrentOwner, n = Object.prototype.hasOwnProperty, p = {
key: !0,
ref: !0,
__self: !0,
__source: !0
};
function q(c, a, k) {
var b, d = {}, e = null, l = null;
void 0 !== k && (e = "" + k);
void 0 !== a.key && (e = "" + a.key);
void 0 !== a.ref && (l = a.ref);
for(b in a)n.call(a, b) && !p.hasOwnProperty(b) && (d[b] = a[b]);
if (c && c.defaultProps) for(b in a = c.defaultProps, a)void 0 === d[b] && (d[b] = a[b]);
return {
$$typeof: g,
type: c,
key: e,
ref: l,
props: d,
_owner: m.current
};
}
exports.jsx = q;
exports.jsxs = q;