swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-12-25 06:36:08 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(plugin/runner): Disable wasi env cleanup (#7607)

Browse Source 
**Description:**

Even after setting shared runtime for the wasi env, `cleanup` still panics. I suspect something internal to cleanup doesn't honor those handles correctly; for now, disable it and try to see if this works.

As commented, this is not a huge issue as the plugin usually doesn't have resources to be cleaned up anyway.
This commit is contained in:
OJ Kwon 2023-06-29 20:28:35 -07:00 committed by GitHub
parent efcad6a499
commit 8209594a8c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/swc_plugin_runner/src/transform_executor.rs
View File

@ -119,8 +119,13 @@ impl PluginTransformState {
guest_program_ptr.1,
)?;
// [TODO]: disabled for now as it always panic if it is being called
// inside of tokio runtime
// https://github.com/wasmerio/wasmer/discussions/3966
// [NOTE]: this is not a critical as plugin does not have things to clean up
// in most cases
if let Some(wasi_env) = &self.wasi_env {
wasi_env.cleanup(&mut self.store, None);
//wasi_env.cleanup(&mut self.store, None);
}
ret