swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-11-23 09:38:16 +03:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix(es/lints): Allow overload in typescript (#5116)

Browse Source
This commit is contained in:
Austaras 2022-07-06 00:33:58 +08:00 committed by GitHub
parent 5a5cfb7e86
commit bef8aebdea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
crates/swc_ecma_lints/src/rules/duplicate_bindings.rs
View File

@ -87,11 +87,16 @@ impl DuplicateBindings {
fn visit_with_stmt_like<T: StmtLike + VisitWith<Self>>(&mut self, s: &[T]) {
let mut fn_name = AHashMap::default();
for s in s {
if let Some(Stmt::Decl(Decl::Fn(s))) = s.as_stmt() {
if let Some(prev) = fn_name.get(&s.ident.sym) {
emit_error(&s.ident.sym, s.ident.span, *prev)
if let Some(Stmt::Decl(Decl::Fn(FnDecl {
ident,
function: Function { body: Some(_), .. },
..
}))) = s.as_stmt()
{
if let Some(prev) = fn_name.get(&ident.sym) {
emit_error(&ident.sym, ident.span, *prev)
} else {
fn_name.insert(s.ident.sym.clone(), s.ident.span);
fn_name.insert(ident.sym.clone(), ident.span);
}
}

11
crates/swc_ecma_lints/tests/pass/issue-5115/1/input.ts Normal file
View File

@ -0,0 +1,11 @@
function makeDate(timestamp: number): Date;
function makeDate(m: number, d: number, y: number): Date;
function makeDate(mOrTimestamp: number, d?: number, y?: number): Date {
if (d !== undefined && y !== undefined) {
return new Date(y, mOrTimestamp, d);
} else {
return new Date(mOrTimestamp);
}
}
export {}