mirror of
https://github.com/swc-project/swc.git
synced 2024-12-25 06:36:08 +03:00
fix(es/minifier): Add WeakRef as a safe global reference (#8458)
**Description:** I was trying to remove references to Weak Ref from minified code and despite the expression not being used, it was still included. E.g. ``` var x = WeakRef; ``` with ``` { "minify": true, "jsc": { "minify": { "compress": { "pure_getters": true, "unused": true }, "mangle": true } } } ``` outputs ``` WeakRef; ``` but when I use something on this list e.g. parseFloat, it gets cleaned up and outputs empty string. btw - I tried different options for pure_getters that I assumed would allow me to say WeakRef as a getter was pure, but it had no effect. WeakRef getter is as safe to remove as the other items on this list and has no effect in accessing it.
This commit is contained in:
parent
4229e7b99b
commit
d681785b42
@ -39,6 +39,7 @@ pub fn is_global_var_with_pure_property_access(s: &str) -> bool {
|
||||
| "NaN"
|
||||
| "Symbol"
|
||||
| "Promise"
|
||||
| "WeakRef"
|
||||
)
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user