swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-10-04 12:18:08 +03:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix(es/utils): Fix string evaluation of array literals (#7731)

Browse Source 
**Related issue:**

 - Closes #7714.
This commit is contained in:
Donny/강동윤 2023-07-31 12:31:37 +09:00 committed by GitHub
parent ffe99a9665
commit e8c58cfd77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/swc_ecma_minifier/tests/fixture/issues/7714/1/config.json Normal file
View File

@ -0,0 +1,4 @@
{
"defaults": true,
"evaluate": true
}

1
crates/swc_ecma_minifier/tests/fixture/issues/7714/1/input.js Normal file
View File

@ -0,0 +1 @@
console.log(`${[1, 1]}`)

1
crates/swc_ecma_minifier/tests/fixture/issues/7714/1/output.js Normal file
View File

@ -0,0 +1 @@
console.log("1,1");

9
crates/swc_ecma_utils/src/lib.rs
View File

@ -1032,10 +1032,11 @@ pub trait ExprExt {
Unknown => return Value::Unknown, Unknown => return Value::Unknown,
})), })),
Expr::Array(ArrayLit { ref elems, .. }) => { Expr::Array(ArrayLit { ref elems, .. }) => {
let mut first = true;
let mut buf = String::new(); let mut buf = String::new();
let len = elems.len();
// null, undefined is "" in array literal. // null, undefined is "" in array literal.
for elem in elems { for (idx, elem) in elems.iter().enumerate() {
let last = idx == len - 1;
let e = match *elem { let e = match *elem {
Some(ref elem) => { Some(ref elem) => {
let ExprOrSpread { ref expr, .. } = *elem; let ExprOrSpread { ref expr, .. } = *elem;
@ -1055,9 +1056,7 @@ pub trait ExprExt {
}; };
buf.push_str(&e); buf.push_str(&e);
if first { if !last {
first = false;
} else {
buf.push(','); buf.push(',');
} }
} }