fix(es/typescript): Correctly handle ESM context (#9490)

**Related issue:**

- https://github.com/nodejs/node/issues/54514

.changeset/nasty-trees-cheer.md

@@ -0,0 +1,6 @@
+---
+swc_ecma_transforms_typescript: patch
+swc_core: patch
+---
+
+fix(es/typescript): Correctly handle ESM context

crates/swc/tests/tsc-references/amdImportNotAsPrimaryExpression.1.normal.js

@@ -37,13 +37,9 @@ define([
 });
 //// [foo_1.ts]
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     var i;
     var x = {};
     var y = false;

crates/swc/tests/tsc-references/amdImportNotAsPrimaryExpression.2.minified.js

@@ -26,10 +26,5 @@ define([
 });
 //// [foo_1.ts]
 define([
-    "require",
-    "exports"
-], function(require, exports) {
-    Object.defineProperty(exports, "__esModule", {
-        value: !0
-    });
-});
+    "require"
+], function(require) {});

crates/swc/tests/tsc-references/cjsImportInES2015.1.normal.js

@@ -9,4 +9,3 @@
 //!    `----
 //// [/project/index.ts]
 function handleError(err) {}
-export { };

crates/swc/tests/tsc-references/cjsImportInES2015.2.minified.js

@@ -8,4 +8,3 @@
 //!  3 | 
 //!    `----
 //// [/project/index.ts]
-export { };

crates/swc/tests/tsc-references/classAbstractImportInstantiation.1.normal.js

@@ -11,4 +11,3 @@ var M;
 })(M || (M = {}));
 var myA = M.A;
 new myA;
-export { };

crates/swc/tests/tsc-references/commonJSImportNotAsPrimaryExpression.1.normal.js

@@ -32,9 +32,6 @@ var E1;
 })(E1 || (E1 = {}));
 //// [foo_1.ts]
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 var i;
 var x = {};
 var y = false;

crates/swc/tests/tsc-references/commonJSImportNotAsPrimaryExpression.2.minified.js

@@ -19,6 +19,3 @@ var E1, E11, _class_call_check = require("@swc/helpers/_/_class_call_check"), C1
 };
 C1.s1 = !0, (E1 = E11 || (E11 = {}))[E1.A = 0] = "A", E1[E1.B = 1] = "B", E1[E1.C = 2] = "C";
 //// [foo_1.ts]
-Object.defineProperty(exports, "__esModule", {
-    value: !0
-});

crates/swc/tests/tsc-references/exportAssignmentMergedInterface.1.normal.js

@@ -7,13 +7,9 @@ define([
 });
 //// [foo_1.ts]
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     var x;
     x("test");
     x(42);

crates/swc/tests/tsc-references/exportAssignmentMergedInterface.2.minified.js

@@ -6,11 +6,8 @@ define([
 });
 //// [foo_1.ts]
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     var x;
-    Object.defineProperty(exports, "__esModule", {
-        value: !0
-    }), x("test"), x(42), x.b, x.c, x.d;
+    x("test"), x(42), x.b, x.c, x.d;
 });

crates/swc/tests/tsc-references/importAliasIdentifiers.1.normal.js

@@ -41,4 +41,3 @@ function fundule() {
 var p;
 var p;
 var p;
-export { };

crates/swc/tests/tsc-references/importImportOnlyModule.1.normal.js

@@ -23,13 +23,9 @@ define([
 });
 //// [foo_1.ts]
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     var answer = 42; // No exports
 });
 //// [foo_2.ts]

crates/swc/tests/tsc-references/importImportOnlyModule.2.minified.js

@@ -19,13 +19,8 @@ define([
 });
 //// [foo_1.ts]
 define([
-    "require",
-    "exports"
-], function(require, exports) {
-    Object.defineProperty(exports, "__esModule", {
-        value: !0
-    });
-});
+    "require"
+], function(require) {});
 //// [foo_2.ts]
 define([
     "require",

crates/swc/tests/tsc-references/importsNotUsedAsValues_error.1.normal.js

@@ -54,9 +54,8 @@ export { };
 //// [/i.ts]
 var h = {};
 console.log(h);
-export { }; // Error
 //// [/j.ts]
-export { }; // noUnusedLocals error only
+ // noUnusedLocals error only
 //// [/k.ts]
 //!   x Export assignment cannot be used when targeting ECMAScript modules. Consider using `export default` or another module format instead.
 //!    ,-[2:1]

crates/swc/tests/tsc-references/importsNotUsedAsValues_error.2.minified.js

@@ -38,9 +38,7 @@ export { };
 //!    `----
 //// [/i.ts]
 console.log({});
-export { };
 //// [/j.ts]
-export { };
 //// [/k.ts]
 //!   x Export assignment cannot be used when targeting ECMAScript modules. Consider using `export default` or another module format instead.
 //!    ,-[2:1]

crates/swc/tests/tsc-references/invalidImportAliasIdentifiers.1.normal.js

@@ -11,4 +11,3 @@ var E;
     E[E["Red"] = 0] = "Red";
     E[E["Blue"] = 1] = "Blue";
 })(E || (E = {}));
-export { };

crates/swc/tests/tsc-references/moduleResolutionWithoutExtension2.1.normal.js

@@ -1,4 +1,4 @@
 //// [moduleResolutionWithoutExtension2.ts]
 //// [/src/buzz.mts]
 // Extensionless relative path cjs import in an ES module
-export { }; // should error, should not ask for extension
+ // should error, should not ask for extension

crates/swc/tests/tsc-references/moduleResolutionWithoutExtension2.2.minified.js

@@ -1,3 +1,2 @@
 //// [moduleResolutionWithoutExtension2.ts]
 //// [/src/buzz.mts]
-export { };

crates/swc/tests/tsc-references/moduleResolutionWithoutExtension7.1.normal.js

@@ -1,4 +1,4 @@
 //// [moduleResolutionWithoutExtension7.ts]
 //// [/src/bar.cts]
 // Extensionless relative path cjs import in a cjs module
-export { }; // should error, should not ask for extension
+ // should error, should not ask for extension

crates/swc/tests/tsc-references/moduleResolutionWithoutExtension7.2.minified.js

@@ -1,3 +1,2 @@
 //// [moduleResolutionWithoutExtension7.ts]
 //// [/src/bar.cts]
-export { };

crates/swc/tests/tsc-references/parserImportDeclaration1.1.normal.js

@@ -1,2 +1 @@
 //// [parserImportDeclaration1.ts]
-export { };

crates/swc/tests/tsc-references/parserImportDeclaration1.2.minified.js

@@ -1,2 +1 @@
 //// [parserImportDeclaration1.ts]
-export { };

crates/swc/tests/tsc-references/scannerImportDeclaration1.1.normal.js

@@ -1,2 +1 @@
 //// [scannerImportDeclaration1.ts]
-export { };

crates/swc/tests/tsc-references/scannerImportDeclaration1.2.minified.js

@@ -1,2 +1 @@
 //// [scannerImportDeclaration1.ts]
-export { };

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/1/output.amd.ts

@@ -1,12 +1,8 @@
 ///<amd-module name='NamedModule'/>
 define("NamedModule", [
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/1/output.cts

@@ -1,8 +1,5 @@
 ///<amd-module name='NamedModule'/>
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 class Foo {
     x;
     constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/1/output.umd.ts

@@ -1,15 +1,10 @@
 ///<amd-module name='NamedModule'/>
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/2/output.amd.ts

@@ -1,13 +1,9 @@
 ///<amd-module name='FirstModuleName'/>
 ///<amd-module name='SecondModuleName'/>
 define("SecondModuleName", [
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/2/output.cts

@@ -1,9 +1,6 @@
 ///<amd-module name='FirstModuleName'/>
 ///<amd-module name='SecondModuleName'/>
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 class Foo {
     x;
     constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/2/output.umd.ts

@@ -1,16 +1,11 @@
 ///<amd-module name='FirstModuleName'/>
 ///<amd-module name='SecondModuleName'/>
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/3/output.amd.ts

@@ -1,12 +1,8 @@
 ///<AmD-moDulE nAme='NamedModule'/>
 define("NamedModule", [
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/3/output.cts

@@ -1,8 +1,5 @@
 ///<AmD-moDulE nAme='NamedModule'/>
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 class Foo {
     x;
     constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/3/output.umd.ts

@@ -1,15 +1,10 @@
 ///<AmD-moDulE nAme='NamedModule'/>
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/4/output.amd.ts

@@ -1,11 +1,7 @@
 /*/<amd-module name='should-ignore'/> */ define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/4/output.cts

@@ -1,7 +1,4 @@
 /*/<amd-module name='should-ignore'/> */ "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 class Foo {
     x;
     constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/amd-triple-slash-directive/4/output.umd.ts

@@ -1,14 +1,9 @@
 /*/<amd-module name='should-ignore'/> */ (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     class Foo {
         x;
         constructor(){

crates/swc_ecma_transforms_module/tests/fixture/common/cts-import-export/export-assign/output.amd.ts

@@ -1,11 +1,7 @@
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     const foo = require("foo");
     module.exports = foo;
 });

crates/swc_ecma_transforms_module/tests/fixture/common/cts-import-export/export-assign/output.cts

@@ -1,6 +1,3 @@
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 const foo = require("foo");
 module.exports = foo;

crates/swc_ecma_transforms_module/tests/fixture/common/cts-import-export/export-assign/output.umd.ts

@@ -1,14 +1,9 @@
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     const foo = require("foo");
     module.exports = foo;
 });

crates/swc_ecma_transforms_module/tests/fixture/common/cts-import-export/export-import/output.amd.ts

@@ -1,10 +1,6 @@
 define([
-    "require",
-    "exports"
-], function(require, exports1) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports1, "__esModule", {
-        value: true
-    });
     const foo = exports.foo = require("foo");
 });

crates/swc_ecma_transforms_module/tests/fixture/common/cts-import-export/export-import/output.cts

@@ -1,5 +1,2 @@
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 const foo = exports.foo = require("foo");

crates/swc_ecma_transforms_module/tests/fixture/common/cts-import-export/export-import/output.umd.ts

@@ -1,13 +1,8 @@
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports1) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports1, "__esModule", {
-        value: true
-    });
     const foo = exports.foo = require("foo");
 });

crates/swc_ecma_transforms_module/tests/fixture/common/issue-1686/output.amd.ts

@@ -1,11 +1,7 @@
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     console.log(1);
 });
  // print b

crates/swc_ecma_transforms_module/tests/fixture/common/issue-1686/output.cts

@@ -1,6 +1,3 @@
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 console.log(1);
  // print b

crates/swc_ecma_transforms_module/tests/fixture/common/issue-1686/output.umd.ts

@@ -1,14 +1,9 @@
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     console.log(1);
 });
  // print b

crates/swc_ecma_transforms_module/tests/fixture/common/issue-4898/1/output.amd.ts

@@ -1,11 +1,7 @@
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     const assert = require("assert");
     assert(true);
 });

crates/swc_ecma_transforms_module/tests/fixture/common/issue-4898/1/output.cts

@@ -1,6 +1,3 @@
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 const assert = require("assert");
 assert(true);

crates/swc_ecma_transforms_module/tests/fixture/common/issue-4898/1/output.umd.ts

@@ -1,14 +1,9 @@
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     const assert = require("assert");
     assert(true);
 });

crates/swc_ecma_transforms_module/tests/fixture/common/issue-5042/2/output.amd.ts

@@ -1,11 +1,7 @@
 define([
-    "require",
-    "exports"
-], function(require, exports) {
+    "require"
+], function(require) {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     const foo = require("foo");
     foo.bar = 1;
     foo.bar = 2;

crates/swc_ecma_transforms_module/tests/fixture/common/issue-5042/2/output.cts

@@ -1,7 +1,4 @@
 "use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
 const foo = require("foo");
 foo.bar = 1;
 foo.bar = 2;

crates/swc_ecma_transforms_module/tests/fixture/common/issue-5042/2/output.umd.ts

@@ -1,14 +1,9 @@
 (function(global, factory) {
-    if (typeof module === "object" && typeof module.exports === "object") factory(exports);
-    else if (typeof define === "function" && define.amd) define([
-        "exports"
-    ], factory);
-    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory(global.input = {});
-})(this, function(exports) {
+    if (typeof module === "object" && typeof module.exports === "object") factory();
+    else if (typeof define === "function" && define.amd) define([], factory);
+    else if (global = typeof globalThis !== "undefined" ? globalThis : global || self) factory();
+})(this, function() {
     "use strict";
-    Object.defineProperty(exports, "__esModule", {
-        value: true
-    });
     const foo = require("foo");
     foo.bar = 1;
     foo.bar = 2;

crates/swc_ecma_transforms_typescript/src/typescript.rs

@@ -90,12 +90,12 @@ impl TypeScript {
         n.body
             .iter()
             .rev()
-            .find(|m| m.is_module_decl())
+            .find(|m| m.is_es_module_decl())
             .map(Spanned::span)
     }
 
     fn restore_esm_ctx(n: &mut Module, span: Span) {
-        if n.body.iter().any(ModuleItem::is_module_decl) {
+        if n.body.iter().any(ModuleItem::is_es_module_decl) {
             return;
         }
 
@@ -109,6 +109,36 @@ impl TypeScript {
     }
 }
 
+trait EsModuleDecl {
+    fn is_es_module_decl(&self) -> bool;
+}
+
+impl EsModuleDecl for ModuleDecl {
+    fn is_es_module_decl(&self) -> bool {
+        // Do not use `matches!`
+        // We should cover all cases explicitly.
+        match self {
+            ModuleDecl::Import(..)
+            | ModuleDecl::ExportDecl(..)
+            | ModuleDecl::ExportNamed(..)
+            | ModuleDecl::ExportDefaultDecl(..)
+            | ModuleDecl::ExportDefaultExpr(..)
+            | ModuleDecl::ExportAll(..) => true,
+
+            ModuleDecl::TsImportEquals(..)
+            | ModuleDecl::TsExportAssignment(..)
+            | ModuleDecl::TsNamespaceExport(..) => false,
+        }
+    }
+}
+
+impl EsModuleDecl for ModuleItem {
+    fn is_es_module_decl(&self) -> bool {
+        self.as_module_decl()
+            .map_or(false, ModuleDecl::is_es_module_decl)
+    }
+}
+
 pub fn tsx<C>(
     cm: Lrc<SourceMap>,
     config: Config,