swc-project/swc
1
1
Fork 0
mirror of https://github.com/swc-project/swc.git synced 2024-12-25 22:56:11 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
122d14c0d3
swc/crates
History
Lewis Liu 122d14c0d3
fix(es/codegen): Fix placing of comments of yield arguments (#7858) 
**Description:**

Looks like the bug I ran into had nothing to do with the changes in
#7856, since it's reproducible without it. Looks like it might have only
surfaced now because https://github.com/swc-project/swc/pull/7853
changed the default value of `jsc.minify.format.comments`? Added a
minimal test case here with the expected result.

Here's the actual output:

```js
 export var padding = '';
 export function exec2({ commands }) {
     return __awaiter(this, void 0, void 0, function*() {
         for(let i2 = 0; i2 < commands.length; i2++){
             let command = commands[i2];
             yield // some-comment
             function({ command }) {
                 command();
             }({
                 command,
                 handleError
             });
         }
     });
 }
```

The comment ends up getting added after the yield, which makes the
output invalid.

Going to see if I can figure out a fix tomorrow, but let me know if you
have any ideas on where to start looking in the meantime!
2023-08-27 23:36:50 +00:00
..
ast_node chore: Publish crates 2023-06-21 15:44:11 +00:00
better_scoped_tls chore: Publish crates 2023-06-22 13:40:52 +00:00
binding_macros chore: Publish crates 2023-08-27 18:25:51 +00:00
dbg-swc chore: Publish crates 2023-08-27 18:25:51 +00:00
from_variant chore: Publish crates 2023-06-21 15:44:11 +00:00
jsdoc chore: Publish crates 2023-08-27 18:25:51 +00:00
preset_env_base chore: Publish crates 2023-06-22 13:40:52 +00:00
string_enum chore: Publish crates 2023-06-21 15:44:11 +00:00
swc fix(es/codegen): Fix placing of comments of yield arguments (#7858) 2023-08-27 23:36:50 +00:00
swc_atoms chore: Publish crates 2023-08-24 08:20:56 +00:00
swc_bundler chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_cached chore: Publish crates 2023-06-22 13:40:52 +00:00
swc_common chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_config chore: Publish crates 2023-06-22 13:40:52 +00:00
swc_config_macro chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_core chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_css chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_ast chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_codegen chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_codegen_macros chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_css_compat chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_lints chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_minifier chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_modules chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_parser chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_prefixer chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_utils chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_css_visit chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_ecma_ast chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_ecma_codegen fix(es/codegen): Fix placing of comments of yield arguments (#7858) 2023-08-27 23:36:50 +00:00
swc_ecma_codegen_macros chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_ecma_dep_graph chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_ext_transforms chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_lints chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_loader chore: Publish crates 2023-08-25 13:48:47 +00:00
swc_ecma_minifier chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_parser chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_preset_env chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_quote chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_quote_macros chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_testing chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_ecma_transforms chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_base chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_classes chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_compat chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_macros chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_ecma_transforms_module chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_optimization chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_proposal chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_react chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_testing chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_transforms_typescript chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_usage_analyzer chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_utils chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_ecma_visit chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_ecmascript chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_eq_ignore_macros chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_error_reporters chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_estree_ast chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_estree_compat chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_fast_graph chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_graph_analyzer chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_html chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_html_ast chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_html_codegen chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_html_codegen_macros chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_html_minifier chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_html_parser chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_html_utils chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_html_visit chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_macros_common chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_node_base chore: Publish crates 2022-10-24 03:58:37 +00:00
swc_node_bundler chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_node_comments chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_nodejs_common chore: Publish crates 2023-06-22 13:40:52 +00:00
swc_plugin build(cargo): Update deps (#7564) 2023-06-22 07:40:41 +00:00
swc_plugin_macro chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_plugin_proxy chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_plugin_runner chore: Publish crates 2023-08-27 18:25:51 +00:00
swc_plugin_testing
swc_timer chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_trace_macro chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_visit chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_visit_macros build(cargo): Update rustc to 2023-07-03 (#7623) 2023-07-05 03:50:43 +00:00
swc_xml chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_xml_ast chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_xml_codegen chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_xml_codegen_macros chore: Publish crates 2023-06-21 15:44:11 +00:00
swc_xml_parser chore: Publish crates 2023-08-24 12:58:41 +00:00
swc_xml_visit chore: Publish crates 2023-08-24 12:58:41 +00:00
testing chore: Publish crates 2023-08-24 12:58:41 +00:00
testing_macros chore: Publish crates 2023-06-22 07:43:38 +00:00