tauri-apps/tauri
1
1
Fork 0
mirror of https://github.com/tauri-apps/tauri.git synced 2024-12-26 04:03:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(api.js): fix http.fetch throwing error if response body is empty, closes #2831 (#3008)

Browse Source 
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
This commit is contained in:
Amr Bashir 2021-12-09 04:39:42 +02:00 committed by GitHub
parent c664e9dbe0
commit 50c63900c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/api-fetch-empty-reponse.md Normal file
View File

@ -0,0 +1,5 @@
---
"api": patch
---
Fix `http.fetch` throwing error if the response is successful but the body is empty.

2
core/tauri/scripts/bundle.js
View File

File diff suppressed because one or more lines are too long

5
tooling/api/src/http.ts
View File

@ -203,7 +203,10 @@ class Client {
// @ts-expect-error // @ts-expect-error
response.data = JSON.parse(response.data as string) response.data = JSON.parse(response.data as string)
} catch (e) { } catch (e) {
if (response.ok) { if (response.ok && (response.data as unknown as string) === '') {
// @ts-expect-error
response.data = {}
} else if (response.ok) {
throw Error( throw Error(
`Failed to parse response \`${response.data}\` as JSON: ${e}; `Failed to parse response \`${response.data}\` as JSON: ${e};
try setting the \`responseType\` option to \`ResponseType.Text\` or \`ResponseType.Binary\` if the API does not return a JSON response.` try setting the \`responseType\` option to \`ResponseType.Text\` or \`ResponseType.Binary\` if the API does not return a JSON response.`