tauri-apps/tauri
1
1
Fork 0
mirror of https://github.com/tauri-apps/tauri.git synced 2024-12-18 08:02:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(nsis): properly handle Webview2 download return value (#11139)

Browse Source 
port of #11131 to 2.x
This commit is contained in:
Amr Bashir 2024-09-26 04:53:05 +03:00 committed by GitHub
parent 5621174b05
commit 544328d5a3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/bundler-nsis-webview2-success.md Normal file
View File

@ -0,0 +1,5 @@
---
"tauri-bundler": "patch:bug"
---
Fix NSIS installer failing to determine whether webview installer downloaded correctly or not.

2
crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi
View File

@ -541,7 +541,7 @@ Section WebView2
DetailPrint "$(webview2Downloading)" DetailPrint "$(webview2Downloading)"
NSISdl::download "https://go.microsoft.com/fwlink/p/?LinkId=2124703" "$TEMP\MicrosoftEdgeWebview2Setup.exe" NSISdl::download "https://go.microsoft.com/fwlink/p/?LinkId=2124703" "$TEMP\MicrosoftEdgeWebview2Setup.exe"
Pop $0 Pop $0
${If} $0 = 0 ${If} $0 == "success"
DetailPrint "$(webview2DownloadSuccess)" DetailPrint "$(webview2DownloadSuccess)"
${Else} ${Else}
DetailPrint "$(webview2DownloadError)" DetailPrint "$(webview2DownloadError)"