tauri-apps/tauri
1
1
Fork 0
mirror of https://github.com/tauri-apps/tauri.git synced 2024-11-24 12:14:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat(core): add app-region: drag to data-tauri-drag-region (#9789)" (#9860)

Browse Source 
* Revert "feat(core): add `app-region: drag` to `data-tauri-drag-region` (#9789)"

This reverts commit ae6b13dfc0.

* Update pre.json

* change files

* Discard changes to .changes/pre.json
This commit is contained in:
Amr Bashir 2024-05-29 18:20:05 +03:00 committed by GitHub
parent 5e8aa6f946
commit dfd05441c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.changes/revert-app-region-drag.md Normal file
View File

@ -0,0 +1,7 @@
---
"tauri": patch:bug
---
Revert adding `app-region: drag` to HTML elements with `data-tauri-drag-region` on Windows as it has a few issues:
- Doesn't allow right click, as it will always show the system context menu on right click.
- `data-tauri-drag-region` works only if the click was on an element that has it, this allows buttons in the custom titlebar to work, however `app-region: drag` will treat the whole area as a titlebar won't even allow clicks on buttons.

5
core/tauri/src/window/scripts/drag.js
View File

@ -63,9 +63,4 @@
}
})
}
if (osName === 'windows' && 'adoptedStyleSheets' in document) {
const sheet = new CSSStyleSheet()
sheet.replaceSync('*[data-tauri-drag-region] { app-region: drag; }')
document.adoptedStyleSheets = [...document.adoptedStyleSheets, sheet]
}
})()