From faf282ca6ccf76c706db46f85aa207018dcf1ced Mon Sep 17 00:00:00 2001 From: Tony <68118705+Legend-Master@users.noreply.github.com> Date: Mon, 24 Jun 2024 15:48:02 +0800 Subject: [PATCH] fix(nsis): use runtime `${If}` check to clean up deep link on uninstall (#10103) --- .changes/nsis-deep-link-uninstall.md | 5 +++++ tooling/bundler/src/bundle/windows/templates/installer.nsi | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changes/nsis-deep-link-uninstall.md diff --git a/.changes/nsis-deep-link-uninstall.md b/.changes/nsis-deep-link-uninstall.md new file mode 100644 index 000000000..f58017567 --- /dev/null +++ b/.changes/nsis-deep-link-uninstall.md @@ -0,0 +1,5 @@ +--- +"tauri-bundler": "patch:bug" +--- + +Fix NSIS uninstaller failing to clean up deep links diff --git a/tooling/bundler/src/bundle/windows/templates/installer.nsi b/tooling/bundler/src/bundle/windows/templates/installer.nsi index 6c3b84fc5..034d14b67 100644 --- a/tooling/bundler/src/bundle/windows/templates/installer.nsi +++ b/tooling/bundler/src/bundle/windows/templates/installer.nsi @@ -679,9 +679,9 @@ Section Uninstall ; Delete deep links {{#each deep_link_protocols as |protocol| ~}} ReadRegStr $R7 SHCTX "Software\Classes\\{{protocol}}\shell\open\command" "" - !if $R7 == "$\"$INSTDIR\${MAINBINARYNAME}.exe$\" $\"%1$\"" + ${If} $R7 == "$\"$INSTDIR\${MAINBINARYNAME}.exe$\" $\"%1$\"" DeleteRegKey SHCTX "Software\Classes\\{{protocol}}" - !endif + ${EndIf} {{/each}}