on master help sign in
Improvements to `toTitle` functionality

Function now correctly deals with apostrophes, etc. For example, the “s” in “it’s”, should not be transformed to upper.

commit0bae88d47cb31959ba08f05e00752425a641acb8 authoral_skipp <al_skipp@fastmail.fm> dateFri 2 Dec 2016, 23:07 (10 years ago) parent4b1fc4c
1 file changed+10−9
Data/Text/Internal/Fusion/Common.hs+10−9
Data/Text/Internal/Fusion/Common.hs+10−9
@@ -107,7 +107,7 @@ import Prelude (Bool(..), Char, Eq(..), Int, Integral, Maybe(..),
107107import qualified Data.List as L
108108import qualified Prelude as P
109109import Data.Bits (shiftL)
110−import Data.Char (isLetter)
110+import Data.Char (isLetter, isSpace)
111111import Data.Int (Int64)
112112import Data.Text.Internal.Fusion.Types
113113import Data.Text.Internal.Fusion.CaseMapping (foldMapping, lowerMapping, titleMapping,
@@ -462,15 +462,16 @@ toTitle (Stream next0 s0 len) = Stream next (CC (False :*: s0) '\0' '\0') len
462462 where
463463 next (CC (letter :*: s) '\0' _) =
464464 case next0 s of
465− Done -> Done
466− Skip s' -> Skip (CC (letter :*: s') '\0' '\0')
465+ Done -> Done
466+ Skip s' -> Skip (CC (letter :*: s') '\0' '\0')
467467 Yield c s'
468− | letter' -> if letter
469− then lowerMapping c (letter' :*: s')
470− else titleMapping c (letter' :*: s')
471− | otherwise -> Yield c (CC (letter' :*: s') '\0' '\0')
472− where letter' = isLetter c
473− next (CC s a b) = Yield a (CC s b '\0')
468+ | nonSpace -> if letter
469+ then lowerMapping c (nonSpace :*: s')
470+ else titleMapping c (letter' :*: s')
471+ | otherwise -> Yield c (CC (letter' :*: s') '\0' '\0')
472+ where nonSpace = P.not (isSpace c)
473+ letter' = isLetter c
474+ next (CC s a b) = Yield a (CC s b '\0')
474475{-# INLINE [0] toTitle #-}
475476
476477data Justify i s = Just1 !i !s