git.iko.soy/text
on master help sign in
Text.Array: Use unsafeFreezeByteArray# in place of unsafeCoerce#

It shouldn't hurt to use the type-safe variant here. Moreover, this unsafeCoerce# usage was responsible for STG lint errors (GHC Trac #8114).

commit543ca59a4e73180c8b0fd4c24313cdea080a81df authorBen Gamari <ben@smart-cactus.org> dateSat 16 Jan 2016, 22:28 (11 years ago) parentb81b294
1 file changed+4−3
compare with master
unifiedsplit
Data/Text/Array.hs+4−3
Data/Text/Array.hs+4−3
@@ -74,7 +74,7 @@ import Foreign.C.Types (CInt, CSize)
7474#endif
7575import GHC.Base (ByteArray#, MutableByteArray#, Int(..),
7676 indexWord16Array#, newByteArray#,
77− unsafeCoerce#, writeWord16Array#)
77+ unsafeFreezeByteArray#, writeWord16Array#)
7878import GHC.ST (ST(..), runST)
7979import GHC.Word (Word16(..))
8080import Prelude hiding (length, read)
@@ -130,8 +130,9 @@ array_size_error = error "Data.Text.Array.new: size overflow"
130130
131131-- | Freeze a mutable array. Do not mutate the 'MArray' afterwards!
132132unsafeFreeze :: MArray s -> ST s Array
133−unsafeFreeze MArray{..} = ST $ \s# ->
134− (# s#, Array (unsafeCoerce# maBA)
133+unsafeFreeze MArray{..} = ST $ \s1# ->
134+ case unsafeFreezeByteArray# maBA s1# of
135+ (# s2#, ba# #) -> (# s2#, Array ba#
135136#if defined(ASSERTS)
136137 maLen
137138#endif