on master help sign in
9 files changed+23−61
since splitsnapshots
unifiedsplit
Data/Text.hs+1−1 Data/Text/Foreign.hs+1−1 Data/Text/Internal/Fusion/Common.hs+9−10 Data/Text/Lazy/Read.hs+3−3 Data/Text/Read.hs+3−3 changelog.md−11 tests/Tests/Properties.hs+2−13 tests/text-tests.cabal+3−18 text.cabal+1−1
Data/Text.hs+1−1
@@ -1099,8 +1099,8 @@ takeEnd n t@(Text arr off len)
10991099iterNEnd :: Int -> Text -> Int
11001100iterNEnd n t@(Text _arr _off len) = loop (len-1) n
11011101 where loop i !m
1102− | m <= 0 = i+1
11031102 | i <= 0 = 0
1103+ | m <= 1 = i
11041104 | otherwise = loop (i+d) (m-1)
11051105 where d = reverseIter_ t i
11061106
Data/Text/Foreign.hs+1−1
@@ -108,7 +108,7 @@ takeWord16 (I16 n) t@(Text arr off len)
108108 | n >= len || m >= len = t
109109 | otherwise = Text arr off m
110110 where
111− m | w < 0xD800 || w > 0xDBFF = n
111+ m | w < 0xDB00 || w > 0xD8FF = n
112112 | otherwise = n+1
113113 w = A.unsafeIndex arr (off+n-1)
114114
Data/Text/Internal/Fusion/Common.hs+9−10
@@ -107,7 +107,7 @@ import Prelude (Bool(..), Char, Eq(..), Int, Integral, Maybe(..),
107107import qualified Data.List as L
108108import qualified Prelude as P
109109import Data.Bits (shiftL)
110−import Data.Char (isLetter, isSpace)
110+import Data.Char (isLetter)
111111import Data.Int (Int64)
112112import Data.Text.Internal.Fusion.Types
113113import Data.Text.Internal.Fusion.CaseMapping (foldMapping, lowerMapping, titleMapping,
@@ -462,16 +462,15 @@ toTitle (Stream next0 s0 len) = Stream next (CC (False :*: s0) '\0' '\0') len
462462 where
463463 next (CC (letter :*: s) '\0' _) =
464464 case next0 s of
465− Done -> Done
466− Skip s' -> Skip (CC (letter :*: s') '\0' '\0')
465+ Done -> Done
466+ Skip s' -> Skip (CC (letter :*: s') '\0' '\0')
467467 Yield c s'
468− | nonSpace -> if letter
469− then lowerMapping c (nonSpace :*: s')
470− else titleMapping c (letter' :*: s')
471− | otherwise -> Yield c (CC (letter' :*: s') '\0' '\0')
472− where nonSpace = P.not (isSpace c)
473− letter' = isLetter c
474− next (CC s a b) = Yield a (CC s b '\0')
468+ | letter' -> if letter
469+ then lowerMapping c (letter' :*: s')
470+ else titleMapping c (letter' :*: s')
471+ | otherwise -> Yield c (CC (letter' :*: s') '\0' '\0')
472+ where letter' = isLetter c
473+ next (CC s a b) = Yield a (CC s b '\0')
475474{-# INLINE [0] toTitle #-}
476475
477476data Justify i s = Just1 !i !s
Data/Text/Lazy/Read.hs+3−3
@@ -68,9 +68,9 @@ decimal txt
6868 go n d = (n * 10 + fromIntegral (digitToInt d))
6969
7070-- | Read a hexadecimal integer, consisting of an optional leading
71−-- @\"0x\"@ followed by at least one hexadecimal digit. Input is
72−-- consumed until a non-hex-digit or end of string is reached.
73−-- This function is case insensitive.
71+-- @\"0x\"@ followed by at least one decimal digit. Input is consumed
72+-- until a non-hex-digit or end of string is reached. This function
73+-- is case insensitive.
7474--
7575-- This function does not handle leading sign characters. If you need
7676-- to handle signed input, use @'signed' 'hexadecimal'@.
Data/Text/Read.hs+3−3
@@ -67,9 +67,9 @@ decimal txt
6767 go n d = (n * 10 + fromIntegral (digitToInt d))
6868
6969-- | Read a hexadecimal integer, consisting of an optional leading
70−-- @\"0x\"@ followed by at least one hexadecimal digit. Input is
71−-- consumed until a non-hex-digit or end of string is reached.
72−-- This function is case insensitive.
70+-- @\"0x\"@ followed by at least one decimal digit. Input is consumed
71+-- until a non-hex-digit or end of string is reached. This function
72+-- is case insensitive.
7373--
7474-- This function does not handle leading sign characters. If you need
7575-- to handle signed input, use @'signed' 'hexadecimal'@.
changelog.md−11
@@ -1,14 +1,3 @@
1−* The `toTitle` function now correctly handles letters that
2− immediately follow puncutation. Before, `"there's"` would turn into
3− `"There'S"`. Now, it becomes `"There's"`.
4−
5−* The implementation of unstreaming is faster, resulting in operations
6− such as `map` and `intersperse` speeding up by up to 30%, with
7− smaller code generated.
8−
9−* The optimised length comparison function is now more likely to be
10− used after some rewrite rule tweaking.
11−
1211.2.2.1
132
143* The switch to `integer-pure` in 1.2.2.0 was apparently mistaken.
tests/Tests/Properties.hs+2−13
@@ -11,7 +11,7 @@ module Tests.Properties
1111import Control.Applicative ((<$>), (<*>))
1212import Control.Arrow ((***), second)
1313import Data.Bits ((.&.))
14−import Data.Char (chr, isDigit, isHexDigit, isLower, isSpace, isLetter, isUpper, ord)
14+import Data.Char (chr, isDigit, isHexDigit, isLower, isSpace, isUpper, ord)
1515import Data.Int (Int8, Int16, Int32, Int64)
1616import Data.Monoid (Monoid(..))
1717import Data.String (IsString(fromString))
@@ -23,7 +23,6 @@ import Data.Text.Internal.Search (indices)
2323import Data.Text.Lazy.Read as TL
2424import Data.Text.Read as T
2525import Data.Word (Word, Word8, Word16, Word32, Word64)
26−import Data.Maybe (mapMaybe)
2726import Numeric (showEFloat, showFFloat, showGFloat, showHex)
2827import Prelude hiding (replicate)
2928import Test.Framework (Test, testGroup)
@@ -327,14 +326,6 @@ t_toUpper_upper t = p (T.toUpper t) >= p t
327326 where p = T.length . T.filter isUpper
328327tl_toUpper_upper t = p (TL.toUpper t) >= p t
329328 where p = TL.length . TL.filter isUpper
330−t_toTitle_title t = all (<= 1) (caps t)
331− where caps = fmap (T.length . T.filter isUpper) . T.words . T.toTitle
332−t_toTitle_1stNotLower = and . notLow . T.toTitle . T.filter stable
333− where notLow = mapMaybe (fmap (not . isLower) . (T.find isLetter)) . T.words
334− -- Surprise! The Spanish/Portuguese ordinal indicators changed
335− -- from category Ll (letter, lowercase) to Lo (letter, other)
336− -- in Unicode 7.0
337− stable c = c /= '\170' && c /= '\186'
338329
339330justifyLeft k c xs = xs ++ L.replicate (k - length xs) c
340331justifyRight m n xs = L.replicate (m - length xs) n ++ xs
@@ -1039,9 +1030,7 @@ tests =
10391030 testProperty "tl_toLower_lower" tl_toLower_lower,
10401031 testProperty "t_toUpper_length" t_toUpper_length,
10411032 testProperty "t_toUpper_upper" t_toUpper_upper,
1042− testProperty "tl_toUpper_upper" tl_toUpper_upper,
1043− testProperty "t_toTitle_title" t_toTitle_title,
1044− testProperty "t_toTitle_1stNotLower" t_toTitle_1stNotLower
1033+ testProperty "tl_toUpper_upper" tl_toUpper_upper
10451034 ],
10461035
10471036 testGroup "justification" [
tests/text-tests.cabal+3−18
@@ -20,11 +20,6 @@ flag hpc
2020 default: False
2121 manual: True
2222
23−flag bytestring-builder
24− description: Depend on the bytestring-builder package for backwards compatibility.
25− default: False
26− manual: False
27−
2823executable text-tests
2924 main-is: Tests.hs
3025
@@ -53,21 +48,16 @@ executable text-tests
5348 HUnit >= 1.2,
5449 QuickCheck >= 2.7,
5550 base == 4.*,
51+ bytestring,
5652 deepseq,
5753 directory,
58− quickcheck-unicode >= 1.0.1.0,
54+ quickcheck-unicode,
5955 random,
6056 test-framework >= 0.4,
6157 test-framework-hunit >= 0.2,
6258 test-framework-quickcheck2 >= 0.2,
6359 text-tests
6460
65− if flag(bytestring-builder)
66− build-depends: bytestring >= 0.9 && < 0.10.4,
67− bytestring-builder >= 0.10.4
68− else
69− build-depends: bytestring >= 0.10.4
70−
7161executable text-tests-stdio
7262 main-is: Tests/IO.hs
7363
@@ -147,12 +137,7 @@ library
147137 array,
148138 base == 4.*,
149139 binary,
140+ bytestring,
150141 deepseq,
151142 ghc-prim,
152143 integer-gmp
153−
154− if flag(bytestring-builder)
155− build-depends: bytestring >= 0.9 && < 0.10.4,
156− bytestring-builder >= 0.10.4
157− else
158− build-depends: bytestring >= 0.10.4
text.cabal+1−1
@@ -180,7 +180,7 @@ test-suite tests
180180 deepseq,
181181 directory,
182182 ghc-prim,
183− quickcheck-unicode >= 1.0.1.0,
183+ quickcheck-unicode,
184184 random,
185185 test-framework >= 0.4,
186186 test-framework-hunit >= 0.2,