tfausak/witch
1
1
Fork 0
mirror of https://github.com/tfausak/witch.git synced 2024-11-22 14:58:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16 from tfausak/gh14-floating-point

Browse Source 
Use `float2Double` instead of `realToFrac`
This commit is contained in:
Taylor Fausak 2021-04-26 08:16:15 -04:00 committed by GitHub
commit 11fbbb9c23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/Witch/Instances.hs
View File

@ -29,6 +29,7 @@ import qualified Data.Text.Lazy as LazyText
import qualified Data.Text.Lazy.Encoding as LazyText import qualified Data.Text.Lazy.Encoding as LazyText
import qualified Data.Typeable as Typeable import qualified Data.Typeable as Typeable
import qualified Data.Word as Word import qualified Data.Word as Word
import qualified GHC.Float as Float
import qualified Numeric.Natural as Natural import qualified Numeric.Natural as Natural
import qualified Witch.Cast as Cast import qualified Witch.Cast as Cast
import qualified Witch.TryCast as TryCast import qualified Witch.TryCast as TryCast
@ -804,9 +805,9 @@ instance TryCast.TryCast Float Rational where
then if s > 0 then Left Exception.Overflow else Left Exception.Underflow then if s > 0 then Left Exception.Overflow else Left Exception.Underflow
else Right $ toRational s else Right $ toRational s
-- | Uses 'realToFrac'. -- | Uses 'Float.double2Float'.
instance Cast.Cast Float Double where instance Cast.Cast Float Double where
cast = realToFrac cast = Float.float2Double
-- Double -- Double
@ -872,9 +873,9 @@ instance TryCast.TryCast Double Rational where
then if s > 0 then Left Exception.Overflow else Left Exception.Underflow then if s > 0 then Left Exception.Overflow else Left Exception.Underflow
else Right $ toRational s else Right $ toRational s
-- | Uses 'realToFrac'. This necessarily loses some precision. -- | Uses 'Float.double2Float'. This necessarily loses some precision.
instance Cast.Cast Double Float where instance Cast.Cast Double Float where
cast = realToFrac cast = Float.double2Float
-- Ratio -- Ratio