toeverything/AFFiNE
1
1
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2024-12-23 14:42:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(electron): devtools open in detach mode (#8200)

Browse Source 
fix AF-1380
This commit is contained in:
pengx17 2024-09-12 03:20:19 +00:00
parent 8bf0458ef4
commit 24bf1beac8
No known key found for this signature in database
GPG Key ID: 23F23D9E8B3971ED
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/frontend/electron/src/main/windows-manager/main-window.ts
View File

@ -258,7 +258,9 @@ export async function openUrlInHiddenWindow(urlObj: URL) {
}); });
if (environment.isDebug) { if (environment.isDebug) {
win.webContents.openDevTools(); win.webContents.openDevTools({
mode: 'detach',
});
} }
win.on('close', e => { win.on('close', e => {

12
packages/frontend/electron/src/main/windows-manager/tab-views.ts
View File

@ -815,7 +815,9 @@ export class WebContentViewsManager {
view.webContents.loadURL(shellViewUrl).catch(logger.error); view.webContents.loadURL(shellViewUrl).catch(logger.error);
if (isDev) { if (isDev) {
view.webContents.openDevTools(); view.webContents.openDevTools({
mode: 'detach',
});
} }
} }
@ -999,13 +1001,17 @@ export const showDevTools = (id?: string) => {
getCustomThemeWindow() getCustomThemeWindow()
.then(w => { .then(w => {
if (w && w.isFocused()) { if (w && w.isFocused()) {
w.webContents.openDevTools(); w.webContents.openDevTools({
mode: 'detach',
});
} else { } else {
const view = id const view = id
? WebContentViewsManager.instance.getViewById(id) ? WebContentViewsManager.instance.getViewById(id)
: WebContentViewsManager.instance.activeWorkbenchView; : WebContentViewsManager.instance.activeWorkbenchView;
if (view) { if (view) {
view.webContents.openDevTools(); view.webContents.openDevTools({
mode: 'detach',
});
} }
} }
}) })