toeverything/AFFiNE
1
1
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2024-12-12 06:43:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow empty mailer password (#6066)

Browse Source 
fix #6046
smtp relay may allow empty password, although this is usually not safe
This commit is contained in:
DarkSky 2024-03-13 10:07:18 +00:00
parent f2ec81b2d0
commit 282b788258
No known key found for this signature in database
GPG Key ID: 97B7D036B1566E9D
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/backend/server/src/fundamentals/mailer/index.ts
View File

@ -8,7 +8,7 @@ import { MAILER } from './mailer';
@OptionalModule({
providers: [MAILER],
exports: [MAILER],
requires: ['mailer.auth.user', 'mailer.auth.pass'],
requires: ['mailer.auth.user'],
})
class MailerModule {}

16
packages/backend/server/src/fundamentals/mailer/mailer.ts
View File

@ -1,4 +1,4 @@
import { FactoryProvider } from '@nestjs/common';
import { FactoryProvider, Logger } from '@nestjs/common';
import { createTransport, Transporter } from 'nodemailer';
import SMTPTransport from 'nodemailer/lib/smtp-transport';
@ -15,7 +15,19 @@ export const MAILER: FactoryProvider<
> = {
provide: MAILER_SERVICE,
useFactory: (config: Config) => {
return config.mailer ? createTransport(config.mailer) : undefined;
if (config.mailer) {
const logger = new Logger('Mailer');
const auth = config.mailer.auth;
if (auth && auth.user && !('pass' in auth)) {
logger.warn(
'Mailer service has not configured password, please make sure your mailer service allow empty password.'
);
}
return createTransport(config.mailer);
} else {
return undefined;
}
},
inject: [Config],
};