toeverything/AFFiNE
1
1
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2024-11-23 13:53:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: wrap all workspaces with Suspense (#2477)

Browse Source
This commit is contained in:
Himself65 2023-05-22 12:39:07 +08:00 committed by GitHub
parent 752bc9ca0e
commit 41a3d6f62f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
apps/web/src/layouts/workspace-layout.tsx
View File

@ -243,12 +243,15 @@ export const WorkspaceLayout: FC<PropsWithChildren> =
(meta && WorkspaceAdapters[meta.flavour].UI.Provider) ?? DefaultProvider; (meta && WorkspaceAdapters[meta.flavour].UI.Provider) ?? DefaultProvider;
return ( return (
<> <>
{/* fixme(himself65): don't re-render whole modals */} {/* load all workspaces is costly, do not block the whole UI */}
<AllWorkspaceContext> <Suspense fallback={null}>
<CurrentWorkspaceContext> <AllWorkspaceContext>
<ModalProvider key={currentWorkspaceId} /> <CurrentWorkspaceContext>
</CurrentWorkspaceContext> {/* fixme(himself65): don't re-render whole modals */}
</AllWorkspaceContext> <ModalProvider key={currentWorkspaceId} />
</CurrentWorkspaceContext>
</AllWorkspaceContext>
</Suspense>
<CurrentWorkspaceContext> <CurrentWorkspaceContext>
<Suspense fallback={<WorkspaceFallback />}> <Suspense fallback={<WorkspaceFallback />}>
<Provider> <Provider>