toeverything/AFFiNE
1
1
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2024-12-02 14:33:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): optimize request chat cards fn (#7331)

Browse Source
This commit is contained in:
Fangdun Tsai 2024-06-26 23:50:45 +08:00 committed by GitHub
parent dcf766f0ee
commit a5662e3de2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 17 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/frontend/core/src/blocksuite/presets/ai/provider.ts
View File

@ -18,10 +18,6 @@ export interface AIChatParams {
autoSelect?: boolean;
}
type RequestChatCardsElement = (
chatPanel: HTMLElement
) => Promise<ChatCards | null>;
export type ActionEventType =
| 'started'
| 'finished'
@ -76,8 +72,17 @@ export class AIProvider {
return AIProvider.instance.toggleGeneralAIOnboarding;
}
static get requestChatCardsElement() {
return AIProvider.instance.requestChatCardsElement;
static genRequestChatCardsFn(params: AIChatParams) {
return async (chatPanel: HTMLElement) => {
const chatCards: ChatCards | null = await new Promise(resolve =>
requestAnimationFrame(() =>
resolve(chatPanel.querySelector('chat-cards'))
)
);
if (!chatCards) return;
if (chatCards.temporaryParams) return;
chatCards.temporaryParams = params;
};
}
private static readonly instance = new AIProvider();
@ -94,14 +99,6 @@ export class AIProvider {
private toggleGeneralAIOnboarding: ((value: boolean) => void) | null = null;
private readonly requestChatCardsElement: RequestChatCardsElement = (
chatPanel: HTMLElement
) => {
return new Promise(resolve => {
resolve(chatPanel.querySelector<ChatCards>('chat-cards'));
});
};
private readonly slots = {
// use case: when user selects "continue in chat" in an ask ai result panel
// do we need to pass the context to the chat panel?

2
packages/frontend/core/src/modules/multi-tab-sidebar/index.ts
View File

@ -1,4 +1,4 @@
export type { SidebarTabName } from './multi-tabs/sidebar-tab';
export { sidebarTabs } from './multi-tabs/sidebar-tabs';
export { sidebarTabs, type TabOnLoadFn } from './multi-tabs/sidebar-tabs';
export { MultiTabSidebarBody } from './view/body';
export { MultiTabSidebarHeaderSwitcher } from './view/header-switcher';

2
packages/frontend/core/src/modules/multi-tab-sidebar/multi-tabs/sidebar-tabs.ts
View File

@ -4,6 +4,8 @@ import { framePanelTab } from './tabs/frame';
import { journalTab } from './tabs/journal';
import { outlineTab } from './tabs/outline';
export type TabOnLoadFn = (component: HTMLElement) => void;
// the list of all possible tabs in affine.
// order matters (determines the order of the tabs)
export const sidebarTabs: SidebarTab[] = [

12
packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx
View File

@ -47,6 +47,7 @@ import {
MultiTabSidebarBody,
MultiTabSidebarHeaderSwitcher,
sidebarTabs,
type TabOnLoadFn,
} from '../../../modules/multi-tab-sidebar';
import {
RightSidebarService,
@ -74,9 +75,7 @@ const DetailPageImpl = memo(function DetailPageImpl() {
const docCollection = workspace.docCollection;
const mode = useLiveData(doc.mode$);
const { appSettings } = useAppSettingHelper();
const [tabOnLoad, setTabOnLoad] = useState<
((component: HTMLElement) => void) | null
>(null);
const [tabOnLoad, setTabOnLoad] = useState<TabOnLoadFn | null>(null);
const isActiveView = useIsActiveView();
// TODO(@eyhn): remove jotai here
@ -110,12 +109,7 @@ const DetailPageImpl = memo(function DetailPageImpl() {
// * The right sidebar is not open
// * Chat panel is not activated
if (!opened || !actived) {
const callback = async (chatPanel: HTMLElement) => {
const chatCards = await AIProvider.requestChatCardsElement(chatPanel);
if (!chatCards) return;
if (chatCards.temporaryParams) return;
chatCards.temporaryParams = params;
};
const callback = AIProvider.genRequestChatCardsFn(params);
setTabOnLoad(() => callback);
} else {
setTabOnLoad(null);