mirror of
https://github.com/toeverything/AFFiNE.git
synced 2024-09-19 15:38:52 +03:00
fix(core): should not reset page preset on rerender (#5034)
Should not reset editor preset when re-render.
See ce7ac88fc7/packages/editor/src/components/editor-container.ts (L197)
. If these props changes, it will trigger some unexpected side effects.
This commit is contained in:
parent
e8616acfe4
commit
ca07b143ef
@ -21,7 +21,7 @@ import {
|
||||
blockSuiteEditorHeaderStyle,
|
||||
blockSuiteEditorStyle,
|
||||
} from './index.css';
|
||||
import { getPresets } from './preset';
|
||||
import { editorPresets } from './preset';
|
||||
|
||||
interface BlockElement extends Element {
|
||||
path: string[];
|
||||
@ -104,12 +104,10 @@ const BlockSuiteEditorImpl = ({
|
||||
|
||||
if (editor.page !== page) {
|
||||
editor.page = page;
|
||||
editor.pagePreset = editorPresets.pageModePreset;
|
||||
editor.edgelessPreset = editorPresets.edgelessModePreset;
|
||||
}
|
||||
|
||||
const presets = getPresets();
|
||||
editor.pagePreset = presets.pageModePreset;
|
||||
editor.edgelessPreset = presets.edgelessModePreset;
|
||||
|
||||
useLayoutEffect(() => {
|
||||
if (editor) {
|
||||
const disposes: (() => void)[] = [];
|
||||
|
@ -17,7 +17,7 @@ class CustomAttachmentService extends AttachmentService {
|
||||
}
|
||||
}
|
||||
|
||||
export function getPresets() {
|
||||
function getPresets() {
|
||||
const pageModePreset = PagePreset.map(preset => {
|
||||
if (preset.schema.model.flavour === 'affine:attachment') {
|
||||
return {
|
||||
@ -42,3 +42,5 @@ export function getPresets() {
|
||||
edgelessModePreset,
|
||||
};
|
||||
}
|
||||
|
||||
export const editorPresets = getPresets();
|
||||
|
Loading…
Reference in New Issue
Block a user