toeverything/AFFiNE
1
1
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2024-12-22 15:41:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: add prefer-array-some rule (#5109)

Browse Source
This commit is contained in:
LongYinan 2023-11-29 04:43:43 +00:00
parent 23cfc58fe2
commit d267029761
No known key found for this signature in database
GPG Key ID: 30B1140CE1C07C99
5 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -209,6 +209,7 @@ const config = {
'unicorn/no-useless-fallback-in-spread': 'error',
'unicorn/prefer-dom-node-dataset': 'error',
'unicorn/prefer-dom-node-append': 'error',
'unicorn/prefer-array-some': 'error',
'sonarjs/no-all-duplicated-branches': 'error',
'sonarjs/no-element-overwrite': 'error',
'sonarjs/no-empty-collection': 'error',

2
package.json
View File

@ -33,7 +33,7 @@
"lint:eslint:fix": "yarn lint:eslint --fix",
"lint:prettier": "prettier --ignore-unknown --cache --check .",
"lint:prettier:fix": "prettier --ignore-unknown --cache --write .",
"lint:ox": "oxlint --deny-warnings --import-plugin -D correctness -D nursery -A no-undef -A consistent-type-exports -A default -A named -A ban-ts-comment",
"lint:ox": "oxlint --deny-warnings --import-plugin -D correctness -D nursery -D prefer-array-some -A no-undef -A consistent-type-exports -A default -A named -A ban-ts-comment",
"lint": "yarn lint:eslint && yarn lint:prettier",
"lint:fix": "yarn lint:eslint:fix && yarn lint:prettier:fix",
"test": "vitest --run",

2
packages/frontend/core/src/components/affine/setting-modal/index.tsx
View File

@ -130,7 +130,7 @@ export const SettingModal = ({
<WorkspaceSetting key={workspaceId} workspaceId={workspaceId} />
</Suspense>
) : null}
{generalSettingList.find(v => v.key === activeTab) ? (
{generalSettingList.some(v => v.key === activeTab) ? (
<GeneralSetting generalKey={activeTab as GeneralSettingKeys} />
) : null}
{activeTab === 'account' && loginStatus === 'authenticated' ? (

4
packages/frontend/i18n/src/index.ts
View File

@ -57,9 +57,9 @@ const standardizeLocale = (language: string) => {
} else if (language.slice(0, 2).toLowerCase() === 'zh') {
language = 'zh-Hant';
}
if (LOCALES.find(locale => locale.tag === language)) return language;
if (LOCALES.some(locale => locale.tag === language)) return language;
if (
LOCALES.find(locale => locale.tag === language.slice(0, 2).toLowerCase())
LOCALES.some(locale => locale.tag === language.slice(0, 2).toLowerCase())
) {
return language.slice(0, 2).toLowerCase();
}

4
packages/plugins/image-preview/src/component/index.tsx
View File

@ -143,7 +143,7 @@ const ImagePreviewModalImpl = (
if (
page
.getPreviousSiblings(block)
.findLast(
.some(
(block): block is ImageBlockModel =>
block.flavour === 'affine:image'
)
@ -160,7 +160,7 @@ const ImagePreviewModalImpl = (
} else if (
page
.getNextSiblings(block)
.find(
.some(
(block): block is ImageBlockModel =>
block.flavour === 'affine:image'
)