toeverything/AFFiNE
1
1
Fork 0
mirror of https://github.com/toeverything/AFFiNE.git synced 2024-11-28 07:22:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove React.FC (#3694)

Browse Source
This commit is contained in:
Garfield Lee 2023-08-11 22:58:44 +08:00 committed by GitHub
parent ce21ea78eb
commit e9f4912665
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/env/src/workspace.ts vendored
View File

@ -6,7 +6,7 @@ import type {
PassiveDocProvider,
Workspace as BlockSuiteWorkspace,
} from '@blocksuite/store';
import type { FC, PropsWithChildren } from 'react';
import type { PropsWithChildren, ReactNode } from 'react';
import type { Collection } from './filter.js';
@ -27,14 +27,14 @@ export interface AffineDownloadProvider extends PassiveDocProvider {
}
/**
* Download the first binary from local indexeddb
* Download the first binary from local IndexedDB
*/
export interface BroadCastChannelProvider extends PassiveDocProvider {
flavour: 'broadcast-channel';
}
/**
* Long polling provider with local indexeddb
* Long polling provider with local IndexedDB
*/
export interface LocalIndexedDBBackgroundProvider
extends StatusAdapter,
@ -165,6 +165,10 @@ type PageListProps<_Flavour extends keyof WorkspaceRegistry> = {
collection: Collection;
};
interface FC<P> {
(props: P): ReactNode;
}
export interface WorkspaceUISchema<Flavour extends keyof WorkspaceRegistry> {
Header: FC<WorkspaceHeaderProps<Flavour>>;
PageDetail: FC<PageDetailProps<Flavour>>;

4
packages/sdk/src/entry.ts
View File

@ -4,7 +4,7 @@ import type { Page } from '@blocksuite/store';
import type { Workspace } from '@blocksuite/store';
import type { Atom, getDefaultStore } from 'jotai/vanilla';
import type { WritableAtom } from 'jotai/vanilla/atom';
import type { FC } from 'react';
import type { FunctionComponent } from 'react';
export type Part = 'headerItem' | 'editor' | 'setting' | 'formatBar';
@ -22,7 +22,7 @@ export type CallbackMap = {
export interface PluginContext {
register: <T extends Part>(part: T, callback: CallbackMap[T]) => void;
utils: {
PluginProvider: FC;
PluginProvider: FunctionComponent; // make more clear
};
}

4
plugins/bookmark/src/app.tsx
View File

@ -4,7 +4,7 @@ import type { SerializedBlock } from '@blocksuite/blocks';
import type { BaseBlockModel } from '@blocksuite/store';
import type { Page } from '@blocksuite/store';
import type { VEditor } from '@blocksuite/virgo';
import type { FC, ReactElement } from 'react';
import type { ReactElement } from 'react';
import { StrictMode } from 'react';
import { useCallback, useEffect, useMemo, useState } from 'react';
@ -121,7 +121,7 @@ const shouldShowBookmarkMenu = (pastedBlocks: SerializedBlock[]) => {
return !!firstBlock.text[0].attributes?.link;
};
const BookMarkUI: FC<BookMarkProps> = ({ page }) => {
const BookMarkUI = ({ page }: BookMarkProps) => {
const [anchor, setAnchor] = useState<Range | null>(null);
const [selectedOption, setSelectedOption] = useState<string>(
menuOptions[0].id