fix: favorite button will not work (#1228)

apps/web/src/components/blocksuite/block-suite-page-list/page-list/index.tsx

@@ -32,10 +32,14 @@ import {
   StyledTitleLink,
   StyledTitleWrapper,
 } from './styles';
-const FavoriteTag = ({
-  pageMeta: { favorite, id },
-}: {
+
+export type FavoriteTagProps = {
   pageMeta: PageMeta;
+  onClick: () => void;
+};
+const FavoriteTag: React.FC<FavoriteTagProps> = ({
+  pageMeta: { favorite },
+  onClick,
 }) => {
   const { theme } = useTheme();
   const { t } = useTranslation();
@@ -49,7 +53,7 @@ const FavoriteTag = ({
         iconSize={[20, 20]}
         onClick={e => {
           e.stopPropagation();
-          // toggleFavoritePage(id);
+          onClick();
           toast(
             favorite ? t('Removed from Favorites') : t('Added to Favorites')
           );
@@ -142,7 +146,16 @@ export const PageList: React.FC<PageListProps> = ({
                         {pageMeta.title || t('Untitled')}
                       </Content>
                     </StyledTitleLink>
-                    {!isTrash && <FavoriteTag pageMeta={pageMeta} />}
+                    {!isTrash && (
+                      <FavoriteTag
+                        onClick={() => {
+                          helper.setPageMeta(pageMeta.id, {
+                            favorite: !pageMeta.favorite,
+                          });
+                        }}
+                        pageMeta={pageMeta}
+                      />
+                    )}
                   </StyledTitleWrapper>
                 </TableCell>
                 {matches && (

tests/local-first-favorites-items.spec.ts

@@ -48,5 +48,12 @@ test.describe('Local first favorite items ui', () => {
     expect(
       page.getByRole('cell', { name: 'this is a new page to favorite' })
     ).not.toBeUndefined();
+
+    await page.getByRole('cell').getByRole('button').nth(0).click();
+    expect(
+      await page
+        .getByText('Click Add to Favorites and the page will appear here.')
+        .isVisible()
+    ).toBe(true);
   });
 });