diff --git a/FiraCode.glyphs b/FiraCode.glyphs index 9f2fdb5..accb177 100644 --- a/FiraCode.glyphs +++ b/FiraCode.glyphs @@ -59,7 +59,7 @@ code = "Alpha\012Epsilon\012Eta\012Iota\012Omicron\012Upsilon\012Omega\012Alpha\ name = GreekUCcalt; } ); -copyright = "Copyright © 2015 by Nikita Prokopov"; +copyright = "Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)"; customParameters = ( { name = openTypeNameLicenseURL; @@ -130,7 +130,7 @@ value = ( } ); date = "2018-09-30 15:05:11 +0000"; -designer = "Nikita Prokopov"; +designer = "Carrois Corporate, Edenspiekermann AG, Nikita Prokopov"; designerURL = "http://tonsky.me"; familyName = "Fira Code"; featurePrefixes = ( @@ -284,7 +284,7 @@ verticalStems = ( ); weight = Light; weightValue = 62; -widthValue = 99.99999; +widthValue = 99; xHeight = 1050; }, { @@ -341,7 +341,6 @@ verticalStems = ( ); weight = Bold; weightValue = 158; -widthValue = 100; xHeight = 1062; } ); @@ -107346,7 +107345,7 @@ name = Bold; weightClass = Bold; } ); -manufacturer = "Nikita Prokopov"; +manufacturer = "Carrois Corporate, Edenspiekermann AG, Nikita Prokopov"; manufacturerURL = "http://tonsky.me"; unitsPerEm = 2000; userData = { diff --git a/distr/ttf/FiraCode-Bold.ttf b/distr/ttf/FiraCode-Bold.ttf index 1c20a71..7c38c5f 100644 Binary files a/distr/ttf/FiraCode-Bold.ttf and b/distr/ttf/FiraCode-Bold.ttf differ diff --git a/distr/ttf/FiraCode-Light.ttf b/distr/ttf/FiraCode-Light.ttf index 27ab704..1c5c40f 100644 Binary files a/distr/ttf/FiraCode-Light.ttf and b/distr/ttf/FiraCode-Light.ttf differ diff --git a/distr/ttf/FiraCode-Medium.ttf b/distr/ttf/FiraCode-Medium.ttf index 1c7cc3e..1e81cd7 100644 Binary files a/distr/ttf/FiraCode-Medium.ttf and b/distr/ttf/FiraCode-Medium.ttf differ diff --git a/distr/ttf/FiraCode-Regular.ttf b/distr/ttf/FiraCode-Regular.ttf index 838ee3f..b33c446 100644 Binary files a/distr/ttf/FiraCode-Regular.ttf and b/distr/ttf/FiraCode-Regular.ttf differ diff --git a/distr/ttf/FiraCode-Retina.ttf b/distr/ttf/FiraCode-Retina.ttf index 61f1d54..6dd48ec 100644 Binary files a/distr/ttf/FiraCode-Retina.ttf and b/distr/ttf/FiraCode-Retina.ttf differ diff --git a/distr/variable_ttf/FiraCode-VF.ttf b/distr/variable_ttf/FiraCode-VF.ttf index 5350a06..d2a1e84 100644 Binary files a/distr/variable_ttf/FiraCode-VF.ttf and b/distr/variable_ttf/FiraCode-VF.ttf differ diff --git a/googlefonts-qa/checks/FiraCode-Light.checks.md b/googlefonts-qa/checks/FiraCode-Light.checks.md index d9d954d..f4f49c3 100644 --- a/googlefonts-qa/checks/FiraCode-Light.checks.md +++ b/googlefonts-qa/checks/FiraCode-Light.checks.md @@ -235,13 +235,6 @@ Fontbakery version: 0.7.0 * 🔥 **FAIL** This is a variable font, but it is using a naming scheme typical of a static font. * 🔥 **FAIL** Please change the font filename to use one of the following valid suffixes for variable fonts: VF, Italic-VF, Roman-VF - -
-🔥 FAIL: Substitute copyright, registered and trademark symbols in name table entries. - -* [com.google.fonts/check/name/unwanted_chars](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/unwanted_chars) -* 🔥 **FAIL** NAMEID #0 contains symbol that should be replaced by '(c)'. -
🔥 FAIL: Checking OS/2 usWeightClass. @@ -249,21 +242,13 @@ Fontbakery version: 0.7.0 * [com.google.fonts/check/usweightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/usweightclass) * 🔥 **FAIL** OS/2 usWeightClass expected value for 'Light' is 300 but this font has 400. -
-
-🔥 FAIL: Are there non-ASCII characters in ASCII-only NAME table entries? - -* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries) -* 🔥 **FAIL** There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries. -* ℹ **INFO** Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright © 2015 by Nikita Prokopov'' -
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb * [com.google.fonts/check/metadata/valid_copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/valid_copyright) * 🔥 **FAIL** METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)' -But instead we have got: 'Copyright 2015 by Nikita Prokopov' +But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)'
@@ -271,7 +256,7 @@ But instead we have got: 'Copyright 2015 by Nikita Prokopov' * [com.google.fonts/check/font_copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/font_copyright) * 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)' -But instead we have got: 'Copyright © 2015 by Nikita Prokopov' +But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)'
@@ -280,13 +265,6 @@ But instead we have got: 'Copyright © 2015 by Nikita Prokopov' * [com.google.fonts/check/metadata/os2_weightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/os2_weightclass) * 🔥 **FAIL** OS/2 usWeightClass (400:"Regular") does not match weight specified at METADATA.pb (300:"Light"). -
-
-🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? - -* [com.google.fonts/check/metadata/nameid/copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/nameid/copyright) -* 🔥 **FAIL** Copyright field for this font on METADATA.pb ('Copyright 2015 by Nikita Prokopov') differs from a copyright notice entry on the name table: 'Copyright (c) 2015 by Nikita Prokopov' -
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. @@ -466,9 +444,9 @@ But instead we have got: 'Copyright © 2015 by Nikita Prokopov' | | FiraCode-Light.ttf | |:--- | ---:| -| Dehinted Size | 237.7kb | -| Hinted Size | 235.8kb | -| Increase | -1916 bytes | +| Dehinted Size | 238.0kb | +| Hinted Size | 236.1kb | +| Increase | -1996 bytes | | Change | -0.8 % | @@ -516,7 +494,7 @@ The version string must ideally include a git commit hash and either a 'dev' or ℹ INFO: Font contains all required tables? * [com.google.fonts/check/required_tables](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/required_tables) -* ℹ **INFO** This font contains the following optional tables [GSUB, loca, DSIG, prep, gasp, GPOS] +* ℹ **INFO** This font contains the following optional tables [GPOS, gasp, DSIG, loca, GSUB, prep] * 🍞 **PASS** Font contains all required tables.
@@ -526,6 +504,13 @@ The version string must ideally include a git commit hash and either a 'dev' or * [com.google.fonts/check/fstype](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/fstype) * 🍞 **PASS** OS/2 fsType is properly set to zero. + +
+🍞 PASS: Substitute copyright, registered and trademark symbols in name table entries. + +* [com.google.fonts/check/name/unwanted_chars](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/unwanted_chars) +* 🍞 **PASS** No need to substitute copyright, registered and trademark symbols in name table entries of this font. +
🍞 PASS: Check copyright namerecords match license file. @@ -568,6 +553,13 @@ The version string must ideally include a git commit hash and either a 'dev' or * [com.google.fonts/check/currency_chars](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/currency_chars) * 🍞 **PASS** Font has all expected currency sign characters. +
+
+🍞 PASS: Are there non-ASCII characters in ASCII-only NAME table entries? + +* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries) +* 🍞 **PASS** None of the ASCII-only NAME table entries contain non-ASCII characteres. +
🍞 PASS: Checks METADATA.pb font.name field matches family name declared on the name table. @@ -732,6 +724,13 @@ The version string must ideally include a git commit hash and either a 'dev' or * 🍞 **PASS** head macStyle ITALIC bit is properly set. * 🍞 **PASS** head macStyle BOLD bit is properly set. +
+
+🍞 PASS: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? + +* [com.google.fonts/check/metadata/nameid/copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/nameid/copyright) +* 🍞 **PASS** Copyright field for this font on METADATA.pb matches copyright notice entries on the name table. +
🍞 PASS: Font has all mandatory 'name' table entries ? @@ -1097,5 +1096,5 @@ The version string must ideally include a git commit hash and either a 'dev' or | 💔 ERROR | 🔥 FAIL | ⚠ WARN | 💤 SKIP | ℹ INFO | 🍞 PASS | |:-----:|:----:|:----:|:----:|:----:|:----:| -| 0 | 11 | 6 | 19 | 7 | 107 | -| 0% | 7% | 4% | 13% | 5% | 71% | +| 0 | 8 | 6 | 19 | 7 | 110 | +| 0% | 5% | 4% | 13% | 5% | 73% | diff --git a/googlefonts-qa/notes/QA-notes.md b/googlefonts-qa/notes/QA-notes.md index 7443f7c..d58c956 100644 --- a/googlefonts-qa/notes/QA-notes.md +++ b/googlefonts-qa/notes/QA-notes.md @@ -4,7 +4,7 @@ ## Checks to resolve ----------------------------- +
🔥 FAIL: Variable font weight coordinates must be multiples of 100. @@ -35,15 +35,43 @@ ----------------------------
-🔥 FAIL: Are there non-ASCII characters in ASCII-only NAME table entries? +[119] FiraCode-Light.ttf +
+🔥 FAIL: Checking file is named canonically. -* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries) -* 🔥 **FAIL** There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries. -* ℹ **INFO** Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright © 2015 by Nikita Prokopov'' +* [com.google.fonts/check/canonical_filename](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/canonical_filename) +* 🔥 **FAIL** This is a variable font, but it is using a naming scheme typical of a static font. +* 🔥 **FAIL** Please change the font filename to use one of the following valid suffixes for variable fonts: VF, Italic-VF, Roman-VF + +
+
+🔥 FAIL: Checking OS/2 usWeightClass. + +* [com.google.fonts/check/usweightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/usweightclass) +* 🔥 **FAIL** OS/2 usWeightClass expected value for 'Light' is 300 but this font has 400.
-- [ ] remove © symbol + +====================================================================================== + +## Waiting on others + +
+🔥 FAIL: Copyright notices match canonical pattern in fonts + +* [com.google.fonts/check/font_copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/font_copyright) +* 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)' +But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)' + +
+ +- additionally, it's unclear how the original copyright on Fira Mono & Fira Code should best be integrated to credit all designers involved + +- [x] file issue on fontbakery (https://github.com/googlefonts/fontbakery/issues/2419) +- [ ] confirm that current approach is fine (https://github.com/google/fonts/issues/1460#issuecomment-476713822) + +---------------------------- ====================================================================================== @@ -61,4 +89,17 @@ - [x] scale UPM to 2000 +---------------------------- + +
+🔥 FAIL: Are there non-ASCII characters in ASCII-only NAME table entries? + +* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries) +* 🔥 **FAIL** There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries. +* ℹ **INFO** Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright © 2015 by Nikita Prokopov'' + +
+ +- [x] remove © symbol + ---------------------------- \ No newline at end of file