tstack/lnav
1
1
Fork 0
mirror of https://github.com/tstack/lnav.git synced 2024-09-11 13:05:51 +03:00
Code Issues Projects Releases Wiki Activity

[filter] change from backquote to tab for activating filter panel

Browse Source
This commit is contained in:
Timothy Stack 2018-11-09 13:59:27 -08:00
parent 2345a32423
commit efe6ccf0d1
6 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
NEWS
View File

@ -2,9 +2,9 @@
lnav v0.8.5:
Features:
* Added a visual filter editor to make it easier to update existing
filters. The editor can be opened by pressing backquote (`). Once
the editor is opened, you can create/delete, enable/disable, and edit
the patterns with hotkeys.
filters. The editor can be opened by pressing TAB. Once the editor
is opened, you can create/delete, enable/disable, and edit the patterns
with hotkeys.
* Added an 'lnav_view_filters' SQL table that can be used to
programmatically manipulate filters.
* The ":write-*" commands will now accept "/dev/clipboard" as a file name

2
src/filter_status_source.cc
View File

@ -32,7 +32,7 @@
#include "lnav.hh"
#include "filter_status_source.hh"
static auto TOGGLE_MSG = "Press backquote (" ANSI_BOLD("`") ") to edit ";
static auto TOGGLE_MSG = "Press(" ANSI_BOLD("TAB") ") to edit ";
static auto HOTKEY_HELP =
ANSI_BOLD("SPC") ": Enable/Disable | "
ANSI_BOLD("ENTER") ": Edit | "

3
src/filter_sub_source.cc
View File

@ -72,7 +72,8 @@ bool filter_sub_source::list_input_handle_key(listview_curses &lv, int ch)
}
switch (ch) {
case '`':
case '\t':
case KEY_BTAB:
case 'q':
lnav_data.ld_mode = LNM_PAGING;
lnav_data.ld_filter_view.reload_data();

4
src/help.txt
View File

@ -176,7 +176,7 @@ Views
leaving the spectrogram view with 'Q', the top time in that
view will be matched to the top time in the log view.
` Toggle focusing on the filter editor or the main view.
TAB Toggle focusing on the filter editor or the main view.
a/A Restore the view that was previously popped with 'q/Q'.
The 'A' hotkey will try to match the top times between the
@ -431,7 +431,7 @@ Filter Editor
-------------
The following hotkeys are only available when the focus is on the filter
editor. You can change the focus by pressing backquote (`).
editor. You can change the focus by pressing TAB.
q Switch the focus back to the main view.
j/down-arrow Select the next filter.

8
src/hotkeys.cc
View File

@ -124,11 +124,6 @@ void handle_paging_key(int ch)
case KEY_BACKSPACE:
break;
case '`':
lnav_data.ld_mode = LNM_FILTER;
lnav_data.ld_filter_view.reload_data();
break;
case 'a':
if (lnav_data.ld_last_view == NULL) {
alerter::singleton().chime();
@ -932,6 +927,9 @@ void handle_paging_key(int ch)
);
tc->reload_data();
} else {
lnav_data.ld_mode = LNM_FILTER;
lnav_data.ld_filter_view.reload_data();
}
break;

4
test/expected_help.txt
View File

@ -176,7 +176,7 @@ Views
leaving the spectrogram view with 'Q', the top time in that
view will be matched to the top time in the log view.
` Toggle focusing on the filter editor or the main view.
TAB Toggle focusing on the filter editor or the main view.
a/A Restore the view that was previously popped with 'q/Q'.
The 'A' hotkey will try to match the top times between the
@ -431,7 +431,7 @@ Filter Editor
-------------
The following hotkeys are only available when the focus is on the filter
editor. You can change the focus by pressing backquote (`).
editor. You can change the focus by pressing TAB.
q Switch the focus back to the main view.
j/down-arrow Select the next filter.