twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-25 21:13:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

increase export feature page size (#7341)

Browse Source 
## Context
Now that we have improved performances, we can increase the export
feature page size from 30 to 200 (and probably above if results are
good). This should be ok since we are only querying the first level of
an object and omit relations.
I've moved this value to a constant.
This commit is contained in:
Weiko 2024-09-30 15:45:17 +02:00 committed by GitHub
parent 95e1053b7a
commit 06d4ba92e5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/twenty-front/src/modules/object-record/record-index/options/constants/ExportTableDataDefaultPageSize.ts Normal file
View File

@ -0,0 +1 @@
export const EXPORT_TABLE_DATA_DEFAULT_PAGE_SIZE = 200;

3
packages/twenty-front/src/modules/object-record/record-index/options/hooks/useExportTableData.ts
View File

@ -2,6 +2,7 @@ import { json2csv } from 'json-2-csv';
import { useMemo } from 'react'; import { useMemo } from 'react';
import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata'; import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
import { EXPORT_TABLE_DATA_DEFAULT_PAGE_SIZE } from '@/object-record/record-index/options/constants/ExportTableDataDefaultPageSize';
import { useProcessRecordsForCSVExport } from '@/object-record/record-index/options/hooks/useProcessRecordsForCSVExport'; import { useProcessRecordsForCSVExport } from '@/object-record/record-index/options/hooks/useProcessRecordsForCSVExport';
import { import {
useTableData, useTableData,
@ -142,7 +143,7 @@ export const useExportTableData = ({
filename, filename,
maximumRequests = 100, maximumRequests = 100,
objectNameSingular, objectNameSingular,
pageSize = 30, pageSize = EXPORT_TABLE_DATA_DEFAULT_PAGE_SIZE,
recordIndexId, recordIndexId,
viewType, viewType,
}: UseExportTableDataOptions) => { }: UseExportTableDataOptions) => {

3
packages/twenty-front/src/modules/object-record/record-index/options/hooks/useTableData.ts
View File

@ -9,6 +9,7 @@ import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { isDefined } from '~/utils/isDefined'; import { isDefined } from '~/utils/isDefined';
import { useRecordBoardStates } from '@/object-record/record-board/hooks/internal/useRecordBoardStates'; import { useRecordBoardStates } from '@/object-record/record-board/hooks/internal/useRecordBoardStates';
import { EXPORT_TABLE_DATA_DEFAULT_PAGE_SIZE } from '@/object-record/record-index/options/constants/ExportTableDataDefaultPageSize';
import { useRecordIndexOptionsForBoard } from '@/object-record/record-index/options/hooks/useRecordIndexOptionsForBoard'; import { useRecordIndexOptionsForBoard } from '@/object-record/record-index/options/hooks/useRecordIndexOptionsForBoard';
import { ViewType } from '@/views/types/ViewType'; import { ViewType } from '@/views/types/ViewType';
import { useFindManyParams } from '../../hooks/useLoadRecordIndexTable'; import { useFindManyParams } from '../../hooks/useLoadRecordIndexTable';
@ -43,7 +44,7 @@ export const useTableData = ({
delayMs, delayMs,
maximumRequests = 100, maximumRequests = 100,
objectNameSingular, objectNameSingular,
pageSize = 30, pageSize = EXPORT_TABLE_DATA_DEFAULT_PAGE_SIZE,
recordIndexId, recordIndexId,
callback, callback,
viewType = ViewType.Table, viewType = ViewType.Table,