twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-25 04:55:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix onboarding status refacto (#6533)

Browse Source 
see comments in
https://github.com/twentyhq/twenty/pull/6531#pullrequestreview-2217807413
- rename method
- add check before setting create profile pending user var
This commit is contained in:
martmull 2024-08-07 17:09:11 +02:00 committed by GitHub
parent 8408cf6d19
commit 10817c5388
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-backfill-new-onboarding-user-vars.ts
View File

@ -73,7 +73,7 @@ export class BackfillNewOnboardingUserVarsCommand extends CommandRunner {
}); });
for (const user of workspace.users) { for (const user of workspace.users) {
await this.onboardingService.setOnboardingCreateProfileCompletion({ await this.onboardingService.setOnboardingCreateProfilePending({
userId: user.id, userId: user.id,
workspaceId: workspace.id, workspaceId: workspace.id,
value: true, value: true,

8
packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
View File

@ -197,11 +197,13 @@ export class SignInUpService {
value: true, value: true,
}); });
await this.onboardingService.setOnboardingCreateProfileCompletion({ if (firstName === '' && lastName === '') {
await this.onboardingService.setOnboardingCreateProfilePending({
userId: user.id, userId: user.id,
workspaceId: workspace.id, workspaceId: workspace.id,
value: true, value: true,
}); });
}
return user; return user;
} }
@ -257,11 +259,13 @@ export class SignInUpService {
value: true, value: true,
}); });
await this.onboardingService.setOnboardingCreateProfileCompletion({ if (firstName === '' && lastName === '') {
await this.onboardingService.setOnboardingCreateProfilePending({
userId: user.id, userId: user.id,
workspaceId: workspace.id, workspaceId: workspace.id,
value: true, value: true,
}); });
}
await this.onboardingService.setOnboardingInviteTeamPending({ await this.onboardingService.setOnboardingInviteTeamPending({
workspaceId: workspace.id, workspaceId: workspace.id,

2
packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.ts
View File

@ -131,7 +131,7 @@ export class OnboardingService {
}); });
} }
async setOnboardingCreateProfileCompletion({ async setOnboardingCreateProfilePending({
userId, userId,
workspaceId, workspaceId,
value, value,

2
packages/twenty-server/src/engine/core-modules/workspace/workspace-workspace-member.listener.ts
View File

@ -36,7 +36,7 @@ export class WorkspaceWorkspaceMemberListener {
return; return;
} }
await this.onboardingService.setOnboardingCreateProfileCompletion({ await this.onboardingService.setOnboardingCreateProfilePending({
userId: payload.userId, userId: payload.userId,
workspaceId: payload.workspaceId, workspaceId: payload.workspaceId,
value: false, value: false,