twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-26 05:24:04 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat: only show Update View button if view can be persisted (#1533)

Browse Source 
Closes #1499
This commit is contained in:
Thaïs 2023-09-11 12:03:01 +02:00 committed by GitHub
parent 9be069bedc
commit 110d5eaa9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
front/src/modules/ui/view-bar/components/UpdateViewButtonGroup.tsx
View File

@ -67,6 +67,10 @@ export const UpdateViewButtonGroup = ({
const setViewEditMode = useSetRecoilState(viewEditModeState); const setViewEditMode = useSetRecoilState(viewEditModeState);
const canPersistView =
currentViewId &&
(canPersistViewFields || canPersistFilters || canPersistSorts);
const handleArrowDownButtonClick = useCallback(() => { const handleArrowDownButtonClick = useCallback(() => {
setIsDropdownOpen((previousIsOpen) => !previousIsOpen); setIsDropdownOpen((previousIsOpen) => !previousIsOpen);
}, []); }, []);
@ -95,17 +99,12 @@ export const UpdateViewButtonGroup = ({
[], [],
); );
if (!canPersistView) return null;
return ( return (
<StyledContainer> <StyledContainer>
<ButtonGroup size="small" accent="blue"> <ButtonGroup size="small" accent="blue">
<Button <Button title="Update view" onClick={handleViewSubmit} />
title="Update view"
disabled={
!currentViewId ||
(!canPersistViewFields && !canPersistFilters && !canPersistSorts)
}
onClick={handleViewSubmit}
/>
<Button <Button
size="small" size="small"
Icon={IconChevronDown} Icon={IconChevronDown}