twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2025-01-05 10:54:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat: add Number field preview in settings (#2397)

Browse Source 
Closes #2327
This commit is contained in:
Thaïs 2023-11-09 08:30:37 +01:00 committed by GitHub
parent 1f5492b4a7
commit 28779f0fb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 38 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
front/src/modules/settings/components/SettingsPageContainer.tsx
View File

@ -6,6 +6,7 @@ const StyledSettingsPageContainer = styled.div<{ width?: number }>`
display: flex;
flex-direction: column;
gap: ${({ theme }) => theme.spacing(8)};
overflow: auto;
padding: ${({ theme }) => theme.spacing(8)};
width: ${({ width }) => (width ? width + 'px' : objectSettingsWidth)};
`;

2
front/src/modules/settings/data-model/components/SettingsObjectFieldTypeSelectSection.tsx
View File

@ -64,7 +64,7 @@ export const SettingsObjectFieldTypeSelectSection = ({
}),
)}
/>
{fieldType === 'TEXT' && (
{['NUMBER', 'TEXT'].includes(fieldType) && (
<StyledSettingsObjectFieldTypeCard
preview={
<SettingsObjectFieldPreview

26
front/src/modules/settings/data-model/components/__stories__/SettingsObjectFieldPreview.stories.tsx
View File

@ -12,15 +12,31 @@ const meta: Meta<typeof SettingsObjectFieldPreview> = {
fieldIconKey: 'IconNotes',
fieldLabel: 'Description',
fieldType: 'TEXT',
objectIconKey: 'IconUser',
objectLabelPlural: 'People',
objectNamePlural: 'people',
isObjectCustom: false,
objectIconKey: 'IconBuildingSkyscraper',
objectLabelPlural: 'Companies',
objectNamePlural: 'companies',
},
};
export default meta;
type Story = StoryObj<typeof SettingsObjectFieldPreview>;
export const StandardObject: Story = { args: { isObjectCustom: false } };
export const Text: Story = {};
export const CustomObject: Story = { args: { isObjectCustom: true } };
export const Number: Story = {
args: {
fieldIconKey: 'IconUsers',
fieldLabel: 'Employees',
fieldType: 'NUMBER',
},
};
export const CustomObject: Story = {
args: {
isObjectCustom: true,
objectIconKey: 'IconApps',
objectLabelPlural: 'Workspaces',
objectNamePlural: 'workspaces',
},
};

15
front/src/modules/settings/data-model/components/__stories__/SettingsObjectFieldTypeSelectSection.stories.tsx
View File

@ -9,7 +9,16 @@ const meta: Meta<typeof SettingsObjectFieldTypeSelectSection> = {
title: 'Modules/Settings/DataModel/SettingsObjectFieldTypeSelectSection',
component: SettingsObjectFieldTypeSelectSection,
decorators: [ComponentDecorator],
args: { fieldType: 'NUMBER' },
args: {
fieldType: 'NUMBER',
fieldIconKey: 'IconUsers',
fieldLabel: 'Employees',
fieldName: 'employees',
isObjectCustom: false,
objectIconKey: 'IconUser',
objectLabelPlural: 'People',
objectNamePlural: 'people',
},
};
export default meta;
@ -17,6 +26,10 @@ type Story = StoryObj<typeof SettingsObjectFieldTypeSelectSection>;
export const Default: Story = {};
export const Disabled: Story = {
args: { disabled: true },
};
export const WithOpenSelect: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);

2
front/src/modules/settings/data-model/constants/dataTypes.ts
View File

@ -13,7 +13,7 @@ export const dataTypes: Record<
MetadataFieldDataType,
{ label: string; Icon: IconComponent; defaultValue?: unknown }
> = {
NUMBER: { label: 'Number', Icon: IconNumbers },
NUMBER: { label: 'Number', Icon: IconNumbers, defaultValue: 2000 },
TEXT: {
label: 'Text',
Icon: IconTextSize,