twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-18 17:12:53 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix infinite loop when opening relation picker in comments pane (#548)

Browse Source 
* Typo

* Remove hotkeys for relation picker
This commit is contained in:
Emilien Chauvet 2023-07-08 20:09:00 -07:00 committed by GitHub
parent fffb8c99cb
commit 49c20907e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
front/src/modules/comments/components/CommentThreadRelationPicker.tsx
View File

@ -12,7 +12,6 @@ import { IconArrowUpRight } from '@tabler/icons-react';
import { CommentThreadForDrawer } from '@/comments/types/CommentThreadForDrawer'; import { CommentThreadForDrawer } from '@/comments/types/CommentThreadForDrawer';
import CompanyChip from '@/companies/components/CompanyChip'; import CompanyChip from '@/companies/components/CompanyChip';
import { useHotkeysScopeOnBooleanState } from '@/hotkeys/hooks/useHotkeysScopeOnBooleanState';
import { useScopedHotkeys } from '@/hotkeys/hooks/useScopedHotkeys'; import { useScopedHotkeys } from '@/hotkeys/hooks/useScopedHotkeys';
import { InternalHotkeysScope } from '@/hotkeys/types/internal/InternalHotkeysScope'; import { InternalHotkeysScope } from '@/hotkeys/types/internal/InternalHotkeysScope';
import { PersonChip } from '@/people/components/PersonChip'; import { PersonChip } from '@/people/components/PersonChip';
@ -98,11 +97,6 @@ export function CommentThreadRelationPicker({ commentThread }: OwnProps) {
const [isMenuOpen, setIsMenuOpen] = useState(false); const [isMenuOpen, setIsMenuOpen] = useState(false);
const [searchFilter, setSearchFilter] = useState(''); const [searchFilter, setSearchFilter] = useState('');
useHotkeysScopeOnBooleanState(
{ scope: InternalHotkeysScope.RelationPicker },
isMenuOpen,
);
const theme = useTheme(); const theme = useTheme();
const peopleIds = const peopleIds =

6
front/src/modules/hotkeys/hooks/useHotkeysScopeOnBooleanState.ts
View File

@ -10,17 +10,17 @@ export function useHotkeysScopeOnBooleanState(
booleanState: boolean, booleanState: boolean,
) { ) {
const addToHotkeysScopeStack = useAddToHotkeysScopeStack(); const addToHotkeysScopeStack = useAddToHotkeysScopeStack();
const removeFromHoteysScopeStack = useRemoveFromHotkeysScopeStack(); const removeFromHotkeysScopeStack = useRemoveFromHotkeysScopeStack();
useEffect(() => { useEffect(() => {
if (booleanState) { if (booleanState) {
addToHotkeysScopeStack(hotkeysScopeStackItem); addToHotkeysScopeStack(hotkeysScopeStackItem);
} else { } else {
removeFromHoteysScopeStack(hotkeysScopeStackItem.scope); removeFromHotkeysScopeStack(hotkeysScopeStackItem.scope);
} }
}, [ }, [
hotkeysScopeStackItem, hotkeysScopeStackItem,
removeFromHoteysScopeStack, removeFromHotkeysScopeStack,
addToHotkeysScopeStack, addToHotkeysScopeStack,
booleanState, booleanState,
]); ]);