From 55be401204d45738e205744e24e04385dc5b4107 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix=20Malfait?= <felix.malfait@gmail.com>
Date: Sat, 29 Jul 2023 19:47:54 -0700
Subject: [PATCH] Add fake characters to prevent password managers from filling
 fields (#989)

---
 .../modules/companies/constants/companyViewFields.tsx  |  2 +-
 .../src/modules/people/constants/peopleViewFields.tsx  | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/front/src/modules/companies/constants/companyViewFields.tsx b/front/src/modules/companies/constants/companyViewFields.tsx
index 4df0ed88b9..0d00d86559 100644
--- a/front/src/modules/companies/constants/companyViewFields.tsx
+++ b/front/src/modules/companies/constants/companyViewFields.tsx
@@ -100,7 +100,7 @@ export const companyViewFields: ViewFieldDefinition<ViewFieldMetadata>[] = [
     metadata: {
       type: 'text',
       fieldName: 'address',
-      placeHolder: 'Address',
+      placeHolder: 'Addre​ss', // Hack: Fake character to prevent password-manager from filling the field
     },
   } satisfies ViewFieldDefinition<ViewFieldTextMetadata>,
 ];
diff --git a/front/src/modules/people/constants/peopleViewFields.tsx b/front/src/modules/people/constants/peopleViewFields.tsx
index db317e6f5d..0463624eeb 100644
--- a/front/src/modules/people/constants/peopleViewFields.tsx
+++ b/front/src/modules/people/constants/peopleViewFields.tsx
@@ -31,8 +31,8 @@ export const peopleViewFields: ViewFieldDefinition<ViewFieldMetadata>[] = [
       type: 'double-text-chip',
       firstValueFieldName: 'firstName',
       secondValueFieldName: 'lastName',
-      firstValuePlaceholder: 'First name',
-      secondValuePlaceholder: 'Last name',
+      firstValuePlaceholder: 'F​irst n​ame', // Hack: Fake character to prevent password-manager from filling the field
+      secondValuePlaceholder: 'L​ast n​ame', // Hack: Fake character to prevent password-manager from filling the field
       avatarUrlFieldName: 'avatarUrl',
       entityType: Entity.Person,
     },
@@ -46,7 +46,7 @@ export const peopleViewFields: ViewFieldDefinition<ViewFieldMetadata>[] = [
     metadata: {
       type: 'text',
       fieldName: 'email',
-      placeHolder: 'Email',
+      placeHolder: 'Ema​il', // Hack: Fake character to prevent password-manager from filling the field
     },
   } satisfies ViewFieldDefinition<ViewFieldTextMetadata>,
   {
@@ -70,7 +70,7 @@ export const peopleViewFields: ViewFieldDefinition<ViewFieldMetadata>[] = [
     metadata: {
       type: 'phone',
       fieldName: 'phone',
-      placeHolder: 'Phone',
+      placeHolder: 'Phon​e', // Hack: Fake character to prevent password-manager from filling the field
     },
   } satisfies ViewFieldDefinition<ViewFieldPhoneMetadata>,
   {
@@ -93,7 +93,7 @@ export const peopleViewFields: ViewFieldDefinition<ViewFieldMetadata>[] = [
     metadata: {
       type: 'text',
       fieldName: 'city',
-      placeHolder: 'City',
+      placeHolder: 'Cit​y', // Hack: Fake character to prevent password-manager from filling the field
     },
   } satisfies ViewFieldDefinition<ViewFieldTextMetadata>,
   {