diff --git a/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.command.ts b/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.command.ts index ac4c7d2873..ac1cc0ea03 100644 --- a/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.command.ts +++ b/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.command.ts @@ -7,6 +7,7 @@ import { MigrateMessageChannelSyncStatusEnumCommand } from 'src/database/command import { SetWorkspaceActivationStatusCommand } from 'src/database/commands/upgrade-version/0-23/0-23-set-workspace-activation-status.command'; import { UpdateActivitiesCommand } from 'src/database/commands/upgrade-version/0-23/0-23-update-activities.command'; import { UpdateFileFolderStructureCommand } from 'src/database/commands/upgrade-version/0-23/0-23-update-file-folder-structure.command'; +import { SyncWorkspaceMetadataCommand } from 'src/engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command'; interface UpdateTo0_23CommandOptions { workspaceId?: string; @@ -18,6 +19,7 @@ interface UpdateTo0_23CommandOptions { }) export class UpgradeTo0_23Command extends CommandRunner { constructor( + private readonly syncWorkspaceMetadataCommand: SyncWorkspaceMetadataCommand, private readonly updateFileFolderStructureCommandOptions: UpdateFileFolderStructureCommand, private readonly migrateLinkFieldsToLinks: MigrateLinkFieldsToLinksCommand, private readonly migrateDomainNameFromTextToLinks: MigrateDomainNameFromTextToLinksCommand, @@ -54,6 +56,10 @@ export class UpgradeTo0_23Command extends CommandRunner { _passedParam, options, ); + await this.syncWorkspaceMetadataCommand.run(_passedParam, { + ...options, + force: true, + }); await this.updateActivitiesCommand.run(_passedParam, options); await this.backfillNewOnboardingUserVarsCommand.run(_passedParam, options); } diff --git a/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.module.ts b/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.module.ts index 5f5d28e02b..05fc1396ce 100644 --- a/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.module.ts +++ b/packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-upgrade-version.module.ts @@ -21,10 +21,12 @@ import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadat import { ObjectMetadataModule } from 'src/engine/metadata-modules/object-metadata/object-metadata.module'; import { WorkspaceCacheVersionModule } from 'src/engine/metadata-modules/workspace-cache-version/workspace-cache-version.module'; import { WorkspaceStatusModule } from 'src/engine/workspace-manager/workspace-status/workspace-manager.module'; +import { WorkspaceSyncMetadataCommandsModule } from 'src/engine/workspace-manager/workspace-sync-metadata/commands/workspace-sync-metadata-commands.module'; import { ViewModule } from 'src/modules/view/view.module'; @Module({ imports: [ + WorkspaceSyncMetadataCommandsModule, TypeOrmModule.forFeature([Workspace], 'core'), FileStorageModule, OnboardingModule, diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration-builder/factories/workspace-migration-field.factory.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration-builder/factories/workspace-migration-field.factory.ts index adda57f20d..2215546761 100644 --- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration-builder/factories/workspace-migration-field.factory.ts +++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration-builder/factories/workspace-migration-field.factory.ts @@ -1,5 +1,7 @@ import { Injectable } from '@nestjs/common'; +import { isDeepStrictEqual } from 'util'; + import { WorkspaceMigrationBuilderAction } from 'src/engine/workspace-manager/workspace-migration-builder/interfaces/workspace-migration-builder-action.interface'; import { @@ -126,30 +128,37 @@ export class WorkspaceMigrationFieldFactory { continue; } - const migrations: WorkspaceMigrationTableAction[] = [ - { - name: computeObjectTargetTable( - originalObjectMetadataMap[ - fieldMetadataUpdate.current.objectMetadataId - ], - ), - action: WorkspaceMigrationTableActionType.ALTER, - columns: this.workspaceMigrationFactory.createColumnActions( - WorkspaceMigrationColumnActionType.ALTER, - fieldMetadataUpdate.current, - fieldMetadataUpdate.altered, - ), - }, - ]; + if ( + !isDeepStrictEqual( + fieldMetadataUpdate.current, + fieldMetadataUpdate.altered, + ) + ) { + const migrations: WorkspaceMigrationTableAction[] = [ + { + name: computeObjectTargetTable( + originalObjectMetadataMap[ + fieldMetadataUpdate.current.objectMetadataId + ], + ), + action: WorkspaceMigrationTableActionType.ALTER, + columns: this.workspaceMigrationFactory.createColumnActions( + WorkspaceMigrationColumnActionType.ALTER, + fieldMetadataUpdate.current, + fieldMetadataUpdate.altered, + ), + }, + ]; - workspaceMigrations.push({ - workspaceId: fieldMetadataUpdate.current.workspaceId, - name: generateMigrationName( - `update-${fieldMetadataUpdate.altered.name}`, - ), - isCustom: false, - migrations, - }); + workspaceMigrations.push({ + workspaceId: fieldMetadataUpdate.current.workspaceId, + name: generateMigrationName( + `update-${fieldMetadataUpdate.altered.name}`, + ), + isCustom: false, + migrations, + }); + } } return workspaceMigrations; diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/workspace-sync-metadata-commands.module.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/workspace-sync-metadata-commands.module.ts index 1178966443..0ad0593eae 100644 --- a/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/workspace-sync-metadata-commands.module.ts +++ b/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/workspace-sync-metadata-commands.module.ts @@ -31,5 +31,6 @@ import { SyncWorkspaceLoggerService } from './services/sync-workspace-logger.ser ConvertRecordPositionsToIntegers, SyncWorkspaceLoggerService, ], + exports: [SyncWorkspaceMetadataCommand], }) export class WorkspaceSyncMetadataCommandsModule {}