3681 avatars are not appearing in the messages and people name should be bold (#3692)

* update font weight

* fix picture not appearing
This commit is contained in:
bosiraphael 2024-01-30 17:46:25 +01:00 committed by GitHub
parent 1838d8e6fb
commit 8b9d62e425
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 13 additions and 2 deletions

View File

@ -24,6 +24,7 @@ const StyledAvatar = styled(Avatar)`
const StyledSenderName = styled.span` const StyledSenderName = styled.span`
font-size: ${({ theme }) => theme.font.size.sm}; font-size: ${({ theme }) => theme.font.size.sm};
font-weight: ${({ theme }) => theme.font.weight.medium};
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
`; `;
@ -35,6 +36,10 @@ const StyledThreadMessageSentAt = styled.div`
font-size: ${({ theme }) => theme.font.size.sm}; font-size: ${({ theme }) => theme.font.size.sm};
`; `;
const StyledRecordChip = styled(RecordChip)`
font-weight: ${({ theme }) => theme.font.weight.medium};
`;
type EmailThreadMessageSenderProps = { type EmailThreadMessageSenderProps = {
sender: EmailThreadMessageParticipant; sender: EmailThreadMessageParticipant;
sentAt: string; sentAt: string;
@ -57,7 +62,7 @@ export const EmailThreadMessageSender = ({
<StyledEmailThreadMessageSender> <StyledEmailThreadMessageSender>
<StyledEmailThreadMessageSenderUser> <StyledEmailThreadMessageSenderUser>
{person ? ( {person ? (
<RecordChip <StyledRecordChip
objectNameSingular={CoreObjectNameSingular.Person} objectNameSingular={CoreObjectNameSingular.Person}
record={person} record={person}
/> />

View File

@ -52,9 +52,12 @@ export const getObjectRecordIdentifier = ({
? 'squared' ? 'squared'
: 'rounded'; : 'rounded';
// TODO: This is a temporary solution before we seed imageIdentifierFieldMetadataId in the database
const avatarUrl = const avatarUrl =
(objectMetadataItem.nameSingular === CoreObjectNameSingular.Company (objectMetadataItem.nameSingular === CoreObjectNameSingular.Company
? getLogoUrlFromDomainName(record['domainName'] ?? '') ? getLogoUrlFromDomainName(record['domainName'] ?? '')
: objectMetadataItem.nameSingular === CoreObjectNameSingular.Person
? record['avatarUrl'] ?? ''
: imageIdentifierFieldValue) ?? ''; : imageIdentifierFieldValue) ?? '';
const basePathToShowPage = getBasePathToShowPage({ const basePathToShowPage = getBasePathToShowPage({

View File

@ -9,12 +9,14 @@ export type RecordChipProps = {
objectNameSingular: string; objectNameSingular: string;
record: ObjectRecord; record: ObjectRecord;
maxWidth?: number; maxWidth?: number;
className?: string;
}; };
export const RecordChip = ({ export const RecordChip = ({
objectNameSingular, objectNameSingular,
record, record,
maxWidth, maxWidth,
className,
}: RecordChipProps) => { }: RecordChipProps) => {
const { objectMetadataItem } = useObjectMetadataItemOnly({ const { objectMetadataItem } = useObjectMetadataItemOnly({
objectNameSingular, objectNameSingular,
@ -34,6 +36,7 @@ export const RecordChip = ({
avatarUrl={objectRecordIdentifier.avatarUrl} avatarUrl={objectRecordIdentifier.avatarUrl}
linkToEntity={objectRecordIdentifier.linkToShowPage} linkToEntity={objectRecordIdentifier.linkToShowPage}
maxWidth={maxWidth} maxWidth={maxWidth}
className={className}
/> />
); );
}; };