twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-23 12:02:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent non-boolean 'active' prop from being forwarded to DOM (#8534)

Browse Source 
Fixes: #8533
This commit is contained in:
Harsh Singh 2024-11-18 00:41:13 +05:30 committed by GitHub
parent badebc513f
commit 9134ed8ce4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/twenty-front/src/modules/ui/layout/tab/components/Tab.tsx
View File

@ -1,3 +1,4 @@
import isPropValid from '@emotion/is-prop-valid';
import { useTheme } from '@emotion/react';
import styled from '@emotion/styled';
import { ReactElement } from 'react';
@ -16,11 +17,9 @@ type TabProps = {
to?: string;
};
const StyledTab = styled.button<{
active?: boolean;
disabled?: boolean;
to?: string;
}>`
const StyledTab = styled('button', {
shouldForwardProp: (prop) => isPropValid(prop) && prop !== 'active',
})<{ active?: boolean; disabled?: boolean; to?: string }>`
align-items: center;
border-bottom: 1px solid ${({ theme }) => theme.border.color.light};
border-color: ${({ theme, active }) =>