twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-23 12:02:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: empty composite field input (#8451)

Browse Source 
Fixes: #7225

---------

Co-authored-by: bosiraphael <raphael.bosi@gmail.com>
This commit is contained in:
Harsh Singh 2024-11-20 20:09:55 +05:30 committed by GitHub
parent 24c0b0f873
commit 96c8673278
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/MultiItemFieldInput.tsx
View File

@ -19,9 +19,8 @@ import { toSpliced } from '~/utils/array/toSpliced';
import { turnIntoEmptyStringIfWhitespacesOnly } from '~/utils/string/turnIntoEmptyStringIfWhitespacesOnly'; import { turnIntoEmptyStringIfWhitespacesOnly } from '~/utils/string/turnIntoEmptyStringIfWhitespacesOnly';
const StyledDropdownMenu = styled(DropdownMenu)` const StyledDropdownMenu = styled(DropdownMenu)`
margin-left: -1px; margin: -1px;
position: relative; position: relative;
margin-top: -1px;
`; `;
type MultiItemFieldInputProps<T> = { type MultiItemFieldInputProps<T> = {
@ -65,8 +64,12 @@ export const MultiItemFieldInput = <T,>({
}; };
const handleDropdownCloseOutside = (event: MouseEvent | TouchEvent) => { const handleDropdownCloseOutside = (event: MouseEvent | TouchEvent) => {
onCancel?.();
event.stopImmediatePropagation(); event.stopImmediatePropagation();
if (inputValue?.trim().length > 0) {
handleSubmitInput();
} else {
onCancel?.();
}
}; };
useListenClickOutside({ useListenClickOutside({
@ -202,10 +205,12 @@ export const MultiItemFieldInput = <T,>({
} }
onEnter={handleSubmitInput} onEnter={handleSubmitInput}
rightComponent={ rightComponent={
<LightIconButton items.length ? (
Icon={isAddingNewItem ? IconPlus : IconCheck} <LightIconButton
onClick={handleSubmitInput} Icon={isAddingNewItem ? IconPlus : IconCheck}
/> onClick={handleSubmitInput}
/>
) : null
} }
/> />
) : ( ) : (

4
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuInput.tsx
View File

@ -36,6 +36,10 @@ const StyledInputContainer = styled.div`
box-sizing: border-box; box-sizing: border-box;
position: relative; position: relative;
width: 100%; width: 100%;
&:not(:first-of-type) {
padding: ${({ theme }) => theme.spacing(1)};
}
`; `;
const StyledRightContainer = styled.div` const StyledRightContainer = styled.div`