twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-03 07:14:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fixed default currency code in currency field (#5028)

Browse Source 
Default currency logic was not handling a specific case where the
default currency is empty in the field metadata.

I fixed the ternary cascade and made it more explicit, thus also
avoiding falling into having an empty currency code being persisted.
This commit is contained in:
Lucas Bordeau 2024-04-18 11:25:17 +02:00 committed by GitHub
parent 7065495223
commit bc5cfd046c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/CurrencyFieldInput.tsx
View File

@ -1,3 +1,5 @@
import { isNonEmptyString } from '@sniptt/guards';
import { CurrencyCode } from '@/object-record/record-field/types/CurrencyCode';
import { FieldCurrencyValue } from '@/object-record/record-field/types/FieldMetadata';
import { CurrencyInput } from '@/ui/field/input/components/CurrencyInput';
@ -30,13 +32,24 @@ export const CurrencyFieldInput = ({
defaultValue,
} = useCurrencyField();
const currencyCode =
draftValue?.currencyCode ??
((defaultValue as FieldCurrencyValue).currencyCode.replace(
/'/g,
'',
) as CurrencyCode) ??
CurrencyCode.USD;
const defaultCurrencyCodeWithoutSQLQuotes = (
defaultValue as FieldCurrencyValue
).currencyCode.replace(/'/g, '') as CurrencyCode;
const defaultCurrencyCodeIsNotEmpty = isNonEmptyString(
defaultCurrencyCodeWithoutSQLQuotes,
);
const draftCurrencyCode = draftValue?.currencyCode;
const draftCurrencyCodeIsEmptyIsNotEmpty =
isNonEmptyString(draftCurrencyCode);
const currencyCode = draftCurrencyCodeIsEmptyIsNotEmpty
? draftCurrencyCode
: defaultCurrencyCodeIsNotEmpty
? defaultCurrencyCodeWithoutSQLQuotes
: CurrencyCode.USD;
const handleEnter = (newValue: string) => {
onEnter?.(() => {