twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-23 20:13:21 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix chromatic tests + re-enable (#3414)

Browse Source 
* Fix chromatic tests + re-enable

* Try to run command manually

* Fix

* Fix

* Fix

* Fix

* Fix

---------

Co-authored-by: Thomas Trompette <thomast@twenty.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Thomas Trompette 2024-01-12 18:32:00 +01:00 committed by GitHub
parent 03b5c40e8a
commit c53abf2f5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
.github/workflows/ci-chromatic.yaml vendored
View File

@ -12,6 +12,7 @@ jobs:
runs-on: ubuntu-latest
env:
REACT_APP_SERVER_BASE_URL: http://127.0.0.1:3000
CHROMATIC_PROJECT_TOKEN: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
steps:
- name: Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0
@ -31,11 +32,7 @@ jobs:
echo "REACT_APP_SERVER_BASE_URL: $REACT_APP_SERVER_BASE_URL" >> .env
- name: Front / Install Dependencies
run: yarn
# - name: Publish to Chromatic
# uses: chromaui/action@v1
# with:
# workingDir: ./packages/twenty-front
# projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
# onlyChanged: true
# buildScriptName: storybook:build
- name: Publish to Chromatic
run: |
cd packages/twenty-front
yarn nx chromatic:ci

3
packages/twenty-front/package.json
View File

@ -37,7 +37,8 @@
"storybook:pages:coverage": "STORYBOOK_SCOPE=pages yarn storybook:coverage",
"graphql:data:generate": "dotenv cross-var graphql-codegen -- --config codegen.cjs",
"graphql:metadata:generate": "dotenv cross-var graphql-codegen -- --config codegen-metadata.cjs",
"chromatic": "dotenv cross-var npx chromatic --project-token=$CHROMATIC_PROJECT_TOKEN"
"chromatic": "cross-var npx chromatic --project-token=$CHROMATIC_PROJECT_TOKEN --build-script-name=storybook:build",
"chromatic:ci": "cross-var npx chromatic --project-token=$CHROMATIC_PROJECT_TOKEN --build-script-name=storybook:build --exit-zero-on-changes"
},
"engines": {
"node": "^18.17.1",

19
packages/twenty-front/src/modules/activities/emails/components/__stories__/Threads.stories.tsx
View File

@ -1,19 +0,0 @@
import { Meta, StoryObj } from '@storybook/react';
import { Threads } from '../Threads';
const meta: Meta<typeof Threads> = {
title: 'Modules/Activity/Emails/Threads',
component: Threads,
args: {
entity: {
targetObjectNameSingular: 'person',
id: '52ba3fd0-c723-4482-8b11-5fc24a587c71',
},
},
};
export default meta;
type Story = StoryObj<typeof Threads>;
export const Default: Story = {};

2
packages/twenty-front/src/modules/favorites/hooks/useFavorites.ts
View File

@ -83,7 +83,7 @@ export const useFavorites = () => {
return favorite;
})
.toSorted((a, b) => a.position - b.position);
.sort((a, b) => a.position - b.position);
}, [
favoriteRelationFieldMetadataItems,
favorites,